Skip to contentSkip to conversation

avr32: fix compiler warning

PATCH In review Gabor Juhos 2 participants 3 messages Sep 25, 2013 – Sep 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 avr32: fix compiler warning

The patch fixes the following compiler warning:
CC arch/avr32/kernel/process.o
arch/avr32/kernel/process.c: In function 'copy_thread':
arch/avr32/kernel/process.c:292: warning: assignment makes integer \
from pointer without a cast

---
Note: the patch is against v3.12-rc2.

---
 arch/avr32/kernel/process.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/avr32/kernel/process.c +1 -1
index c273100..42a53e74 100644
@@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 		memset(childregs, 0, sizeof(struct pt_regs));
 		p->thread.cpu_context.r0 = arg;
 		p->thread.cpu_context.r1 = usp; /* fn */
-		p->thread.cpu_context.r2 = syscall_return;
+		p->thread.cpu_context.r2 = (unsigned long)syscall_return;
 		p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
 		childregs->sr = MODE_SUPERVISOR;
 	} else {
Signature · 1 line
1.7.10
Acked-by on v1 1/1
#1 lore raw

Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:

Tuning subject to

avr32: cast syscall_return to silence compiler warning

Quoted 5 lines

The patch fixes the following compiler warning:
CC arch/avr32/kernel/process.o
arch/avr32/kernel/process.c: In function 'copy_thread':
arch/avr32/kernel/process.c:292: warning: assignment makes integer \
from pointer without a cast

Thank you for fixing.

Quoted 1 line
Quoted 2 lines

---
Note: the patch is against v3.12-rc2.

Added to my for-linus branch.

Quoted 17 lines
---
 arch/avr32/kernel/process.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/avr32/kernel/process.c +1 -1
index c273100..42a53e74 100644
@@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 		memset(childregs, 0, sizeof(struct pt_regs));
 		p->thread.cpu_context.r0 = arg;
 		p->thread.cpu_context.r1 = usp; /* fn */
-		p->thread.cpu_context.r2 = syscall_return;
+		p->thread.cpu_context.r2 = (unsigned long)syscall_return;
 		p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
 		childregs->sr = MODE_SUPERVISOR;
 	} else {
Signature · 2 lines
mvh
Hans-Christian Egtvedt
#2 lore raw

2013.09.26. 8:18 keltezéssel, Hans-Christian Egtvedt írta:

Quoted 5 lines

Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:

Tuning subject to

avr32: cast syscall_return to silence compiler warning

This is indeed better, thanks.

Quoted 9 lines
Quoted 6 lines

The patch fixes the following compiler warning:
CC arch/avr32/kernel/process.o
arch/avr32/kernel/process.c: In function 'copy_thread':
arch/avr32/kernel/process.c:292: warning: assignment makes integer \
from pointer without a cast

Thank you for fixing.

Quoted 8 lines
Quoted 1 line
Quoted 2 lines

---
Note: the patch is against v3.12-rc2.

Added to my for-linus branch.

Thanks you!

-Gabor