package: fix github download URL
PATCH 1/1 package: fix github download URL
--- package/cpuload/cpuload.mk | 4 ++-- package/fb-test-app/fb-test-app.mk | 4 ++-- package/input-event-daemon/input-event-daemon.mk | 4 ++-- package/lcdapi/lcdapi.mk | 4 ++-- package/libcec/libcec.mk | 4 ++-- package/libiqrf/libiqrf.mk | 4 ++-- package/luasql/luasql.mk | 4 ++-- package/tinymembench/tinymembench.mk | 4 ++-- package/xl2tp/xl2tp.mk | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)
package/cpuload/cpuload.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -CPULOAD_VERSION = v0.3 -CPULOAD_SITE = http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_VERSION = 0.3 +CPULOAD_SITE = https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2 CPULOAD_LICENSE_FILES = COPYING
package/fb-test-app/fb-test-app.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -FB_TEST_APP_VERSION = v1.0.0 -FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball/$(FB_TEST_APP_VERSION) +FB_TEST_APP_VERSION = 1.0.0 +FB_TEST_APP_SITE = https://github.com/prpplague/fb-test-app/tarball/v$(FB_TEST_APP_VERSION) FB_TEST_APP_LICENSE = GPLv2 FB_TEST_APP_LICENSE_FILES = COPYING
package/input-event-daemon/input-event-daemon.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -INPUT_EVENT_DAEMON_VERSION = v0.1.3 -INPUT_EVENT_DAEMON_SITE = http://github.com/gandro/input-event-daemon/tarball/$(INPUT_EVENT_DAEMON_VERSION) +INPUT_EVENT_DAEMON_VERSION = 0.1.3 +INPUT_EVENT_DAEMON_SITE = https://github.com/gandro/input-event-daemon/tarball/v$(INPUT_EVENT_DAEMON_VERSION) INPUT_EVENT_DAEMON_LICENSE = input-event-daemon license INPUT_EVENT_DAEMON_LICENSE_FILES = README
package/lcdapi/lcdapi.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -LCDAPI_VERSION = v0.4 -LCDAPI_SITE = http://github.com/spdawson/lcdapi/tarball/$(LCDAPI_VERSION) +LCDAPI_VERSION = 0.4 +LCDAPI_SITE = https://github.com/spdawson/lcdapi/tarball/v$(LCDAPI_VERSION) LCDAPI_LICENSE = LGPLv2.1+ LCDAPI_LICENSE_FILES = COPYING
package/libcec/libcec.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -LIBCEC_VERSION = libcec-2.1.1 -LIBCEC_SITE = http://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION) +LIBCEC_VERSION = 2.1.1 +LIBCEC_SITE = https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION) LIBCEC_LICENSE = GPLv2+ LIBCEC_LICENSE_FILES = COPYING
package/libiqrf/libiqrf.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -LIBIQRF_VERSION = v0.1.2 -LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION) +LIBIQRF_VERSION = 0.1.2 +LIBIQRF_SITE = https://github.com/nandra/libiqrf/tarball/v$(LIBIQRF_VERSION) LIBIQRF_INSTALL_STAGING = YES LIBIQRF_DEPENDENCIES = libusb
package/luasql/luasql.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -LUASQL_VERSION = v2.3.0 -LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/$(LUASQL_VERSION) +LUASQL_VERSION = 2.3.0 +LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/v$(LUASQL_VERSION) LUASQL_LICENSE = MIT LUASQL_LICENSE_FILES = README LUASQL_DEPENDENCIES = lua
package/tinymembench/tinymembench.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -TINYMEMBENCH_VERSION = v0.2 -TINYMEMBENCH_SITE = http://github.com/ssvb/tinymembench/tarball/$(TINYMEMBENCH_VERSION) +TINYMEMBENCH_VERSION = 0.2 +TINYMEMBENCH_SITE = https://github.com/ssvb/tinymembench/tarball/v$(TINYMEMBENCH_VERSION) TINYMEMBENCH_LICENSE = MIT TINYMEMBENCH_LICENSE_FILES = main.c
package/xl2tp/xl2tp.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -XL2TP_VERSION = v1.3.1 -XL2TP_SITE = http://github.com/xelerance/xl2tpd/tarball/$(XL2TP_VERSION) +XL2TP_VERSION = 1.3.1 +XL2TP_SITE = https://github.com/xelerance/xl2tpd/tarball/v$(XL2TP_VERSION) XL2TP_DEPENDENCIES = libpcap define XL2TP_BUILD_CMDS
Signature · 1 line
1.7.9.5
PATCH 1/1 package: fix github download URL
Hi Jerzy,
Quoted 139 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>--- package/cpuload/cpuload.mk | 4 ++-- package/fb-test-app/fb-test-app.mk | 4 ++-- package/input-event-daemon/input-event-daemon.mk | 4 ++-- package/lcdapi/lcdapi.mk | 4 ++-- package/libcec/libcec.mk | 4 ++-- package/libiqrf/libiqrf.mk | 4 ++-- package/luasql/luasql.mk | 4 ++-- package/tinymembench/tinymembench.mk | 4 ++-- package/xl2tp/xl2tp.mk | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)package/cpuload/cpuload.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -CPULOAD_VERSION = v0.3 -CPULOAD_SITE = http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_VERSION = 0.3 +CPULOAD_SITE = https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2 CPULOAD_LICENSE_FILES = COPYINGpackage/fb-test-app/fb-test-app.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -FB_TEST_APP_VERSION = v1.0.0 -FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball/$(FB_TEST_APP_VERSION) +FB_TEST_APP_VERSION = 1.0.0 +FB_TEST_APP_SITE = https://github.com/prpplague/fb-test-app/tarball/v$(FB_TEST_APP_VERSION) FB_TEST_APP_LICENSE = GPLv2 FB_TEST_APP_LICENSE_FILES = COPYINGpackage/input-event-daemon/input-event-daemon.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -INPUT_EVENT_DAEMON_VERSION = v0.1.3 -INPUT_EVENT_DAEMON_SITE = http://github.com/gandro/input-event-daemon/tarball/$(INPUT_EVENT_DAEMON_VERSION) +INPUT_EVENT_DAEMON_VERSION = 0.1.3 +INPUT_EVENT_DAEMON_SITE = https://github.com/gandro/input-event-daemon/tarball/v$(INPUT_EVENT_DAEMON_VERSION) INPUT_EVENT_DAEMON_LICENSE = input-event-daemon license INPUT_EVENT_DAEMON_LICENSE_FILES = READMEpackage/lcdapi/lcdapi.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LCDAPI_VERSION = v0.4 -LCDAPI_SITE = http://github.com/spdawson/lcdapi/tarball/$(LCDAPI_VERSION) +LCDAPI_VERSION = 0.4 +LCDAPI_SITE = https://github.com/spdawson/lcdapi/tarball/v$(LCDAPI_VERSION) LCDAPI_LICENSE = LGPLv2.1+ LCDAPI_LICENSE_FILES = COPYINGpackage/libcec/libcec.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LIBCEC_VERSION = libcec-2.1.1 -LIBCEC_SITE = http://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION) +LIBCEC_VERSION = 2.1.1 +LIBCEC_SITE = https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION) LIBCEC_LICENSE = GPLv2+ LIBCEC_LICENSE_FILES = COPYINGpackage/libiqrf/libiqrf.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LIBIQRF_VERSION = v0.1.2 -LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION) +LIBIQRF_VERSION = 0.1.2 +LIBIQRF_SITE = https://github.com/nandra/libiqrf/tarball/v$(LIBIQRF_VERSION) LIBIQRF_INSTALL_STAGING = YES LIBIQRF_DEPENDENCIES = libusbpackage/luasql/luasql.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LUASQL_VERSION = v2.3.0 -LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/$(LUASQL_VERSION) +LUASQL_VERSION = 2.3.0 +LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/v$(LUASQL_VERSION) LUASQL_LICENSE = MIT LUASQL_LICENSE_FILES = README LUASQL_DEPENDENCIES = luapackage/tinymembench/tinymembench.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -TINYMEMBENCH_VERSION = v0.2 -TINYMEMBENCH_SITE = http://github.com/ssvb/tinymembench/tarball/$(TINYMEMBENCH_VERSION) +TINYMEMBENCH_VERSION = 0.2 +TINYMEMBENCH_SITE = https://github.com/ssvb/tinymembench/tarball/v$(TINYMEMBENCH_VERSION) TINYMEMBENCH_LICENSE = MIT TINYMEMBENCH_LICENSE_FILES = main.cpackage/xl2tp/xl2tp.mk +0
-0@@ -4,8 +4,8 @@ #
package/xl2tp/xl2tp.mk
Quoted 10 lines
package/xl2tp/xl2tp.mk +2
-3################################################################################ -XL2TP_VERSION = v1.3.1 -XL2TP_SITE = http://github.com/xelerance/xl2tpd/tarball/$(XL2TP_VERSION) +XL2TP_VERSION = 1.3.1 +XL2TP_SITE = https://github.com/xelerance/xl2tpd/tarball/v$(XL2TP_VERSION) XL2TP_DEPENDENCIES = libpcap define XL2TP_BUILD_CMDS --
Content-wise this looks fine (not tested) but in this case I think that there should be a little more info in the commit message: 'fix' is not really correct as everything worked before. The only reason you're doing this is to make the names of the tarballs and the build directories nicer.
Also, I think you should update the manual to explain the rationale and update the example (it explicitly uses v1.0).
Best regards,
Thomas
PATCH 1/1 package: fix github download URL
Hi Thomas,
Thanks for your review.
Quoted 151 lines
Hi Jerzy,
Quoted 147 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>--- package/cpuload/cpuload.mk | 4 ++-- package/fb-test-app/fb-test-app.mk | 4 ++-- package/input-event-daemon/input-event-daemon.mk | 4 ++-- package/lcdapi/lcdapi.mk | 4 ++-- package/libcec/libcec.mk | 4 ++-- package/libiqrf/libiqrf.mk | 4 ++-- package/luasql/luasql.mk | 4 ++-- package/tinymembench/tinymembench.mk | 4 ++-- package/xl2tp/xl2tp.mk | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)package/cpuload/cpuload.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -CPULOAD_VERSION = v0.3 -CPULOAD_SITE = http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_VERSION = 0.3 +CPULOAD_SITE = https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2 CPULOAD_LICENSE_FILES = COPYINGpackage/fb-test-app/fb-test-app.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -FB_TEST_APP_VERSION = v1.0.0 -FB_TEST_APP_SITE = http://github.com/prpplague/fb-test-app/tarball/$(FB_TEST_APP_VERSION) +FB_TEST_APP_VERSION = 1.0.0 +FB_TEST_APP_SITE = https://github.com/prpplague/fb-test-app/tarball/v$(FB_TEST_APP_VERSION) FB_TEST_APP_LICENSE = GPLv2 FB_TEST_APP_LICENSE_FILES = COPYINGpackage/input-event-daemon/input-event-daemon.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -INPUT_EVENT_DAEMON_VERSION = v0.1.3 -INPUT_EVENT_DAEMON_SITE = http://github.com/gandro/input-event-daemon/tarball/$(INPUT_EVENT_DAEMON_VERSION) +INPUT_EVENT_DAEMON_VERSION = 0.1.3 +INPUT_EVENT_DAEMON_SITE = https://github.com/gandro/input-event-daemon/tarball/v$(INPUT_EVENT_DAEMON_VERSION) INPUT_EVENT_DAEMON_LICENSE = input-event-daemon license INPUT_EVENT_DAEMON_LICENSE_FILES = READMEpackage/lcdapi/lcdapi.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LCDAPI_VERSION = v0.4 -LCDAPI_SITE = http://github.com/spdawson/lcdapi/tarball/$(LCDAPI_VERSION) +LCDAPI_VERSION = 0.4 +LCDAPI_SITE = https://github.com/spdawson/lcdapi/tarball/v$(LCDAPI_VERSION) LCDAPI_LICENSE = LGPLv2.1+ LCDAPI_LICENSE_FILES = COPYINGpackage/libcec/libcec.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LIBCEC_VERSION = libcec-2.1.1 -LIBCEC_SITE = http://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION) +LIBCEC_VERSION = 2.1.1 +LIBCEC_SITE = https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION) LIBCEC_LICENSE = GPLv2+ LIBCEC_LICENSE_FILES = COPYINGpackage/libiqrf/libiqrf.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LIBIQRF_VERSION = v0.1.2 -LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION) +LIBIQRF_VERSION = 0.1.2 +LIBIQRF_SITE = https://github.com/nandra/libiqrf/tarball/v$(LIBIQRF_VERSION) LIBIQRF_INSTALL_STAGING = YES LIBIQRF_DEPENDENCIES = libusbpackage/luasql/luasql.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -LUASQL_VERSION = v2.3.0 -LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/$(LUASQL_VERSION) +LUASQL_VERSION = 2.3.0 +LUASQL_SITE = https://github.com/keplerproject/luasql/tarball/v$(LUASQL_VERSION) LUASQL_LICENSE = MIT LUASQL_LICENSE_FILES = README LUASQL_DEPENDENCIES = luapackage/tinymembench/tinymembench.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -TINYMEMBENCH_VERSION = v0.2 -TINYMEMBENCH_SITE = http://github.com/ssvb/tinymembench/tarball/$(TINYMEMBENCH_VERSION) +TINYMEMBENCH_VERSION = 0.2 +TINYMEMBENCH_SITE = https://github.com/ssvb/tinymembench/tarball/v$(TINYMEMBENCH_VERSION) TINYMEMBENCH_LICENSE = MIT TINYMEMBENCH_LICENSE_FILES = main.cpackage/xl2tp/xl2tp.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -XL2TP_VERSION = v1.3.1 -XL2TP_SITE = http://github.com/xelerance/xl2tpd/tarball/$(XL2TP_VERSION) +XL2TP_VERSION = 1.3.1 +XL2TP_SITE = https://github.com/xelerance/xl2tpd/tarball/v$(XL2TP_VERSION) XL2TP_DEPENDENCIES = libpcap
Quoted 8 lines
package/xl2tp/xl2tp.mk
Quoted 2 lines
package/xl2tp/xl2tp.mk +0
-1define XL2TP_BUILD_CMDS --Content-wise this looks fine (not tested) but in this case I think that there should be a little more info in the commit message: 'fix' is not really correct as everything worked before. The only reason you're doing this is to make the names of the tarballs and the build directories nicer.
Agree
Quoted 3 lines
Also, I think you should update the manual to explain the rationale and update the example (it explicitly uses v1.0).
Yes, of course.
I will submit the patch again.
Regards,
Jerzy
Quoted 4 lines
Best regards,
Thomas
PATCH 1/1 package: fix github download URL
In reply to Jerzy Grzegorekpackage/cpuload/cpuload.mk line 9
Quoted 13 lines · Jerzy Grzegorek
package/cpuload/cpuload.mk +2
-2@@ -4,8 +4,8 @@ # ################################################################################ -CPULOAD_VERSION = v0.3 -CPULOAD_SITE =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_VERSION = 0.3 +CPULOAD_SITE =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2
Not that it's a big deal to me, but I don't agree with the concept of
this change. The meaning of this URL is that you export a certain tag from a git repository. It is conceptually not the same as a release tarball that a project creates. Therefore, I think the VERSION should be exactly the same as the tag name, so that it stays as close as possible as what we would have if we used the git site method.
Also you change the URL to https here. With the recent problems with
https URLs that we've seen on the autobuilders recently, I wonder if this is a good idea?
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 package: fix github download URL
Hi Arnout,
Thanks for the feedback.
Quoted 9 lines · Jerzy Grzegorek
Quoted 8 lines
package/cpuload/cpuload.mk +0
-0@@ -4,8 +4,8 @@ # ################################################################################
Quoted 14 lines
package/cpuload/cpuload.mk line 10
Quoted 6 lines
package/cpuload/cpuload.mk +1
-2-CPULOAD_VERSION = v0.3 -CPULOAD_SITE =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_SITE =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2Not that it's a big deal to me, but I don't agree with the concept of
this change. The meaning of this URL is that you export a certain tag from a git repository. It is conceptually not the same as a release tarball that a project creates. Therefore, I think the VERSION should be exactly the same as the tag name, so that it stays as close as possible as what we would have if we used the git site method.
Take into account that if tag has prefix, BR generates tarball with weird name.
For instance for libcec:
tag: libcec-2.1.1LIBCEC_VERSION = libcec-2.1.1LIBCEC_SITE =
https://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION)
tarball name downloaded by BR: libcec-libcec-2.1.1.tar.gz
but whenLIBCEC_VERSION = 2.1.1LIBCEC_SITE =
https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION)
the tarball name generated by github matches the one from BR:
libcec-2.1.1.tar.gz
Additionally there are a few packages in BR with that approach, e.g. civetweb, mongrel2, sqlcipher
Regards,
Jerzy
Quoted 8 lines
Also you change the URL to https here. With the recent problems with
https URLs that we've seen on the autobuilders recently, I wonder if this is a good idea?Regards,
Arnout
PATCH 1/1 package: fix github download URL
Dear Jerzy Grzegorek,
Quoted 33 lines · Jerzy Grzegorek
Quoted 9 lines · Jerzy Grzegorek
Quoted 8 lines
package/cpuload/cpuload.mk +0
-0@@ -4,8 +4,8 @@ # ################################################################################Quoted 14 lines
package/cpuload/cpuload.mk line 10
Quoted 6 lines
package/cpuload/cpuload.mk +1
-2-CPULOAD_VERSION = v0.3 -CPULOAD_SITE =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_SITE =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2Not that it's a big deal to me, but I don't agree with the concept of
this change. The meaning of this URL is that you export a certain tag from a git repository. It is conceptually not the same as a release tarball that a project creates. Therefore, I think the VERSION should be exactly the same as the tag name, so that it stays as close as possible as what we would have if we used the git site method.Take into account that if tag has prefix, BR generates tarball with weird name.
For instance for libcec:
tag: libcec-2.1.1LIBCEC_VERSION= libcec-2.1.1LIBCEC_SITE=
https://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION)
tarball name downloaded by BR: libcec-libcec-2.1.1.tar.gz
Quoted 6 lines
but when
LIBCEC_VERSION= 2.1.1LIBCEC_SITE=
https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION)
the tarball name generated by github matches the one from BR:
libcec-2.1.1.tar.gz
I tend to agree with Arnout. We don't care if tarballs have weird names, upstream projects should simply learn to name their tags properly. Having <pkg>_VERSION match the Git tag name seems more important to me than having nice tarball names.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package: fix github download URL
Arnout, Thomas,
Thanks for your comments.
Quoted 41 lines
Dear Jerzy Grzegorek,
Quoted 31 lines · Jerzy Grzegorek
Quoted 9 lines · Jerzy Grzegorek
Quoted 8 lines
package/cpuload/cpuload.mk +0
-0@@ -4,8 +4,8 @@ # ################################################################################Quoted 13 lines
package/cpuload/cpuload.mk line 10
Quoted 6 lines
package/cpuload/cpuload.mk +1
-2-CPULOAD_VERSION = v0.3 -CPULOAD_SITE =http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION) +CPULOAD_SITE =https://github.com/kelvincheung/cpuload/tarball/v$(CPULOAD_VERSION) CPULOAD_LICENSE = GPLv2Not that it's a big deal to me, but I don't agree with the concept of
this change. The meaning of this URL is that you export a certain tag from a git repository. It is conceptually not the same as a release tarball that a project creates. Therefore, I think the VERSION should be exactly the same as the tag name, so that it stays as close as possible as what we would have if we used the git site method.Take into account that if tag has prefix, BR generates tarball with weird name.
For instance for libcec:
tag: libcec-2.1.1LIBCEC_VERSION= libcec-2.1.1LIBCEC_SITE=
https://github.com/Pulse-Eight/libcec/tarball/$(LIBCEC_VERSION)
tarball name downloaded by BR: libcec-libcec-2.1.1.tar.gzQuoted 6 lines
but when
LIBCEC_VERSION= 2.1.1LIBCEC_SITE=
https://github.com/Pulse-Eight/libcec/tarball/libcec-$(LIBCEC_VERSION)
the tarball name generated by github matches the one from BR:
libcec-2.1.1.tar.gz
Quoted 4 lines
I tend to agree with Arnout. We don't care if tarballs have weird names, upstream projects should simply learn to name their tags properly. Having <pkg>_VERSION match the Git tag name seems more important to me than having nice tarball names.
Ok, then I'll send a patch to cleanup civetweb, liblog4c-localtime, mongrel2 and sqlcipher .
Regards,
Jerzy
Quoted 3 lines
Best regards,
Thomas