Skip to contentSkip to conversation

Exynos5250 SATA Support

PATCH Superseded Yuvaraj Kumar C D 8 participants 21 messages Oct 1, 2013 – Nov 19, 2013

Subsystems (4)

v1 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

cover Exynos5250 SATA Support

This series adds the SATA support on exynos5250 SOC.Also it uses generic phy framework patch[1] posted by Kishon Vijay Abraham I.
[1].drivers: phy: add generic PHY framework.

Yuvaraj Kumar C D (3):
ahci: exynos: add ahci sata support on Exynos platform
Phy: Exynos: Add Exynos5250 sata phy driver
ARM: dts: Enable ahci sata and sata phy

 arch/arm/boot/dts/exynos5250-arndale.dts  |    9 +-
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    6 +-
 arch/arm/boot/dts/exynos5250.dtsi         |   21 ++-
 drivers/ata/Kconfig                       |    9 ++
 drivers/ata/Makefile                      |    1 +
 drivers/ata/ahci_exynos.c                 |  226 ++++++++++++++++++++++++++
 drivers/phy/Kconfig                       |    6 +
 drivers/phy/Makefile                      |    1 +
 drivers/phy/exynos/Kconfig                |    5 +
 drivers/phy/exynos/Makefile               |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c   |   53 ++++++
 drivers/phy/exynos/sata_phy_exynos5250.c  |  248 +++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h  |   33 ++++
 13 files changed, 613 insertions(+), 10 deletions(-)
 create mode 100644 drivers/ata/ahci_exynos.c
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c
drivers/ata/Kconfig +9 -0
index 4e73772..99b2392 100644
@@ -106,6 +106,15 @@ config AHCI_IMX
 
 	  If unsure, say N.
 
+config AHCI_EXYNOS
+	tristate "Samsung Exynos AHCI SATA support"
+	depends on SATA_AHCI_PLATFORM
+	help
+	  This option enables support for the Samsung's Exynos SoC's
+	  onboard AHCI SATA.
+
+	  If unsure, say N.
+
 config SATA_FSL
 	tristate "Freescale 3.0Gbps SATA support"
 	depends on FSL_SOC
drivers/ata/Makefile +1 -0
index 46518c6..0e1f420f 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
 obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
 obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o
+obj-$(CONFIG_AHCI_EXYNOS)	+= ahci_exynos.o
 
 # SFF w/ custom DMA
 obj-$(CONFIG_PDC_ADMA)		+= pdc_adma.o
drivers/ata/ahci_exynos.c new file +226 -0

226 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Hi Yuvaraj,

Review

Quoted 6 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

(quoted diff) +2 -0
+err_out:
+               platform_set_drvdata(pdev, NULL);

This is not necessary. Driver core clears it upon detach or failure.

Quoted 4 lines
drivers/ata/ahci_exynos.c new file +4 -0
+               platform_device_put(ahci_pdev);
+               return ret;
+       }
+

drivers/ata/ahci_exynos.c line 207

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+       return 0;
+}
+
+static int exynos_ahci_remove(struct platform_device *pdev)
+{
+       struct exynos_ahci_priv *priv = platform_get_drvdata(pdev);
+       struct platform_device *ahci_pdev = priv->ahci_pdev;
+
+       platform_device_unregister(ahci_pdev);
+       platform_set_drvdata(pdev, NULL);

ditto

Signature · 2 lines
With warm regards,
Sachin
#3 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

In reply to Yuvaraj Kumar C D
Quoted 25 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c
drivers/ata/Kconfig +0 -0
index 4e73772..99b2392 100644

drivers/ata/Kconfig config AHCI_IMX · line 111

Quoted 6 lines
drivers/ata/Kconfig +3 -0
@@ -106,6 +106,15 @@ config AHCI_IMX
 
 	  If unsure, say N.
 
+config AHCI_EXYNOS
+	tristate "Samsung Exynos AHCI SATA support"
+	depends on SATA_AHCI_PLATFORM

Can we select GENERIC_PHY here?

Quoted 61 lines
drivers/ata/Kconfig +6 -0
+	help
+	  This option enables support for the Samsung's Exynos SoC's
+	  onboard AHCI SATA.
+
+	  If unsure, say N.
+
 config SATA_FSL
 	tristate "Freescale 3.0Gbps SATA support"
 	depends on FSL_SOC
drivers/ata/Makefile +1 -0
index 46518c6..0e1f420f 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
 obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
 obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o
+obj-$(CONFIG_AHCI_EXYNOS)	+= ahci_exynos.o
 
 # SFF w/ custom DMA
 obj-$(CONFIG_PDC_ADMA)		+= pdc_adma.o
drivers/ata/ahci_exynos.c new file +34 -0
new file mode 100644
index 0000000..7f0af00
@@ -0,0 +1,226 @@
+/*
+ * Samsung AHCI SATA platform driver
+ * Copyright 2013 Samsung Electronics Co., Ltd.
+ *
+ * based on the AHCI SATA platform driver by Jeff Garzik and Anton Vorontsov
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/i2c.h>
+#include <linux/io.h>
+#include <linux/ahci_platform.h>
+#include <linux/of_device.h>
+#include <linux/phy/phy.h>
+#include "ahci.h"
+
+#define MHZ             (1000 * 1000)
+
+struct exynos_ahci_priv {
+	struct platform_device *ahci_pdev;
+	struct clk *sclk;

drivers/ata/ahci_exynos.c line 44

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+	unsigned int freq;
+	struct phy *phy;
+};
+
+static int exynos_sata_init(struct device *dev, void __iomem *mmio)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	int ret;
+
+	priv->phy = devm_phy_get(dev , "sata-phy");

^^
spurious space here

phy_get should be called from probe.

drivers/ata/ahci_exynos.c line 50

Quoted 6 lines
drivers/ata/ahci_exynos.c new file +6 -0
+	if (IS_ERR(priv->phy))
+		return PTR_ERR(priv->phy);
+
+	ret = phy_init(priv->phy);
+	if (ret < 0) {
+			dev_err(dev, "failed to init SATA PHY\n");

single tab is sufficient here and below.

Quoted 13 lines
drivers/ata/ahci_exynos.c new file +13 -0
+			return ret;
+	}
+
+	ret = clk_prepare_enable(priv->sclk);
+	if (ret < 0) {
+		dev_err(dev, "failed to enable source clk\n");
+		return ret;
+	}
+
+	ret = clk_set_rate(priv->sclk, priv->freq * MHZ);
+	if (ret < 0) {
+		dev_err(dev, "failed to set clk frequency\n");
+		clk_disable_unprepare(priv->sclk);

drivers/ata/ahci_exynos.c line 73

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+		return ret;
+	}
+
+	return 0;
+}
+
+static void exynos_sata_exit(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	if (!IS_ERR(priv->sclk))

This error check is not needed. You fail probe if you dont get clock anyways.

drivers/ata/ahci_exynos.c line 81

Quoted 8 lines
drivers/ata/ahci_exynos.c new file +8 -0
+		clk_disable_unprepare(priv->sclk);
+}
+
+static int exynos_sata_suspend(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+
+	if (!IS_ERR(priv->sclk))

ditto..

Quoted 5 lines
drivers/ata/ahci_exynos.c new file +5 -0
+		clk_disable_unprepare(priv->sclk);
+	phy_power_off(priv->phy);
+	return 0;
+}
+

drivers/ata/ahci_exynos.c line 96

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+static int exynos_sata_resume(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	phy_power_on(priv->phy);
+	exynos_sata_init(dev, NULL);
+	return 0;
+}
+
+static struct ahci_platform_data exynos_sata_pdata = {
+	.init = exynos_sata_init,

Why is exynos_sata_init given as callback and also in exynos_sata_resume?

drivers/ata/ahci_exynos.c line 99

Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+	.exit = exynos_sata_exit,
+	.suspend = exynos_sata_suspend,
+	.resume = exynos_sata_resume,

Can't we use this in runtime_suspend/runtime_resume or suspend/resume pm ops?

Quoted 22 lines
drivers/ata/ahci_exynos.c new file +22 -0
+};
+
+static const struct of_device_id exynos_ahci_of_match[] = {
+	{ .compatible = "samsung,exynos5250-sata-ahci",
+		.data = &exynos_sata_pdata},
+	{},
+};
+MODULE_DEVICE_TABLE(of, exynos_ahci_of_match);
+
+static int exynos_sata_parse_dt(struct device_node *np,
+				struct exynos_ahci_priv *priv)
+{
+	if (!np)
+		return -EINVAL;
+	return of_property_read_u32(np, "samsung,sata-freq",
+						&priv->freq);
+}
+
+static int exynos_ahci_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct resource *mem, *irq, res[2];

drivers/ata/ahci_exynos.c line 131

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+	const struct of_device_id *of_id;
+	const struct ahci_platform_data *pdata = NULL;
+	struct exynos_ahci_priv *priv;
+	struct device *ahci_dev;
+	struct platform_device *ahci_pdev;
+	int ret;
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv) {
+		dev_err(dev, "can't alloc ahci_host_priv\n");

error message not needed. kzalloc will give a dump if it fails.

drivers/ata/ahci_exynos.c line 135

Quoted 4 lines
drivers/ata/ahci_exynos.c new file +4 -0
+		return -ENOMEM;
+	}
+
+	ahci_pdev = platform_device_alloc("ahci", -1);

Should be using PLATFORM_DEVID_AUTO unless it is absolutely necessary.

Quoted 50 lines
drivers/ata/ahci_exynos.c new file +50 -0
+	if (!ahci_pdev)
+		return -ENODEV;
+
+	ahci_dev = &ahci_pdev->dev;
+	ahci_dev->parent = dev;
+
+	ret = exynos_sata_parse_dt(dev->of_node, priv);
+	if (ret < 0) {
+			dev_err(dev, "failed to parse device tree\n");
+			goto err_out;
+	}
+
+	priv->sclk = devm_clk_get(dev, "sclk_sata");
+	if (IS_ERR(priv->sclk)) {
+		dev_err(dev, "failed to get sclk_sata\n");
+		ret = PTR_ERR(priv->sclk);
+		goto err_out;
+	}
+	priv->ahci_pdev = ahci_pdev;
+	platform_set_drvdata(pdev, priv);
+
+	of_id = of_match_device(exynos_ahci_of_match, dev);
+	if (of_id) {
+		pdata = of_id->data;
+	} else {
+		ret = -EINVAL;
+		goto err_out;
+	}
+
+	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
+	if (!mem || !irq) {
+		dev_err(dev, "no mmio/irq resource\n");
+		ret = -ENOMEM;
+		goto err_out;
+	}
+
+	res[0] = *mem;
+	res[1] = *irq;
+
+	ahci_dev->coherent_dma_mask = DMA_BIT_MASK(32);
+	ahci_dev->dma_mask = &ahci_dev->coherent_dma_mask;
+	ahci_dev->of_node = dev->of_node;
+
+	ret = platform_device_add_resources(ahci_pdev, res, 2);
+	if (ret)
+		goto err_out;
+
+	ret = platform_device_add_data(ahci_pdev, pdata, sizeof(*pdata));
+	if (ret)

drivers/ata/ahci_exynos.c line 195

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+		goto err_out;
+
+	ret = platform_device_add(ahci_pdev);
+	if (ret) {
+
+
+err_out:
+		platform_set_drvdata(pdev, NULL);
+		platform_device_put(ahci_pdev);
+		return ret;

Move this to the end of this function and then goto err_out for better readability.

Quoted 20 lines
drivers/ata/ahci_exynos.c new file +20 -0
+	}
+
+	return 0;
+}
+
+static int exynos_ahci_remove(struct platform_device *pdev)
+{
+	struct exynos_ahci_priv *priv = platform_get_drvdata(pdev);
+	struct platform_device *ahci_pdev = priv->ahci_pdev;
+
+	platform_device_unregister(ahci_pdev);
+	platform_set_drvdata(pdev, NULL);
+
+	return 0;
+}
+
+static struct platform_driver exynos_ahci_driver = {
+	.probe = exynos_ahci_probe,
+	.remove = exynos_ahci_remove,
+	.driver = {

drivers/ata/ahci_exynos.c line 225

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+		.name = "sata-exynos",
+		.owner = THIS_MODULE,
+		.of_match_table = exynos_ahci_of_match,
+	},
+};
+module_platform_driver(exynos_ahci_driver);
+
+MODULE_DESCRIPTION("Samsung Exynos AHCI SATA platform driver");
+MODULE_AUTHOR("Yuvaraj C D <[email protected]>");
+MODULE_LICENSE("GPL");

GPL v2?

Thanks
Kishon

#4 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

In reply to Yuvaraj Kumar C D

Hi,

Quoted 25 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c
drivers/ata/Kconfig +0 -0
index 4e73772..99b2392 100644

drivers/ata/Kconfig config AHCI_IMX · line 111

Quoted 6 lines
drivers/ata/Kconfig +3 -0
@@ -106,6 +106,15 @@ config AHCI_IMX
 
 	  If unsure, say N.
 
+config AHCI_EXYNOS
+	tristate "Samsung Exynos AHCI SATA support"
+	depends on SATA_AHCI_PLATFORM

This should also depend on SOC_EXYNOS5250.

Quoted 40 lines
drivers/ata/Kconfig +6 -0
+	help
+	  This option enables support for the Samsung's Exynos SoC's
+	  onboard AHCI SATA.
+
+	  If unsure, say N.
+
 config SATA_FSL
 	tristate "Freescale 3.0Gbps SATA support"
 	depends on FSL_SOC
drivers/ata/Makefile +1 -0
index 46518c6..0e1f420f 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
 obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
 obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o
+obj-$(CONFIG_AHCI_EXYNOS)	+= ahci_exynos.o
 
 # SFF w/ custom DMA
 obj-$(CONFIG_PDC_ADMA)		+= pdc_adma.o
drivers/ata/ahci_exynos.c new file +13 -0
new file mode 100644
index 0000000..7f0af00
@@ -0,0 +1,226 @@
+/*
+ * Samsung AHCI SATA platform driver
+ * Copyright 2013 Samsung Electronics Co., Ltd.
+ *
+ * based on the AHCI SATA platform driver by Jeff Garzik and Anton Vorontsov
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for

drivers/ata/ahci_exynos.c line 23

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along with
+ * this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/i2c.h>

This include doesn't seem to be needed.

Quoted 13 lines
drivers/ata/ahci_exynos.c new file +13 -0
+#include <linux/io.h>
+#include <linux/ahci_platform.h>
+#include <linux/of_device.h>
+#include <linux/phy/phy.h>
+#include "ahci.h"
+
+#define MHZ             (1000 * 1000)
+
+struct exynos_ahci_priv {
+	struct platform_device *ahci_pdev;
+	struct clk *sclk;
+	unsigned int freq;
+	struct phy *phy;

drivers/ata/ahci_exynos.c line 46

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+};
+
+static int exynos_sata_init(struct device *dev, void __iomem *mmio)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	int ret;
+
+	priv->phy = devm_phy_get(dev , "sata-phy");
+	if (IS_ERR(priv->phy))
+		return PTR_ERR(priv->phy);

This should happen in ->probe (exynos_sata_init() is also called in exynos_sata_resume() so the above code will be executed on every resume operation which is incorrect).

Also please take a look at the following patch:

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

Quoted 35 lines
drivers/ata/ahci_exynos.c new file +35 -0
+	ret = phy_init(priv->phy);
+	if (ret < 0) {
+			dev_err(dev, "failed to init SATA PHY\n");
+			return ret;
+	}
+
+	ret = clk_prepare_enable(priv->sclk);
+	if (ret < 0) {
+		dev_err(dev, "failed to enable source clk\n");
+		return ret;
+	}
+
+	ret = clk_set_rate(priv->sclk, priv->freq * MHZ);
+	if (ret < 0) {
+		dev_err(dev, "failed to set clk frequency\n");
+		clk_disable_unprepare(priv->sclk);
+		return ret;
+	}
+
+	return 0;
+}
+
+static void exynos_sata_exit(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	if (!IS_ERR(priv->sclk))
+		clk_disable_unprepare(priv->sclk);
+}
+
+static int exynos_sata_suspend(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+
+	if (!IS_ERR(priv->sclk))
+		clk_disable_unprepare(priv->sclk);

drivers/ata/ahci_exynos.c line 92

Quoted 10 lines
drivers/ata/ahci_exynos.c new file +10 -0
+	phy_power_off(priv->phy);
+	return 0;
+}
+
+static int exynos_sata_resume(struct device *dev)
+{
+	struct exynos_ahci_priv *priv = dev_get_drvdata(dev->parent);
+	phy_power_on(priv->phy);
+	exynos_sata_init(dev, NULL);
+	return 0;

It should be:

	return exynos_sata_init(dev, NULL);

Also please fix exynos_sata_suspend() to call exynos_sata_exit().

[...]

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

#5 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Quoted 21 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c

[.....]

Quoted 3 lines
Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+	priv->phy = devm_phy_get(dev , "sata-phy");
+	if (IS_ERR(priv->phy))
+		return PTR_ERR(priv->phy);

[.....]

Quoted 6 lines

Also please take a look at the following patch:

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

I also agree with Bartlomiej Zolnierkiewicz's opinion. 'ahci_exynos.c' just calls PHY API, without any additional control for Exynos AHCI IP.

Best regards,
Jingoo Han

Quoted 7 lines
Quoted 7 lines
drivers/ata/ahci_exynos.c new file +6 -0
+	ret = phy_init(priv->phy);
+	if (ret < 0) {
+			dev_err(dev, "failed to init SATA PHY\n");
+			return ret;
+	}
+
#6 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Quoted 34 lines · Jingoo Han
Quoted 21 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c

[.....]

Quoted 3 lines
Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+   priv->phy = devm_phy_get(dev , "sata-phy");
+   if (IS_ERR(priv->phy))
+           return PTR_ERR(priv->phy);

[.....]

Quoted 2 lines

Also please take a look at the following patch:

Quoted 8 lines
Quoted 4 lines

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

I also agree with Bartlomiej Zolnierkiewicz's opinion. 'ahci_exynos.c' just calls PHY API, without any additional control for Exynos AHCI IP.

In addition to PHY handling,it also deals with the special clock sclk_sata which is not dealt in ahci_platform.c(certainly exynos specific).

Morever there is a wrapper driver to handle the platform specific things for the sata.Please refer the patch[1]
[1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver
https://lkml.org/lkml/2013/9/19/166

[2]ahci_imx: add ahci sata support on imx platforms

I think, if we have platform specific driver like ahci_xxx.c , it would be better to handle the sata PHY in ahci_xxx.c so that we can retain and re-use the ahci_platform.c as it is.

Further comments will be much appreciated.

Quoted 12 lines

Best regards,
Jingoo Han

Quoted 7 lines
Quoted 7 lines
drivers/ata/ahci_exynos.c new file +6 -0
+   ret = phy_init(priv->phy);
+   if (ret < 0) {
+                   dev_err(dev, "failed to init SATA PHY\n");
+                   return ret;
+   }
+
#7 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Hi,

Quoted 43 lines · Yuvaraj Kumar
Quoted 34 lines · Jingoo Han
Quoted 21 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c

[.....]

Quoted 3 lines
Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+   priv->phy = devm_phy_get(dev , "sata-phy");
+   if (IS_ERR(priv->phy))
+           return PTR_ERR(priv->phy);

[.....]

Quoted 2 lines

Also please take a look at the following patch:

Quoted 8 lines
Quoted 4 lines

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

I also agree with Bartlomiej Zolnierkiewicz's opinion. 'ahci_exynos.c' just calls PHY API, without any additional control for Exynos AHCI IP.

Quoted 8 lines

In addition to PHY handling,it also deals with the special clock sclk_sata which is not dealt in ahci_platform.c(certainly exynos specific).

Morever there is a wrapper driver to handle the platform specific things for the sata.Please refer the patch[1]
[1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver
https://lkml.org/lkml/2013/9/19/166

This driver doesn't do anything at the moment since the OMAP hwmod layer takes care of enabling the relevant clocks. So I was planning to drop it for now.

Quoted 7 lines

[2]ahci_imx: add ahci sata support on imx platforms

I think, if we have platform specific driver like ahci_xxx.c , it would be better to handle the sata PHY in ahci_xxx.c so that we can retain and re-use the ahci_platform.c as it is.

The Generic PHY framework [3] has been merged into Greg's usb-next branch. The operations there are pretty generic and IMO the PHY can be handled in the ahci_platform driver.

[3] Generic PHY framework

    https://lkml.org/lkml/2013/9/27/581

cheers,
-roger

Quoted 14 lines

Further comments will be much appreciated.

Quoted 12 lines

Best regards,
Jingoo Han

Quoted 7 lines
Quoted 7 lines
drivers/ata/ahci_exynos.c new file +6 -0
+   ret = phy_init(priv->phy);
+   if (ret < 0) {
+                   dev_err(dev, "failed to init SATA PHY\n");
+                   return ret;
+   }
+
#8 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

In reply to Yuvaraj Kumar
Quoted 40 lines · Yuvaraj Kumar
Quoted 39 lines · Jingoo Han
Quoted 21 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c

[.....]

Quoted 3 lines
Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+   priv->phy = devm_phy_get(dev , "sata-phy");
+   if (IS_ERR(priv->phy))
+           return PTR_ERR(priv->phy);

[.....]

Quoted 6 lines

Also please take a look at the following patch:

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

Quoted 6 lines
Quoted 3 lines

I also agree with Bartlomiej Zolnierkiewicz's opinion. 'ahci_exynos.c' just calls PHY API, without any additional control for Exynos AHCI IP.

In addition to PHY handling,it also deals with the special clock sclk_sata which is not dealt in ahci_platform.c(certainly exynos specific).

Handling the special clock 'sclk_sata' is another issue. Please, look at that other 'sclk_*'s are handled.
Also, if possible, please add 'the code handling the special clock' to 'ahci_platform.c'.

Quoted 5 lines

Morever there is a wrapper driver to handle the platform specific things for the sata.Please refer the patch[1]
[1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver
https://lkml.org/lkml/2013/9/19/166

As Roger Quadros mentioned, 'ti_sata' driver will be dropped.

Quoted 2 lines

[2]ahci_imx: add ahci sata support on imx platforms

'ahci_imx' is necessary, because 'ahci_imx' controls some specific registers.

However, 'ahci_exynos.c' does not control any registers.

Quoted 3 lines

I think, if we have platform specific driver like ahci_xxx.c , it would be better to handle the sata PHY in ahci_xxx.c so that we can retain and re-use the ahci_platform.c as it is.

I think that the platform specific driver like ahci_xxx.c is not necessary, because 'ahci_exynos.c' does not control any special registers.

Best regards,
Jingoo Han

Quoted 3 lines

Further comments will be much appreciated.

#9 lore raw

PATCH 1/3 ahci: exynos: add ahci sata support on Exynos platform

Hi,

Quoted 69 lines · On Friday 11 of October 2013 15:49:04 Jingoo Han wrote:
Quoted 40 lines · Yuvaraj Kumar
Quoted 39 lines · Jingoo Han
Quoted 21 lines · Bartlomiej Zolnierkiewicz
Quoted 20 lines · Yuvaraj Kumar C D

Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization.

This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform driver, and keep the generic ahci_platform driver clean as much as possible.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/ata/Kconfig       |    9 ++
 drivers/ata/Makefile      |    1 +
 drivers/ata/ahci_exynos.c |  226 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 236 insertions(+)
 create mode 100644 drivers/ata/ahci_exynos.c

[.....]

Quoted 3 lines
Quoted 3 lines
drivers/ata/ahci_exynos.c new file +3 -0
+   priv->phy = devm_phy_get(dev , "sata-phy");
+   if (IS_ERR(priv->phy))
+           return PTR_ERR(priv->phy);

[.....]

Quoted 6 lines

Also please take a look at the following patch:

https://lkml.org/lkml/2013/9/19/173

it adds PHY support to ahci_platform driver, maybe it can be used for your needs as well.

Quoted 6 lines
Quoted 3 lines

I also agree with Bartlomiej Zolnierkiewicz's opinion. 'ahci_exynos.c' just calls PHY API, without any additional control for Exynos AHCI IP.

In addition to PHY handling,it also deals with the special clock sclk_sata which is not dealt in ahci_platform.c(certainly exynos specific).

Handling the special clock 'sclk_sata' is another issue. Please, look at that other 'sclk_*'s are handled.
Also, if possible, please add 'the code handling the special clock' to 'ahci_platform.c'.

Quoted 5 lines

Morever there is a wrapper driver to handle the platform specific things for the sata.Please refer the patch[1]
[1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver
https://lkml.org/lkml/2013/9/19/166

As Roger Quadros mentioned, 'ti_sata' driver will be dropped.

Quoted 2 lines

[2]ahci_imx: add ahci sata support on imx platforms

'ahci_imx' is necessary, because 'ahci_imx' controls some specific registers.

However, 'ahci_exynos.c' does not control any registers.

Quoted 7 lines
Quoted 3 lines

I think, if we have platform specific driver like ahci_xxx.c , it would be better to handle the sata PHY in ahci_xxx.c so that we can retain and re-use the ahci_platform.c as it is.

I think that the platform specific driver like ahci_xxx.c is not necessary, because 'ahci_exynos.c' does not control any special registers.

My big +1 to all the JIngoo's points above.

Best regards,
Tomasz

#10 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

In reply to Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +6 -0
index 5f85909..ab3d1c6 100644
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
 	  devices present in the kernel. This layer will have the generic
 	  API by which phy drivers can create PHY using the phy framework and
 	  phy users can obtain reference to the PHY.
+
+if GENERIC_PHY
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +1 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
 obj-$(CONFIG_GENERIC_PHY)	+= phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)	+= exynos/
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+	tristate "Samsung Sata SerDes/PHY driver"
+	help
+	  Support for Samsung sata SerDes/Phy found on Samsung
+	  SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)	+= sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +53 -0

53 lines not on this page · raw message

drivers/phy/exynos/sata_phy_exynos5250.c new file +248 -0

248 lines not on this page · raw message

drivers/phy/exynos/sata_phy_exynos5250.h new file +33 -0
new file mode 100644
index 0000000..64e38a1
@@ -0,0 +1,33 @@
+/*
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * Author:
+ *	Yuvaraj Kumar C D<[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ */
+
+#define EXYNOS5_SATA_RESET		0x4
+#define EXYNOS5_SATA_MODE0              0x10
+#define EXYNOS5_SATA_CTRL0              0x14
+#define EXYNOS5_SATA_STAT0		0x18
+#define EXYNOS5_SATA_PHSATA_CTRLM       0xE0
+#define EXYNOS5_SATA_PHSATA_CTRL0       0xE4
+#define EXYNOS5_SATA_PHSATA_STATM       0xF0
+#define EXYNOS5_SATA_PHSTAT0            0xF4
+
+#define RESET_CMN_RST_N			(1 << 1)
+#define LINK_RESET			0xF0000
+#define CTRL0_P0_PHY_CALIBRATED_SEL	(1 << 9)
+#define CTRL0_P0_PHY_CALIBRATED		(1 << 8)
+#define PHCTRLM_REF_RATE		(1 << 1)
+#define PHCTRLM_HIGH_SPEED		(1 << 0)
+#define PHSTATM_PLL_LOCKED		(1 << 0)
+#define SATA_PHY_CON_RESET              (LINK_RESET | 3F)
+#define EXYNOS_SATA_PHY_EN		(1 << 0)
+
+void sataphy_attach_i2c_client(struct i2c_client *sata_phy);
+extern struct i2c_driver sataphy_i2c_driver;
Signature · 1 line
1.7.9.5
#11 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Hi Yuvaraj,

drivers/phy/exynos/exynos5250_phy_i2c.c line 38

Quoted 9 lines · Yuvaraj Kumar C D
drivers/phy/exynos/exynos5250_phy_i2c.c new file +9 -0
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+       dev_info(&client->adapter->dev,
+               "detached %s from i2c adapter successfully\n",
+               client->name);
+
+       return 0;
+}
+

Since this function does not do anything, this could be removed.

drivers/phy/exynos/exynos5250_phy_i2c.c line 51

Quoted 13 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +13 -0
+static const struct i2c_device_id phy_i2c_device_match[] = {
+       { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+
+struct i2c_driver sataphy_i2c_driver = {
+       .probe    = exynos_sata_i2c_probe,
+       .id_table = phy_i2c_device_match,
+       .remove         = exynos_sata_i2c_remove,
+       .driver   = {
+               .name = "sata-phy-i2c",
+               .owner = THIS_MODULE,
+               .of_match_table = (void *)phy_i2c_device_match,

type casting is not required.

Signature · 2 lines
With warm regards,
Sachin
#12 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

In reply to Yuvaraj Kumar C D
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
 	  devices present in the kernel. This layer will have the generic
 	  API by which phy drivers can create PHY using the phy framework and
 	  phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

drivers/phy/Makefile line 6

Quoted 13 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +1 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
 obj-$(CONFIG_GENERIC_PHY)	+= phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)	+= exynos/

simply have phy-exynos5250 in drivers/phy.

Quoted 71 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+	tristate "Samsung Sata SerDes/PHY driver"
+	help
+	  Support for Samsung sata SerDes/Phy found on Samsung
+	  SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)	+= sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +43 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *	Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+		const struct i2c_device_id *i2c_id)
+{
+	sataphy_attach_i2c_client(client);
+
+	dev_info(&client->adapter->dev,
+		"attached %s into i2c adapter successfully\n",
+		client->name);
+
+	return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+	dev_info(&client->adapter->dev,
+		"detached %s from i2c adapter successfully\n",
+		client->name);
+
+	return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+	{ "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 10 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +10 -0
+struct i2c_driver sataphy_i2c_driver = {
+	.probe    = exynos_sata_i2c_probe,
+	.id_table = phy_i2c_device_match,
+	.remove		= exynos_sata_i2c_remove,
+	.driver   = {
+		.name = "sata-phy-i2c",
+		.owner = THIS_MODULE,
+		.of_match_table = (void *)phy_i2c_device_match,
+		},
+};

As I just mentioned above, we can merge this driver with the below one.

Quoted 215 lines
drivers/phy/exynos/sata_phy_exynos5250.c new file +209 -0
new file mode 100644
index 0000000..726c10e
@@ -0,0 +1,248 @@
+/*
+ * Samsung SATA SerDes(PHY) driver
+ *
+ * Copyright (C) 2013 Samsung Electronics Co., Ltd.
+ * Authors: Girish K S <[email protected]>
+ *         Yuvaraj Kumar C D <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/phy/phy.h>
+#include <linux/i2c.h>
+#include <linux/platform_device.h>
+#include <linux/spinlock.h>
+#include <linux/clk.h>
+#include "sata_phy_exynos5250.h"
+
+static struct i2c_client *phy_i2c_client;
+
+struct exynos_sata_phy {
+	struct phy *phy;
+	struct clk *phyclk;
+	void __iomem *regs;
+	void __iomem *pmureg;
+};
+
+static bool wait_for_reg_status(void __iomem *base, u32 reg, u32 checkbit,
+				u32 status)
+{
+	unsigned long timeout = jiffies + usecs_to_jiffies(1000);
+	while (time_before(jiffies, timeout)) {
+		if ((readl(base + reg) & checkbit) == status)
+			return true;
+	}
+	return false;
+}
+
+void sataphy_attach_i2c_client(struct i2c_client *sata_phy)
+{
+	if (sata_phy)
+		phy_i2c_client = sata_phy;
+}
+
+static int __set_phy_state(struct exynos_sata_phy *state, unsigned int on)
+{
+	u32 reg;
+
+	reg = readl(state->pmureg);
+	if (on)
+		reg |= EXYNOS_SATA_PHY_EN;
+	else
+		reg &= ~EXYNOS_SATA_PHY_EN;
+	writel(reg, state->pmureg);
+
+	return 0;
+}
+
+static int exynos_sata_phy_power_on(struct phy *phy)
+{
+	struct exynos_sata_phy *state = phy_get_drvdata(phy);
+
+	return __set_phy_state(state, 1);
+}
+
+static int exynos_sata_phy_power_off(struct phy *phy)
+{
+	struct exynos_sata_phy *state = phy_get_drvdata(phy);
+
+	return __set_phy_state(state, 0);
+}
+
+static int exynos_sataphy_parse_dt(struct device *dev,
+				struct exynos_sata_phy *sata)
+{
+	struct device_node *np = dev->of_node;
+	struct device_node *sataphy_pmu;
+
+	sataphy_pmu = of_get_child_by_name(np, "sataphy-pmu");
+	if (!sataphy_pmu) {
+		dev_err(dev, "No PMU interface for sata-phy\n");
+		return -ENODEV;
+	}
+
+	sata->pmureg = of_iomap(sataphy_pmu, 0);
+	if (!sata->pmureg) {
+		dev_err(dev, "Can't get sata-phy pmu control register\n");
+		of_node_put(sataphy_pmu);
+		return -ENXIO;
+	}
+
+	of_node_put(sataphy_pmu);
+	return 0;
+}
+
+static int exynos_sata_phy_init(struct phy *phy)
+{
+	u32 val;
+	int ret = 0;
+	u8 buf[] = { 0x3A, 0x0B };
+	struct exynos_sata_phy *sata_phy = phy_get_drvdata(phy);
+
+	if (!phy_i2c_client)
+		return -EPROBE_DEFER;
+
+	writel(EXYNOS_SATA_PHY_EN, sata_phy->pmureg);
+
+	val = 0;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+	val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+	val |= 0xFF;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+	val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+	val |= LINK_RESET;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+	val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+	val |= RESET_CMN_RST_N;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+	val = readl(sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+	val &= ~PHCTRLM_REF_RATE;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+
+	/* High speed enable for Gen3 */
+	val = readl(sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+	val |= PHCTRLM_HIGH_SPEED;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+
+	val |= CTRL0_P0_PHY_CALIBRATED_SEL | CTRL0_P0_PHY_CALIBRATED;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_CTRL0);
+
+	writel(0x2, sata_phy->regs + EXYNOS5_SATA_MODE0);
+
+	ret = i2c_master_send(phy_i2c_client, buf, sizeof(buf));
+	if (ret < 0)
+		return -ENXIO;
+
+	/* release cmu reset */
+	val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+	val &= ~RESET_CMN_RST_N;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+	val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+	val |= RESET_CMN_RST_N;
+	writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+	return (wait_for_reg_status(sata_phy->regs, EXYNOS5_SATA_PHSATA_STATM,
+		PHSTATM_PLL_LOCKED, 1)) ? 0 : -EINVAL;
+
+}
+
+static struct phy_ops exynos_sata_phy_ops = {
+	.init		= exynos_sata_phy_init,
+	.power_on	= exynos_sata_phy_power_on,
+	.power_off	= exynos_sata_phy_power_off,
+	.owner		= THIS_MODULE,
+};
+
+static int exynos_sata_phy_probe(struct platform_device *pdev)
+{
+	struct exynos_sata_phy *sata;
+	struct device *dev = &pdev->dev;
+	struct resource *res;
+	struct phy_provider *phy_provider;
+	char label[9];
+	int ret = 0;
+
+	sata = devm_kzalloc(dev, sizeof(*sata), GFP_KERNEL);
+	if (!sata)
+		return -ENOMEM;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+	sata->regs = devm_ioremap_resource(dev, res);
+	if (IS_ERR(sata->regs))
+		return PTR_ERR(sata->regs);
+
+	dev_set_drvdata(dev, sata);
+
+	if (i2c_add_driver(&sataphy_i2c_driver)) {
+		dev_err(dev, "failed to register sataphy i2c driver\n");
+		return -ENOENT;
+	}
+
+	sata->phyclk = devm_clk_get(dev, "sata_phyctrl");
+	if (IS_ERR(sata->phyclk)) {
+		dev_err(dev, "failed to get clk for PHY\n");
+		return PTR_ERR(sata->phyclk);
+	}
+
+	ret = clk_prepare_enable(sata->phyclk);
+	if (ret < 0) {
+		dev_err(dev, "failed to enable source clk\n");
+		return ret;
+	}
+
+	if (dev->of_node) {
+		ret = exynos_sataphy_parse_dt(dev, sata);
+		if (ret)
+			return ret;

drivers/phy/exynos/sata_phy_exynos5250.c line 219

Quoted 10 lines
drivers/phy/exynos/sata_phy_exynos5250.c new file +10 -0
+	}
+
+	phy_provider = devm_of_phy_provider_register(dev,
+					of_phy_simple_xlate);
+	if (IS_ERR(phy_provider))
+		return PTR_ERR(phy_provider);
+
+	snprintf(label, sizeof(label), "%s.%d", "sata-phy", pdev->id);
+
+	sata->phy = devm_phy_create(dev, pdev->id, &exynos_sata_phy_ops, label);

Alright. You are using a older version of PHY framework. I'll wait for you to adapt to the latest version of PHY framework [1] before reviewing any further.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next

Thanks
Kishon

#13 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 75 lines
Quoted 75 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +47 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
Quoted 8 lines

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 6 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +6 -0
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Quoted 220 lines
Quoted 220 lines
drivers/phy/exynos/sata_phy_exynos5250.c new file +214 -0
new file mode 100644
index 0000000..726c10e
@@ -0,0 +1,248 @@
+/*
+ * Samsung SATA SerDes(PHY) driver
+ *
+ * Copyright (C) 2013 Samsung Electronics Co., Ltd.
+ * Authors: Girish K S <[email protected]>
+ *         Yuvaraj Kumar C D <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/phy/phy.h>
+#include <linux/i2c.h>
+#include <linux/platform_device.h>
+#include <linux/spinlock.h>
+#include <linux/clk.h>
+#include "sata_phy_exynos5250.h"
+
+static struct i2c_client *phy_i2c_client;
+
+struct exynos_sata_phy {
+     struct phy *phy;
+     struct clk *phyclk;
+     void __iomem *regs;
+     void __iomem *pmureg;
+};
+
+static bool wait_for_reg_status(void __iomem *base, u32 reg, u32 checkbit,
+                             u32 status)
+{
+     unsigned long timeout = jiffies + usecs_to_jiffies(1000);
+     while (time_before(jiffies, timeout)) {
+             if ((readl(base + reg) & checkbit) == status)
+                     return true;
+     }
+     return false;
+}
+
+void sataphy_attach_i2c_client(struct i2c_client *sata_phy)
+{
+     if (sata_phy)
+             phy_i2c_client = sata_phy;
+}
+
+static int __set_phy_state(struct exynos_sata_phy *state, unsigned int on)
+{
+     u32 reg;
+
+     reg = readl(state->pmureg);
+     if (on)
+             reg |= EXYNOS_SATA_PHY_EN;
+     else
+             reg &= ~EXYNOS_SATA_PHY_EN;
+     writel(reg, state->pmureg);
+
+     return 0;
+}
+
+static int exynos_sata_phy_power_on(struct phy *phy)
+{
+     struct exynos_sata_phy *state = phy_get_drvdata(phy);
+
+     return __set_phy_state(state, 1);
+}
+
+static int exynos_sata_phy_power_off(struct phy *phy)
+{
+     struct exynos_sata_phy *state = phy_get_drvdata(phy);
+
+     return __set_phy_state(state, 0);
+}
+
+static int exynos_sataphy_parse_dt(struct device *dev,
+                             struct exynos_sata_phy *sata)
+{
+     struct device_node *np = dev->of_node;
+     struct device_node *sataphy_pmu;
+
+     sataphy_pmu = of_get_child_by_name(np, "sataphy-pmu");
+     if (!sataphy_pmu) {
+             dev_err(dev, "No PMU interface for sata-phy\n");
+             return -ENODEV;
+     }
+
+     sata->pmureg = of_iomap(sataphy_pmu, 0);
+     if (!sata->pmureg) {
+             dev_err(dev, "Can't get sata-phy pmu control register\n");
+             of_node_put(sataphy_pmu);
+             return -ENXIO;
+     }
+
+     of_node_put(sataphy_pmu);
+     return 0;
+}
+
+static int exynos_sata_phy_init(struct phy *phy)
+{
+     u32 val;
+     int ret = 0;
+     u8 buf[] = { 0x3A, 0x0B };
+     struct exynos_sata_phy *sata_phy = phy_get_drvdata(phy);
+
+     if (!phy_i2c_client)
+             return -EPROBE_DEFER;
+
+     writel(EXYNOS_SATA_PHY_EN, sata_phy->pmureg);
+
+     val = 0;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+     val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+     val |= 0xFF;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+     val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+     val |= LINK_RESET;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+     val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+     val |= RESET_CMN_RST_N;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+     val = readl(sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+     val &= ~PHCTRLM_REF_RATE;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+
+     /* High speed enable for Gen3 */
+     val = readl(sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+     val |= PHCTRLM_HIGH_SPEED;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_PHSATA_CTRLM);
+
+     val |= CTRL0_P0_PHY_CALIBRATED_SEL | CTRL0_P0_PHY_CALIBRATED;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_CTRL0);
+
+     writel(0x2, sata_phy->regs + EXYNOS5_SATA_MODE0);
+
+     ret = i2c_master_send(phy_i2c_client, buf, sizeof(buf));
+     if (ret < 0)
+             return -ENXIO;
+
+     /* release cmu reset */
+     val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+     val &= ~RESET_CMN_RST_N;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+     val = readl(sata_phy->regs + EXYNOS5_SATA_RESET);
+     val |= RESET_CMN_RST_N;
+     writel(val, sata_phy->regs + EXYNOS5_SATA_RESET);
+
+     return (wait_for_reg_status(sata_phy->regs, EXYNOS5_SATA_PHSATA_STATM,
+             PHSTATM_PLL_LOCKED, 1)) ? 0 : -EINVAL;
+
+}
+
+static struct phy_ops exynos_sata_phy_ops = {
+     .init           = exynos_sata_phy_init,
+     .power_on       = exynos_sata_phy_power_on,
+     .power_off      = exynos_sata_phy_power_off,
+     .owner          = THIS_MODULE,
+};
+
+static int exynos_sata_phy_probe(struct platform_device *pdev)
+{
+     struct exynos_sata_phy *sata;
+     struct device *dev = &pdev->dev;
+     struct resource *res;
+     struct phy_provider *phy_provider;
+     char label[9];
+     int ret = 0;
+
+     sata = devm_kzalloc(dev, sizeof(*sata), GFP_KERNEL);
+     if (!sata)
+             return -ENOMEM;
+
+     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+     sata->regs = devm_ioremap_resource(dev, res);
+     if (IS_ERR(sata->regs))
+             return PTR_ERR(sata->regs);
+
+     dev_set_drvdata(dev, sata);
+
+     if (i2c_add_driver(&sataphy_i2c_driver)) {
+             dev_err(dev, "failed to register sataphy i2c driver\n");
+             return -ENOENT;
+     }
+
+     sata->phyclk = devm_clk_get(dev, "sata_phyctrl");
+     if (IS_ERR(sata->phyclk)) {
+             dev_err(dev, "failed to get clk for PHY\n");
+             return PTR_ERR(sata->phyclk);
+     }
+
+     ret = clk_prepare_enable(sata->phyclk);
+     if (ret < 0) {
+             dev_err(dev, "failed to enable source clk\n");
+             return ret;
+     }
+
+     if (dev->of_node) {
+             ret = exynos_sataphy_parse_dt(dev, sata);
+             if (ret)
+                     return ret;
+     }
+
+     phy_provider = devm_of_phy_provider_register(dev,
+                                     of_phy_simple_xlate);
+     if (IS_ERR(phy_provider))
Quoted 8 lines

drivers/phy/exynos/sata_phy_exynos5250.c line 219

Quoted 5 lines
drivers/phy/exynos/sata_phy_exynos5250.c new file +5 -0
+             return PTR_ERR(phy_provider);
+
+     snprintf(label, sizeof(label), "%s.%d", "sata-phy", pdev->id);
+
+     sata->phy = devm_phy_create(dev, pdev->id, &exynos_sata_phy_ops, label);

Alright. You are using a older version of PHY framework. I'll wait for you to adapt to the latest version of PHY framework [1] before reviewing any further.

Sure,I will adapt to the latest version of PHY framework and post soon.

Quoted 10 lines

[1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next

Thanks
Kishon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#14 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Hi,

Quoted 145 lines · Yuvaraj Cd
Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 75 lines
Quoted 75 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +47 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
Quoted 8 lines

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 6 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +6 -0
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

Quoted 3 lines

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Can you point to any discussions where it was decided to go with this approach?

Thanks
Kishon

#15 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Quoted 148 lines · Kishon Vijay Abraham I

Hi,

Quoted 145 lines · Yuvaraj Cd
Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 83 lines
Quoted 71 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +43 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 10 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +10 -0
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

Quoted 5 lines
Quoted 3 lines

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Can you point to any discussions where it was decided to go with this approach?

Sorry,what I meant is exynos_hdmiphy.c is already exist in the mainline with this approach.

Initially it was merged on my local patches(Not upstreamed).But after referring to the
exynos_hdmiphy.c driver and with lot of internal discussions ,it was decided to go with
the already existing approach.

Quoted 3 lines

Thanks
Kishon

#16 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Quoted 153 lines · Yuvaraj Kumar
Quoted 152 lines · Kishon Vijay Abraham I

Hi,

Quoted 148 lines · Yuvaraj Cd
Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 75 lines
Quoted 75 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +47 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
Quoted 8 lines

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 6 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +6 -0
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Quoted 8 lines
Quoted 1 line

Can you point to any discussions where it was decided to go with this approach?

Sorry,what I meant is exynos_hdmiphy.c is already exist in the mainline with this approach.

Initially it was merged on my local patches(Not upstreamed).But after referring to the
exynos_hdmiphy.c driver and with lot of internal discussions ,it was decided to go with

I don't have any idea about the internal discussions whatever you had. IMO Exynos5250 sata phy driver should be modelled as an i2c client driver if you don't have a good reason to do otherwise.

Thanks
Kishon

Quoted 5 lines

the already existing approach.

Quoted 3 lines

Thanks
Kishon

#17 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Quoted 158 lines · Kishon Vijay Abraham I
Quoted 157 lines · Yuvaraj Kumar
Quoted 148 lines · Kishon Vijay Abraham I

Hi,

Quoted 145 lines · Yuvaraj Cd
Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 83 lines
Quoted 71 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +43 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 10 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +10 -0
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

Quoted 5 lines
Quoted 3 lines

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Can you point to any discussions where it was decided to go with this approach?

Sorry,what I meant is exynos_hdmiphy.c is already exist in the mainline with this approach.

Quoted 8 lines
Quoted 4 lines

Initially it was merged on my local patches(Not upstreamed).But after referring to the
exynos_hdmiphy.c driver and with lot of internal discussions ,it was decided to go with

I don't have any idea about the internal discussions whatever you had. IMO Exynos5250 sata phy driver should be modelled as an i2c client driver if you don't have a good reason to do otherwise.

In Exynos5250,some of the registers of SATA PHY controller are I/O mapped and some are accessible
only through I2C controller.
As the whole registers of SATA PHY controller cannot be accessible through I2C bus, it cannot be made as an i2c client driver.

Quoted 10 lines

Thanks
Kishon

Quoted 5 lines

the already existing approach.

Quoted 3 lines

Thanks
Kishon

#18 lore raw

PATCH 2/3 Phy: Exynos: Add Exynos5250 sata phy driver

Quoted 164 lines · Yuvaraj Kumar
Quoted 163 lines · Kishon Vijay Abraham I
Quoted 161 lines · Yuvaraj Kumar
Quoted 148 lines · Kishon Vijay Abraham I

Hi,

Quoted 145 lines · Yuvaraj Cd
Quoted 56 lines · Kishon Vijay Abraham I
Quoted 4 lines · Yuvaraj Kumar C D

This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY.

Why not make the Exynos5250 sata phy as a i2c client driver instead?

Quoted 31 lines

This patch incorporates the generic phy framework to deal with sata phy.

This patch depends on the below patch
[1].drivers: phy: add generic PHY framework
by Kishon Vijay Abraham I<[email protected]>

---
 drivers/phy/Kconfig                      |    6 +
 drivers/phy/Makefile                     |    1 +
 drivers/phy/exynos/Kconfig               |    5 +
 drivers/phy/exynos/Makefile              |    5 +
 drivers/phy/exynos/exynos5250_phy_i2c.c  |   53 +++++++
 drivers/phy/exynos/sata_phy_exynos5250.c |  248 ++++++++++++++++++++++++++++++
 drivers/phy/exynos/sata_phy_exynos5250.h |   33 ++++
 7 files changed, 351 insertions(+)
 create mode 100644 drivers/phy/exynos/Kconfig
 create mode 100644 drivers/phy/exynos/Makefile
 create mode 100644 drivers/phy/exynos/exynos5250_phy_i2c.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.c
 create mode 100644 drivers/phy/exynos/sata_phy_exynos5250.h
drivers/phy/Kconfig +0 -0
index 5f85909..ab3d1c6 100644

drivers/phy/Kconfig menuconfig GENERIC_PHY · line 15

Quoted 5 lines
drivers/phy/Kconfig +2 -0
@@ -11,3 +11,9 @@ menuconfig GENERIC_PHY
        devices present in the kernel. This layer will have the generic
        API by which phy drivers can create PHY using the phy framework and
        phy users can obtain reference to the PHY.
+
+if GENERIC_PHY

NAK. Just select GENERIC_PHY from your driver Kconfig.

Quoted 11 lines
drivers/phy/Kconfig +4 -0
+
+source "drivers/phy/exynos/Kconfig"
+
+endif
drivers/phy/Makefile +0 -0
index 9e9560f..e0223d7 100644
@@ -3,3 +3,4 @@
 #
 
Quoted 4 lines

drivers/phy/Makefile line 6

Quoted 2 lines
drivers/phy/Makefile +1 -0
 obj-$(CONFIG_GENERIC_PHY)    += phy-core.o
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += exynos/

simply have phy-exynos5250 in drivers/phy.

ok.

Quoted 83 lines
Quoted 71 lines
drivers/phy/exynos/Kconfig new file +5 -0
new file mode 100644
index 0000000..fa125fb
@@ -0,0 +1,5 @@
+config PHY_SAMSUNG_SATA
+     tristate "Samsung Sata SerDes/PHY driver"
+     help
+       Support for Samsung sata SerDes/Phy found on Samsung
+       SoCs.
drivers/phy/exynos/Makefile new file +5 -0
new file mode 100644
index 0000000..50dc7eb
@@ -0,0 +1,5 @@
+#
+# Makefile for the exynos phy drivers.
+#
+ccflags-y := -Idrivers/phy/exynos
+obj-$(CONFIG_PHY_SAMSUNG_SATA)       += sata_phy_exynos5250.o exynos5250_phy_i2c.o
drivers/phy/exynos/exynos5250_phy_i2c.c new file +43 -0
new file mode 100644
index 0000000..9c75d3b
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics Co.Ltd
+ * Author:
+ *   Yuvaraj C D <[email protected]>
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include "sata_phy_exynos5250.h"
+
+static int exynos_sata_i2c_probe(struct i2c_client *client,
+             const struct i2c_device_id *i2c_id)
+{
+     sataphy_attach_i2c_client(client);
+
+     dev_info(&client->adapter->dev,
+             "attached %s into i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static int exynos_sata_i2c_remove(struct i2c_client *client)
+{
+     dev_info(&client->adapter->dev,
+             "detached %s from i2c adapter successfully\n",
+             client->name);
+
+     return 0;
+}
+
+static const struct i2c_device_id phy_i2c_device_match[] = {
+     { "sata-phy-i2c", 0 },
+};
+MODULE_DEVICE_TABLE(of, phy_i2c_device_match);
+

drivers/phy/exynos/exynos5250_phy_i2c.c line 53

Quoted 10 lines
drivers/phy/exynos/exynos5250_phy_i2c.c new file +10 -0
+struct i2c_driver sataphy_i2c_driver = {
+     .probe    = exynos_sata_i2c_probe,
+     .id_table = phy_i2c_device_match,
+     .remove         = exynos_sata_i2c_remove,
+     .driver   = {
+             .name = "sata-phy-i2c",
+             .owner = THIS_MODULE,
+             .of_match_table = (void *)phy_i2c_device_match,
+             },
+};

As I just mentioned above, we can merge this driver with the below one.

Quoted 5 lines
Quoted 3 lines

True, Initially it was merged.But already existing drivers of which are of similar to this kind were done in this way. Please refer /drivers/gpu/drm//exynos/exynos_hdmiphy.c

Can you point to any discussions where it was decided to go with this approach?

Sorry,what I meant is exynos_hdmiphy.c is already exist in the mainline with this approach.

Initially it was merged on my local patches(Not upstreamed).But after referring to the
exynos_hdmiphy.c driver and with lot of internal discussions ,it was decided to go with

Quoted 8 lines
Quoted 3 lines

I don't have any idea about the internal discussions whatever you had. IMO Exynos5250 sata phy driver should be modelled as an i2c client driver if you don't have a good reason to do otherwise.

In Exynos5250,some of the registers of SATA PHY controller are I/O mapped and some are accessible
only through I2C controller.
As the whole registers of SATA PHY controller cannot be accessible through I2C bus, it cannot be made as an i2c client driver.

Ah ok.. Makes sense. Thanks for clarifying.

Cheers
Kishon

Quoted 10 lines
Quoted 10 lines

Thanks
Kishon

Quoted 5 lines

the already existing approach.

Quoted 3 lines

Thanks
Kishon

#19 lore raw

PATCH 3/3 ARM: dts: Enable ahci sata and sata phy

In reply to Yuvaraj Kumar C D

This patch adds dt entry for ahci sata controller and its corresponding phy controller.phy node has been added w.r.t new generic phy framework.

---
 arch/arm/boot/dts/exynos5250-arndale.dts  |    9 ++++++++-
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    6 +-----
 arch/arm/boot/dts/exynos5250.dtsi         |   21 +++++++++++++++++----
 3 files changed, 26 insertions(+), 10 deletions(-)
arch/arm/boot/dts/exynos5250-arndale.dts +8 -1
index cee55fa..50db341 100644
@@ -363,7 +363,14 @@
 	};
 
 	i2c at 121D0000 {
-		status = "disabled";
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <40000>;
+		samsung,i2c-slave-addr = <0x38>;
+
+		sata-phy {
+			compatible = "sata-phy-i2c";
+			reg = <0x38>;
+		};
 	};
 
 	dwmmc_0: dwmmc0 at 12200000 {
arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -5
index 2538b32..21b4b25a 100644
@@ -91,15 +91,11 @@
 		samsung,i2c-slave-addr = <0x38>;
 
 		sata-phy {
-			compatible = "samsung,sata-phy";
+			compatible = "sata-phy-i2c";
 			reg = <0x38>;
 		};
 	};
 
-	sata at 122F0000 {
-		samsung,sata-freq = <66>;
-	};
-
 	i2c at 12C80000 {
 		samsung,i2c-sda-delay = <100>;
 		samsung,i2c-max-bus-freq = <66000>;
arch/arm/boot/dts/exynos5250.dtsi +17 -4
index 668ce5d..46a0e3b 100644
@@ -46,6 +46,7 @@
 		i2c6 = &i2c_6;
 		i2c7 = &i2c_7;
 		i2c8 = &i2c_8;
+		i2c9 = &i2c_9;
 		pinctrl0 = &pinctrl_0;
 		pinctrl1 = &pinctrl_1;
 		pinctrl2 = &pinctrl_2;
@@ -216,16 +217,28 @@
 	};
 
 	sata at 122F0000 {
-		compatible = "samsung,exynos5-sata-ahci";
+		compatible = "samsung,exynos5250-sata-ahci";
+		samsung,sata-freq = <66>;
 		reg = <0x122F0000 0x1ff>;
 		interrupts = <0 115 0>;
 		clocks = <&clock 277>, <&clock 143>;
 		clock-names = "sata", "sclk_sata";
+		phys = <&sata_phy>;
+		phy-names = "sata-phy";
 	};
 
-	sata-phy at 12170000 {
-		compatible = "samsung,exynos5-sata-phy";
+	sata_phy:sata-phy at 12170000 {
+		compatible = "samsung,exynos5250-sata-phy";
 		reg = <0x12170000 0x1ff>;
+		clocks = <&clock 287>;
+		clock-names = "sata_phyctrl";
+		#phy-cells = <0>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+		sataphy-pmu {
+			reg = <0x10040724 0x4>;
+			};
 	};
 
 	i2c_0: i2c at 12C60000 {
@@ -334,7 +347,7 @@
 		clock-names = "i2c";
 	};
 
-	i2c at 121D0000 {
+	i2c_9: i2c at 121D0000 {
                 compatible = "samsung,exynos5-sata-phy-i2c";
                 reg = <0x121D0000 0x100>;
                 #address-cells = <1>;
Signature · 1 line
1.7.9.5
#20 lore raw

PATCH 3/3 ARM: dts: Enable ahci sata and sata phy

Hi Yuvaraj,

Quoted 3 lines · Yuvaraj Kumar C D

This patch adds dt entry for ahci sata controller and its corresponding phy controller.phy node has been added w.r.t new generic phy framework.

[snip]

arch/arm/boot/dts/exynos5250-arndale.dts line 370

Quoted 2 lines
arch/arm/boot/dts/exynos5250-arndale.dts +2 -0
+
+               sata-phy {

Shouldn't this be sata-phy at 38?

Quoted 3 lines
arch/arm/boot/dts/exynos5250-arndale.dts +3 -0
+                       compatible = "sata-phy-i2c";
+                       reg = <0x38>;
+               };

[snip]

arch/arm/boot/dts/exynos5250.dtsi line 230

Quoted 3 lines
arch/arm/boot/dts/exynos5250.dtsi +1 -2
-       sata-phy at 12170000 {
-               compatible = "samsung,exynos5-sata-phy";
+       sata_phy:sata-phy at 12170000 {

nit: A space after sata_phy: would be good.

Signature · 2 lines
With warm regards,
Sachin