Skip to contentSkip to conversation

omniorb: cleanup autobuild failure, CFLAGS issue

PATCH Superseded Matt Weber 2 participants 5 messages Sep 27, 2013 – Oct 1, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 omniorb: cleanup autobuild failure, CFLAGS issue

Fixed:
http://autobuild.buildroot.net/results/a08baf8821e3ee1fb9c36c8f74c4ced466af167b/
http://autobuild.buildroot.net/results/f0c7379c1f405385d3a64c0349c3d9565065e8a7/
http://autobuild.buildroot.net/results/c3de25ca52fdb8ffda7472cf9f7b64514954cbb1/

Change Log:
The target CFLAGS were getting mixed in during a manual build of some omniorb pkg tools that could be viewed as host tools.
This manual build was a dirty workaround and created some bad cornercases. So I converted the package over to actually using the host pkg build and removed the need for a patch and custom mods in the build.

Also there wasn't a dependency on the target having python, just host-python for performing the initial build. So depends were adjusted accordingly. If python bindings are required, they can be found in a different package called omniORBpy. The omniORB package only uses python for the build process.

Fixed a bug with long double support. Currently leaving it disabled as most targets won't use it. This allows greater toolchain compatibility.

---
 .../omniorb-0001-crosscompile-tool-export.patch    |   30 ------------
 package/omniorb/omniorb.mk                         |   47 +++++++++-----------
 2 files changed, 21 insertions(+), 56 deletions(-)
 delete mode 100644 package/omniorb/omniorb-0001-crosscompile-tool-export.patch
package/omniorb/omniorb-0001-crosscompile-tool-export.patch deleted +0 -30
deleted file mode 100644
index 260d86f..0000000
@@ -1,30 +0,0 @@
-beforeauto.mk.in: added support for overriding the configure time
-defined CC/CXX/RANLIB/CPP variables so that a couple pkg tools could be
-built which generate code during the cross compile build.
-
-http://www.omniorb-support.com/pipermail/omniorb-list/2013-September/031473.html
-
-Signed-off-by: Matt Weber <[email protected]>
-
---- omniorb-4.1.6.orig/mk/beforeauto.mk.in	2013-09-12 12:49:55.668708148 -0500
-+++ omniorb-4.1.6/mk/beforeauto.mk.in	2013-09-12 12:51:22.707928579 -0500
-@@ -672,15 +672,15 @@
- #
- 
- AR              = ar cq
--CC              = @CC@
--CXX             = @CXX@
--RANLIB		= @RANLIB@
-+CC		?= @CC@
-+CXX		?= @CXX@
-+RANLIB		?= @RANLIB@
- MKDIRHIER	= $(BASE_OMNI_TREE)/bin/scripts/omkdirhier
- INSTLIBFLAGS	= -m 0644
- INSTEXEFLAGS	= -m 0755
- CP		= cp
- MV		= mv -f
--CPP		= @CPP@
-+CPP		?= @CPP@
- OMKDEPEND	= $(TOOLBINDIR)/omkdepend
- RMDIRHIER	= $(RM) -rf
- 
package/omniorb/omniorb.mk +21 -26

58 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 omniorb: cleanup autobuild failure, CFLAGS issue

Quoted 18 lines · Matt Weber

Fixed:
http://autobuild.buildroot.net/results/a08baf8821e3ee1fb9c36c8f74c4ced466af167b/
http://autobuild.buildroot.net/results/f0c7379c1f405385d3a64c0349c3d9565065e8a7/
http://autobuild.buildroot.net/results/c3de25ca52fdb8ffda7472cf9f7b64514954cbb1/

Change Log:
The target CFLAGS were getting mixed in during a manual build of some omniorb pkg tools that could be viewed as host tools.
This manual build was a dirty workaround and created some bad cornercases. So I converted the package over to actually using the host pkg build and removed the need for a patch and custom mods in the build.

Also there wasn't a dependency on the target having python, just host-python for performing the initial build. So depends were adjusted accordingly. If python bindings are required, they can be found in a different package called omniORBpy. The omniORB package only uses python for the build process.

Quoted 4 lines

Fixed a bug with long double support. Currently leaving it disabled as most targets won't use it. This allows greater toolchain compatibility.

Looks good. However:

[snip]

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 22

Quoted 7 lines
package/omniorb/omniorb.mk +7 -0
+# Defaulting long double support to a safe option for the
+# mix of embedded targets, this could later be automated
+# based on checking the capability of the cross toolchain
+# for "__LONG_DOUBLE_128__".  Currently the host and target
+# need to match because of the code generation done by the
+# host tools during the target compile (ie headers generated
+# on host are used in target build).

Ouch, this smells like there could also be an issue when the host and
the target have different data representations (e.g. endianness or bitwidth). Do you think there is a risk of this?

Quoted 4 lines
package/omniorb/omniorb.mk +1 -2
+OMNIORB_CONF_OPT += --disable-longdouble
 
-# omniORB is currently not cross-compile friendly and has some assumptions
-# where a couple host tools are built in place and then used during the

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 30

Quoted 10 lines
package/omniorb/omniorb.mk +5 -4
-# build.  The tools generate code from the IDL description language, which
-# is then built into the cross compiled OMNIORB application.
-# So this first hook builds the tools required for the host side
-# generation of code. Then the second hook cleans up before the install.
+# omniORB is not completely cross-compile friendly and has some
+# assumptions where a couple host tools must be built and then
+# used by the target build.  The host tools generate code from
+# the IDL description language, which is then built into the
+# cross compiled target OMNIORB application.
  define OMNIORB_BUILD_TOOLS

Minor nit: you probably want to rename this variable as well.

Quoted 10 lines
package/omniorb/omniorb.mk +4 -3
-	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) \
-		-C $(@D)/src/tool export
+	# Point to the host folder to get HOST_OMNIORB tools
+	$(SED) 's:TOOLBINDIR = $$(TOP)/$$(BINDIR):TOOLBINDIR = $(HOST_DIR)/usr/bin:g' $(@D)/mk/beforeauto.mk
+	# Disables OMNIORB tool building
+	echo "EmbeddedSystem=1" >> $(@D)/mk/beforeauto.mk
  endef
  OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_BUILD_TOOLS
 
-define OMNIORB_CLEAN_TOOLS

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 38

Quoted 10 lines
package/omniorb/omniorb.mk +1 -9
-	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) \
-		-C $(@D)/src/tool clean
-endef
-OMNIORB_POST_BUILD_HOOKS += OMNIORB_CLEAN_TOOLS
-
-define OMNIORB_FIXUP_FILE_PATHS_HOOK
-	$(SED) "s:$(HOST_DIR)/usr:/usr:g" $(STAGING_DIR)/usr/bin/omniidl
-endef
-OMNIORB_POST_INSTALL_STAGING_HOOKS += OMNIORB_FIXUP_FILE_PATHS_HOOK
+HOST_OMNIORB_DEPENDENCIES = host-python

We usually put the host DEPENDENCIES just below the target stuff. So:

###########

# header
###########

<target variable definitions>

<host variable definitions>

<conditional target variables>

<conditional host variables>

<target cmds and hooks>

<host cmds and hooks>

$(eval $(...))
$(eval $(host-...))

Regards,
Arnout

Quoted 4 lines

$(eval $(autotools-package))
+$(eval $(host-autotools-package))

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 omniorb: cleanup autobuild failure, CFLAGS issue

Arnout Vandecappelle <[email protected]> wrote on 10/01/2013 11:30:04 AM:

Quoted 7 lines

From: Arnout Vandecappelle <[email protected]>
To: Matt Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 10/01/2013 02:09 PM
Subject: Re: [Buildroot] [PATCH 1/1] omniorb: cleanup autobuild failure, CFLAGS issue

Quoted 15 lines
Quoted 2 lines · Matt Weber

Fixed:
http://autobuild.buildroot.net/results/

a08baf8821e3ee1fb9c36c8f74c4ced466af167b/

Quoted 1 line

http://autobuild.buildroot.net/results/

f0c7379c1f405385d3a64c0349c3d9565065e8a7/

Quoted 1 line

http://autobuild.buildroot.net/results/

c3de25ca52fdb8ffda7472cf9f7b64514954cbb1/

Quoted 7 lines

Change Log:
The target CFLAGS were getting mixed in during a manual build of some omniorb pkg tools that could be viewed as host tools.
This manual build was a dirty workaround and created some bad cornercases. So I converted the package over to actually using the host pkg build and removed the need for a patch and custom mods inthe

build.

Quoted 3 lines
Quoted 3 lines

Also there wasn't a dependency on the target having python, just host-python for performing the initial build. So depends were

adjusted

Quoted 7 lines
Quoted 1 line

accordingly. If python bindings are required, they can be found in

a different

Quoted 5 lines

package called omniORBpy. The omniORB package only uses python for the build process.

Fixed a bug with long double support. Currently leaving it disabled as most targets won't use it. This allows greater toolchain

compatibility.

Quoted 6 lines
Quoted 2 lines

Looks good. However:

[snip]

Quoted 11 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 22

Quoted 7 lines
package/omniorb/omniorb.mk +7 -0
+# Defaulting long double support to a safe option for the
+# mix of embedded targets, this could later be automated
+# based on checking the capability of the cross toolchain
+# for "__LONG_DOUBLE_128__".  Currently the host and target
+# need to match because of the code generation done by the
+# host tools during the target compile (ie headers generated
+# on host are used in target build).

Ouch, this smells like there could also be an issue when the host and
the target have different data representations (e.g. endianness or bitwidth). Do you think there is a risk of this?

I don't believe there is a risk if I also disable it on the host (which I'll add in my next update).
HOST_OMNIORB_CONF_OPT += --disable-longdouble
I think the use case of having both the host and target support it is going to
have to be a customization done by a user for a specific target capability build.
To accommodate that here would be impractical since we don't have control over
the host compiler version and would really only have the option to immediately fail
the build if the target toolchain didn't also support longdouble. Is this a reasonable
assumption? Leaving it disabled allows the pkg to work on all of the targets
and if you need extended long support you could do additional customization
for your specific toolchain configuration.

Quoted 4 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2

Quoted 4 lines
package/omniorb/omniorb.mk +1 -1
+OMNIORB_CONF_OPT += --disable-longdouble
 
-# omniORB is currently not cross-compile friendly and has some 

assumptions

Quoted 1 line
Quoted 1 line

-# where a couple host tools are built in place and then used during

the

Quoted 1 line
Quoted 1 line

-# build. The tools generate code from the IDL description language,

which

Quoted 3 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2

Quoted 3 lines
package/omniorb/omniorb.mk +0 -3
-# is then built into the cross compiled OMNIORB application.
-# So this first hook builds the tools required for the host side
-# generation of code. Then the second hook cleans up before the 

install.

Quoted 8 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 30

Quoted 6 lines
package/omniorb/omniorb.mk +5 -0
+# omniORB is not completely cross-compile friendly and has some
+# assumptions where a couple host tools must be built and then
+# used by the target build.  The host tools generate code from
+# the IDL description language, which is then built into the
+# cross compiled target OMNIORB application.
  define OMNIORB_BUILD_TOOLS

Minor nit: you probably want to rename this variable as well.

Sure.

Quoted 35 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2

Quoted 5 lines
package/omniorb/omniorb.mk +2 -2
-   $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) \
-      -C $(@D)/src/tool export
+   # Point to the host folder to get HOST_OMNIORB tools
+   $(SED) 's:TOOLBINDIR = $$(TOP)/$$(BINDIR):TOOLBINDIR = $

(HOST_DIR)/usr/bin:g' $(@D)/mk/beforeauto.mk

Quoted 6 lines
package/omniorb/omniorb.mk +2 -1
+   # Disables OMNIORB tool building
+   echo "EmbeddedSystem=1" >> $(@D)/mk/beforeauto.mk
  endef
  OMNIORB_POST_CONFIGURE_HOOKS += OMNIORB_BUILD_TOOLS
 
-define OMNIORB_CLEAN_TOOLS

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 38

Quoted 10 lines
package/omniorb/omniorb.mk +1 -9
-   $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) \
-      -C $(@D)/src/tool clean
-endef
-OMNIORB_POST_BUILD_HOOKS += OMNIORB_CLEAN_TOOLS
-
-define OMNIORB_FIXUP_FILE_PATHS_HOOK
-   $(SED) "s:$(HOST_DIR)/usr:/usr:g" $(STAGING_DIR)/usr/bin/omniidl
-endef
-OMNIORB_POST_INSTALL_STAGING_HOOKS += OMNIORB_FIXUP_FILE_PATHS_HOOK
+HOST_OMNIORB_DEPENDENCIES = host-python

We usually put the host DEPENDENCIES just below the target stuff. So:

###########

# header
###########

<target variable definitions>

<host variable definitions>

<conditional target variables>

Quoted 9 lines

<conditional host variables>

<target cmds and hooks>

<host cmds and hooks>

$(eval $(...))
$(eval $(host-...))

Sure, I'll get a header added and follow that by the host dependencies and the new host conf opt for longdouble disable.

Quoted 18 lines

Regards,
Arnout

Quoted 4 lines

$(eval $(autotools-package))
+$(eval $(host-autotools-package))

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 omniorb: cleanup autobuild failure, CFLAGS issue

Quoted 1 line · Matthew Weber

Arnout Vandecappelle<[email protected]> wrote on 10/01/2013 11:30:04 AM:

[snip]

Quoted 12 lines
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 22

Quoted 7 lines
package/omniorb/omniorb.mk +7 -0
+# Defaulting long double support to a safe option for the
+# mix of embedded targets, this could later be automated
+# based on checking the capability of the cross toolchain
+# for "__LONG_DOUBLE_128__".  Currently the host and target
+# need to match because of the code generation done by the
+# host tools during the target compile (ie headers generated
+# on host are used in target build).

Ouch, this smells like there could also be an issue when the host and
the target have different data representations (e.g. endianness or bitwidth). Do you think there is a risk of this?

Quoted 2 lines

I don't believe there is a risk if I also disable it on the host (which I'll add in my next update).

That's not what I meant. For longdouble it's fine because it's
disabled. However, you are building the omniidl with native compilation, and you use that to generate some source code for the target (at least that's what I understand). My guess is that this is used to generate the (de)serialization code of the RPC. However, if omniorb is so bad at cross-compilation, there is a risk that they didn't consider that the endianness and bitwidths of the generated code may be different from the endianness and bitwidths that are detected during native compilation.

So to be sure, it should be tested on a big-endian target if the
generated code works correctly. Bitwidths are even trickier to test...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH 1/1 omniorb: cleanup autobuild failure, CFLAGS issue

Arnout Vandecappelle <[email protected]> wrote on 10/01/2013 03:41:53 PM:

Quoted 7 lines

From: Arnout Vandecappelle <[email protected]>
To: Matthew Weber <[email protected]>
Cc: buildroot at busybox.net
Date: 10/01/2013 03:42 PM
Subject: Re: [Buildroot] [PATCH 1/1] omniorb: cleanup autobuild failure, CFLAGS issue

Quoted 12 lines
Quoted 1 line · Matthew Weber

Arnout Vandecappelle<[email protected]> wrote on 10/01/2013 11:30:04 AM:

[snip]

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 7 lines

package/omniorb/omniorb.mk OMNIORB_SOURCE = omniORB-$(OMNIORB_VERSION).tar.bz2 · line 22

Quoted 7 lines
package/omniorb/omniorb.mk +7 -0
+# Defaulting long double support to a safe option for the
+# mix of embedded targets, this could later be automated
+# based on checking the capability of the cross toolchain
+# for "__LONG_DOUBLE_128__".  Currently the host and target
+# need to match because of the code generation done by the
+# host tools during the target compile (ie headers generated
+# on host are used in target build).

Ouch, this smells like there could also be an issue when the host

and

Quoted 12 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines

the target have different data representations (e.g. endianness or bitwidth). Do you think there is a risk of this?

I don't believe there is a risk if I also disable it on the host (which I'll add in my next update).

That's not what I meant. For longdouble it's fine because it's
disabled. However, you are building the omniidl with native compilation,

and you use that to generate some source code for the target (at least that's what I understand). My guess is that this is used to generate the

Quoted 9 lines

(de)serialization code of the RPC. However, if omniorb is so bad at cross-compilation, there is a risk that they didn't consider that the endianness and bitwidths of the generated code may be different from the

endianness and bitwidths that are detected during native compilation.

So to be sure, it should be tested on a big-endian target if the
generated code works correctly. Bitwidths are even trickier to test...

Sorry, this is going to get a little messy, bare with me. The basis for my cross build was from this website, he outlined some of the issues.
http://www.omniorb-support.com/omniwiki/CrossCompiling

I've done some additional checking.... I think we do have an issue since I separated the host build out from the target build. Now the configure script for the host (tools) build isn't getting called with the target config opts.
This means all the arch specific headers and datatype sizing isn't getting stored and used during the native build. I.e. any builds of native tools aren't
constrained to the target definitions. I believe if I add an override of the host configure script to run
with the target config opts, then it should be back to the original assumptions and produce correct tool (omniidle) outputs.
- At that point the endianess then should also be ok, since the config script checking is used to adjust the build to create the correct target outputs. I have seen where this was causing a bug in a previous version, so I believe it's working.
However I will build for a PPC and give things a try.
- Next the bitwidths issue.... Since we first do a config against the target architecture during the host build,
it sets up all the headers to match the target.
From that output, I did verify the datatypes
were getting sizing according to the target.

Quoted 9 lines

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F