Skip to contentSkip to conversation

xfstests: filter projid32bit info out of growfs & info output

PATCH In review Eric Sandeen 3 participants 3 messages Oct 6, 2013 – Oct 15, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: filter projid32bit info out of growfs & info output

commit 67e389c xfsprogs: support CRC enabled filesystem detection

changed xfs_growfs (and by extension xfs_info) to report the projid32bit value. This breaks at least xfstest xfs/206 due to the changed output, so filter it as we do for mkfs in that test.

---

tests/xfs/206 +2 -0
index fcbdd9e..d2c2ade 100755
@@ -86,6 +86,7 @@ echo "=== xfs_growfs ==="
 xfs_growfs $tmpdir \
 	| sed -e "s,^meta-data=.*isize,meta-data=FILE                   isize,g" \
 		-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+		-e "s/, projid32bit=[0-9]//" \
 		-e "/.*crc=/d"
 
 # and double-check the new geometry
@@ -93,6 +94,7 @@ echo "=== xfs_info ==="
 xfs_info $tmpdir \
 	| sed -e "s,^meta-data=.*isize,meta-data=FILE                   isize,g" \
 		-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+		-e "s/, projid32bit=[0-9]//" \
 		-e "/.*crc=/d"
 
 # _cleanup cleans up for us

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 22 lines · Eric Sandeen

commit 67e389c xfsprogs: support CRC enabled filesystem detection

changed xfs_growfs (and by extension xfs_info) to report the projid32bit value. This breaks at least xfstest xfs/206 due to the changed output, so filter it as we do for mkfs in that test.

---

tests/xfs/206 +1 -0
index fcbdd9e..d2c2ade 100755
@@ -86,6 +86,7 @@ echo "=== xfs_growfs ==="
 xfs_growfs $tmpdir \
 	| sed -e "s,^meta-data=.*isize,meta-data=FILE                   isize,g" \
 		-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+		-e "s/, projid32bit=[0-9]//" \
 		-e "/.*crc=/d"
 
 # and double-check the new geometry

tests/xfs/206 echo "=== xfs_info ===" · line 100

Quoted 7 lines
tests/xfs/206 +1 -0
@@ -93,6 +94,7 @@ echo "=== xfs_info ==="
 xfs_info $tmpdir \
 	| sed -e "s,^meta-data=.*isize,meta-data=FILE                   isize,g" \
 		-e "s/\(^log.*blocks=\)\([0-9]*,\)/\1XXXXX,/" \
+		-e "s/, projid32bit=[0-9]//" \
 		-e "/.*crc=/d"
 
 # _cleanup cleans up for us

Yup, that's needed. There's a bunch of other things we need to do to correctly test 16/32bit project ids without failures. Have a look here:

http://oss.sgi.com/archives/xfs/2013-06/msg00219.html

For the mods I posted back in June to avoid failures with the CRC enabled filesystems in tests that assume certain options can be turned on/off on XFS filesystems.

I'm still running xfstests with that patch....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#2 lore raw
Quoted 11 lines · Dave Chinner

Yup, that's needed. There's a bunch of other things we need to do to correctly test 16/32bit project ids without failures. Have a look here:

http://oss.sgi.com/archives/xfs/2013-06/msg00219.html

For the mods I posted back in June to avoid failures with the CRC enabled filesystems in tests that assume certain options can be turned on/off on XFS filesystems.

I'm still running xfstests with that patch....

Would be good to get it in ASAP!

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs