Skip to contentSkip to conversation

net: af802154: Fix wrong structure declaration

PATCH In review Guenter Roeck 3 participants 4 messages Oct 6, 2013 – Oct 8, 2013 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: af802154: Fix wrong structure declaration

net_devce doesn't exist.

---
 net/ieee802154/af802154.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ieee802154/af802154.h +1 -1
index b1ec525..62f5f63 100644
@@ -25,7 +25,7 @@
 #define AF802154_H
 
 struct sk_buff;
-struct net_devce;
+struct net_device;
 extern struct proto ieee802154_raw_prot;
 extern struct proto ieee802154_dgram_prot;
 void ieee802154_raw_deliver(struct net_device *dev, struct sk_buff *skb);
Signature · 1 line
1.7.9.7

A message that is not in the archive (sent off-list or not yet received): 1381095841-15031-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org

#2 lore raw
Quoted 1 line · Guenter Roeck

net_devce doesn't exist.

[]

net/ieee802154/af802154.h

Quoted 1 line
net/ieee802154/af802154.h +0 -0

[]

net/ieee802154/af802154.h line 28

Quoted 6 lines
net/ieee802154/af802154.h +1 -1
@@ -25,7 +25,7 @@
 #define AF802154_H
 
 struct sk_buff;
-struct net_devce;
+struct net_device;

That argues more for deletion than correction.

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk

#3 lore raw
Quoted 5 lines · Joe Perches
Quoted 1 line · Guenter Roeck

net_devce doesn't exist.

[]

net/ieee802154/af802154.h

Quoted 1 line
net/ieee802154/af802154.h +0 -0

[]

Quoted 9 lines

net/ieee802154/af802154.h line 28

Quoted 6 lines
net/ieee802154/af802154.h +1 -1
@@ -25,7 +25,7 @@
  #define AF802154_H
 
  struct sk_buff;
-struct net_devce;
+struct net_device;

That argues more for deletion than correction.

I thought the idea was to ensure that every structure is declared. In this case it appears that the structure happens to be declared in other include files, so we are lucky. On the other side, if so, "struct proto", "struct net" and "struct ieee802154_addr" should probably be declared as well ...

Ultimately, I don't really care one way or another. I just happened to stumble over it. Fine with me to remove it. Maybe the maintainers should decide what if anything to do.

Guenter

maintainer
#4 lore raw
In reply to Guenter Roeck

From: Guenter Roeck <[email protected]>
Date: Sun, 6 Oct 2013 14:44:01 -0700

Quoted 3 lines

net_devce doesn't exist.

This is simply rediculous.

The reason I say this is that every user of this header includes net/sock.h which in turn includes linux/skbuff.h and linux/netdevice.h which therefore bring in all the necessary structure definitions.

Really, the most correct change is to make af802154.h explicitly include those header files.