Skip to contentSkip to conversation

nft: arp: add parse_target to nft_family_ops_arp

PATCH Applied Giuseppe Longo 3 participants 3 messages Oct 6, 2013 – Oct 8, 2013 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nft: arp: add parse_target to nft_family_ops_arp

This patch adds parse_target for arp family, fixing segfaults for xtables-arp -L after rules like:

- xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
- xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01

---
 iptables/nft-arp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
iptables/nft-arp.c +1 -0
index 570962d..08f8814 100644
@@ -643,4 +643,5 @@ struct nft_family_ops nft_family_ops_arp = {
 	.print_firewall		= nft_arp_print_firewall,
 	.post_parse		= NULL,
 	.rule_find		= nft_arp_rule_find,
+	.parse_target		= nft_arp_parse_target,
 };
Signature · 1 line
1.7.8.6
#1 lore raw

Good catch!

I probably read that file dozens of time and did not spot this...

Thanks,

Tomasz

Quoted 21 lines

This patch adds parse_target for arp family, fixing segfaults for xtables-arp -L after rules like:

- xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
- xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01

---
  iptables/nft-arp.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
iptables/nft-arp.c +1 -0
index 570962d..08f8814 100644
@@ -643,4 +643,5 @@ struct nft_family_ops nft_family_ops_arp = {
  	.print_firewall		= nft_arp_print_firewall,
  	.post_parse		= NULL,
  	.rule_find		= nft_arp_rule_find,
+	.parse_target		= nft_arp_parse_target,
  };
maintainer Applied
#2 lore raw
In reply to Giuseppe Longo
Quoted 5 lines · Giuseppe Longo

This patch adds parse_target for arp family, fixing segfaults for xtables-arp -L after rules like:

- xtables-arp -A OUTPUT -o eth0 -j CLASSIFY --set-class 0:7
- xtables-arp -A OUTPUT -o eth1 --h-length 6 -j mangle --mangle-mac-s 01:00:5e:00:01:01

Applied, thanks Giuseppe.