Skip to contentSkip to conversation

lighttpd: fix build failure without ipv6

PATCH New Gustavo Zacarias 3 participants 3 messages Oct 7, 2013 – Oct 8, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 lighttpd: fix build failure without ipv6

Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
and http://redmine.lighttpd.net/issues/2515
Autobuilders didn't hit it yet, but i did.

---
 ...ile.patch => lighttpd-01-Fix-default-config-file.patch} |  0
 package/lighttpd/lighttpd-02-mod_extforward.patch          | 14 ++++++++++++++
 2 files changed, 14 insertions(+)
 rename package/lighttpd/{lighttpd-Fix-default-config-file.patch => lighttpd-01-Fix-default-config-file.patch} (100%)
 create mode 100644 package/lighttpd/lighttpd-02-mod_extforward.patch
package/lighttpd/lighttpd-01-Fix-default-config-file.patch renamed from package/lighttpd/lighttpd-Fix-default-config-file.patch +0 -0
similarity index 100%
rename from package/lighttpd/lighttpd-Fix-default-config-file.patch
rename to package/lighttpd/lighttpd-01-Fix-default-config-file.patch
package/lighttpd/lighttpd-02-mod_extforward.patch new file +14 -0
new file mode 100644
index 0000000..3efd2b1
@@ -0,0 +1,14 @@
+From http://redmine.lighttpd.net/issues/2515
+
+Signed-off-by: Gustavo Zacarias <[email protected]>
+
+--- a/src/mod_extforward.c	(revision 2909)
++++ b/src/mod_extforward.c	(working copy)
+@@ -439,7 +439,6 @@
+ #ifdef HAVE_IPV6
+ 		ipstr_to_sockaddr(srv, real_remote_addr, &sock);
+ #else
+-		UNUSED(addrs_left);
+ 		sock.ipv4.sin_addr.s_addr = inet_addr(real_remote_addr);
+ 		sock.plain.sa_family = (sock.ipv4.sin_addr.s_addr == 0xFFFFFFFF) ? AF_UNSPEC : AF_INET;
+ #endif
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v2 1/1 lighttpd: fix build failure without ipv6

Quoted 27 lines · Gustavo Zacarias

Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
and http://redmine.lighttpd.net/issues/2515
Autobuilders didn't hit it yet, but i did.

---
  ...ile.patch => lighttpd-01-Fix-default-config-file.patch} |  0
  package/lighttpd/lighttpd-02-mod_extforward.patch          | 14 ++++++++++++++
  2 files changed, 14 insertions(+)

rename package/lighttpd/{lighttpd-Fix-default-config-file.patch => lighttpd-01-Fix-default-config-file.patch} (100%) create mode 100644 package/lighttpd/lighttpd-02-mod_extforward.patch

package/lighttpd/lighttpd-01-Fix-default-config-file.patch renamed from package/lighttpd/lighttpd-Fix-default-config-file.patch +0 -0
similarity index 100%
rename from package/lighttpd/lighttpd-Fix-default-config-file.patch
rename to package/lighttpd/lighttpd-01-Fix-default-config-file.patch
package/lighttpd/lighttpd-02-mod_extforward.patch new file +4 -0
new file mode 100644
index 0000000..3efd2b1
@@ -0,0 +1,14 @@
+From http://redmine.lighttpd.net/issues/2515
+
+Signed-off-by: Gustavo Zacarias <[email protected]>
+

package/lighttpd/lighttpd-02-mod_extforward.patch line 14

Quoted 10 lines
package/lighttpd/lighttpd-02-mod_extforward.patch new file +10 -0
+--- a/src/mod_extforward.c	(revision 2909)
++++ b/src/mod_extforward.c	(working copy)
+@@ -439,7 +439,6 @@
+ #ifdef HAVE_IPV6
+ 		ipstr_to_sockaddr(srv, real_remote_addr, &sock);
+ #else
+-		UNUSED(addrs_left);
+ 		sock.ipv4.sin_addr.s_addr = inet_addr(real_remote_addr);
+ 		sock.plain.sa_family = (sock.ipv4.sin_addr.s_addr == 0xFFFFFFFF) ? AF_UNSPEC : AF_INET;
+ #endif

oh this is rather embarrasing. I am taking care of the Gentoo bug myself :/ I assumed the ipv6 is disabled by default since i didn't see it in the lighttpd.mk makefile but reading the configure.ac it appears to always be enabled :( Sorry about that.

Thanks for the patch!

#2 lore raw

PATCH v2 1/1 lighttpd: fix build failure without ipv6

In reply to Gustavo Zacarias
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
Gustavo> and http://redmine.lighttpd.net/issues/2515
Gustavo> Autobuilders didn't hit it yet, but i did.

Gustavo> Signed-off-by: Gustavo Zacarias <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard