Skip to contentSkip to conversation

config.mk: enable -fstack-usage only when it is desired

PATCH New Masahiro Yamada 4 participants 10 messages Sep 26, 2013 – Oct 15, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

As far as I know, gcc does not support -fstack-usage for some targets such as blackfin, m68k, microblaze, etc.

If -fstack-usage option is given for those targets, gcc displays a warning message as follows:

warning: -fstack-usage not supported for this target [enabled by default]

But it still exits with status 0.

So,

    # Report stack usage if supported
    CFLAGS_STACK := $(call cc-option,-fstack-usage)
    CFLAGS += $(CFLAGS_STACK)

does not work as we expect because cc-option sees exit status to judge whether the given option is supported or not.

To suppress warnings for such targets that -fstack-usage is not supported, this commit surrounds the concerned lines with
ifdef CONFIG_CC_STACKUSAGE .. endif.

---
 config.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
config.mk +3 -3
index 48913f6..d405ab4 100644
@@ -278,9 +278,9 @@ CFLAGS_WARN := $(call cc-option,-Wno-format-nonliteral) \
 	       $(call cc-option,-Wno-format-security)
 CFLAGS += $(CFLAGS_WARN)
 
-# Report stack usage if supported
-CFLAGS_STACK := $(call cc-option,-fstack-usage)
-CFLAGS += $(CFLAGS_STACK)
+ifdef CONFIG_CC_STACKUSAGE
+CFLAGS += $(call cc-option,-fstack-usage)
+endif
 
 BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 19 lines · Masahiro Yamada

As far as I know, gcc does not support -fstack-usage for some targets such as blackfin, m68k, microblaze, etc.

If -fstack-usage option is given for those targets, gcc displays a warning message as follows:

warning: -fstack-usage not supported for this target [enabled by default]

But it still exits with status 0.

So,

    # Report stack usage if supported
    CFLAGS_STACK := $(call cc-option,-fstack-usage)
    CFLAGS += $(CFLAGS_STACK)

does not work as we expect because cc-option sees exit status to judge whether the given option is supported or not.

Quoted 6 lines

To suppress warnings for such targets that -fstack-usage is not supported, this commit surrounds the concerned lines with
ifdef CONFIG_CC_STACKUSAGE .. endif.

The problem here is that except for whatever arches don't support
- -fstack-usage, we always want to generate this information, to assist in debugging stack usage problems (which can be a real problem within SPL for example). How about ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif around it?

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSRCAOAAoJENk4IS6UOR1WQ3AP/2kWJVnQqpMXUvX5XJ/jXzsW tNx0Rj+JZcXgH8Nl4EAPj/oBQEA6H5Qnic0pEE9G8HpkrgEsCfqn9wAsbvN/8pCw ZaU7zkORh4ieAz1w+ZJeJgx8rksxWNbVqFzttwDrOtvOK2s1WMLi7zfypw7DPoc/ ZPuvZJRHbbEFMqf9Y6Mo2smnM9uo+z+JnsNBio2Fau5A8VoZIaAI8Z2rob352oQ7 1MM2J1ncrmxEOO178CEbLD0dAJWqNZFNfpSZpfb/V+vYMaAMmCgYALXuBbue+JDy PfeRxPD8iXiv5G40dQce0mjoUVDujnuOAlralaQBv0okegnGgF6ghf+bWt+sxTuT h9/nY3i0ToRplsk2GKNAMVDNzonKBgk9BAz78ZVc6qMaLi6g9d8XVfXhoLLbWLPC XEEZOYlflt6pnsybQjhux0UOm6hyy1moqll6GukEVmUWtYrMjimPLy2uKmeTdPbU vnHOCcRHUD8SPBAyA9voOlwDJteusVH6FAsNoXLSSjnLI+vrBLhXTlUH/kRXMuA3 JRSLLBcwRi/VDxe0gWjSGbmTnOiWVKkg9nLNBdqMnqJI8vTYZjwDxJ50RLUQJWSq N+kB3yZ/+ElhPi7vjJc8hy+sHUNfoVN1z6TyfY1fRxJfXXccDyBUE8eqEOWxBGg7 YldF9zwHiqjs2m/WuiIY
=YRCk
-----END PGP SIGNATURE-----

#2 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Quoted 3 lines · Tom Rini
Quoted 2 lines · Masahiro Yamada

As far as I know, gcc does not support -fstack-usage for some targets such as blackfin, m68k, microblaze, etc.

Please remove microblaze from this list.
Our gcc support fstack-usage.

If your microblaze gcc doesn't support this flag
then upgrade gcc version.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130926/afa49300/attachment.pgp>
#3 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hello Michal

Quoted 2 lines

Please remove microblaze from this list.
Our gcc support fstack-usage.

I will. Thanks for helpful information!

Quoted 2 lines

If your microblaze gcc doesn't support this flag
then upgrade gcc version.

I tested microblaze-linux-gcc 4.8.0
I downloaded from ftp://ftp.kernel.org/pub/tools/crosstool/index.html

Can I get the prebuilt newer version at some download sites or need to build from source code?

Best Regards
Masahiro Yamada

#4 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hi,

David: Can you please tell to Masahiro where he can download toolchain in any format which will support -fstack-usage.

I have microblazeel-xilinx-linux-gnu-gcc (crosstool-NG 1.18.0) 4.6.4 20120924 (prerelease)

Thanks,
Michal

Quoted 21 lines · Masahiro Yamada

Hello Michal

Quoted 2 lines

Please remove microblaze from this list.
Our gcc support fstack-usage.

I will. Thanks for helpful information!

Quoted 2 lines

If your microblaze gcc doesn't support this flag
then upgrade gcc version.

I tested microblaze-linux-gcc 4.8.0
I downloaded from ftp://ftp.kernel.org/pub/tools/crosstool/index.html

Can I get the prebuilt newer version at some download sites or need to build from source code?

Best Regards
Masahiro Yamada

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130927/8a6c6cda/attachment.pgp>
#5 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

In reply to Tom Rini

Hello Tom.

Quoted 5 lines

The problem here is that except for whatever arches don't support
- -fstack-usage, we always want to generate this information, to assist in debugging stack usage problems (which can be a real problem within SPL for example). How about ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif around it?

OK. This works.

But I'm kind of afraid ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif might be too arch-specific to be written in the top config.mk.

Instead, we can add
CONFIG_CC_STACKUSAGE=y
to arch/{arm, powerpc, x86, microblaze ...}/config.mk

Best Regards
Masahiro Yamada

#6 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hello Masahiro,

Quoted 6 lines · Masahiro Yamada
Quoted 6 lines

The problem here is that except for whatever arches don't support
- -fstack-usage, we always want to generate this information, to assist in debugging stack usage problems (which can be a real problem within SPL for example). How about ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif around it?

Quoted 8 lines

OK. This works.

But I'm kind of afraid ifneq($(CONFIG_M68K)$(CONFIG_...),y) ... endif might be too arch-specific to be written in the top config.mk.

Instead, we can add
CONFIG_CC_STACKUSAGE=y
to arch/{arm, powerpc, x86, microblaze ...}/config.mk

I guess below patch should work as well. Anyone aware of any side affects it might cause?

---
Regards,
Jeroen

config.mk +0 -0
index 48913f6..177f685 100644
@@ -117,7 +117,7 @@ CC_TEST_OFILE := 

$(OBJTREE)/include/generated/cc_test_file.o
-include $(CC_OPTIONS_CACHE_FILE)

cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_OFILE)); \
- if $(CC) $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
+ if $(CC) -Werror $(CFLAGS) $(1) -S -xc /dev/null -o

$(CC_TEST_OFILE) \
                 > /dev/null 2>&1; then \
                 echo 'CC_OPTIONS += $(strip $1)' >> 
$(CC_OPTIONS_CACHE_FILE); \
                 echo "$(1)"; fi)
#7 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hello Jeroen,

Quoted 12 lines
config.mk +0 -0
index 48913f6..177f685 100644
@@ -117,7 +117,7 @@ CC_TEST_OFILE := 

$(OBJTREE)/include/generated/cc_test_file.o
-include $(CC_OPTIONS_CACHE_FILE)

cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_OFILE)); \
- if $(CC) $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
+ if $(CC) -Werror $(CFLAGS) $(1) -S -xc /dev/null -o

Quoted 5 lines
$(CC_TEST_OFILE) \
                 > /dev/null 2>&1; then \
                 echo 'CC_OPTIONS += $(strip $1)' >> 
$(CC_OPTIONS_CACHE_FILE); \
                 echo "$(1)"; fi)

It looks like this was already suggested by Tom too. See http://patchwork.ozlabs.org/patch/183174/

I tested this patch but unfortunatelly it did not work.

I downloaded bfin-linux-gcc 4.6.3 from ftp://ftp.kernel.org/pub/tools/crosstool/index.html

I added -Werror to config.mk and I tried:

CROSS_COMPILE=bfin-linux- ./MAKEALL -a blackfin

The log message was still sprinkled with lots of warnings like
warning: -fstack-usage not supported for this target [enabled by default]

So, I looked into it more closely and
I found gcc can compile the input file /dev/null successfully even if -fstack-usage is not supported.

    $ bfin-uclinux-gcc -fstack-usage -S -xc /dev/null 
    $ echo $?
    0
    $ bfin-uclinux-gcc -Werror -fstack-usage -S -xc /dev/null 
    $ echo $?
    0

Instead of /dev/null, I prepared a very simple C source code as an input.

    $ cat test.c
    int test(void)
    {
        return 0;
    }
    $ bfin-uclinux-gcc -fstack-usage -S -xc test.c
    test.c: In function 'test':
    test.c:4:1: warning: -fstack-usage not supported for this target [enabled by default]
    $ echo $?
    0
    $ bfin-uclinux-gcc -fstack-usage -Werror -S -xc test.c
    test.c: In function 'test':
    test.c:4:1: error: -fstack-usage not supported for this target [-Werror]
    cc1: all warnings being treated as errors
    $ echo $?
    1

This time we can detect unsupported -fstack-usage by the exit status.

So, along with -Werror, I think /dev/null should also be replaced with some _REAL_ C source file.
But my concern about this treak is we might go far from Kbuild. In Linux Kernel, cc-option is impilemented in scripts/Kbuild.include. It uses /dev/null as input.
I wish U-Boot would someday adopt (not nessarily the same but very similar) Kbuild.

If you see Linux Kernel top Makefile,
many of optional CFLAGS are provided thru cc-option and also can be turned on/off by CONFIG_ switch.

That is one reason I suggested to introduce CONFIG_CC_STACKUSAGE option. But this is just my opinion and I would not necessarily stick to this idea. Please feel free to suggest your thought.

Best Regards
Masahiro Yamada

#8 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hello Masahiro,

Quoted 80 lines · Masahiro Yamada

Hello Jeroen,

Quoted 8 lines
config.mk +0 -0
index 48913f6..177f685 100644
@@ -117,7 +117,7 @@ CC_TEST_OFILE :=

$(OBJTREE)/include/generated/cc_test_file.o
-include $(CC_OPTIONS_CACHE_FILE)

Quoted 9 lines
   cc-option-sys = $(shell mkdir -p $(dir $(CC_TEST_OFILE)); \
-               if $(CC) $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
+               if $(CC) -Werror $(CFLAGS) $(1) -S -xc /dev/null -o
$(CC_TEST_OFILE) \
                  > /dev/null 2>&1; then \
                  echo 'CC_OPTIONS += $(strip $1)' >>
$(CC_OPTIONS_CACHE_FILE); \
                  echo "$(1)"; fi)

It looks like this was already suggested by Tom too. See http://patchwork.ozlabs.org/patch/183174/

I tested this patch but unfortunatelly it did not work.

I downloaded bfin-linux-gcc 4.6.3 from ftp://ftp.kernel.org/pub/tools/crosstool/index.html

I added -Werror to config.mk and I tried:

CROSS_COMPILE=bfin-linux- ./MAKEALL -a blackfin

The log message was still sprinkled with lots of warnings like
warning: -fstack-usage not supported for this target [enabled by default]

So, I looked into it more closely and
I found gcc can compile the input file /dev/null successfully even if -fstack-usage is not supported.

     $ bfin-uclinux-gcc -fstack-usage -S -xc /dev/null
     $ echo $?
     0
     $ bfin-uclinux-gcc -Werror -fstack-usage -S -xc /dev/null
     $ echo $?
     0

Instead of /dev/null, I prepared a very simple C source code as an input.

     $ cat test.c
     int test(void)
     {
         return 0;
     }
     $ bfin-uclinux-gcc -fstack-usage -S -xc test.c
     test.c: In function 'test':
     test.c:4:1: warning: -fstack-usage not supported for this target [enabled by default]
     $ echo $?
     0
     $ bfin-uclinux-gcc -fstack-usage -Werror -S -xc test.c
     test.c: In function 'test':
     test.c:4:1: error: -fstack-usage not supported for this target [-Werror]
     cc1: all warnings being treated as errors
     $ echo $?
     1

This time we can detect unsupported -fstack-usage by the exit status.

So, along with -Werror, I think /dev/null should also be replaced with some _REAL_ C source file.
But my concern about this treak is we might go far from Kbuild. In Linux Kernel, cc-option is impilemented in scripts/Kbuild.include. It uses /dev/null as input.
I wish U-Boot would someday adopt (not nessarily the same but very similar) Kbuild.

Quoted 9 lines

If you see Linux Kernel top Makefile,
many of optional CFLAGS are provided thru cc-option and also can be turned on/off by CONFIG_ switch.

That is one reason I suggested to introduce CONFIG_CC_STACKUSAGE option. But this is just my opinion and I would not necessarily stick to this idea. Please feel free to suggest your thought.

I tried to google this a bit, one thing I found was
http://sourceware.org/bugzilla/show_bug.cgi?id=5210, but I fail to (easily) find a reliable gcc reference. Perhaps we should file a bug? -Werror doesn't work with /dev/null when -fstack-usage is not supported...

I cannot comment on your concern regarding Kbuild, since I am unaware of its internals. I just suggested above since it would be a cleaner approach (if it worked...).

Regards,
Jeroen

#9 lore raw

PATCH 1/1 config.mk: enable -fstack-usage only when it is desired

Hello Jeroen

Quoted 6 lines

I tried to google this a bit, one thing I found was
http://sourceware.org/bugzilla/show_bug.cgi?id=5210, but I fail to (easily) find a reliable gcc reference. Perhaps we should file a bug? -Werror doesn't work with /dev/null when -fstack-usage is not supported...

I might be a bug but I cannot say with confident. Anyway, we need to do something
with the current gcc behavior.

Quoted 3 lines

I cannot comment on your concern regarding Kbuild, since I am unaware of its internals. I just suggested above since it would be a cleaner approach (if it worked...).

I posted
version2 : config.mk: disable -fstack-usage for blackfin and m68k and
version3 : config.mk: fix -fstack-usage support test

I think the latter is close to your idea and I believe it's better.

Best Regards
Masahiro Yamada