Skip to contentSkip to conversation

ARM: tegra: add clock properties for devices of Tegra124

PATCH New Joseph Lo 2 participants 4 messages Oct 8, 2013 – Dec 12, 2013

Subsystems (2)
lore
Share & tools
lore

Joseph Lo

author
#0 lore raw

PATCH 1/1 ARM: tegra: add clock properties for devices of Tegra124

This patch adds clock properties for devices in the DT for basic support of Tegra124 SoC.

---
This patch was based on the series of Tegra124 clock driver and the basic support of Tegra124. It coulud be used to replace the "HACK" patch in the basic support of Tegra124 series.

---
 arch/arm/boot/dts/tegra124-venice2.dts | 13 +++++++++++++
 arch/arm/boot/dts/tegra124.dtsi        | 16 ++++++++++++++++
 2 files changed, 29 insertions(+)
arch/arm/boot/dts/tegra124-venice2.dts +13 -0
index 2bfc7ab..5859ec2 100644
@@ -17,4 +17,17 @@
 	pmc at 7000e400 {
 		nvidia,invert-interrupt;
 	};
+
+	clocks {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		clk32k_in: clock {
+			compatible = "fixed-clock";
+			reg=<0>;
+			#clock-cells = <0>;
+			clock-frequency = <32768>;
+		};
+	};
 };
arch/arm/boot/dts/tegra124.dtsi +16 -0
index 905f148..7862024 100644
@@ -1,3 +1,4 @@
+#include <dt-bindings/clock/tegra124-car.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 
 #include "skeleton.dtsi"
@@ -27,6 +28,13 @@
 			     <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&tegra_car TEGRA124_CLK_TIMER>;
+	};
+
+	tegra_car: clock at 60006000 {
+		compatible = "nvidia,tegra124-car";
+		reg = <0x60006000 0x1000>;
+		#clock-cells = <1>;
 	};
 
 	/*
@@ -43,6 +51,7 @@
 		reg-shift = <2>;
 		interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_UARTA>;
 	};
 
 	serial at 70006040 {
@@ -51,6 +60,7 @@
 		reg-shift = <2>;
 		interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_UARTB>;
 	};
 
 	serial at 70006200 {
@@ -59,6 +69,7 @@
 		reg-shift = <2>;
 		interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_UARTC>;
 	};
 
 	serial at 70006300 {
@@ -67,6 +78,7 @@
 		reg-shift = <2>;
 		interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_UARTD>;
 	};
 
 	serial at 70006400 {
@@ -75,6 +87,7 @@
 		reg-shift = <2>;
 		interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_UARTE>;
 	};
 
 	rtc at 7000e000 {
@@ -82,11 +95,14 @@
 		reg = <0x7000e000 0x100>;
 		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
 		status = "disabled";
+		clocks = <&tegra_car TEGRA124_CLK_RTC>;
 	};
 
 	pmc at 7000e400 {
 		compatible = "nvidia,tegra124-pmc";
 		reg = <0x7000e400 0x400>;
+		clocks = <&tegra_car TEGRA124_CLK_PCLK>, <&clk32k_in>;
+		clock-names = "pclk", "clk32k_in";
 	};
 
 	cpus {
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 ARM: tegra: add clock properties for devices of Tegra124

Quoted 2 lines · Joseph Lo

This patch adds clock properties for devices in the DT for basic support of Tegra124 SoC.

This looks reasonable. I'll wait until the clock driver stuff is finalized and merged, then apply this on top.

#2 lore raw

PATCH 1/1 ARM: tegra: add clock properties for devices of Tegra124

Quoted 6 lines · Stephen Warren
Quoted 2 lines · Joseph Lo

This patch adds clock properties for devices in the DT for basic support of Tegra124 SoC.

This looks reasonable. I'll wait until the clock driver stuff is finalized and merged, then apply this on top.

Actually, I can't apply this yet, since it relies on the file <dt-bindings/clock/tegra124-car.h>, which is being added for 3.13 in a patch in the clock tree. This will have to wait until v3.13-rc1 or later.

#3 lore raw

PATCH 1/1 ARM: tegra: add clock properties for devices of Tegra124

In reply to Joseph Lo
Quoted 2 lines · Joseph Lo

This patch adds clock properties for devices in the DT for basic support of Tegra124 SoC.

I've applied this to Tegra's for-3.14/dt branch, with one minor fixup to add a unit address to /clocks/clock in tegra124-venice2.dts.