Skip to contentSkip to conversation

Fixed to checkpatch.pl errors to vlan_dev.c

PATCH In review Ozgur Karatas 2 participants 2 messages Dec 5, 2016

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ozgur Karatas

author
#0 lore raw

PATCH 1/1 Fixed to checkpatch.pl errors to vlan_dev.c

Hello all,

I will solve a checkpatch errors.

Signed-off-by Ozgur Karatas <[email protected]>
---
 net/8021q/vlan_dev.c                               |   2 +-
net/8021q/vlan_dev.c +1 -1
index fbfacd5..2edb495 100644
@@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
 
 static void vlan_dev_netpoll_cleanup(struct net_device *dev)
 {
-       struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
+       struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
        struct netpoll *netpoll = vlan->netpoll;
 
        if (!netpoll)
#1 lore raw

Hello.

Quoted 5 lines · Ozgur Karatas

Hello all,

I will solve a checkpatch errors.

Signed-off-by Ozgur Karatas <[email protected]>

The patch itself looks good, but please have a read about having a good commit message. I would suggest reading Documentation/SubmittingPatches section 14: The canonical patch format

Especially the parts about the subject line and summary.

Quoted 9 lines
---
 net/8021q/vlan_dev.c                               |   2 +-
net/8021q/vlan_dev.c +0 -0
index fbfacd5..2edb495 100644

net/8021q/vlan_dev.c static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n · line 744

Quoted 8 lines
net/8021q/vlan_dev.c +1 -1
@@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
 
 static void vlan_dev_netpoll_cleanup(struct net_device *dev)
 {
-       struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
+       struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
        struct netpoll *netpoll = vlan->netpoll;
 
        if (!netpoll)

regards
Stefan Schmidt