Skip to contentSkip to conversation

sf: add missing Atmel at25df321 spi flash support

PATCH New Bo Shen 4 participants 12 messages Oct 10, 2013 – Oct 14, 2013 1 message not in the archive Memory technology devices (MTD)

lore
Share & tools
lore

Bo Shen

author
#0 lore raw

PATCH 1/3 sf: add missing Atmel at25df321 spi flash support

As the spi flash transfer to multiple parts, it is forgot to add Atmel AT25DF321 spi flash support, which broken several Atmel EK boards which this chip. So, add it

---
 drivers/mtd/spi/sf_probe.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/sf_probe.c +1 -0
index 4251b1b..6e19d79 100644
@@ -46,6 +46,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
 	{"AT45DB161D",	   0x1f2600, 0x0,	64 * 1024,    32,	       SECT_4K},
 	{"AT45DB321D",	   0x1f2700, 0x0,	64 * 1024,    64,	       SECT_4K},
 	{"AT45DB641D",	   0x1f2800, 0x0,	64 * 1024,   128,	       SECT_4K},
+	{"AT25DF321",      0x1f4701, 0x0,	64 * 1024,    64,	       SECT_4K},
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	{"EN25Q32B",	   0x1c3016, 0x0,	64 * 1024,    64,	             0},
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/3 sf: change indentation in <sf_probe.c>

---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +1 -1
index 6e19d79..9646914 100644
@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
  * @jedec:		Device jedec ID (0x[1byte_manuf_id][2byte_dev_id])
  * @ext_jedec:		Device ext_jedec ID
  * @sector_size:	Sector size of this device
- * @nr_sectors:	No.of sectors on this device
+ * @nr_sectors:		No.of sectors on this device
  * @flags:		Importent param, for flash specific behaviour
  */
 struct spi_flash_params {
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/3 sf: change indentation in <sf_probe.c>

Quoted 10 lines · Bo Shen
---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +0 -0
index 6e19d79..9646914 100644

drivers/mtd/spi/sf_probe.c DECLARE_GLOBAL_DATA_PTR; · line 29

Quoted 6 lines
drivers/mtd/spi/sf_probe.c +1 -1
@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
  * @jedec:             Device jedec ID (0x[1byte_manuf_id][2byte_dev_id])
  * @ext_jedec:         Device ext_jedec ID
  * @sector_size:       Sector size of this device
- * @nr_sectors:        No.of sectors on this device
+ * @nr_sectors:                No.of sectors on this device
  * @flags:             Importent param, for flash specific behaviour

Added this cleanup part of some others too and sent a patch, please Ack.

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
author
#3 lore raw

PATCH 3/3 sf: using the same license header format

In reply to Bo Shen
---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +1 -1
index 9646914..2086022 100644
@@ -5,7 +5,7 @@
  * Copyright (C) 2010 Reinhard Meyer, EMK Elektronik
  * Copyright (C) 2013 Jagannadha Sutradharudu Teki, Xilinx Inc.
  *
- * Licensed under the GPL-2 or later.
+ * SPDX-License-Identifier:	GPL-2.0+
  */
 
 #include <common.h>
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 3/3 sf: using the same license header format

Quoted 11 lines · Bo Shen
---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +0 -0
index 9646914..2086022 100644

drivers/mtd/spi/sf_probe.c line 9

Quoted 6 lines
drivers/mtd/spi/sf_probe.c +1 -1
@@ -5,7 +5,7 @@
  * Copyright (C) 2010 Reinhard Meyer, EMK Elektronik
  * Copyright (C) 2013 Jagannadha Sutradharudu Teki, Xilinx Inc.
  *
- * Licensed under the GPL-2 or later.
+ * SPDX-License-Identifier:    GPL-2.0+
  */

I guess "Licensed under the GPL-2 or later." is not comes under SPDX. Can you please confirm.

Added Wolfgang Denk and Tom - may be they will clarify.

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
#5 lore raw

PATCH 3/3 sf: using the same license header format

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 22 lines · Jagan Teki
Quoted 11 lines · Bo Shen
---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +0 -0
index 9646914..2086022 100644

drivers/mtd/spi/sf_probe.c line 9

Quoted 6 lines
drivers/mtd/spi/sf_probe.c +1 -1
@@ -5,7 +5,7 @@
  * Copyright (C) 2010 Reinhard Meyer, EMK Elektronik
  * Copyright (C) 2013 Jagannadha Sutradharudu Teki, Xilinx Inc.
  *
- * Licensed under the GPL-2 or later.
+ * SPDX-License-Identifier:    GPL-2.0+
  */

I guess "Licensed under the GPL-2 or later." is not comes under SPDX. Can you please confirm.

Quoted 1 line

Added Wolfgang Denk and Tom - may be they will clarify.

We're using the same tag and format everywhere, so this change is correct to make. Thanks!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSVtnWAAoJENk4IS6UOR1WLUwP/A4iR/rtHb++TuHx8EVUFP/W 2Hssb2awA8w/TipKq+PjdNOVJunKqEZx3Z44RUTcWVpYNFWpsrsm8fo/Wc7JLHwd uciIG2p0fjV7TcPYUzma2rDteJMotcXpcURX9fDRjbEh3Dd8fU9uO7lDgo4WwwTL qRFs/Zh4LOJqh3gINkMO5DC4fcG4DipYd0PDgdaHWrYt/RkJ71BxvAsuM3YQIRZz J7XYcUphcIMh16TWTi5Fwz2db0PnekCe347YbrVXxtC20Yly9a633q9joYdsqzwI J0QntQ30PY4nI21ZRwUsGdW84jhBT4P1/Y/IDkC+bsfA3ih+n5VH+3k6DqK0ikit Piy3ZfSkgXcAEX1lXee3/S7SIxDzn9yu2F3Lex/cwGmBSa02ehhn2wYJwyjC1aZc 5yzC9g5tSJjR+kyMDw6qc2A6pRp08LMchRBDRS0Wz1OutPyAGnwwYHlyW4isbwwY hZFBz9yKGnSZBDYXCBu2udy/lnK69j0Oi1JLwm0GFsuwt5wkkd4Fk4P2bvdYunez oQ7Cu/v2Fkwrpzt5E8w2HqE4jO0Tpls+ciOOZcqB1Fb+nCf8IdWUWIQWcjRuzK3w HF74r1pcYdBY5b9OtKh3YinrleMVb6vkCb4l7Sgr1avyHxNXFaZJxW/m8lwX1/nD sicEfHHYlQyxdl/+71aS
=BtiO
-----END PGP SIGNATURE-----

#6 lore raw

PATCH 3/3 sf: using the same license header format

Quoted 26 lines · Tom Rini

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 22 lines · Jagan Teki
Quoted 11 lines · Bo Shen
---
 drivers/mtd/spi/sf_probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/sf_probe.c +0 -0
index 9646914..2086022 100644

drivers/mtd/spi/sf_probe.c line 9

Quoted 6 lines
drivers/mtd/spi/sf_probe.c +1 -1
@@ -5,7 +5,7 @@
  * Copyright (C) 2010 Reinhard Meyer, EMK Elektronik
  * Copyright (C) 2013 Jagannadha Sutradharudu Teki, Xilinx Inc.
  *
- * Licensed under the GPL-2 or later.
+ * SPDX-License-Identifier:    GPL-2.0+
  */

I guess "Licensed under the GPL-2 or later." is not comes under SPDX. Can you please confirm.

Quoted 4 lines
Quoted 1 line

Added Wolfgang Denk and Tom - may be they will clarify.

We're using the same tag and format everywhere, so this change is correct to make. Thanks!

Thanks Tom.

Bo Shen, I will add this change + and respective sf files changes and send out a patch.

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
#7 lore raw

PATCH 3/3 sf: using the same license header format

In reply to Jagan Teki

Dear Jagan Teki,

Quoted 9 lines · In message <CAD6G_RSBiJn4eaKco4-Gx9uKoMyhAEpWewrm91DW3Qf_he0ivw@mail.gmail.com>…
Quoted 4 lines

- * Licensed under the GPL-2 or later.
+ * SPDX-License-Identifier: GPL-2.0+
*/

I guess "Licensed under the GPL-2 or later." is not comes under SPDX. Can you please confirm.

Added Wolfgang Denk and Tom - may be they will clarify.

"GPL-2 or later" means GPL-2.0+; the suggested patch looks fine to me.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In Nature there are neither rewards nor punishments, there are conse-
quences.                                            -- R.G. Ingersoll

A message that is not in the archive (sent off-list or not yet received): CAD6G_RSJbaQz4pqHwxt6Y0Z7iBm_W4DQ_MQ0zJHZGKBnDd4z=A@mail.gmail.com

author
#9 lore raw

PATCH 1/3 sf: add missing Atmel at25df321 spi flash support

Hi Jagan,

Quoted 12 lines · Jagan Teki

Thanks for this.

Quoted 9 lines · Bo Shen

As the spi flash transfer to multiple parts, it is forgot to add Atmel AT25DF321 spi flash support, which broken several Atmel EK boards which this chip. So, add it

---
  drivers/mtd/spi/sf_probe.c |    1 +
  1 file changed, 1 insertion(+)
Quoted 14 lines

drivers/mtd/spi/sf_probe.c static const struct spi_flash_params spi_flash_params_table[] = { · line 52

Quoted 12 lines
drivers/mtd/spi/sf_probe.c +1 -0
index 4251b1b..6e19d79 100644
@@ -46,6 +46,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
         {"AT45DB161D",     0x1f2600, 0x0,       64 * 1024,    32,              SECT_4K},
         {"AT45DB321D",     0x1f2700, 0x0,       64 * 1024,    64,              SECT_4K},
         {"AT45DB641D",     0x1f2800, 0x0,       64 * 1024,   128,              SECT_4K},
+       {"AT25DF321",      0x1f4701, 0x0,       64 * 1024,    64,              SECT_4K},
  #endif
  #ifdef CONFIG_SPI_FLASH_EON            /* EON */
         {"EN25Q32B",       0x1c3016, 0x0,       64 * 1024,    64,                    0},

Did you tested Atmel flash with new probe support?

Yes, tested with AT25DF321 (the missing one). It works well.

For AT45 series, not tested yet, as in mainline, for AT45 series, they are using dataflash driver. I am planning to move AT45 series using SF, but too busy and this just in work queue.

Best Regards,
Bo Shen

author
#10 lore raw

PATCH 1/3 sf: add missing Atmel at25df321 spi flash support

Hi Jagan,
Cc Tom.

Quoted 14 lines · Bo Shen

Hi Jagan,

Quoted 11 lines · Jagan Teki

Thanks for this.

Quoted 8 lines · Bo Shen

As the spi flash transfer to multiple parts, it is forgot to add Atmel AT25DF321 spi flash support, which broken several Atmel EK boards which this chip. So, add it

---
  drivers/mtd/spi/sf_probe.c |    1 +
  1 file changed, 1 insertion(+)

If this patch not applied before release at Oct 14, it will make a regression for several Atmel EK boards boot from spi flash.

Would you please pick it before release?

Best Regards,
Bo Shen

#11 lore raw

PATCH 1/3 sf: add missing Atmel at25df321 spi flash support

Quoted 18 lines · Bo Shen

Hi Jagan,
Cc Tom.

Quoted 13 lines · Bo Shen

Hi Jagan,

Quoted 9 lines · Jagan Teki

Thanks for this.

Quoted 5 lines · Bo Shen

As the spi flash transfer to multiple parts, it is forgot to add Atmel AT25DF321 spi flash support, which broken several Atmel EK boards which this chip. So, add it

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
---
  drivers/mtd/spi/sf_probe.c |    1 +
  1 file changed, 1 insertion(+)

If this patch not applied before release at Oct 14, it will make a regression for several Atmel EK boards boot from spi flash.

Agreed, thanks for your concern.

Quoted 2 lines

Would you please pick it before release?

Yes, I will pick this.
and will send one more pull request for cleanup, this should be part of.

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
author
#12 lore raw

PATCH 1/3 sf: add missing Atmel at25df321 spi flash support

Hi Jagan,

Quoted 25 lines · Jagan Teki
Quoted 24 lines · Bo Shen

Hi Jagan,
Cc Tom.

Quoted 17 lines · Bo Shen

Hi Jagan,

Quoted 13 lines · Jagan Teki

Thanks for this.

Quoted 9 lines · Bo Shen

As the spi flash transfer to multiple parts, it is forgot to add Atmel AT25DF321 spi flash support, which broken several Atmel EK boards which this chip. So, add it

---
   drivers/mtd/spi/sf_probe.c |    1 +
   1 file changed, 1 insertion(+)
Quoted 8 lines
Quoted 2 lines

If this patch not applied before release at Oct 14, it will make a regression for several Atmel EK boards boot from spi flash.

Agreed, thanks for your concern.

Quoted 2 lines

Would you please pick it before release?

Yes, I will pick this.
and will send one more pull request for cleanup, this should be part of.

Thanks.

Best Regards,
Bo Shen