include/asm-generic/atomic.h: use 'unsigned int' instead of 'unsigned long' for atomic_clear_mask()
Subsystems (2)
PATCH 1/1 include/asm-generic/atomic.h: use 'unsigned int' instead of 'unsigned long' for atomic_clear_mask()
For atomic_clear_mask(), 'v->counter' is 'int', so it is better to use 'unsigned int' instead of 'unsigned long' for parameter 'mask' to make atomic_clear_mask() itself consistency.
And atomic_[set/clear]_mask() are pairs, the modification can also let them consistent with each other.
Although the original implementation can not cause bugs, it is still better to let it improved.
Signed-off-by Chen Gang <[email protected]>
--- include/asm-generic/atomic.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/asm-generic/atomic.h +1 -1
@@ -153,7 +153,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)* Atomically clears the bits set in @mask from @v */ #ifndef atomic_clear_mask -static inline void atomic_clear_mask (unsigned long mask,atomic_t *v) +static inline void atomic_clear_mask (unsigned int mask,atomic_t *v) {unsigned long flags;
Signature · 1 line
1.7.7.6