i2c_reloc_fixup fails on m68k
RFC 1/1 i2c_reloc_fixup fails on m68k
Hello,
I have a access violation problem with i2c_reloc_fixup on coldfire m68k systems.
I found out, the i2c_reloc_fixup tries to relocate the adapter itself, but at this time i2c_adap_p is already relocated.
Can anybody confirm this?
I think also m68k, backfin and nds32 systems are affected
regards
Jens
---
drivers/i2c/i2c_core.c +0 -4
@@ -53,10 +53,6 @@ void i2c_reloc_fixup(void)return ;for (i =0 ; i < max; i++) { -/* adapter itself */ - addr = (unsigned long )i2c_adap_p; - addr += gd->reloc_off; - i2c_adap_p = (struct i2c_adapter *)addr;/* i2c_init() */ addr = (unsigned long )i2c_adap_p->init; addr += gd->reloc_off;
Hello Jens,
Am 23.09.2013 15:50, schrieb Jens Scharsig:
Quoted 7 lines
Hello,
I have a access violation problem with
i2c_reloc_fixupon coldfire m68k systems.I found out, the
i2c_reloc_fixuptries to relocate the adapter itself, but at this timei2c_adap_pis already relocated.
Which toolchain?
Quoted 1 line
Can anybody confirm this?
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) and Macpaul Lin (for nds32) to Cc ...
Quoted 1 line
I think also m68k, backfin and nds32 systems are affected
Sorry, I have no such system ... maybe you are the first who stepped in it ...
Quoted 6 lines
---
drivers/i2c/i2c_core.c +0
-0
drivers/i2c/i2c_core.c void i2c_reloc_fixup(void) · line 58
Quoted 10 lines
drivers/i2c/i2c_core.c +0
-4@@ -53,10 +53,6 @@ void i2c_reloc_fixup(void)return ;for (i =0 ; i< max; i++) { -/* adapter itself */ - addr = (unsigned long )i2c_adap_p; - addr += gd->reloc_off; - i2c_adap_p = (struct i2c_adapter *)addr;/* i2c_init() */ addr = (unsigned long )i2c_adap_p->init; addr += gd->reloc_off;
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hello Heiko,
Quoted 8 lines
Hello Jens,
Quoted 5 lines
I have a access violation problem with
i2c_reloc_fixupon coldfire m68k systems.I found out, the
i2c_reloc_fixuptries to relocate the adapter itself, but at this timei2c_adap_pis already relocated.Which toolchain?
m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1 Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Quoted 10 lines
Quoted 2 lines
Can anybody confirm this?
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) and Macpaul Lin (for nds32) to Cc ...
Quoted 1 line
I think also m68k, backfin and nds32 systems are affected
Sorry, I have no such system ... maybe you are the first who stepped in it ...
I have only a m68k system, but only this tree arch's call i2c_reloc_fixup in this way.
regards
Jens
Hello Jens,
Am 24.09.2013 09:41, schrieb Jens Scharsig:
Quoted 21 lines
Hello Heiko,
Quoted 8 lines
Hello Jens,
Quoted 5 lines
I have a access violation problem with
i2c_reloc_fixupon coldfire m68k systems.I found out, the
i2c_reloc_fixuptries to relocate the adapter itself, but at this timei2c_adap_pis already relocated.Which toolchain?
m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1 Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.Quoted 6 lines
Quoted 2 lines
Can anybody confirm this?
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) and Macpaul Lin (for nds32) to Cc ...
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
I think also m68k, backfin and nds32 systems are affected
Sorry, I have no such system ... maybe you are the first who stepped in it ...
I have only a m68k system, but only this tree arch's call
i2c_reloc_fixupin this way.
Any news here?
@Jens: I want to add this patch in the new merge window, could you send a correct patch please, thanks!
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hello Heiko,
Am 2013-10-14 07:51, schrieb Heiko Schocher:
Quoted 26 lines
Hello Jens,
Am 24.09.2013 09:41, schrieb Jens Scharsig:
Quoted 23 lines
Hello Heiko,
Quoted 8 lines
Hello Jens,
Quoted 5 lines
I have a access violation problem with
i2c_reloc_fixupon coldfire m68k systems.I found out, the
i2c_reloc_fixuptries to relocate the adapter itself, but at this timei2c_adap_pis already relocated.Which toolchain?
m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1 Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.Quoted 8 lines
Quoted 2 lines
Can anybody confirm this?
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) and Macpaul Lin (for nds32) to Cc ...
Quoted 1 line
I think also m68k, backfin and nds32 systems are affected
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Sorry, I have no such system ... maybe you are the first who stepped in it ...
I have only a m68k system, but only this tree arch's call
i2c_reloc_fixupin this way.Any news here?
No, silence anywhere
Quoted 3 lines
@Jens: I want to add this patch in the new merge window, could you send a correct patch please, thanks!
I will do this soon.
Regards Jens
Quoted 13 lines · On Tuesday 24 September 2013 02:33:55 Heiko Schocher wrote:
Am 23.09.2013 15:50, schrieb Jens Scharsig:
Quoted 7 lines
Hello,
I have a access violation problem with
i2c_reloc_fixupon coldfire m68k systems.I found out, the
i2c_reloc_fixuptries to relocate the adapter itself, but at this timei2c_adap_pis already relocated.Which toolchain?
Quoted 1 line
Can anybody confirm this?
Quoted 7 lines
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k) and Macpaul Lin (for nds32) to Cc ...
Quoted 1 line
I think also m68k, backfin and nds32 systems are affected
Sorry, I have no such system ... maybe you are the first who stepped in it ...
Blackfin doesn't do self-relocation like that, so we don't care :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131014/dbe9d9a2/attachment.pgp>