PCI: Refactor restore_msi_irqs - code movement
PATCH 1/3 PCI: Refactor restore_msi_irqs - code movement
Move default_restore_msi_irqs down to reference msi_mask_irq and msix_mask_irq.
This patch lays the groundwork for patch titled:
'PCI: Refactor MSI/MSIX mask restore code to fix interrupt lost issue'
--- drivers/pci/msi.c | 36 ++++++++++++++++++------------------ 1 files changed, 18 insertions(+), 18 deletions(-)
drivers/pci/msi.c +18 -18
@@ -116,24 +116,6 @@ void __weak arch_teardown_msi_irqs(struct pci_dev *dev)return default_teardown_msi_irqs (dev); } -void default_restore_msi_irqs (struct pci_dev *dev,int irq) -{ -struct msi_desc *entry; - - entry =NULL ; -if (dev->msix_enabled) { -list_for_each_entry (entry, &dev->msi_list, list) { -if (irq == entry->irq) -break ; - } - }else if (dev->msi_enabled) { - entry =irq_get_msi_desc (irq); - } - -if (entry) -write_msi_msg (irq, &entry->msg); -} -void __weak arch_restore_msi_irqs (struct pci_dev *dev,int irq) {return default_restore_msi_irqs (dev, irq);
@@ -252,6 +234,24 @@ void unmask_msi_irq(struct irq_data *data)msi_set_mask_bit (data,0 ); } +void default_restore_msi_irqs (struct pci_dev *dev,int irq) +{ +struct msi_desc *entry; + + entry =NULL ; +if (dev->msix_enabled) { +list_for_each_entry (entry, &dev->msi_list, list) { +if (irq == entry->irq) +break ; + } + }else if (dev->msi_enabled) { + entry =irq_get_msi_desc (irq); + } + +if (entry) +write_msi_msg (irq, &entry->msg); +} +void __read_msi_msg (struct msi_desc *entry,struct msi_msg *msg) {BUG_ON (entry->dev->current_state !=PCI_D0 );
Signature · 1 line
1.7.3
Quoted 9 lines · Zhenzhong Duan
Move
default_restore_msi_irqsdown to referencemsi_mask_irqandmsix_mask_irq.This patch lays the groundwork for patch titled:
'PCI: Refactor MSI/MSIX mask restore code to fix interrupt lost issue'Tested-by Sucheta Chakraborty <[email protected]>Signed-off-by Zhenzhong Duan <[email protected]>
It looks good. Also, I tested this patch on Exynos5440.
Best regards,
Jingoo Han
Quoted 9 lines · Zhenzhong Duan
Move
default_restore_msi_irqsdown to referencemsi_mask_irqandmsix_mask_irq.This patch lays the groundwork for patch titled:
'PCI: Refactor MSI/MSIX mask restore code to fix interrupt lost issue'Tested-by Sucheta Chakraborty <[email protected]>Signed-off-by Zhenzhong Duan <[email protected]>
It looks good. Also, I tested this patch on Exynos5440.
Best regards,
Jingoo Han