ipc/sem.c: fix small codingstyle
PATCH 1/1 ipc/sem.c: fix small codingstyle
From: Li Bin <[email protected]>
small codingstyle fix: '*' should be adjacent to the data name.
--- ipc/sem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ipc/sem.c +1 -1
@@ -2077,7 +2077,7 @@ void exit_sem(struct task_struct *tsk)/* perform adjustments registered in un */ for (i =0 ; i < sma->sem_nsems; i++) { -struct sem * semaphore = &sma->sem_base[i]; +struct sem *semaphore = &sma->sem_base[i];if (un->semadj[i]) { semaphore->semval += un->semadj[i];/*
Signature · 1 line
1.8.2.1
Quoted 3 lines · Libin
From: Li Bin <[email protected]>
small codingstyle fix: '*' should be adjacent to the data name.
There are *tons* of these, go crazy.
Quoted 19 lines
Signed-off-by Li Bin <[email protected]>--- ipc/sem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ipc/sem.c +1
-1@@ -2077,7 +2077,7 @@ void exit_sem(struct task_struct *tsk)/* perform adjustments registered in un */ for (i =0 ; i < sma->sem_nsems; i++) { -struct sem * semaphore = &sma->sem_base[i]; +struct sem *semaphore = &sma->sem_base[i];if (un->semadj[i]) { semaphore->semval += un->semadj[i];/*
Quoted 7 lines · Davidlohr Bueso
Quoted 3 lines · Libin
From: Li Bin <[email protected]>
small codingstyle fix: '*' should be adjacent to the data name.
There are *tons* of these, go crazy.
Here are the whitespace changes proposed by
$ scripts/checkpatch -f --fix --types=pointer_location,spacing,space_before_tab ipc/*.[ch]
$ git diff -w shows no difference
ipc/compat.c | 10 +++--- ipc/compat_mq.c | 2 +- ipc/ipc_sysctl.c | 14 ++++---- ipc/mqueue.c | 16 ++++----- ipc/msg.c | 18 +++++------ ipc/sem.c | 98 ++++++++++++++++++++++++++++---------------------------- ipc/shm.c | 34 ++++++++++---------- ipc/util.c | 24 +++++++------- ipc/util.h | 14 ++++---- 9 files changed, 115 insertions(+), 115 deletions(-)
ipc/compat.c +5 -5
@@ -197,7 +197,7 @@ static inline int __put_compat_ipc_perm(struct ipc64_perm *p,static inline int get_compat_semid64_ds (struct semid64_ds *s64,struct compat_semid64_ds __user *up64) { -if (!access_ok (VERIFY_READ , up64,sizeof (*up64))) +if (!access_ok (VERIFY_READ , up64,sizeof (*up64)))return -EFAULT ;return __get_compat_ipc64_perm (&s64->sem_perm, &up64->sem_perm); }
@@ -205,7 +205,7 @@ static inline int get_compat_semid64_ds(struct semid64_ds *s64,static inline int get_compat_semid_ds (struct semid64_ds *s,struct compat_semid_ds __user *up) { -if (!access_ok (VERIFY_READ , up,sizeof (*up))) +if (!access_ok (VERIFY_READ , up,sizeof (*up)))return -EFAULT ;return __get_compat_ipc_perm (&s->sem_perm, &up->sem_perm); }
@@ -215,7 +215,7 @@ static inline int put_compat_semid64_ds(struct semid64_ds *s64, {int err; -if (!access_ok (VERIFY_WRITE , up64,sizeof (*up64))) +if (!access_ok (VERIFY_WRITE , up64,sizeof (*up64)))return -EFAULT ; err =__put_compat_ipc64_perm (&s64->sem_perm, &up64->sem_perm); err |=__put_user (s64->sem_otime, &up64->sem_otime);
@@ -229,7 +229,7 @@ static inline int put_compat_semid_ds(struct semid64_ds *s, {int err; -if (!access_ok (VERIFY_WRITE , up,sizeof (*up))) +if (!access_ok (VERIFY_WRITE , up,sizeof (*up)))return -EFAULT ; err =__put_compat_ipc_perm (&s->sem_perm, &up->sem_perm); err |=__put_user (s->sem_otime, &up->sem_otime);
@@ -376,7 +376,7 @@ COMPAT_SYSCALL_DEFINE6(ipc, u32, call, int, first, int, second,struct compat_ipc_kludge ipck;if (!uptr)return -EINVAL ; -if (copy_from_user (&ipck, uptr,sizeof (ipck))) +if (copy_from_user (&ipck, uptr,sizeof (ipck)))return -EFAULT ; uptr =compat_ptr (ipck.msgp); fifth = ipck.msgtyp;
ipc/compat_mq.c +1 -1
@@ -64,7 +64,7 @@ asmlinkage long compat_sys_mq_open(const char __user *u_name,return sys_mq_open (u_name, oflag, mode, p); } -static int compat_prepare_timeout (struct timespec __user * *p, +static int compat_prepare_timeout (struct timespec __user **p,const struct compat_timespec __user *u) {struct timespec ts;
ipc/ipc_sysctl.c +7 -7
@@ -166,21 +166,21 @@ static struct ctl_table ipc_kern_table[] = { { .procname = "shmmax", .data = &init_ipc_ns.shm_ctlmax, - .maxlen = sizeof (init_ipc_ns.shm_ctlmax), + .maxlen = sizeof(init_ipc_ns.shm_ctlmax), .mode = 0644, .proc_handler = proc_ipc_doulongvec_minmax, }, { .procname = "shmall", .data = &init_ipc_ns.shm_ctlall, - .maxlen = sizeof (init_ipc_ns.shm_ctlall), + .maxlen = sizeof(init_ipc_ns.shm_ctlall), .mode = 0644, .proc_handler = proc_ipc_doulongvec_minmax, }, { .procname = "shmmni", .data = &init_ipc_ns.shm_ctlmni, - .maxlen = sizeof (init_ipc_ns.shm_ctlmni), + .maxlen = sizeof(init_ipc_ns.shm_ctlmni), .mode = 0644, .proc_handler = proc_ipc_dointvec, },
@@ -196,28 +196,28 @@ static struct ctl_table ipc_kern_table[] = { { .procname = "msgmax", .data = &init_ipc_ns.msg_ctlmax, - .maxlen = sizeof (init_ipc_ns.msg_ctlmax), + .maxlen = sizeof(init_ipc_ns.msg_ctlmax), .mode = 0644, .proc_handler = proc_ipc_dointvec, }, { .procname = "msgmni", .data = &init_ipc_ns.msg_ctlmni, - .maxlen = sizeof (init_ipc_ns.msg_ctlmni), + .maxlen = sizeof(init_ipc_ns.msg_ctlmni), .mode = 0644, .proc_handler = proc_ipc_callback_dointvec, }, { .procname = "msgmnb", .data = &init_ipc_ns.msg_ctlmnb, - .maxlen = sizeof (init_ipc_ns.msg_ctlmnb), + .maxlen = sizeof(init_ipc_ns.msg_ctlmnb), .mode = 0644, .proc_handler = proc_ipc_dointvec, }, { .procname = "sem", .data = &init_ipc_ns.sem_ctls, - .maxlen = 4*sizeof (int), + .maxlen = 4*sizeof(int), .mode = 0644, .proc_handler = proc_ipc_dointvec, },
ipc/mqueue.c +8 -8
@@ -6,7 +6,7 @@* * Spinlocks: Mohamed Abbas ([email protected]) * Lockless receive & send, fd based notify: -* Manfred Spraul ([email protected]) +* Manfred Spraul ([email protected]) * * Audit: George Wilson ([email protected]) *
@@ -73,7 +73,7 @@ struct mqueue_inode_info {struct mq_attr attr;struct sigevent notify; -struct pid * notify_owner; +struct pid *notify_owner;struct user_namespace *notify_user_ns;struct user_struct *user;/* user who created, for accounting */ struct sock *notify_sock;
@@ -92,7 +92,7 @@ static void remove_notification(struct mqueue_inode_info *info);static struct kmem_cache *mqueue_inode_cachep; -static struct ctl_table_header * mq_sysctl_table; +static struct ctl_table_header *mq_sysctl_table;static inline struct mqueue_inode_info *MQUEUE_I (struct inode *inode) {
@@ -466,13 +466,13 @@ out_unlock:static int mqueue_unlink (struct inode *dir,struct dentry *dentry) { -struct inode *inode = dentry->d_inode; +struct inode *inode = dentry->d_inode; dir->i_ctime = dir->i_mtime = dir->i_atime =CURRENT_TIME ; dir->i_size -=DIRENT_SIZE ; -drop_nlink (inode); -dput (dentry); -return 0 ; +drop_nlink (inode); +dput (dentry); +return 0 ; }/*
@@ -622,7 +622,7 @@ static struct ext_wait_queue *wq_get_first_waiter(static inline void set_cookie (struct sk_buff *skb,char code) { - ((char *)skb->data)[NOTIFY_COOKIE_LEN -1 ] = code; + ((char *)skb->data)[NOTIFY_COOKIE_LEN -1 ] = code; }/*
ipc/msg.c +9 -9
@@ -318,7 +318,7 @@ SYSCALL_DEFINE2(msgget, key_t, key, int, msgflg)static inline unsigned long copy_msqid_to_user (void __user *buf,struct msqid64_ds *in,int version) { -switch (version) { +switch (version) {case IPC_64 :return copy_to_user (buf, in,sizeof (*in));case IPC_OLD :
@@ -363,7 +363,7 @@ copy_msqid_to_user(void __user *buf, struct msqid64_ds *in, int version)static inline unsigned long copy_msqid_from_user (struct msqid64_ds *out,void __user *buf,int version) { -switch (version) { +switch (version) {case IPC_64 :if (copy_from_user (out, buf,sizeof (*out)))return -EFAULT ;
@@ -375,9 +375,9 @@ copy_msqid_from_user(struct msqid64_ds *out, void __user *buf, int version)if (copy_from_user (&tbuf_old, buf,sizeof (tbuf_old)))return -EFAULT ; - out->msg_perm.uid = tbuf_old.msg_perm.uid; - out->msg_perm.gid = tbuf_old.msg_perm.gid; - out->msg_perm.mode = tbuf_old.msg_perm.mode; + out->msg_perm.uid = tbuf_old.msg_perm.uid; + out->msg_perm.gid = tbuf_old.msg_perm.gid; + out->msg_perm.mode = tbuf_old.msg_perm.mode;if (tbuf_old.msg_qbytes ==0 ) out->msg_qbytes = tbuf_old.msg_lqbytes;
@@ -606,13 +606,13 @@ SYSCALL_DEFINE3(msgctl, int, msqid, int, cmd, struct msqid_ds __user *, buf)static int testmsg (struct msg_msg *msg,long type,int mode) { -switch (mode) +switch (mode) {case SEARCH_ANY :case SEARCH_NUMBER :return 1 ;case SEARCH_LESSEQUAL : -if (msg->m_type <=type) +if (msg->m_type <= type)return 1 ;break ;case SEARCH_EQUAL :
@@ -970,7 +970,7 @@ long do_msgrcv(int msqid, void __user *buf, size_t bufsz, long msgtyp, int msgfl* wake_up_process(). There is a race with exit(), see * ipc/mqueue.c for the details. */ - msg = (struct msg_msg *)msr_d.r_msg; + msg = (struct msg_msg *)msr_d.r_msg;while (msg ==NULL ) {cpu_relax (); msg = (struct msg_msg *)msr_d.r_msg;
@@ -991,7 +991,7 @@ long do_msgrcv(int msqid, void __user *buf, size_t bufsz, long msgtyp, int msgfl/* Lockless receive, part 4: * Repeat test after acquiring the spinlock. */ - msg = (struct msg_msg *)msr_d.r_msg; + msg = (struct msg_msg *)msr_d.r_msg;if (msg !=ERR_PTR (-EAGAIN )) goto out_unlock0;
ipc/sem.c +49 -49
316 lines not on this page · raw message
ipc/shm.c +17 -17
@@ -67,7 +67,7 @@ static const struct vm_operations_struct shm_vm_ops;static int newseg (struct ipc_namespace *,struct ipc_params *);static void shm_open (struct vm_area_struct *vma);static void shm_close (struct vm_area_struct *vma); -static void shm_destroy (struct ipc_namespace *ns,struct shmid_kernel *shp); +static void shm_destroy (struct ipc_namespace *ns,struct shmid_kernel *shp);#ifdef CONFIG_PROC_FS static int sysvipc_shm_proc_show (struct seq_file *s,void *it);#endif
@@ -91,7 +91,7 @@ static void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)struct shmid_kernel *shp; shp = container_of(ipcp, struct shmid_kernel, shm_perm); -if (shp->shm_nattch){ +if (shp->shm_nattch) { shp->shm_perm.mode |=SHM_DEST ;/* Do not find it any more */ shp->shm_perm.key =IPC_PRIVATE ;
@@ -116,7 +116,7 @@ static int __init ipc_ns_init(void)pure_initcall (ipc_ns_init); -void __init shm_init (void ) +void __init shm_init (void ) {ipc_init_proc_interface ("sysvipc/shm" , #if BITS_PER_LONG <= 32
@@ -216,7 +216,7 @@ static void shm_destroy(struct ipc_namespace *ns, struct shmid_kernel *shp)else if (shp->mlock_user)user_shm_unlock (file_inode (shp->shm_file)->i_size, shp->mlock_user); -fput (shp->shm_file); +fput (shp->shm_file);ipc_rcu_putref (shp, shm_rcu_free); }
@@ -245,7 +245,7 @@ static bool shm_may_destroy(struct ipc_namespace *ns, struct shmid_kernel *shp)*/ static void shm_close (struct vm_area_struct *vma) { -struct file * file = vma->vm_file; +struct file *file = vma->vm_file;struct shm_file_data *sfd =shm_file_data (file);struct shmid_kernel *shp;struct ipc_namespace *ns = sfd->ns;
@@ -376,7 +376,7 @@ static struct mempolicy *shm_get_policy(struct vm_area_struct *vma, }#endif -static int shm_mmap (struct file * file,struct vm_area_struct * vma) +static int shm_mmap (struct file *file,struct vm_area_struct *vma) {struct shm_file_data *sfd =shm_file_data (file);int ret;
@@ -483,7 +483,7 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params)int error;struct shmid_kernel *shp;size_t numpages = (size +PAGE_SIZE -1 ) >>PAGE_SHIFT ; -struct file * file; +struct file *file;char name[13 ];int id;vm_flags_t acctflag =0 ;
@@ -509,7 +509,7 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params)return error; } -sprintf (name,"SYSV%08x" , key); +sprintf (name,"SYSV%08x" , key);if (shmflg &SHM_HUGETLB ) {struct hstate *hs;size_t hugesize;
@@ -530,7 +530,7 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params) }else {/* * Do not allow no accounting for OVERCOMMIT_NEVER, even -* if it's asked for. +* if it's asked for. */ if ((shmflg &SHM_NORESERVE ) && sysctl_overcommit_memory !=OVERCOMMIT_NEVER )
@@ -625,7 +625,7 @@ SYSCALL_DEFINE3(shmget, key_t, key, size_t, size, int, shmflg)static inline unsigned long copy_shmid_to_user (void __user *buf,struct shmid64_ds *in,int version) { -switch (version) { +switch (version) {case IPC_64 :return copy_to_user (buf, in,sizeof (*in));case IPC_OLD :
@@ -652,7 +652,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_static inline unsigned long copy_shmid_from_user (struct shmid64_ds *out,void __user *buf,int version) { -switch (version) { +switch (version) {case IPC_64 :if (copy_from_user (out, buf,sizeof (*out)))return -EFAULT ;
@@ -677,14 +677,14 @@ copy_shmid_from_user(struct shmid64_ds *out, void __user *buf, int version)static inline unsigned long copy_shminfo_to_user (void __user *buf,struct shminfo64 *in,int version) { -switch (version) { +switch (version) {case IPC_64 :return copy_to_user (buf, in,sizeof (*in));case IPC_OLD : {struct shminfo out; -if (in->shmmax >INT_MAX ) +if (in->shmmax >INT_MAX ) out.shmmax =INT_MAX ;else out.shmmax = (int )in->shmmax;
@@ -843,14 +843,14 @@ static int shmctl_nolock(struct ipc_namespace *ns, int shmid, shminfo.shmall = ns->shm_ctlall; shminfo.shmmin =SHMMIN ; -if (copy_shminfo_to_user (buf, &shminfo, version)) +if (copy_shminfo_to_user (buf, &shminfo, version))return -EFAULT ;down_read (&shm_ids (ns).rwsem); err =ipc_get_maxid (&shm_ids (ns));up_read (&shm_ids (ns).rwsem); -if (err<0 ) +if (err <0 ) err =0 ; goto out; }
@@ -861,7 +861,7 @@ static int shmctl_nolock(struct ipc_namespace *ns, int shmid,memset (&shm_info,0 ,sizeof (shm_info));down_read (&shm_ids (ns).rwsem); shm_info.used_ids =shm_ids (ns).in_use; -shm_get_stat (ns, &shm_info.shm_rss, &shm_info.shm_swp); +shm_get_stat (ns, &shm_info.shm_rss, &shm_info.shm_swp); shm_info.shm_tot = ns->shm_tot; shm_info.swap_attempts =0 ; shm_info.swap_successes =0 ;
@@ -1034,7 +1034,7 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg, ulong *raddr,struct shmid_kernel *shp;unsigned long addr;unsigned long size; -struct file * file; +struct file *file;int err;unsigned long flags;unsigned long prot;
ipc/util.c +12 -12
@@ -135,7 +135,7 @@ void ipc_init_ids(struct ipc_ids *ids)if (seq_limit >USHRT_MAX ) ids->seq_max =USHRT_MAX ;else - ids->seq_max = seq_limit; + ids->seq_max = seq_limit; }idr_init (&ids->ipcs_idr);
@@ -212,7 +212,7 @@ static struct kern_ipc_perm *ipc_findkey(struct ipc_ids *ids, key_t key) }/** -* ipc_get_maxid - get the last assigned id +* ipc_get_maxid - get the last assigned id * @ids: IPC identifier set * * Called with ipc_ids.rwsem held.
@@ -243,7 +243,7 @@ int ipc_get_maxid(struct ipc_ids *ids) }/** -* ipc_addid - add an IPC identifier +* ipc_addid - add an IPC identifier * @ids: IPC identifier set * @new: new IPC permission set * @size: limit for the number of used ids
@@ -255,7 +255,7 @@ int ipc_get_maxid(struct ipc_ids *ids)* * Called with writer ipc_ids.rwsem held. */ -int ipc_addid (struct ipc_ids * ids,struct kern_ipc_perm * new,int size) +int ipc_addid (struct ipc_ids *ids,struct kern_ipc_perm *new,int size) {kuid_t euid;kgid_t egid;
@@ -448,7 +448,7 @@ void ipc_rmid(struct ipc_ids *ids, struct kern_ipc_perm *ipcp)void *ipc_alloc (int size) {void *out; -if (size >PAGE_SIZE ) +if (size >PAGE_SIZE ) out =vmalloc (size);else out =kmalloc (size,GFP_KERNEL );
@@ -464,9 +464,9 @@ void *ipc_alloc(int size)* used in the allocation call. */ -void ipc_free (void * ptr,int size) +void ipc_free (void *ptr,int size) { -if (size >PAGE_SIZE ) +if (size >PAGE_SIZE )vfree (ptr);else kfree (ptr);
@@ -527,7 +527,7 @@ void ipc_rcu_free(struct rcu_head *head)* Check user, group, other permissions for access * to ipc resources. return 0 if allowed * -* @flag will most probably be 0 or S_...UGO from <linux/stat.h> +* @flag will most probably be 0 or S_...UGO from <linux/stat.h> */ int ipcperms (struct ipc_namespace *ns,struct kern_ipc_perm *ipcp,short flag)
@@ -566,7 +566,7 @@ int ipcperms(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp, short flag)*/ -void kernel_to_ipc64_perm (struct kern_ipc_perm *in,struct ipc64_perm *out) +void kernel_to_ipc64_perm (struct kern_ipc_perm *in,struct ipc64_perm *out) { out->key = in->key; out->uid =from_kuid_munged (current_user_ns (), in->uid);
@@ -586,7 +586,7 @@ void kernel_to_ipc64_perm (struct kern_ipc_perm *in, struct ipc64_perm *out)* object and store it into the @out pointer. */ -void ipc64_perm_to_ipc_perm (struct ipc64_perm *in,struct ipc_perm *out) +void ipc64_perm_to_ipc_perm (struct ipc64_perm *in,struct ipc_perm *out) { out->key = in->key;SET_UID (out->uid, in->uid);
@@ -772,7 +772,7 @@ err:* just the command code. */ -int ipc_parse_version (int *cmd) +int ipc_parse_version (int *cmd) {if (*cmd &IPC_64 ) { *cmd ^=IPC_64 ;
@@ -809,7 +809,7 @@ static struct kern_ipc_perm *sysvipc_find_ipc(struct ipc_ids *ids, loff_t pos,if (total >= ids->in_use)return NULL ; -for ( ; pos <IPCMNI ; pos++) { +for (; pos <IPCMNI ; pos++) { ipc =idr_find (&ids->ipcs_idr, pos);if (ipc !=NULL ) { *new_pos = pos +1 ;
ipc/util.h +7 -7
@@ -15,9 +15,9 @@#define SEQ_MULTIPLIER (IPCMNI) -void sem_init (void ); -void msg_init (void ); -void shm_init (void ); +void sem_init (void ); +void msg_init (void ); +void shm_init (void );struct ipc_namespace ;
@@ -116,8 +116,8 @@ int ipcperms(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp, short flg);/* for rare, potentially huge allocations. * both function can sleep */ -void *ipc_alloc (int size); -void ipc_free (void * ptr,int size); +void *ipc_alloc (int size); +void ipc_free (void *ptr,int size);/* * For allocation that need to be freed by RCU.
@@ -125,7 +125,7 @@ void ipc_free(void* ptr, int size);* getref increases the refcount, the putref call that reduces the recount * to 0 schedules the rcu destruction. Caller must guarantee locking. */ -void *ipc_rcu_alloc (int size); +void *ipc_rcu_alloc (int size);int ipc_rcu_getref (void *ptr);void ipc_rcu_putref (void *ptr,void (*func)(struct rcu_head *head));void ipc_rcu_free (struct rcu_head *head);
@@ -144,7 +144,7 @@ struct kern_ipc_perm *ipcctl_pre_down_nolock(struct ipc_namespace *ns,/* On IA-64, we always use the "64-bit version" of the IPC structures. */ # define ipc_parse_version (cmd) IPC_64#else -int ipc_parse_version (int *cmd); +int ipc_parse_version (int *cmd);#endif extern void free_msg (struct msg_msg *msg);
Hi Joe,
Quoted 9 lines · Joe Perches
Quoted 6 lines · Davidlohr Bueso
Quoted 3 lines · Libin
From: Li Bin <[email protected]>
small codingstyle fix: '*' should be adjacent to the data name.
There are *tons* of these, go crazy.
Here are the whitespace changes proposed by
$ scripts/checkpatch -f --fix --types=pointer_location,spacing,space_before_tab ipc/*.[ch]
/me hides, probably most of them are mine.
Davidlohr: Do you have anything outstanding for ipc/*.c? I have nothing.
My proposal would be that the checkpatch -f patch should be added for 3.14, i.e. let's give the code one more cycle to calm down. Grek just sent me 47 patches for the backport to 3.10-stable, I don't want any whitespace noise right now.
--
Manfred
Quoted 8 lines · Manfred Spraul
Hi Joe,
Quoted 5 lines · Joe Perches
Quoted 4 lines · Davidlohr Bueso
Quoted 3 lines · Libin
From: Li Bin <[email protected]>
small codingstyle fix: '*' should be adjacent to the data name.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
There are *tons* of these, go crazy.
Here are the whitespace changes proposed by
$ scripts/checkpatch -f --fix --types=pointer_location,spacing,space_before_tab ipc/*.[ch]/me hides, probably most of them are mine.
Davidlohr: Do you have anything outstanding for
ipc/*.c? I have nothing.
Nope.
Quoted 3 lines
My proposal would be that the checkpatch -f patch should be added for 3.14, i.e. let's give the code one more cycle to calm down.
I think it would be fine for the 3.13 merge window, but considering all the action for this release, I have no problem waiting longer.
Quoted 2 lines
Grek just sent me 47 patches for the backport to 3.10-stable, I don't want any whitespace noise right now.
+1
Thanks,
Davidlohr
Quoted 2 lines · Davidlohr Bueso
Quoted 1 line · Manfred Spraul
Hi Joe,
Hi all.
Quoted 3 lines
Quoted 2 lines
Grek just sent me 47 patches for the backport to 3.10-stable, I don't want any whitespace noise right now.
+1
Do it when it's convenient or don't do it at all.
No worries from me.
It's pretty automatic if you use checkpatch from -next.
$ scripts/checkpatch.pl -f --fix --types=pointer_location,spacing,space_before_tab ipc/*.[ch]
$ find ipc/ -name "*.EXPERIMENTAL-checkpatch-fixes" | \
while read file ; do mv $file ${file%.EXPERIMENTAL-checkpatch-fixes}; doneThe space_before_tab suggested correction currently only removes a single space before the tab and may need to be run multiple times.