Skip to contentSkip to conversation

machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader

PATCH In review Khem Raj 3 participants 4 messages Oct 17, 2013 Arm i.MX and Layerscape

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader

Lets play the layer with other BSP layers in distro

---
 conf/machine/include/imx-base.inc | 3 +++
 conf/machine/include/mxs-base.inc | 3 +++
 2 files changed, 6 insertions(+)
conf/machine/include/imx-base.inc +3 -0
index beeee5f..ff5e96b 100644
@@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
 PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
 PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
 PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
 
 EXTRA_IMAGEDEPENDS = "u-boot"
conf/machine/include/mxs-base.inc +3 -0
index a048f9c..ef3130d 100644
@@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
 
 PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
 UBOOT_ENTRYPOINT = "0x40008000"
 UBOOT_MAKE_TARGET = "u-boot.sb"
 UBOOT_SUFFIX = "sb"
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 1 line · Khem Raj

Lets play the layer with other BSP layers in distro

I think I like your patch, but i don't like your commit log, sorry :(

Would you mind to add 1)Why are you making the patch 2)What error it did cause to you?

I don't mind if you keep your sentence as is, but i think something else is needed.

Daiane

Quoted 5 lines
---
  conf/machine/include/imx-base.inc | 3 +++
  conf/machine/include/mxs-base.inc | 3 +++

Please, grep the source in order to double check if there is any other machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, but I'm not sure.

Quoted 31 lines
  2 files changed, 6 insertions(+)
conf/machine/include/imx-base.inc +3 -0
index beeee5f..ff5e96b 100644
@@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
  PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
  PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
  PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
 
  EXTRA_IMAGEDEPENDS = "u-boot"
conf/machine/include/mxs-base.inc +3 -0
index a048f9c..ef3130d 100644
@@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
 
  PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
  UBOOT_ENTRYPOINT = "0x40008000"
  UBOOT_MAKE_TARGET = "u-boot.sb"
  UBOOT_SUFFIX = "sb"
Signature · 1 line
Daiane
author
#2 lore raw
Quoted 6 lines · Daiane Angolini
Quoted 2 lines · Khem Raj

Lets play the layer with other BSP layers in distro

I think I like your patch, but i don't like your commit log, sorry :(

Yes there is missing bits, it must have been "lets it ..." nevertheless you can change it to "lets it coexist with other bsp layers in a multimachine distribution setup"

Quoted 3 lines

Would you mind to add 1)Why are you making the patch 2)What error it did cause to you?

Bit bake virtual/bootloader would build wrong u-boot thats why the patch

Quoted 58 lines

I don't mind if you keep your sentence as is, but i think something else is needed.

Daiane

Quoted 5 lines
---
  conf/machine/include/imx-base.**inc | 3 +++
  conf/machine/include/mxs-base.**inc | 3 +++

Please, grep the source in order to double check if there is any other machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, but I'm not sure.

   2 files changed, 6 insertions(+)
Quoted 25 lines
conf/machine/include/imx-**base.inc +0 -0
index beeee5f..ff5e96b 100644
@@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/**libgl_mx6 ?=

"gpu-viv-bin-mx6q"
PREFERRED_PROVIDER_virtual/**libgles1_mx6 ?= "gpu-viv-bin-mx6q" PREFERRED_PROVIDER_virtual/**libgles2_mx6 ?= "gpu-viv-bin-mx6q"

conf/machine/include/imx-**base.inc +3 -0
+# u-boot
+PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
+
  PREFERRED_PROVIDER_virtual/**kernel_mx3 = "linux-fslc"
 
  EXTRA_IMAGEDEPENDS = "u-boot"
conf/machine/include/mxs-**base.inc +0 -0
index a048f9c..ef3130d 100644

conf/machine/include/mxs-**base.inc SOC_FAMILY = "mxs" · line 19

Quoted 9 lines
conf/machine/include/mxs-**base.inc +3 -0
@@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
 
  PREFERRED_PROVIDER_virtual/**kernel_mx23 = "linux-fslc"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
+
  UBOOT_ENTRYPOINT = "0x40008000"
  UBOOT_MAKE_TARGET = "u-boot.sb"
  UBOOT_SUFFIX = "sb"

--
Daiane

#3 lore raw
Quoted 14 lines · Khem Raj
Quoted 7 lines · Daiane Angolini
Quoted 2 lines · Khem Raj

Lets play the layer with other BSP layers in distro

I think I like your patch, but i don't like your commit log, sorry :(

Yes there is missing bits, it must have been "lets it ..." nevertheless you can change it to "lets it coexist with other bsp layers in a multimachine distribution setup"

Quoted 10 lines
Quoted 2 lines

Would you mind to add 1)Why are you making the patch 2)What error it did cause to you?

Bit bake virtual/bootloader would build wrong u-boot thats why the patch

Quoted 5 lines

I don't mind if you keep your sentence as is, but i think something else is needed.

Please Khem please a v2 with a more extended commitlog and please check of other boards setting the U-Boot preference; as Daiane said we have other references for it and it'd be better to fix this in same patch.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750