Skip to contentSkip to conversation

net bridge: remove unused field

PATCH In review Jamal Hadi Salim 2 participants 3 messages Oct 14, 2013 – Oct 18, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net bridge: remove unused field

Trivial patch

cheers,
jamal

commit 984b1bc7c51a1201707238f7aa5fa1a8b72fde90

Author: jamal <[email protected]>
Date:   Mon Oct 14 17:04:16 2013 -0400

Remove unused enum

include/uapi/linux/if_link.h +0 -5
index 80394e8..f8dab16 100644
@@ -209,11 +209,6 @@ enum {
 #define IFLA_INET6_MAX	(__IFLA_INET6_MAX - 1)
 
 enum {
-	BRIDGE_MODE_UNSPEC,
-	BRIDGE_MODE_HAIRPIN,
-};
-
-enum {
 	IFLA_BRPORT_UNSPEC,
 	IFLA_BRPORT_STATE,	/* Spanning tree state     */
 	IFLA_BRPORT_PRIORITY,	/* "             priority  */
maintainer
#1 lore raw

From: Jamal Hadi Salim <[email protected]>
Date: Mon, 14 Oct 2013 17:11:09 -0400

Quoted 1 line

Trivial patch

I know it seems rediculous, but anything we export to userspace, as we do in this UAPI header, could be potentially be used by some piece of source out there.

I'd rather just leave it be, you can add a comment saying it's unused if you wish, but I'd really rather not remove it and run the risk of breaking someone's build out there.

Thanks.

#2 lore raw

The only reason i made an exception of this one is because:
a) nothing in the kernel touches it
b) nothing in iproute2 touches it
c) the intended logic to transport the hairpin knob is now in IFLA_BRPORT_MODE

But: I empathize;-> Your call

cheers,
jamal

Quoted 12 lines · David Miller

I know it seems rediculous, but anything we export to userspace, as we do in this UAPI header, could be potentially be used by some piece of source out there.

I'd rather just leave it be, you can add a comment saying it's unused if you wish, but I'd really rather not remove it and run the risk of breaking someone's build out there.

Thanks.