ARM: vt8500: Staticize local symbols

PATCH New Sachin Kamat 3 participants 6 messages May 27, 2014 – May 30, 2014

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm/VT8500 Arm architecture

lore

Share & tools

lore

Sachin Kamat

author

2014-05-27 11:57 UTC #0 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Variables local to this file are made static.

Signed-off-by Sachin Kamat <[email protected]>

---
 arch/arm/mach-vt8500/vt8500.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

arch/arm/mach-vt8500/vt8500.c +3 -3

index 4a73464cb11b..2da7be31e7e2 100644
@@ -44,7 +44,7 @@
 
 static void __iomem *pmc_base;
 
-void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
 {
 	if (pmc_base)
 		writel(1, pmc_base + VT8500_PMSR_REG);

@@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
 	},
 };
 
-void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
 {
 	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
 }

@@ -72,7 +72,7 @@ static void vt8500_power_off(void)
 	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
 }
 
-void __init vt8500_init(void)
+static void __init vt8500_init(void)
 {
 	struct device_node *np;
 #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)

Signature · 1 line

1.7.9.5

Arnd Bergmann

2014-05-27 12:05 UTC #1 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Quoted 6 lines · On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:

Variables local to this file are made static.
Signed-off-by Sachin Kamat <[email protected]>
---
 arch/arm/mach-vt8500/vt8500.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by Arnd Bergmann <[email protected]>

Looks good to me, but you forgot to take the maintainer on Cc.

How should we handle this patch? I guess this is the only one for vt8500 in 3.16, so I can pick it up directly with Tony's Ack.

Quoted 32 lines

arch/arm/mach-vt8500/vt8500.c +3 -3

index 4a73464cb11b..2da7be31e7e2 100644
@@ -44,7 +44,7 @@
 
 static void __iomem *pmc_base;
 
-void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
 {
 	if (pmc_base)
 		writel(1, pmc_base + VT8500_PMSR_REG);

@@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
 	},
 };
 
-void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
 {
 	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
 }

@@ -72,7 +72,7 @@ static void vt8500_power_off(void)
 	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
 }
 
-void __init vt8500_init(void)
+static void __init vt8500_init(void)
 {
 	struct device_node *np;
 #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)

Tony Prisk

2014-05-29 20:44 UTC #2 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Quoted 41 lines · Arnd Bergmann

Quoted 6 lines · On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
Variables local to this file are made static.
Signed-off-by Sachin Kamat <[email protected]>
---
  arch/arm/mach-vt8500/vt8500.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by Arnd Bergmann <[email protected]>
Looks good to me, but you forgot to take the maintainer on Cc.
How should we handle this patch? I guess this is the only one for vt8500 in 3.16, so I can pick it up directly with Tony's Ack.
Quoted 26 lines
arch/arm/mach-vt8500/vt8500.c +2 -2
index 4a73464cb11b..2da7be31e7e2 100644
@@ -44,7 +44,7 @@
 
  static void __iomem *pmc_base;
 
-void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
  {
  	if (pmc_base)
  		writel(1, pmc_base + VT8500_PMSR_REG);
@@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
  	},
  };
 
-void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
  {
  	iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
  }
@@ -72,7 +72,7 @@ static void vt8500_power_off(void)
  	asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));
  }
 

Quoted 6 lines

arch/arm/mach-vt8500/vt8500.c static void vt8500_power_off(void) · line 78
Quoted 6 lines
arch/arm/mach-vt8500/vt8500.c +1 -1
-void __init vt8500_init(void)
+static void __init vt8500_init(void)
  {
  	struct device_node *np;
  #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)

Acked-by Tony Prisk <[email protected]>

Can you pick this up please Arnd? Doesn't look like there will be anything else for 3.16

Regards
Tony P

Sachin Kamat

author

2014-05-30 06:19 UTC #3 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Quoted 42 lines · Tony Prisk

Quoted 40 lines · Arnd Bergmann
Quoted 7 lines · On Tuesday 27 May 2014 17:27:43 Sachin Kamat wrote:
Variables local to this file are made static.
Signed-off-by Sachin Kamat <[email protected]>
---
  arch/arm/mach-vt8500/vt8500.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by Arnd Bergmann <[email protected]>
Looks good to me, but you forgot to take the maintainer on Cc.
How should we handle this patch? I guess this is the only one for vt8500 in 3.16, so I can pick it up directly with Tony's Ack.
Quoted 22 lines
arch/arm/mach-vt8500/vt8500.c +2 -0
index 4a73464cb11b..2da7be31e7e2 100644
@@ -44,7 +44,7 @@
    static void __iomem *pmc_base;
  -void vt8500_restart(enum reboot_mode mode, const char *cmd)
+static void vt8500_restart(enum reboot_mode mode, const char *cmd)
  {
        if (pmc_base)
                writel(1, pmc_base + VT8500_PMSR_REG);
@@ -60,7 +60,7 @@ static struct map_desc vt8500_io_desc[] __initdata = {
        },
  };
  -void __init vt8500_map_io(void)
+static void __init vt8500_map_io(void)
  {
        iotable_init(vt8500_io_desc, ARRAY_SIZE(vt8500_io_desc));
  }
@@ -72,7 +72,7 @@ static void vt8500_power_off(void)
        asm("mcr%? p15, 0, %0, c7, c0, 4" : : "r" (0));

Quoted 8 lines

Quoted 7 lines
arch/arm/mach-vt8500/vt8500.c static void vt8500_power_off(void) · line 78
Quoted 7 lines
arch/arm/mach-vt8500/vt8500.c +1 -0
  }
  -void __init vt8500_init(void)
+static void __init vt8500_init(void)
  {
        struct device_node *np;
  #if defined(CONFIG_FB_VT8500) || defined(CONFIG_FB_WM8505)
Acked-by Tony Prisk <[email protected]>

Thanks Tony.

Quoted 2 lines

Can you pick this up please Arnd? Doesn't look like there will be anything else for 3.16

Arnd,

I have a few more similar patches for other platforms (mvebu, sti, spear). Can I send them as well along with the accumulated acks for you to apply?

---
With warm regards,
Sachin

Arnd Bergmann

2014-05-30 14:53 UTC #4 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Quoted 3 lines · On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:

I have a few more similar patches for other platforms (mvebu, sti, spear). Can I send them as well along with the accumulated acks for you to apply?

Yes, that's fine. If you can, please send a pull request with the lot to arm at kernel.org, with the maintainers and linux-arm-kernel on Cc.

Arnd

Sachin Kamat

author

2014-05-30 17:03 UTC #5 lore raw

PATCH 1/1 ARM: vt8500: Staticize local symbols

Quoted 7 lines · Arnd Bergmann

Quoted 3 lines · On Friday 30 May 2014 11:49:02 Sachin Kamat wrote:
I have a few more similar patches for other platforms (mvebu, sti, spear). Can I send them as well along with the accumulated acks for you to apply?
Yes, that's fine. If you can, please send a pull request with the lot to arm at kernel.org, with the maintainers and linux-arm-kernel on Cc.

Actually, I happened to post all the 8 patches to linux-arm-kernel with the respective
maintainers and you in Cc before leaving for the weekend (The first patch in the series
being "[PATCH Resend 1/8] ARM: sti: Staticize local variables"). Please see if you can
pick them up. Else I will send you a pull request on Monday.

Signature · 2 lines

With warm regards,
Sachin