Skip to contentSkip to conversation

udev: Re-fix touchscreen detection rule

PATCH In review Tom Rini 3 participants 5 messages Oct 22, 2013

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 udev: Re-fix touchscreen detection rule

* Fix the rule to detect the touchscreen and create the /dev/input/touchscreen0 device node more reliably. udev knows how to detect a touchscreen and sets ID_INPUT_TOUCHSCREEN for us to check against.
* This has already been submitted upstream and can be removed when meta-arago switches to something that contains this fix, possibly Dora.
* The patch has already been submitted to oe-core at:
http://article.gmane.org/gmane.comp.handhelds.openembedded.core/44297

Cc Chase Maupin <[email protected]>
Cc Franklin Cooper Jr. <[email protected]>
Cc Denys Dmytriyenko <[email protected]>
---
 .../recipes-core/udev/udev/local.rules             |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta-arago-distro/recipes-core/udev/udev/local.rules +1 -3
index d0cbf91..d0b0216 100644
@@ -17,7 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
-# Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
-# has an EV_ABS value (-a) which is used for touchscreen type devices.
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
 
Signature · 1 line
1.7.9.5
Tested-by on v1 1/1
#1 lore raw

Needs a PR bump but I can handle that when I push.

Tested on AM437x-evm

Quoted 52 lines

-----Original Message-----
From: Tom Rini [mailto:[email protected]] On Behalf Of Rini, Tom
Sent: Tuesday, October 22, 2013 11:43 AM
To: [email protected]
Cc: Maupin, Chase; Cooper Jr., Franklin; Dmytriyenko, Denys
Subject: [PATCH] udev: Re-fix touchscreen detection rule

* Fix the rule to detect the touchscreen and create the /dev/input/touchscreen0 device node more reliably. udev knows
how to
detect a touchscreen and sets ID_INPUT_TOUCHSCREEN for us to
check
against.
* This has already been submitted upstream and can be removed when meta-arago switches to something that contains this fix,
possibly
Dora.
* The patch has already been submitted to oe-core at:

http://article.gmane.org/gmane.comp.handhelds.openembedded.core/44
297

Cc Chase Maupin <[email protected]>
Cc Franklin Cooper Jr. <[email protected]>
Cc Denys Dmytriyenko <[email protected]>

---
.../recipes-core/udev/udev/local.rules | 4 +---

1 file changed, 1 insertion(+), 3 deletions(-)
meta-arago-distro/recipes-core/udev/udev/local.rules +0 -0
index d0cbf91..d0b0216 100644
@@ -17,7 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*",

RUN+="/sbin/modprobe $env{MODALIAS}"

# Create a symlink to any touchscreen input device
-# Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
-# has an EV_ABS value (-a) which is used for touchscreen type devices.
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"

--
1.7.9.5

author
#2 lore raw
Quoted 5 lines · Chase

Needs a PR bump but I can handle that when I push.

Tested on AM437x-evm

Automagic PR bumping isn't live on this branch? Out of the loop, sorry.

Signature · 1 line
Tom
#3 lore raw

Nah, we don't use it yet.

Denys

-----Original Message-----
From: Rini, Tom [[email protected]]
Received: Tuesday, 22 Oct 2013, 18:45
To: Maupin, Chase [[email protected]]
CC: [email protected] [[email protected]]; Cooper Jr., Franklin [[email protected]]; Dmytriyenko, Denys [[email protected]]
Subject: Re: [PATCH] udev: Re-fix touchscreen detection rule

Quoted 5 lines · Chase

Needs a PR bump but I can handle that when I push.

Tested on AM437x-evm

Automagic PR bumping isn't live on this branch? Out of the loop, sorry.

--
Tom

#4 lore raw
In reply to Tom Rini

Ack. Can push it soon.

Denys

-----Original Message-----
From: Rini, Tom [[email protected]]
Received: Tuesday, 22 Oct 2013, 17:43
To: [email protected] [[email protected]]
CC: Maupin, Chase [[email protected]]; Cooper Jr., Franklin [[email protected]]; Dmytriyenko, Denys [[email protected]]
Subject: [PATCH] udev: Re-fix touchscreen detection rule

* Fix the rule to detect the touchscreen and create the /dev/input/touchscreen0 device node more reliably. udev knows how to detect a touchscreen and sets ID_INPUT_TOUCHSCREEN for us to check against.
* This has already been submitted upstream and can be removed when meta-arago switches to something that contains this fix, possibly Dora.
* The patch has already been submitted to oe-core at:
http://article.gmane.org/gmane.comp.handhelds.openembedded.core/44297

Cc Chase Maupin <[email protected]>
Cc Franklin Cooper Jr. <[email protected]>
Cc Denys Dmytriyenko <[email protected]>
---
 .../recipes-core/udev/udev/local.rules             |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta-arago-distro/recipes-core/udev/udev/local.rules +1 -3
index d0cbf91..d0b0216 100644
@@ -17,7 +17,5 @@
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
-# Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
-# has an EV_ABS value (-a) which is used for touchscreen type devices.
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
 

--
1.7.9.5