Skip to contentSkip to conversation

packages/Config.in: Fix case on entries titles

PATCH New Maxime Hadjinlian 3 participants 4 messages Oct 24, 2013 – Oct 25, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 packages/Config.in: Fix case on entries titles

---
 package/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/Config.in +3 -3
index ebbdeb5..8519f45 100644
@@ -169,7 +169,7 @@ source "package/gnuplot/Config.in"
 source "package/jhead/Config.in"
 source "package/rrdtool/Config.in"
 
-comment "graphic libraries"
+comment "Graphic libraries"
 source "package/cegui06/Config.in"
 source "package/directfb/Config.in"
 source "package/directfb-examples/Config.in"
@@ -196,7 +196,7 @@ source "package/sdl_net/Config.in"
 source "package/sdl_sound/Config.in"
 source "package/sdl_ttf/Config.in"
 
-comment "other GUIs"
+comment "Other GUIs"
 source "package/efl/Config.in"
 source "package/qt/Config.in"
 
@@ -241,7 +241,7 @@ source "package/liberation/Config.in"
 source "package/libsexy/Config.in"
 source "package/x11r7/xkeyboard-config/Config.in"
 
-comment "X Window managers"
+comment "X window managers"
 source "package/blackbox/Config.in"
 source "package/enlightenment/Config.in"
 source "package/fluxbox/Config.in"
Signature · 1 line
1.8.4.rc3
#1 lore raw

PATCH 1/1 packages/Config.in: Fix case on entries titles

Hi Maxime,

Quoted 27 lines · Maxime Hadjinlian
---
 package/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/Config.in +2 -2
index ebbdeb5..8519f45 100644
@@ -169,7 +169,7 @@ source "package/gnuplot/Config.in"
 source "package/jhead/Config.in"
 source "package/rrdtool/Config.in"
 
-comment "graphic libraries"
+comment "Graphic libraries"
 source "package/cegui06/Config.in"
 source "package/directfb/Config.in"
 source "package/directfb-examples/Config.in"
@@ -196,7 +196,7 @@ source "package/sdl_net/Config.in"
 source "package/sdl_sound/Config.in"
 source "package/sdl_ttf/Config.in"
 
-comment "other GUIs"
+comment "Other GUIs"
 source "package/efl/Config.in"
 source "package/qt/Config.in"
 

package/Config.in source "package/liberation/Config.in" · line 247

Quoted 8 lines
package/Config.in +1 -1
@@ -241,7 +241,7 @@ source "package/liberation/Config.in"
 source "package/libsexy/Config.in"
 source "package/x11r7/xkeyboard-config/Config.in"
 
-comment "X Window managers"
+comment "X window managers"
 source "package/blackbox/Config.in"
 source "package/enlightenment/Config.in"
 source "package/fluxbox/Config.in"

Maxime, when you send multiple versions of a patch, could you use v2, v3, ... in the subject line (PATCH v2) to make it easier for reviewers to distinghuish the different versions? Also below the changelog you should put a description of the changes compared to the previous version.
See http://buildroot.uclibc.org/downloads/manual/manual.html#_patch_revision_changelog

Also, I believe it is customary to resend the entire series when there is a revision of one of its patches.

Thanks,
Thomas

#2 lore raw

PATCH 1/1 packages/Config.in: Fix case on entries titles

Quoted 42 lines · Thomas De Schampheleire

Hi Maxime,

Quoted 27 lines · Maxime Hadjinlian
---
  package/Config.in | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
package/Config.in +2 -2
index ebbdeb5..8519f45 100644
@@ -169,7 +169,7 @@ source "package/gnuplot/Config.in"
  source "package/jhead/Config.in"
  source "package/rrdtool/Config.in"
 
-comment "graphic libraries"
+comment "Graphic libraries"
  source "package/cegui06/Config.in"
  source "package/directfb/Config.in"
  source "package/directfb-examples/Config.in"
@@ -196,7 +196,7 @@ source "package/sdl_net/Config.in"
  source "package/sdl_sound/Config.in"
  source "package/sdl_ttf/Config.in"
 
-comment "other GUIs"
+comment "Other GUIs"
  source "package/efl/Config.in"
  source "package/qt/Config.in"
 

package/Config.in source "package/liberation/Config.in" · line 247

Quoted 8 lines
package/Config.in +1 -1
@@ -241,7 +241,7 @@ source "package/liberation/Config.in"
  source "package/libsexy/Config.in"
  source "package/x11r7/xkeyboard-config/Config.in"
 
-comment "X Window managers"
+comment "X window managers"
  source "package/blackbox/Config.in"
  source "package/enlightenment/Config.in"
  source "package/fluxbox/Config.in"
Quoted 2 lines

Maxime, when you send multiple versions of a patch, could you use v2, v3, ... in the subject line (PATCH v2) to make it easier for reviewers

Note that you can do this with git-send-email (or format-patch):

git send-email -v2 # Send out PATCH v2, requires git >= 1.8.something
git send-email --subject-prefix 'PATCH v2'

Regards,
Arnout

Quoted 15 lines

to distinghuish the different versions? Also below the changelog you should put a description of the changes compared to the previous version.
See http://buildroot.uclibc.org/downloads/manual/manual.html#_patch_revision_changelog

Also, I believe it is customary to resend the entire series when there is a revision of one of its patches.

Thanks,
Thomas
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 packages/Config.in: Fix case on entries titles

Quoted 46 lines · Arnout Vandecappelle
Quoted 45 lines · Thomas De Schampheleire

Hi Maxime,

Quoted 28 lines · Maxime Hadjinlian
---
  package/Config.in | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
package/Config.in +2 -2
index ebbdeb5..8519f45 100644
@@ -169,7 +169,7 @@ source "package/gnuplot/Config.in"
  source "package/jhead/Config.in"
  source "package/rrdtool/Config.in"
 
-comment "graphic libraries"
+comment "Graphic libraries"
  source "package/cegui06/Config.in"
  source "package/directfb/Config.in"
  source "package/directfb-examples/Config.in"
@@ -196,7 +196,7 @@ source "package/sdl_net/Config.in"
  source "package/sdl_sound/Config.in"
  source "package/sdl_ttf/Config.in"
 
-comment "other GUIs"
+comment "Other GUIs"
  source "package/efl/Config.in"
  source "package/qt/Config.in"
 

package/Config.in source "package/liberation/Config.in" · line 247

Quoted 8 lines
package/Config.in +1 -1
@@ -241,7 +241,7 @@ source "package/liberation/Config.in"
  source "package/libsexy/Config.in"
  source "package/x11r7/xkeyboard-config/Config.in"
 
-comment "X Window managers"
+comment "X window managers"
  source "package/blackbox/Config.in"
  source "package/enlightenment/Config.in"
  source "package/fluxbox/Config.in"
Quoted 9 lines
Quoted 2 lines

Maxime, when you send multiple versions of a patch, could you use v2, v3, ... in the subject line (PATCH v2) to make it easier for reviewers

Note that you can do this with git-send-email (or format-patch):

git send-email -v2 # Send out PATCH v2, requires git >= 1.8.something
git send-email --subject-prefix 'PATCH v2'

Thanks, I did not know about that !

Quoted 12 lines

Regards,
Arnout

Quoted 8 lines

to distinghuish the different versions? Also below the changelog you should put a description of the changes compared to the previous version.
See
http://buildroot.uclibc.org/downloads/manual/manual.html#_patch_revision_changelog

Also, I believe it is customary to resend the entire series when there is a revision of one of its patches.

Yes, I though about sending the patch as an alone change instead of part of a serie but it was wrong of me since this one depends on the change introduced by the first patch.
Anyway, sorry for theses mistakes, I should have known better.

I'll wait on further comment on the first patch and resend the serie with a changelog.

Quoted 17 lines
Quoted 8 lines

Thanks,
Thomas
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F