Skip to contentSkip to conversation

arc: kernel: export symbol for pm_power_off in reset.c

PATCH In review Chen Gang 2 participants 4 messages Oct 28, 2013 – Oct 29, 2013 Synopsys ARC architecture

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arc: kernel: export symbol for pm_power_off in reset.c

Need export symbol for it, or can not pass compiling, the related error with allmodconfig:

MODPOST 2994 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

---
 arch/arc/kernel/reset.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arc/kernel/reset.c +1 -0
index e227a2b..2768fa1 100644
@@ -31,3 +31,4 @@ void machine_power_off(void)
 }
 
 void (*pm_power_off) (void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
Signature · 1 line
1.7.7.6
author
#1 lore raw

After this patch, and with limitations below, arc finishes allmodconfig.

- with EXTRA_CFLAGS=-mmedium-calls.

- disable CONFIG_CC_OPTIMIZE_FOR_SIZE.

- by pass 5-7 gcc issues (4-5 may duplicate).

- by pass 1 binutils issue (when disable CONFIG_CC_OPTIMIZE_FOR_SIZE).

Next (within 2013-10-31) I will/should:

- shrink cross-compilers information, at least.

- finish the patch for "portable assembler code - newline"

Left:

- it also content sevaval warnings (even not use "EXTRA_CFLAGS=-W").

- for next-20130927 tree, arc can not pass defconfig, either.

- not let it run under kvm (I don't know whether we support kvm).

Thanks.

Quoted 23 lines · Chen Gang

Need export symbol for it, or can not pass compiling, the related error with allmodconfig:

MODPOST 2994 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

---
 arch/arc/kernel/reset.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arc/kernel/reset.c +1 -0
index e227a2b..2768fa1 100644
@@ -31,3 +31,4 @@ void machine_power_off(void)
 }
 
 void (*pm_power_off) (void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
Signature · 1 line
Chen Gang
#2 lore raw
In reply to Chen Gang
Quoted 9 lines · Chen Gang

Need export symbol for it, or can not pass compiling, the related error with allmodconfig:

MODPOST 2994 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

Applied for 3.13

Thx,
-Vineet

author
#3 lore raw
Quoted 4 lines · Vineet Gupta
Quoted 3 lines · Chen Gang

Need export symbol for it, or can not pass compiling, the related error with allmodconfig:

Quoted 9 lines
Quoted 6 lines

MODPOST 2994 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!

Applied for 3.13

Thanks.

Signature · 1 line
Chen Gang