Skip to contentSkip to conversation

ext4-new-features: fix syntax error in configure

PATCH Applied Honggyu Kim 2 participants 3 messages Oct 28, 2013 – Oct 29, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4-new-features: fix syntax error in configure

In configure, string comparison is done using double assignment. /bin/sh doesn't allow to compare strings using "==". So "==" is modified to "=".

---
 testcases/kernel/fs/ext4-new-features/configure |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/fs/ext4-new-features/configure +2 -2
index 13f43f9..12849e5 100755
@@ -14,9 +14,9 @@ read EXT4_DEV
 
 echo "The partition is: $EXT4_DEV, Are you sure(Y/N)?"
 read RESULT
-if [ "$RESULT" == "Y" ] || [ "$RESULT" == "y" ]; then
+if [ "$RESULT" = "Y" ] || [ "$RESULT" = "y" ]; then
 	echo "EXT4_DEV=$EXT4_DEV" > ./ext4-test-config
-elif [ "$RESULT" == "N" ]; then
+elif [ "$RESULT" = "N" ]; then
 	echo "Give up specifing a partition!"
 else
 	echo "Your input is wrong($RESULT)."
Signature · 14 lines
1.7.9.5



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Honggyu Kim

In configure, string comparison is done using double assignment. /bin/sh doesn't allow to compare strings using "==". So "==" is modified to "=".

Quoted 11 lines
---
 testcases/kernel/fs/ext4-new-features/configure |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/fs/ext4-new-features/configure +0 -0
index 13f43f9..12849e5 100755
@@ -14,9 +14,9 @@ read EXT4_DEV
 

testcases/kernel/fs/ext4-new-features/configure read EXT4_DEV · line 22

Quoted 10 lines
testcases/kernel/fs/ext4-new-features/configure +2 -2
 echo "The partition is: $EXT4_DEV, Are you sure(Y/N)?"
 read RESULT
-if [ "$RESULT" == "Y" ] || [ "$RESULT" == "y" ]; then
+if [ "$RESULT" = "Y" ] || [ "$RESULT" = "y" ]; then
 	echo "EXT4_DEV=$EXT4_DEV" > ./ext4-test-config
-elif [ "$RESULT" == "N" ]; then
+elif [ "$RESULT" = "N" ]; then
 	echo "Give up specifing a partition!"
 else
 	echo "Your input is wrong($RESULT)."

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Applied
#2 lore raw
In reply to Honggyu Kim
Quoted 5 lines · Honggyu Kim

In configure, string comparison is done using double assignment. /bin/sh doesn't allow to compare strings using "==". So "==" is modified to "=".

Applied, thank you.

Wanlong Gao

------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list