Skip to contentSkip to conversation

EXYNOS5420: Add SMDK5420 board support

PATCH Superseded Rajeshwari S Shinde 7 participants 37 messages Oct 29, 2013 – Nov 15, 2013

Subsystems (3)

v6 of 13 Superseded Latest is v13 →

lore
Share & tools
lore
#0 lore raw

v6 cover EXYNOS5420: Add SMDK5420 board support

This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420.

Changes in V2:
- Corrected a compilation issue for SMDK5420.

Changes in V3:
- Add patch to support variable size SPL support
- Add patch to disable SMU for eMMC.

Changes in V4:
- Added check for MAX77686 pmic compilation.
- Added correct calculation of gpio based addresses.
- Rebased on the latest u-boot code.
- Removed patches for UART and TZPC changes as they were not needed.
- Added flag to disable SMU for eMMC.

Changes in V5:
- Moved functions board_mmc_init and board_eth_init to common/board.c in case of device tree support.

Changes in V6:
- Rebased on the latest mainline branch.
- Moved the definitions for SMU to arch/arm dwmmc.h

Rajeshwari S Shinde (10):
EXYNOS5: Create a common board file
Exynos5420: Add base addresses for 5420
Exynos5420: Add clock initialization for 5420
Exynos5420: Add DDR3 initialization for 5420
Exynos5420: Add support for 5420 in pinmux and gpio
Exynos5420: Add base patch for SMDK5420
DTS: Add dts support for SMDK5420
Config: Add initial config for SMDK5420
SPL: EXYNOS: Prepare for variable size SPL support
DWMMC: SMDK5420: Disable SMU for eMMC

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/dmc_common.c         |  10 +-
 arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c      | 421 +++++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740 +++++++++++++++++++------
 arch/arm/cpu/armv7/exynos/pinmux.c             | 241 +++++++-
 arch/arm/dts/exynos5.dtsi                      | 211 +++++++
 arch/arm/dts/exynos5250.dtsi                   | 178 +-----
 arch/arm/dts/exynos5420.dtsi                   |  74 +++
 arch/arm/include/asm/arch-exynos/board.h       |  17 +
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 arch/arm/include/asm/arch-exynos/cpu.h         |  53 +-
 arch/arm/include/asm/arch-exynos/dmc.h         | 121 ++--
 arch/arm/include/asm/arch-exynos/dwmmc.h       |  13 +
 arch/arm/include/asm/arch-exynos/gpio.h        | 143 ++++-
 arch/arm/include/asm/arch-exynos/periph.h      |   3 +
 board/samsung/common/Makefile                  |   4 +
 board/samsung/common/board.c                   | 407 ++++++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts      | 172 ++++++
 board/samsung/smdk5250/exynos5-dt.c            | 361 +-----------
 board/samsung/smdk5250/smdk5250.c              | 182 +-----
 board/samsung/smdk5420/Makefile                |  34 ++
 board/samsung/smdk5420/smdk5420.c              | 159 ++++++
 board/samsung/smdk5420/smdk5420_spl.c          |  52 ++
 boards.cfg                                     |   1 +
 drivers/mmc/dw_mmc.c                           |  11 +
 drivers/mmc/exynos_dw_mmc.c                    |   3 +
 include/configs/exynos5-dt.h                   | 302 ++++++++++
 include/configs/exynos5250-dt.h                | 317 +----------
 include/configs/smdk5420.h                     |  56 ++
 include/dwmmc.h                                |   3 +
 spl/Makefile                                   |   7 +-
 tools/Makefile                                 |   2 +
 tools/mkexynosspl.c                            | 167 ++++--
 36 files changed, 4271 insertions(+), 1328 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 arch/arm/include/asm/arch-exynos/board.h
 create mode 100644 board/samsung/common/board.c
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
 create mode 100644 board/samsung/smdk5420/Makefile
 create mode 100644 board/samsung/smdk5420/smdk5420.c
 create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
 create mode 100644 include/configs/exynos5-dt.h
 create mode 100644 include/configs/smdk5420.h
Signature · 1 line
1.7.12.4
#1 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:
- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.

 arch/arm/include/asm/arch-exynos/board.h |  17 ++
 board/samsung/common/Makefile            |   4 +
 board/samsung/common/board.c             | 405 +++++++++++++++++++++++++++++++
 board/samsung/smdk5250/exynos5-dt.c      | 361 +--------------------------
 board/samsung/smdk5250/smdk5250.c        | 182 +-------------
 include/configs/exynos5250-dt.h          |   2 +
 6 files changed, 435 insertions(+), 536 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-exynos/board.h
 create mode 100644 board/samsung/common/board.c
arch/arm/include/asm/arch-exynos/board.h new file +17 -0
new file mode 100644
index 0000000..243fb12
@@ -0,0 +1,17 @@
+/*
+ * (C) Copyright 2013 Samsung Electronics
+ * Rajeshwari Shinde <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _EXYNOS_BOARD_H
+#define _EXYNOS_BOARD_H
+
+/*
+ * Exynos baord specific changes for
+ * board_init
+ */
+int exynos_init(void);
+
+#endif	/* EXYNOS_BOARD_H */
board/samsung/common/Makefile +4 -0
index 9e48a7b..eab8ab2 100644
@@ -11,6 +11,10 @@ LIB	= $(obj)libsamsung.o
 
 COBJS-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
 
+ifeq ($(CONFIG_SPL_BUILD),)
+COBJS-$(CONFIG_BOARD_COMMON)	+= board.o
+endif
+
 SRCS    := $(COBJS-y:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS-y))
 
board/samsung/common/board.c new file +405 -0

405 lines not on this page · raw message

board/samsung/smdk5250/exynos5-dt.c +4 -357

411 lines not on this page · raw message

board/samsung/smdk5250/smdk5250.c +3 -179

219 lines not on this page · raw message

include/configs/exynos5250-dt.h +2 -0
index 8c21909..3736ea8 100644
@@ -21,6 +21,8 @@
 #define CONFIG_ARCH_CPU_INIT
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_BOARD_COMMON
+#define CONFIG_ARCH_EARLY_INIT_R
 
 /* Enable fdt support for Exynos5250 */
 #define CONFIG_OF_CONTROL
Signature · 1 line
1.7.12.4
#2 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hello Rajeshwari,

Quoted 26 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:
- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.

  arch/arm/include/asm/arch-exynos/board.h |  17 ++
  board/samsung/common/Makefile            |   4 +
  board/samsung/common/board.c             | 405 +++++++++++++++++++++++++++++++
  board/samsung/smdk5250/exynos5-dt.c      | 361 +--------------------------
  board/samsung/smdk5250/smdk5250.c        | 182 +-------------
  include/configs/exynos5250-dt.h          |   2 +
  6 files changed, 435 insertions(+), 536 deletions(-)
Quoted 3 lines

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

The name of exynos5 common file can't be just "board.c" since it is common only for Exynos5 boards and is placed in Samsung common. We have few Exynos4 boards in u-boot and in future we can introduce common board file for them too.
So it is better to add some additional word to this file name. This also needs to change config name or add checking SOC version in common Makefile.

Thank you,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
#3 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hi Przemyslaw

Quoted 37 lines · Przemyslaw Marczak

Hello Rajeshwari,

Quoted 29 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:
- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.

  arch/arm/include/asm/arch-exynos/board.h |  17 ++
  board/samsung/common/Makefile            |   4 +
  board/samsung/common/board.c             | 405
+++++++++++++++++++++++++++++++
  board/samsung/smdk5250/exynos5-dt.c      | 361
+--------------------------
  board/samsung/smdk5250/smdk5250.c        | 182 +-------------
  include/configs/exynos5250-dt.h          |   2 +
  6 files changed, 435 insertions(+), 536 deletions(-)
Quoted 3 lines

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

Quoted 7 lines

The name of exynos5 common file can't be just "board.c" since it is common only for Exynos5 boards and is placed in Samsung common.
We have few Exynos4 boards in u-boot and in future we can introduce common board file for them too.
So it is better to add some additional word to this file name. This also needs to change config name or add checking SOC version in common Makefile.

Cannot we use the same file even for exynos4 boards.

Signature · 2 lines
Regards,
Rajeshwari Shinde
Quoted 11 lines

Thank you,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hi,

Quoted 41 lines · Rajeshwari Birje

Hi Przemyslaw

Quoted 37 lines · Przemyslaw Marczak

Hello Rajeshwari,

Quoted 32 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:
- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.

   arch/arm/include/asm/arch-exynos/board.h |  17 ++
   board/samsung/common/Makefile            |   4 +
   board/samsung/common/board.c             | 405
+++++++++++++++++++++++++++++++
   board/samsung/smdk5250/exynos5-dt.c      | 361
+--------------------------
   board/samsung/smdk5250/smdk5250.c        | 182 +-------------
   include/configs/exynos5250-dt.h          |   2 +
   6 files changed, 435 insertions(+), 536 deletions(-)

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

Quoted 9 lines
Quoted 7 lines

The name of exynos5 common file can't be just "board.c" since it is common only for Exynos5 boards and is placed in Samsung common.
We have few Exynos4 boards in u-boot and in future we can introduce common board file for them too.
So it is better to add some additional word to this file name. This also needs to change config name or add checking SOC version in common Makefile.

Cannot we use the same file even for exynos4 boards.

I'm not sure that you understand my intention.

You want to introduce:
board/samsung/common/board.c - with only Exynos5 code

I mean that it should looks like this, e.g:
"board/samsung/common/board_exynos4.c" - common code for all Exynos 4 "board/samsung/common/board_exynos5.c" - common code for all Exynos 5 since there is some duplicated code in Exynos4 boards that can be moved to one common file in the future.
Do you understand my intention now?

Regards

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
#5 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hi,

Quoted 31 lines · Przemyslaw Marczak

Hi,

Quoted 27 lines · Rajeshwari Birje

Hi Przemyslaw

Quoted 22 lines · Przemyslaw Marczak

Hello Rajeshwari,

Quoted 17 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:--

Regards,
Rajeshwari Shind

Quoted 35 lines
Quoted 27 lines
Quoted 17 lines
Quoted 13 lines

- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.

   arch/arm/include/asm/arch-exynos/board.h |  17 ++
   board/samsung/common/Makefile            |   4 +
   board/samsung/common/board.c             | 405
+++++++++++++++++++++++++++++++
   board/samsung/smdk5250/exynos5-dt.c      | 361
+--------------------------
   board/samsung/smdk5250/smdk5250.c        | 182 +-------------
   include/configs/exynos5250-dt.h          |   2 +
   6 files changed, 435 insertions(+), 536 deletions(-)
Quoted 3 lines

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

Quoted 10 lines

The name of exynos5 common file can't be just "board.c" since it is common
only for Exynos5 boards and is placed in Samsung common.
We have few Exynos4 boards in u-boot and in future we can introduce common
board file for them too.
So it is better to add some additional word to this file name. This also needs to change config name or add checking SOC version in common Makefile.

Quoted 2 lines

Cannot we use the same file even for exynos4 boards.

I'm not sure that you understand my intention.

You want to introduce:
board/samsung/common/board.c - with only Exynos5 code

Quoted 7 lines

I mean that it should looks like this, e.g:
"board/samsung/common/board_exynos4.c" - common code for all Exynos 4 "board/samsung/common/board_exynos5.c" - common code for all Exynos 5 since there is some duplicated code in Exynos4 boards that can be moved to one common file in the future.
Do you understand my intention now?

Yes I understood your intention, but had a question cannot we use the same file board.c for exynos4 and exynos5 too.
Since both have most of functions similar like board_init, dram_init, board_uart_init and so on.

If u still feel that exynos4 and exynos5 have lots of functions different in board/samsung we can create a seperate file. I was hoping the same board.c could be reused for exynos4 also.

Signature · 2 lines
Regards,
Rajeshwari Shind
Quoted 8 lines

Regards

--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

#6 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hi,

Quoted 80 lines · Rajeshwari Birje

Hi,

Quoted 31 lines · Przemyslaw Marczak

Hi,

Quoted 27 lines · Rajeshwari Birje

Hi Przemyslaw

Quoted 22 lines · Przemyslaw Marczak

Hello Rajeshwari,

Quoted 17 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:--

Regards,
Rajeshwari Shind

Quoted 35 lines
Quoted 27 lines
Quoted 17 lines
Quoted 8 lines

- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.
arch/arm/include/asm/arch-exynos/board.h | 17 ++
board/samsung/common/Makefile | 4 +
board/samsung/common/board.c | 405
+++++++++++++++++++++++++++++++

Quoted 8 lines
    board/samsung/smdk5250/exynos5-dt.c      | 361
+--------------------------
    board/samsung/smdk5250/smdk5250.c        | 182 +-------------
    include/configs/exynos5250-dt.h          |   2 +
    6 files changed, 435 insertions(+), 536 deletions(-)

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

Quoted 10 lines

The name of exynos5 common file can't be just "board.c" since it is common
only for Exynos5 boards and is placed in Samsung common.
We have few Exynos4 boards in u-boot and in future we can introduce common
board file for them too.
So it is better to add some additional word to this file name. This also needs to change config name or add checking SOC version in common Makefile.

Quoted 2 lines

Cannot we use the same file even for exynos4 boards.

I'm not sure that you understand my intention.

You want to introduce:
board/samsung/common/board.c - with only Exynos5 code

Quoted 7 lines

I mean that it should looks like this, e.g:
"board/samsung/common/board_exynos4.c" - common code for all Exynos 4 "board/samsung/common/board_exynos5.c" - common code for all Exynos 5 since there is some duplicated code in Exynos4 boards that can be moved to one common file in the future.
Do you understand my intention now?

Quoted 9 lines

Yes I understood your intention, but had a question cannot we use the same file board.c for exynos4 and exynos5 too.
Since both have most of functions similar like board_init, dram_init, board_uart_init and so on.

If u still feel that exynos4 and exynos5 have lots of functions different in board/samsung we can create a seperate file. I was hoping the same board.c could be reused for exynos4 also.

Ah, ok. This is good idea with the one common file. Then we will have board files with strict board dependent functions. So I don't have any objections jet.
Regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
#7 lore raw

PATCH v6 1/10 EXYNOS5: Create a common board file

Hi,

Quoted 98 lines · Przemyslaw Marczak

Hi,

Quoted 94 lines · Rajeshwari Birje

Hi,

Quoted 35 lines · Przemyslaw Marczak

Hi,

Quoted 30 lines · Rajeshwari Birje

Hi Przemyslaw

Quoted 24 lines · Przemyslaw Marczak

Hello Rajeshwari,

Quoted 18 lines · Rajeshwari S Shinde

Create a common board.c file for all functions which are common across all EXYNOS5 platforms.

exynos_init function is provided for platform specific code.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added check for the compilation of MAX77686 pmic.
Changes in V5:--

Regards,
Rajeshwari Shind

Quoted 37 lines
Quoted 29 lines
Quoted 18 lines
Quoted 9 lines

- Moved board_eth_init and board_mmc_init in case of device tree support
Changes in V6:
- None.
arch/arm/include/asm/arch-exynos/board.h | 17 ++
board/samsung/common/Makefile | 4 +
board/samsung/common/board.c | 405
+++++++++++++++++++++++++++++++

Quoted 8 lines
    board/samsung/smdk5250/exynos5-dt.c      | 361
+--------------------------
    board/samsung/smdk5250/smdk5250.c        | 182 +-------------
    include/configs/exynos5250-dt.h          |   2 +
    6 files changed, 435 insertions(+), 536 deletions(-)

create mode 100644 arch/arm/include/asm/arch-exynos/board.h create mode 100644 board/samsung/common/board.c

Quoted 11 lines

The name of exynos5 common file can't be just "board.c" since it is common
only for Exynos5 boards and is placed in Samsung common. We have few Exynos4 boards in u-boot and in future we can introduce common
board file for them too.
So it is better to add some additional word to this file name. This also
needs to change config name or add checking SOC version in common Makefile.

Quoted 2 lines

Cannot we use the same file even for exynos4 boards.

I'm not sure that you understand my intention.

You want to introduce:
board/samsung/common/board.c - with only Exynos5 code

Quoted 8 lines

I mean that it should looks like this, e.g:
"board/samsung/common/board_exynos4.c" - common code for all Exynos 4 "board/samsung/common/board_exynos5.c" - common code for all Exynos 5 since there is some duplicated code in Exynos4 boards that can be moved to
one common file in the future.
Do you understand my intention now?

Yes I understood your intention, but had a question cannot we use the same file board.c for exynos4 and exynos5 too.
Since both have most of functions similar like board_init, dram_init, board_uart_init and so on.

Quoted 8 lines
Quoted 4 lines

If u still feel that exynos4 and exynos5 have lots of functions different in board/samsung we can create a seperate file. I was hoping the same board.c could be reused for exynos4 also.

Ah, ok. This is good idea with the one common file. Then we will have board files with strict board dependent functions. So I don't have any objections jet.
Regards,

Ok Thank you.

Signature · 2 lines
Regards,
Rajeshwari Shinde
Quoted 7 lines

--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

#8 lore raw

PATCH v6 2/10 Exynos5420: Add base addresses for 5420

In reply to Rajeshwari S Shinde

Adds base addresses of various IPs and controllers required for Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added base address for TZPC.
Changes in V5:
- None
Chnages in V6:
- Rebased on latest samsung mainline branch.

 arch/arm/include/asm/arch-exynos/cpu.h | 49 +++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-exynos/cpu.h +48 -1
index 4b67191..10a2ac3 100644
@@ -88,7 +88,7 @@
 #define EXYNOS4X12_DMC_PHY_BASE		DEVICE_NOT_AVAILABLE
 #define EXYNOS4X12_AUDIOSS_BASE		DEVICE_NOT_AVAILABLE
 
-/* EXYNOS5 Common*/
+/* EXYNOS5 */
 #define EXYNOS5_I2C_SPACING		0x10000
 
 #define EXYNOS5_AUDIOSS_BASE		0x03810000
@@ -124,6 +124,46 @@
 #define EXYNOS5_ADC_BASE		DEVICE_NOT_AVAILABLE
 #define EXYNOS5_MODEM_BASE		DEVICE_NOT_AVAILABLE
 
+/* EXYNOS5420 Common */
+#define EXYNOS5420_I2C_SPACING		0x10000
+
+#define EXYNOS5420_AUDIOSS_BASE		0x03810000
+#define EXYNOS5420_GPIO_PART5_BASE	0x03860000
+#define EXYNOS5420_PRO_ID		0x10000000
+#define EXYNOS5420_CLOCK_BASE		0x10010000
+#define EXYNOS5420_POWER_BASE		0x10040000
+#define EXYNOS5420_SWRESET		0x10040400
+#define EXYNOS5420_SYSREG_BASE		0x10050000
+#define EXYNOS5420_TZPC_BASE		0x100E0000
+#define EXYNOS5420_WATCHDOG_BASE	0x101D0000
+#define EXYNOS5420_ACE_SFR_BASE		0x10830000
+#define EXYNOS5420_DMC_PHY_BASE		0x10C00000
+#define EXYNOS5420_DMC_CTRL_BASE	0x10C20000
+#define EXYNOS5420_DMC_TZASC0_BASE	0x10D40000
+#define EXYNOS5420_DMC_TZASC1_BASE	0x10D50000
+#define EXYNOS5420_USB_HOST_EHCI_BASE	0x12110000
+#define EXYNOS5420_MMC_BASE		0x12200000
+#define EXYNOS5420_SROMC_BASE		0x12250000
+#define EXYNOS5420_UART_BASE		0x12C00000
+#define EXYNOS5420_I2C_BASE		0x12C60000
+#define EXYNOS5420_I2C_8910_BASE	0x12E00000
+#define EXYNOS5420_SPI_BASE		0x12D20000
+#define EXYNOS5420_I2S_BASE		0x12D60000
+#define EXYNOS5420_PWMTIMER_BASE	0x12DD0000
+#define EXYNOS5420_SPI_ISP_BASE		0x131A0000
+#define EXYNOS5420_GPIO_PART2_BASE	0x13400000
+#define EXYNOS5420_GPIO_PART3_BASE	0x13410000
+#define EXYNOS5420_GPIO_PART4_BASE	0x14000000
+#define EXYNOS5420_GPIO_PART1_BASE	0x14010000
+#define EXYNOS5420_MIPI_DSIM_BASE	0x14500000
+#define EXYNOS5420_DP_BASE		0x145B0000
+
+#define EXYNOS5420_USBPHY_BASE		DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_USBOTG_BASE		DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_FIMD_BASE		DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_ADC_BASE		DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_MODEM_BASE		DEVICE_NOT_AVAILABLE
+
 #ifndef __ASSEMBLY__
 #include <asm/io.h>
 /* CPU detection macros */
@@ -157,6 +197,10 @@ static inline void s5p_set_cpu_id(void)
 		/* Exynos5250 */
 		s5p_cpu_id = 0x5250;
 		break;
+	case 0x420:
+		/* Exynos5420 */
+		s5p_cpu_id = 0x5420;
+		break;
 	}
 }
 
@@ -184,6 +228,7 @@ static inline int __attribute__((no_instrument_function)) \
 IS_EXYNOS_TYPE(exynos4210, 0x4210)
 IS_EXYNOS_TYPE(exynos4412, 0x4412)
 IS_EXYNOS_TYPE(exynos5250, 0x5250)
+IS_EXYNOS_TYPE(exynos5420, 0x5420)
 
 #define SAMSUNG_BASE(device, base)				\
 static inline unsigned int __attribute__((no_instrument_function)) \
@@ -194,6 +239,8 @@ static inline unsigned int __attribute__((no_instrument_function)) \
 			return EXYNOS4X12_##base;		\
 		return EXYNOS4_##base;				\
 	} else if (cpu_is_exynos5()) {				\
+		if (proid_is_exynos5420())			\
+			return EXYNOS5420_##base;		\
 		return EXYNOS5_##base;				\
 	}							\
 	return 0;						\
Signature · 1 line
1.7.12.4
#9 lore raw

PATCH v6 2/10 Exynos5420: Add base addresses for 5420

Dear Rajeshwari S Shinde,

Quoted 27 lines · Rajeshwari S Shinde

Adds base addresses of various IPs and controllers required for Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added base address for TZPC.
Changes in V5:
- None
Chnages in V6:
- Rebased on latest samsung mainline branch.

 arch/arm/include/asm/arch-exynos/cpu.h | 49
+++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-exynos/cpu.h +0 -0
index 4b67191..10a2ac3 100644

arch/arm/include/asm/arch-exynos/cpu.h line 92

Quoted 6 lines
arch/arm/include/asm/arch-exynos/cpu.h +1 -1
@@ -88,7 +88,7 @@
 #define EXYNOS4X12_DMC_PHY_BASE                DEVICE_NOT_AVAILABLE
 #define EXYNOS4X12_AUDIOSS_BASE                DEVICE_NOT_AVAILABLE
 
-/* EXYNOS5 Common*/
+/* EXYNOS5 */
 

maybe it was wrong change.

arch/arm/include/asm/arch-exynos/cpu.h line 128

Quoted 9 lines
arch/arm/include/asm/arch-exynos/cpu.h +0 -0
 #define EXYNOS5_I2C_SPACING            0x10000
 

#define EXYNOS5_AUDIOSS_BASE 0x03810000

arch/arm/include/asm/arch-exynos/cpu.h +1 -0
@@ -124,6 +124,46 @@
 #define EXYNOS5_ADC_BASE               DEVICE_NOT_AVAILABLE
 #define EXYNOS5_MODEM_BASE             DEVICE_NOT_AVAILABLE
 
+/* EXYNOS5420 Common */
 

It was not common.

Quoted 72 lines
arch/arm/include/asm/arch-exynos/cpu.h +39 -0
+#define EXYNOS5420_I2C_SPACING         0x10000
+
+#define EXYNOS5420_AUDIOSS_BASE                0x03810000
+#define EXYNOS5420_GPIO_PART5_BASE     0x03860000
+#define EXYNOS5420_PRO_ID              0x10000000
+#define EXYNOS5420_CLOCK_BASE          0x10010000
+#define EXYNOS5420_POWER_BASE          0x10040000
+#define EXYNOS5420_SWRESET             0x10040400
+#define EXYNOS5420_SYSREG_BASE         0x10050000
+#define EXYNOS5420_TZPC_BASE           0x100E0000
+#define EXYNOS5420_WATCHDOG_BASE       0x101D0000
+#define EXYNOS5420_ACE_SFR_BASE                0x10830000
+#define EXYNOS5420_DMC_PHY_BASE                0x10C00000
+#define EXYNOS5420_DMC_CTRL_BASE       0x10C20000
+#define EXYNOS5420_DMC_TZASC0_BASE     0x10D40000
+#define EXYNOS5420_DMC_TZASC1_BASE     0x10D50000
+#define EXYNOS5420_USB_HOST_EHCI_BASE  0x12110000
+#define EXYNOS5420_MMC_BASE            0x12200000
+#define EXYNOS5420_SROMC_BASE          0x12250000
+#define EXYNOS5420_UART_BASE           0x12C00000
+#define EXYNOS5420_I2C_BASE            0x12C60000
+#define EXYNOS5420_I2C_8910_BASE       0x12E00000
+#define EXYNOS5420_SPI_BASE            0x12D20000
+#define EXYNOS5420_I2S_BASE            0x12D60000
+#define EXYNOS5420_PWMTIMER_BASE       0x12DD0000
+#define EXYNOS5420_SPI_ISP_BASE                0x131A0000
+#define EXYNOS5420_GPIO_PART2_BASE     0x13400000
+#define EXYNOS5420_GPIO_PART3_BASE     0x13410000
+#define EXYNOS5420_GPIO_PART4_BASE     0x14000000
+#define EXYNOS5420_GPIO_PART1_BASE     0x14010000
+#define EXYNOS5420_MIPI_DSIM_BASE      0x14500000
+#define EXYNOS5420_DP_BASE             0x145B0000
+
+#define EXYNOS5420_USBPHY_BASE         DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_USBOTG_BASE         DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_FIMD_BASE           DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_ADC_BASE            DEVICE_NOT_AVAILABLE
+#define EXYNOS5420_MODEM_BASE          DEVICE_NOT_AVAILABLE
+
 #ifndef __ASSEMBLY__
 #include <asm/io.h>

/* CPU detection macros */

arch/arm/include/asm/arch-exynos/cpu.h +5 -0
@@ -157,6 +197,10 @@ static inline void s5p_set_cpu_id(void)
                /* Exynos5250 */
                s5p_cpu_id = 0x5250;
                break;
+       case 0x420:
+               /* Exynos5420 */
+               s5p_cpu_id = 0x5420;
+               break;
        }
 }
 
@@ -184,6 +228,7 @@ static inline int
 __attribute__((no_instrument_function)) \
 IS_EXYNOS_TYPE(exynos4210, 0x4210)
 IS_EXYNOS_TYPE(exynos4412, 0x4412)
 IS_EXYNOS_TYPE(exynos5250, 0x5250)
+IS_EXYNOS_TYPE(exynos5420, 0x5420)
 
 #define SAMSUNG_BASE(device, base)                             \

static inline unsigned int __attribute__((no_instrument_function)) \

arch/arm/include/asm/arch-exynos/cpu.h +2 -0
@@ -194,6 +239,8 @@ static inline unsigned int
 __attribute__((no_instrument_function)) \
                        return EXYNOS4X12_##base;               \
                return EXYNOS4_##base;                          \
        } else if (cpu_is_exynos5()) {                          \
+               if (proid_is_exynos5420())                      \
+                       return EXYNOS5420_##base;               \
                return EXYNOS5_##base;                          \
        }                                                       \
        return 0;                                               \
Quoted 8 lines

--
1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#10 lore raw

PATCH v6 3/10 Exynos5420: Add clock initialization for 5420

In reply to Rajeshwari S Shinde

This patch adds code for clock initialization and clock settings of various IP's and controllers, required for Exynos5420

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Corrected the multiline commenting style
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740 +++++++++++++++++++------
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 6 files changed, 1673 insertions(+), 201 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +256 -14
index 36fedd6..b52e61a 100644
@@ -96,7 +96,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
 
 	freq = CONFIG_SYS_CLK_FREQ;
 
-	if (pllreg == EPLL) {
+	if (pllreg == EPLL || pllreg == RPLL) {
 		k = k & 0xffff;
 		/* FOUT = (MDIV + K / 65536) * FIN / (PDIV * 2^SDIV) */
 		fout = (m + k / PLL_DIV_65536) * (freq / (p * (1 << s)));
@@ -117,7 +117,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int r, unsigned int k)
 			div = PLL_DIV_1024;
 		else if (proid_is_exynos4412())
 			div = PLL_DIV_65535;
-		else if (proid_is_exynos5250())
+		else if (cpu_is_exynos5())
 			div = PLL_DIV_65536;
 		else
 			return 0;
@@ -362,6 +362,43 @@ unsigned long clock_get_periph_rate(int peripheral)
 		return 0;
 }
 
+/* exynos5420: return pll clock frequency */
+static unsigned long exynos5420_get_pll_clk(int pllreg)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned long r, k = 0;
+
+	switch (pllreg) {
+	case APLL:
+		r = readl(&clk->apll_con0);
+		break;
+	case MPLL:
+		r = readl(&clk->mpll_con0);
+		break;
+	case EPLL:
+		r = readl(&clk->epll_con0);
+		k = readl(&clk->epll_con1);
+		break;
+	case VPLL:
+		r = readl(&clk->vpll_con0);
+		k = readl(&clk->vpll_con1);
+		break;
+	case BPLL:
+		r = readl(&clk->bpll_con0);
+		break;
+	case RPLL:
+		r = readl(&clk->rpll_con0);
+		k = readl(&clk->rpll_con1);
+		break;
+	default:
+		printf("Unsupported PLL (%d)\n", pllreg);
+		return 0;
+	}
+
+	return exynos_get_pll_clk(pllreg, r, k);
+}
+
 /* exynos4: return ARM clock frequency */
 static unsigned long exynos4_get_arm_clk(void)
 {
@@ -485,6 +522,27 @@ static unsigned long exynos4x12_get_pwm_clk(void)
 	return pclk;
 }
 
+/* exynos5420: return pwm clock frequency */
+static unsigned long exynos5420_get_pwm_clk(void)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned long pclk, sclk;
+	unsigned int ratio;
+
+	/*
+	 * CLK_DIV_PERIC3
+	 * PWM_RATIO [3:0]
+	 */
+	ratio = readl(&clk->div_peric0);
+	ratio = (ratio >> 28) & 0xf;
+	sclk = get_pll_clk(MPLL);
+
+	pclk = sclk / (ratio + 1);
+
+	return pclk;
+}
+
 /* exynos4: return uart clock frequency */
 static unsigned long exynos4_get_uart_clk(int dev_index)
 {
@@ -624,6 +682,53 @@ static unsigned long exynos5_get_uart_clk(int dev_index)
 	return uclk;
 }
 
+/* exynos5420: return uart clock frequency */
+static unsigned long exynos5420_get_uart_clk(int dev_index)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned long uclk, sclk;
+	unsigned int sel;
+	unsigned int ratio;
+
+	/*
+	 * CLK_SRC_PERIC0
+	 * UART0_SEL [3:0]
+	 * UART1_SEL [7:4]
+	 * UART2_SEL [8:11]
+	 * UART3_SEL [12:15]
+	 * UART4_SEL [16:19]
+	 * UART5_SEL [23:20]
+	 */
+	sel = readl(&clk->src_peric0);
+	sel = (sel >> ((dev_index * 4) + 4)) & 0x7;
+
+	if (sel == 0x3)
+		sclk = get_pll_clk(MPLL);
+	else if (sel == 0x6)
+		sclk = get_pll_clk(EPLL);
+	else if (sel == 0x7)
+		sclk = get_pll_clk(RPLL);
+	else
+		return 0;
+
+	/*
+	 * CLK_DIV_PERIC0
+	 * UART0_RATIO [3:0]
+	 * UART1_RATIO [7:4]
+	 * UART2_RATIO [8:11]
+	 * UART3_RATIO [12:15]
+	 * UART4_RATIO [16:19]
+	 * UART5_RATIO [23:20]
+	 */
+	ratio = readl(&clk->div_peric0);
+	ratio = (ratio >> ((dev_index * 4) + 8)) & 0xf;
+
+	uclk = sclk / (ratio + 1);
+
+	return uclk;
+}
+
 static unsigned long exynos4_get_mmc_clk(int dev_index)
 {
 	struct exynos4_clock *clk =
@@ -718,6 +823,34 @@ static unsigned long exynos5_get_mmc_clk(int dev_index)
 	return uclk;
 }
 
+static unsigned long exynos5420_get_mmc_clk(int dev_index)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned long uclk, sclk;
+	unsigned int sel, ratio;
+	int shift = 0;
+
+	sel = readl(&clk->src_fsys);
+	sel = (sel >> ((dev_index * 4) + 8)) & 0x7;
+
+	if (sel == 0x3)
+		sclk = get_pll_clk(MPLL);
+	else if (sel == 0x6)
+		sclk = get_pll_clk(EPLL);
+	else
+		return 0;
+
+	ratio = readl(&clk->div_fsys1);
+
+	shift = dev_index * 10;
+
+	ratio = (ratio >> shift) & 0x3ff;
+	uclk = (sclk / (ratio + 1));
+
+	return uclk;
+}
+
 /* exynos4: set the mmc clock */
 static void exynos4_set_mmc_clk(int dev_index, unsigned int div)
 {
@@ -804,6 +937,23 @@ static void exynos5_set_mmc_clk(int dev_index, unsigned int div)
 	writel(val, addr);
 }
 
+/* exynos5: set the mmc clock */
+static void exynos5420_set_mmc_clk(int dev_index, unsigned int div)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	unsigned int addr;
+	unsigned int val, shift;
+
+	addr = (unsigned int)&clk->div_fsys1;
+	shift = dev_index * 10;
+
+	val = readl(addr);
+	val &= ~(0x3ff << shift);
+	val |= (div & 0x3ff) << shift;
+	writel(val, addr);
+}
+
 /* get_lcd_clk: return lcd clock frequency */
 static unsigned long exynos4_get_lcd_clk(void)
 {
@@ -1324,6 +1474,84 @@ static int exynos5_set_spi_clk(enum periph_id periph_id,
 	return 0;
 }
 
+static int exynos5420_set_spi_clk(enum periph_id periph_id,
+					unsigned int rate)
+{
+	struct exynos5420_clock *clk =
+		(struct exynos5420_clock *)samsung_get_base_clock();
+	int main;
+	unsigned int fine, val;
+	unsigned shift, pre_shift;
+	unsigned div_mask = 0xf, pre_div_mask = 0xff;
+
+	main = clock_calc_best_scalar(4, 8, 400000000, rate, &fine);
+	if (main < 0) {
+		debug("%s: Cannot set clock rate for periph %d",
+		      __func__, periph_id);
+		return -1;
+	}
+	main = main - 1;
+	fine = fine - 1;
+
+	switch (periph_id) {
+	case PERIPH_ID_SPI0:
+		val = readl(&clk->div_peric1);
+		val &= ~(div_mask << 20);
+		val |= (main << 20);
+		writel(val, &clk->div_peric1);
+
+		val = readl(&clk->div_peric4);
+		val &= ~(pre_div_mask << 8);
+		val |= (fine << 8);
+		writel(val, &clk->div_peric4);
+		break;
+	case PERIPH_ID_SPI1:
+		val = readl(&clk->div_peric1);
+		val &= ~(div_mask << 24);
+		val |= (main << 24);
+		writel(val, &clk->div_peric1);
+
+		val = readl(&clk->div_peric4);
+		val &= ~(pre_div_mask << 16);
+		val |= (fine << 16);
+		writel(val, &clk->div_peric4);
+		break;
+	case PERIPH_ID_SPI2:
+		val = readl(&clk->div_peric1);
+		val &= ~(div_mask << 28);
+		val |= (main << 28);
+		writel(val, &clk->div_peric1);
+
+		val = readl(&clk->div_peric4);
+		val &= ~(pre_div_mask << 24);
+		val |= (fine << 24);
+		writel(val, &clk->div_peric4);
+		break;
+	case PERIPH_ID_SPI3:
+		shift = 16;
+		pre_shift = 0;
+		clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+				(main & div_mask) << shift);
+		clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+				(fine & pre_div_mask) << pre_shift);
+		break;
+	case PERIPH_ID_SPI4:
+		shift = 20;
+		pre_shift = 8;
+		clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+				(main & div_mask) << shift);
+		clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+				(fine & pre_div_mask) << pre_shift);
+		break;
+	default:
+		debug("%s: Unsupported peripheral ID %d\n", __func__,
+		      periph_id);
+		return -1;
+	}
+
+	return 0;
+}
+
 static unsigned long exynos4_get_i2c_clk(void)
 {
 	struct exynos4_clock *clk =
@@ -1341,9 +1569,11 @@ static unsigned long exynos4_get_i2c_clk(void)
 
 unsigned long get_pll_clk(int pllreg)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_get_pll_clk(pllreg);
 		return exynos5_get_pll_clk(pllreg);
-	else {
+	} else {
 		if (proid_is_exynos4412())
 			return exynos4x12_get_pll_clk(pllreg);
 		return exynos4_get_pll_clk(pllreg);
@@ -1375,9 +1605,11 @@ unsigned long get_i2c_clk(void)
 
 unsigned long get_pwm_clk(void)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_get_pwm_clk();
 		return clock_get_periph_rate(PERIPH_ID_PWM0);
-	else {
+	} else {
 		if (proid_is_exynos4412())
 			return exynos4x12_get_pwm_clk();
 		return exynos4_get_pwm_clk();
@@ -1386,9 +1618,11 @@ unsigned long get_pwm_clk(void)
 
 unsigned long get_uart_clk(int dev_index)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_get_uart_clk(dev_index);
 		return exynos5_get_uart_clk(dev_index);
-	else {
+	} else {
 		if (proid_is_exynos4412())
 			return exynos4x12_get_uart_clk(dev_index);
 		return exynos4_get_uart_clk(dev_index);
@@ -1397,17 +1631,22 @@ unsigned long get_uart_clk(int dev_index)
 
 unsigned long get_mmc_clk(int dev_index)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_get_mmc_clk(dev_index);
 		return exynos5_get_mmc_clk(dev_index);
-	else
+	} else {
 		return exynos4_get_mmc_clk(dev_index);
+	}
 }
 
 void set_mmc_clk(int dev_index, unsigned int div)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_set_mmc_clk(dev_index, div);
 		exynos5_set_mmc_clk(dev_index, div);
-	else {
+	} else {
 		if (proid_is_exynos4412())
 			exynos4x12_set_mmc_clk(dev_index, div);
 		exynos4_set_mmc_clk(dev_index, div);
@@ -1438,10 +1677,13 @@ void set_mipi_clk(void)
 
 int set_spi_clk(int periph_id, unsigned int rate)
 {
-	if (cpu_is_exynos5())
+	if (cpu_is_exynos5()) {
+		if (proid_is_exynos5420())
+			return exynos5420_set_spi_clk(periph_id, rate);
 		return exynos5_set_spi_clk(periph_id, rate);
-	else
+	} else {
 		return 0;
+	}
 }
 
 int set_i2s_clk_prescaler(unsigned int src_frq, unsigned int dst_frq,
arch/arm/cpu/armv7/exynos/clock_init.h +17 -0
index c28ff3a..a875d0b 100644
@@ -10,7 +10,11 @@
 #define __EXYNOS_CLOCK_INIT_H
 
 enum {
+#ifdef CONFIG_EXYNOS5420
+	MEM_TIMINGS_MSR_COUNT	= 5,
+#else
 	MEM_TIMINGS_MSR_COUNT	= 4,
+#endif
 };
 
 /* These are the ratio's for configuring ARM clock */
@@ -59,6 +63,18 @@ struct mem_timings {
 	unsigned bpll_mdiv;
 	unsigned bpll_pdiv;
 	unsigned bpll_sdiv;
+	unsigned kpll_mdiv;
+	unsigned kpll_pdiv;
+	unsigned kpll_sdiv;
+	unsigned dpll_mdiv;
+	unsigned dpll_pdiv;
+	unsigned dpll_sdiv;
+	unsigned ipll_mdiv;
+	unsigned ipll_pdiv;
+	unsigned ipll_sdiv;
+	unsigned spll_mdiv;
+	unsigned spll_pdiv;
+	unsigned spll_sdiv;
 	unsigned pclk_cdrex_ratio;
 	unsigned direct_cmd_msr[MEM_TIMINGS_MSR_COUNT];
 
@@ -115,6 +131,7 @@ struct mem_timings {
 	uint8_t send_zq_init;		/* 1 to send this command */
 	unsigned impedance;		/* drive strength impedeance */
 	uint8_t gate_leveling_enable;	/* check gate leveling is enabled */
+	uint8_t read_leveling_enable;	/* check h/w read leveling is enabled */
 };
 
 /**
arch/arm/cpu/armv7/exynos/clock_init_exynos5.c +338 -14

390 lines not on this page · raw message

arch/arm/cpu/armv7/exynos/exynos5_setup.h +567 -173

856 lines not on this page · raw message

arch/arm/include/asm/arch-exynos/clk.h +1 -0
index 1d6fa93..cdeef32 100644
@@ -14,6 +14,7 @@
 #define HPLL	3
 #define VPLL	4
 #define BPLL	5
+#define RPLL	6
 
 enum pll_src_bit {
 	EXYNOS_SRC_MPLL = 6,
arch/arm/include/asm/arch-exynos/clock.h +494 -0

500 lines not on this page · raw message

Signature · 1 line
1.7.12.4
#11 lore raw

PATCH v6 3/10 Exynos5420: Add clock initialization for 5420

Dear Rajeshwari S Shinde,

Quoted 42 lines · Rajeshwari S Shinde

This patch adds code for clock initialization and clock settings of various IP's and controllers, required for Exynos5420

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Corrected the multiline commenting style
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740
+++++++++++++++++++------
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 6 files changed, 1673 insertions(+), 201 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +1 -1
index 36fedd6..b52e61a 100644
@@ -96,7 +96,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
 r, unsigned int k)
 
        freq = CONFIG_SYS_CLK_FREQ;
 
-       if (pllreg == EPLL) {
+       if (pllreg == EPLL || pllreg == RPLL) {
                k = k & 0xffff;
                /* FOUT = (MDIV + K / 65536) * FIN / (PDIV * 2^SDIV) */
                fout = (m + k / PLL_DIV_65536) * (freq / (p * (1 << s)));

arch/arm/cpu/armv7/exynos/clock.c static int exynos_get_pll_clk(int pllreg, unsigned int · line 122

Quoted 7 lines
arch/arm/cpu/armv7/exynos/clock.c +1 -1
@@ -117,7 +117,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
 r, unsigned int k)
                        div = PLL_DIV_1024;
                else if (proid_is_exynos4412())
                        div = PLL_DIV_65535;
-               else if (proid_is_exynos5250())
+               else if (cpu_is_exynos5())
 

please don't mix proid_is... and cpu_is...

Quoted 240 lines
arch/arm/cpu/armv7/exynos/clock.c +0 -0
                        div = PLL_DIV_65536;
                else
                        return 0;
arch/arm/cpu/armv7/exynos/clock.c +105 -0
@@ -362,6 +362,43 @@ unsigned long clock_get_periph_rate(int peripheral)
                return 0;
 }
 
+/* exynos5420: return pll clock frequency */
+static unsigned long exynos5420_get_pll_clk(int pllreg)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long r, k = 0;
+
+       switch (pllreg) {
+       case APLL:
+               r = readl(&clk->apll_con0);
+               break;
+       case MPLL:
+               r = readl(&clk->mpll_con0);
+               break;
+       case EPLL:
+               r = readl(&clk->epll_con0);
+               k = readl(&clk->epll_con1);
+               break;
+       case VPLL:
+               r = readl(&clk->vpll_con0);
+               k = readl(&clk->vpll_con1);
+               break;
+       case BPLL:
+               r = readl(&clk->bpll_con0);
+               break;
+       case RPLL:
+               r = readl(&clk->rpll_con0);
+               k = readl(&clk->rpll_con1);
+               break;
+       default:
+               printf("Unsupported PLL (%d)\n", pllreg);
+               return 0;
+       }
+
+       return exynos_get_pll_clk(pllreg, r, k);
+}
+
 /* exynos4: return ARM clock frequency */
 static unsigned long exynos4_get_arm_clk(void)
 {
@@ -485,6 +522,27 @@ static unsigned long exynos4x12_get_pwm_clk(void)
        return pclk;
 }
 
+/* exynos5420: return pwm clock frequency */
+static unsigned long exynos5420_get_pwm_clk(void)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long pclk, sclk;
+       unsigned int ratio;
+
+       /*
+        * CLK_DIV_PERIC3
+        * PWM_RATIO [3:0]
+        */
+       ratio = readl(&clk->div_peric0);
+       ratio = (ratio >> 28) & 0xf;
+       sclk = get_pll_clk(MPLL);
+
+       pclk = sclk / (ratio + 1);
+
+       return pclk;
+}
+
 /* exynos4: return uart clock frequency */
 static unsigned long exynos4_get_uart_clk(int dev_index)
 {
@@ -624,6 +682,53 @@ static unsigned long exynos5_get_uart_clk(int
 dev_index)
        return uclk;
 }
 
+/* exynos5420: return uart clock frequency */
+static unsigned long exynos5420_get_uart_clk(int dev_index)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long uclk, sclk;
+       unsigned int sel;
+       unsigned int ratio;
+
+       /*
+        * CLK_SRC_PERIC0
+        * UART0_SEL [3:0]
+        * UART1_SEL [7:4]
+        * UART2_SEL [8:11]
+        * UART3_SEL [12:15]
+        * UART4_SEL [16:19]
+        * UART5_SEL [23:20]
+        */
+       sel = readl(&clk->src_peric0);
+       sel = (sel >> ((dev_index * 4) + 4)) & 0x7;
+
+       if (sel == 0x3)
+               sclk = get_pll_clk(MPLL);
+       else if (sel == 0x6)
+               sclk = get_pll_clk(EPLL);
+       else if (sel == 0x7)
+               sclk = get_pll_clk(RPLL);
+       else
+               return 0;
+
+       /*
+        * CLK_DIV_PERIC0
+        * UART0_RATIO [3:0]
+        * UART1_RATIO [7:4]
+        * UART2_RATIO [8:11]
+        * UART3_RATIO [12:15]
+        * UART4_RATIO [16:19]
+        * UART5_RATIO [23:20]
+        */
+       ratio = readl(&clk->div_peric0);
+       ratio = (ratio >> ((dev_index * 4) + 8)) & 0xf;
+
+       uclk = sclk / (ratio + 1);
+
+       return uclk;
+}
+
 static unsigned long exynos4_get_mmc_clk(int dev_index)
 {

struct exynos4_clock *clk =

arch/arm/cpu/armv7/exynos/clock.c +28 -0
@@ -718,6 +823,34 @@ static unsigned long exynos5_get_mmc_clk(int
 dev_index)
        return uclk;
 }
 
+static unsigned long exynos5420_get_mmc_clk(int dev_index)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long uclk, sclk;
+       unsigned int sel, ratio;
+       int shift = 0;
+
+       sel = readl(&clk->src_fsys);
+       sel = (sel >> ((dev_index * 4) + 8)) & 0x7;
+
+       if (sel == 0x3)
+               sclk = get_pll_clk(MPLL);
+       else if (sel == 0x6)
+               sclk = get_pll_clk(EPLL);
+       else
+               return 0;
+
+       ratio = readl(&clk->div_fsys1);
+
+       shift = dev_index * 10;
+
+       ratio = (ratio >> shift) & 0x3ff;
+       uclk = (sclk / (ratio + 1));
+
+       return uclk;
+}
+
 /* exynos4: set the mmc clock */
 static void exynos4_set_mmc_clk(int dev_index, unsigned int div)

{

arch/arm/cpu/armv7/exynos/clock.c +17 -0
@@ -804,6 +937,23 @@ static void exynos5_set_mmc_clk(int dev_index,
 unsigned int div)
        writel(val, addr);
 }
 
+/* exynos5: set the mmc clock */
+static void exynos5420_set_mmc_clk(int dev_index, unsigned int div)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned int addr;
+       unsigned int val, shift;
+
+       addr = (unsigned int)&clk->div_fsys1;
+       shift = dev_index * 10;
+
+       val = readl(addr);
+       val &= ~(0x3ff << shift);
+       val |= (div & 0x3ff) << shift;
+       writel(val, addr);
+}
+
 /* get_lcd_clk: return lcd clock frequency */
 static unsigned long exynos4_get_lcd_clk(void)

{

arch/arm/cpu/armv7/exynos/clock.c +44 -0
@@ -1324,6 +1474,84 @@ static int exynos5_set_spi_clk(enum periph_id
 periph_id,
        return 0;
 }
 
+static int exynos5420_set_spi_clk(enum periph_id periph_id,
+                                       unsigned int rate)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       int main;
+       unsigned int fine, val;
+       unsigned shift, pre_shift;
+       unsigned div_mask = 0xf, pre_div_mask = 0xff;
+
+       main = clock_calc_best_scalar(4, 8, 400000000, rate, &fine);
+       if (main < 0) {
+               debug("%s: Cannot set clock rate for periph %d",
+                     __func__, periph_id);
+               return -1;
+       }
+       main = main - 1;
+       fine = fine - 1;
+
+       switch (periph_id) {
+       case PERIPH_ID_SPI0:
+               val = readl(&clk->div_peric1);
+               val &= ~(div_mask << 20);
+               val |= (main << 20);
+               writel(val, &clk->div_peric1);
+
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 8);
+               val |= (fine << 8);
+               writel(val, &clk->div_peric4);
+               break;
+       case PERIPH_ID_SPI1:
+               val = readl(&clk->div_peric1);
+               val &= ~(div_mask << 24);
+               val |= (main << 24);
+               writel(val, &clk->div_peric1);
+
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 16);
+               val |= (fine << 16);
+               writel(val, &clk->div_peric4);
+               break;
+       case PERIPH_ID_SPI2:
+               val = readl(&clk->div_peric1);

arch/arm/cpu/armv7/exynos/clock.c static int exynos5_set_spi_clk(enum periph_id · line 1531

Quoted 10 lines
arch/arm/cpu/armv7/exynos/clock.c +9 -0
+               val &= ~(div_mask << 28);
+               val |= (main << 28);
+               writel(val, &clk->div_peric1);
+
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 24);
+               val |= (fine << 24);
+               writel(val, &clk->div_peric4);
+               break;
 

I think we can use same code for SPI0/1/2.

Quoted 623 lines
arch/arm/cpu/armv7/exynos/clock.c +25 -0
+       case PERIPH_ID_SPI3:
+               shift = 16;
+               pre_shift = 0;
+               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+                               (main & div_mask) << shift);
+               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+                               (fine & pre_div_mask) << pre_shift);
+               break;
+       case PERIPH_ID_SPI4:
+               shift = 20;
+               pre_shift = 8;
+               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+                               (main & div_mask) << shift);
+               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+                               (fine & pre_div_mask) << pre_shift);
+               break;
+       default:
+               debug("%s: Unsupported peripheral ID %d\n", __func__,
+                     periph_id);
+               return -1;
+       }
+
+       return 0;
+}
+
 static unsigned long exynos4_get_i2c_clk(void)

{
struct exynos4_clock *clk =

arch/arm/cpu/armv7/exynos/clock.c +26 -12
@@ -1341,9 +1569,11 @@ static unsigned long exynos4_get_i2c_clk(void)
 
 unsigned long get_pll_clk(int pllreg)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_pll_clk(pllreg);
                return exynos5_get_pll_clk(pllreg);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_pll_clk(pllreg);
                return exynos4_get_pll_clk(pllreg);
@@ -1375,9 +1605,11 @@ unsigned long get_i2c_clk(void)
 
 unsigned long get_pwm_clk(void)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_pwm_clk();
                return clock_get_periph_rate(PERIPH_ID_PWM0);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_pwm_clk();
                return exynos4_get_pwm_clk();
@@ -1386,9 +1618,11 @@ unsigned long get_pwm_clk(void)
 
 unsigned long get_uart_clk(int dev_index)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_uart_clk(dev_index);
                return exynos5_get_uart_clk(dev_index);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_uart_clk(dev_index);
                return exynos4_get_uart_clk(dev_index);
@@ -1397,17 +1631,22 @@ unsigned long get_uart_clk(int dev_index)
 
 unsigned long get_mmc_clk(int dev_index)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_mmc_clk(dev_index);
                return exynos5_get_mmc_clk(dev_index);
-       else
+       } else {
                return exynos4_get_mmc_clk(dev_index);
+       }
 }
 
 void set_mmc_clk(int dev_index, unsigned int div)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_set_mmc_clk(dev_index, div);
                exynos5_set_mmc_clk(dev_index, div);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        exynos4x12_set_mmc_clk(dev_index, div);
                exynos4_set_mmc_clk(dev_index, div);
@@ -1438,10 +1677,13 @@ void set_mipi_clk(void)
 
 int set_spi_clk(int periph_id, unsigned int rate)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_set_spi_clk(periph_id, rate);
                return exynos5_set_spi_clk(periph_id, rate);
-       else
+       } else {
                return 0;
+       }
 }
 
 int set_i2s_clk_prescaler(unsigned int src_frq, unsigned int dst_frq,
arch/arm/cpu/armv7/exynos/clock_init.h +17 -0
index c28ff3a..a875d0b 100644
@@ -10,7 +10,11 @@
 #define __EXYNOS_CLOCK_INIT_H
 
 enum {
+#ifdef CONFIG_EXYNOS5420
+       MEM_TIMINGS_MSR_COUNT   = 5,
+#else
        MEM_TIMINGS_MSR_COUNT   = 4,
+#endif
 };
 
 /* These are the ratio's for configuring ARM clock */
@@ -59,6 +63,18 @@ struct mem_timings {
        unsigned bpll_mdiv;
        unsigned bpll_pdiv;
        unsigned bpll_sdiv;
+       unsigned kpll_mdiv;
+       unsigned kpll_pdiv;
+       unsigned kpll_sdiv;
+       unsigned dpll_mdiv;
+       unsigned dpll_pdiv;
+       unsigned dpll_sdiv;
+       unsigned ipll_mdiv;
+       unsigned ipll_pdiv;
+       unsigned ipll_sdiv;
+       unsigned spll_mdiv;
+       unsigned spll_pdiv;
+       unsigned spll_sdiv;
        unsigned pclk_cdrex_ratio;
        unsigned direct_cmd_msr[MEM_TIMINGS_MSR_COUNT];
 
@@ -115,6 +131,7 @@ struct mem_timings {
        uint8_t send_zq_init;           /* 1 to send this command */
        unsigned impedance;             /* drive strength impedeance */
        uint8_t gate_leveling_enable;   /* check gate leveling is enabled
 */
+       uint8_t read_leveling_enable;   /* check h/w read leveling is

enabled */
};

/**

arch/arm/cpu/armv7/exynos/clock_init_exynos5.c +338 -14
index a24c2f3..e7f1496 100644
@@ -24,6 +24,24 @@
 DECLARE_GLOBAL_DATA_PTR;
 
 struct arm_clk_ratios arm_clk_ratios[] = {
+#ifdef CONFIG_EXYNOS5420
+       {
+               .arm_freq_mhz = 900,
+
+               .apll_mdiv = 0x96,
+               .apll_pdiv = 0x2,
+               .apll_sdiv = 0x1,
+
+               .arm2_ratio = 0x0,
+               .apll_ratio = 0x3,
+               .pclk_dbg_ratio = 0x6,
+               .atb_ratio = 0x6,
+               .periph_ratio = 0x7,
+               .acp_ratio = 0x0,
+               .cpud_ratio = 0x2,
+               .arm_ratio = 0x0,
+       }
+#else
        {
                .arm_freq_mhz = 600,
 
@@ -115,8 +133,133 @@ struct arm_clk_ratios arm_clk_ratios[] = {
                .cpud_ratio = 0x3,
                .arm_ratio = 0x0,
        }
+#endif
 };
+
 struct mem_timings mem_timings[] = {
+#ifdef CONFIG_EXYNOS5420
+       {
+               .mem_manuf = MEM_MANUF_SAMSUNG,
+               .mem_type = DDR_MODE_DDR3,
+               .frequency_mhz = 800,
+
+               /* MPLL @800MHz*/
+               .mpll_mdiv = 0xc8,
+               .mpll_pdiv = 0x3,
+               .mpll_sdiv = 0x1,
+               /* CPLL @666MHz */
+               .cpll_mdiv = 0xde,
+               .cpll_pdiv = 0x4,
+               .cpll_sdiv = 0x1,
+               /* EPLL @600MHz */
+               .epll_mdiv = 0x64,
+               .epll_pdiv = 0x2,
+               .epll_sdiv = 0x1,
+               /* VPLL @430MHz */
+               .vpll_mdiv = 0xd7,
+               .vpll_pdiv = 0x3,
+               .vpll_sdiv = 0x2,
+               /* BPLL @800MHz */
+               .bpll_mdiv = 0xc8,
+               .bpll_pdiv = 0x3,
+               .bpll_sdiv = 0x1,
+               /* KPLL @600MHz */
+               .kpll_mdiv = 0x190,
+               .kpll_pdiv = 0x4,
+               .kpll_sdiv = 0x2,
+               /* DPLL @600MHz */
+               .dpll_mdiv = 0x190,
+               .dpll_pdiv = 0x4,
+               .dpll_sdiv = 0x2,
+               /* IPLL @370MHz */
+               .ipll_mdiv = 0xb9,
+               .ipll_pdiv = 0x3,
+               .ipll_sdiv = 0x2,
+               /* SPLL @400MHz */
+               .spll_mdiv = 0xc8,
+               .spll_pdiv = 0x3,
+               .spll_sdiv = 0x2,
+
+               .direct_cmd_msr = {
+                       0x00020018, 0x00030000, 0x00010046, 0x00000d70,
+                       0x00000c70
+               },
+               .timing_ref = 0x000000bb,
+               .timing_row = 0x6836650f,
+               .timing_data = 0x3630580b,
+               .timing_power = 0x41000a26,
+               .phy0_dqs = 0x08080808,
+               .phy1_dqs = 0x08080808,
+               .phy0_dq = 0x08080808,
+               .phy1_dq = 0x08080808,
+               .phy0_tFS = 0x8,
+               .phy1_tFS = 0x8,
+               .phy0_pulld_dqs = 0xf,
+               .phy1_pulld_dqs = 0xf,
+
+               .lpddr3_ctrl_phy_reset = 0x1,
+               .ctrl_start_point = 0x10,
+               .ctrl_inc = 0x10,
+               .ctrl_start = 0x1,
+               .ctrl_dll_on = 0x1,
+               .ctrl_ref = 0x8,
+
+               .ctrl_force = 0x1a,
+               .ctrl_rdlat = 0x0b,
+               .ctrl_bstlen = 0x08,
+
+               .fp_resync = 0x8,
+               .iv_size = 0x7,
+               .dfi_init_start = 1,
+               .aref_en = 1,
+
+               .rd_fetch = 0x3,
+
+               .zq_mode_dds = 0x7,
+               .zq_mode_term = 0x1,
+               .zq_mode_noterm = 1,
+
+               /*
+               * Dynamic Clock: Always Running
+               * Memory Burst length: 8
+               * Number of chips: 1
+               * Memory Bus width: 32 bit
+               * Memory Type: DDR3
+               * Additional Latancy for PLL: 0 Cycle
+               */
+               .memcontrol = DMC_MEMCONTROL_CLK_STOP_DISABLE |
+                       DMC_MEMCONTROL_DPWRDN_DISABLE |
+                       DMC_MEMCONTROL_DPWRDN_ACTIVE_PRECHARGE |
+                       DMC_MEMCONTROL_TP_DISABLE |
+                       DMC_MEMCONTROL_DSREF_DISABLE |
+                       DMC_MEMCONTROL_ADD_LAT_PALL_CYCLE(0) |
+                       DMC_MEMCONTROL_MEM_TYPE_DDR3 |
+                       DMC_MEMCONTROL_MEM_WIDTH_32BIT |
+                       DMC_MEMCONTROL_NUM_CHIP_1 |
+                       DMC_MEMCONTROL_BL_8 |
+                       DMC_MEMCONTROL_PZQ_DISABLE |
+                       DMC_MEMCONTROL_MRR_BYTE_7_0,
+               .memconfig = DMC_MEMCONFIG_CHIP_MAP_SPLIT |
+                       DMC_MEMCONFIGX_CHIP_COL_10 |
+                       DMC_MEMCONFIGX_CHIP_ROW_15 |
+                       DMC_MEMCONFIGX_CHIP_BANK_8,
+               .prechconfig_tp_cnt = 0xff,
+               .dpwrdn_cyc = 0xff,
+               .dsref_cyc = 0xffff,
+               .concontrol = DMC_CONCONTROL_DFI_INIT_START_DISABLE |
+                       DMC_CONCONTROL_TIMEOUT_LEVEL0 |
+                       DMC_CONCONTROL_RD_FETCH_DISABLE |
+                       DMC_CONCONTROL_EMPTY_DISABLE |
+                       DMC_CONCONTROL_AREF_EN_DISABLE |
+                       DMC_CONCONTROL_IO_PD_CON_DISABLE,
+               .dmc_channels = 1,
+               .chips_per_channel = 1,
+               .chips_to_configure = 1,
+               .send_zq_init = 1,
+               .gate_leveling_enable = 1,
+               .read_leveling_enable = 0,
+       }
+#else
        {
                .mem_manuf = MEM_MANUF_ELPIDA,
                .mem_type = DDR_MODE_DDR3,
@@ -324,6 +467,7 @@ struct mem_timings mem_timings[] = {
                .impedance = IMP_OUTPUT_DRV_40_OHM,
                .gate_leveling_enable = 1,
        }
+#endif
 };
 
 /**
@@ -399,7 +543,7 @@ struct mem_timings *clock_get_mem_timings(void)
        return NULL;
 }
 
-void system_clock_init()
+static void exynos5250_system_clock_init(void)
 {
        struct exynos5_clock *clk =
                (struct exynos5_clock *)samsung_get_base_clock();
@@ -436,19 +580,13 @@ void system_clock_init()
        } while ((val | MUX_BPLL_SEL_MASK) != val);
 
        /* PLL locktime */
-       writel(APLL_LOCK_VAL, &clk->apll_lock);
-
-       writel(MPLL_LOCK_VAL, &clk->mpll_lock);
-
-       writel(BPLL_LOCK_VAL, &clk->bpll_lock);
-
-       writel(CPLL_LOCK_VAL, &clk->cpll_lock);
-
-       writel(GPLL_LOCK_VAL, &clk->gpll_lock);
-
-       writel(EPLL_LOCK_VAL, &clk->epll_lock);
-
-       writel(VPLL_LOCK_VAL, &clk->vpll_lock);
+       writel(mem->apll_pdiv * PLL_LOCK_FACTOR, &clk->apll_lock);
+       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
+       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
+       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
+       writel(mem->gpll_pdiv * PLL_X_LOCK_FACTOR, &clk->gpll_lock);
+       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
+       writel(mem->vpll_pdiv * PLL_X_LOCK_FACTOR, &clk->vpll_lock);
 
        writel(CLK_REG_DISABLE, &clk->pll_div2_sel);
 
@@ -640,6 +778,192 @@ void system_clock_init()
        writel(val, &clk->div_fsys2);
 }
 
+static void exynos5420_system_clock_init(void)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)EXYNOS5_CLOCK_BASE;
+       struct mem_timings *mem;
+       struct arm_clk_ratios *arm_clk_ratio;
+       u32 val;
+
+       mem = clock_get_mem_timings();
+       arm_clk_ratio = get_arm_ratios();
+
+       /* PLL locktime */
+       writel(arm_clk_ratio->apll_pdiv * PLL_LOCK_FACTOR,
 &clk->apll_lock);
+       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
+       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
+       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
+       writel(mem->dpll_pdiv * PLL_LOCK_FACTOR, &clk->dpll_lock);
+       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
+       writel(mem->vpll_pdiv * PLL_LOCK_FACTOR, &clk->vpll_lock);
+       writel(mem->ipll_pdiv * PLL_LOCK_FACTOR, &clk->ipll_lock);
+       writel(mem->spll_pdiv * PLL_LOCK_FACTOR, &clk->spll_lock);
+       writel(mem->kpll_pdiv * PLL_LOCK_FACTOR, &clk->kpll_lock);
+
+       setbits_le32(&clk->src_cpu, MUX_HPM_SEL_MASK);
+
+       writel(0, &clk->src_top6);
+
+       writel(0, &clk->src_cdrex);
+       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
+       writel(HPM_RATIO,  &clk->div_cpu1);
+       writel(CLK_DIV_CPU0_VAL,  &clk->div_cpu0);
+
+       /* switch A15 clock source to OSC clock before changing APLL */
+       clrbits_le32(&clk->src_cpu, APLL_FOUT);
+
+       /* Set APLL */
+       writel(APLL_CON1_VAL, &clk->apll_con1);
+       val = set_pll(arm_clk_ratio->apll_mdiv,
+                     arm_clk_ratio->apll_pdiv,
+                     arm_clk_ratio->apll_sdiv);
+       writel(val, &clk->apll_con0);
+       while ((readl(&clk->apll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* now it is safe to switch to APLL */
+       setbits_le32(&clk->src_cpu, APLL_FOUT);
+
+       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
+       writel(CLK_DIV_KFC_VAL, &clk->div_kfc0);
+
+       /* switch A7 clock source to OSC clock before changing KPLL */
+       clrbits_le32(&clk->src_kfc, KPLL_FOUT);
+
+       /* Set KPLL*/
+       writel(KPLL_CON1_VAL, &clk->kpll_con1);
+       val = set_pll(mem->kpll_mdiv, mem->kpll_pdiv, mem->kpll_sdiv);
+       writel(val, &clk->kpll_con0);
+       while ((readl(&clk->kpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* now it is safe to switch to KPLL */
+       setbits_le32(&clk->src_kfc, KPLL_FOUT);
+
+       /* Set MPLL */
+       writel(MPLL_CON1_VAL, &clk->mpll_con1);
+       val = set_pll(mem->mpll_mdiv, mem->mpll_pdiv, mem->mpll_sdiv);
+       writel(val, &clk->mpll_con0);
+       while ((readl(&clk->mpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set DPLL */
+       writel(DPLL_CON1_VAL, &clk->dpll_con1);
+       val = set_pll(mem->dpll_mdiv, mem->dpll_pdiv, mem->dpll_sdiv);
+       writel(val, &clk->dpll_con0);
+       while ((readl(&clk->dpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set EPLL */
+       writel(EPLL_CON2_VAL, &clk->epll_con2);
+       writel(EPLL_CON1_VAL, &clk->epll_con1);
+       val = set_pll(mem->epll_mdiv, mem->epll_pdiv, mem->epll_sdiv);
+       writel(val, &clk->epll_con0);
+       while ((readl(&clk->epll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set CPLL */
+       writel(CPLL_CON1_VAL, &clk->cpll_con1);
+       val = set_pll(mem->cpll_mdiv, mem->cpll_pdiv, mem->cpll_sdiv);
+       writel(val, &clk->cpll_con0);
+       while ((readl(&clk->cpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set IPLL */
+       writel(IPLL_CON1_VAL, &clk->ipll_con1);
+       val = set_pll(mem->ipll_mdiv, mem->ipll_pdiv, mem->ipll_sdiv);
+       writel(val, &clk->ipll_con0);
+       while ((readl(&clk->ipll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set VPLL */
+       writel(VPLL_CON1_VAL, &clk->vpll_con1);
+       val = set_pll(mem->vpll_mdiv, mem->vpll_pdiv, mem->vpll_sdiv);
+       writel(val, &clk->vpll_con0);
+       while ((readl(&clk->vpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set BPLL */
+       writel(BPLL_CON1_VAL, &clk->bpll_con1);
+       val = set_pll(mem->bpll_mdiv, mem->bpll_pdiv, mem->bpll_sdiv);
+       writel(val, &clk->bpll_con0);
+       while ((readl(&clk->bpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set SPLL */
+       writel(SPLL_CON1_VAL, &clk->spll_con1);
+       val = set_pll(mem->spll_mdiv, mem->spll_pdiv, mem->spll_sdiv);
+       writel(val, &clk->spll_con0);
+       while ((readl(&clk->spll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       writel(CLK_DIV_CDREX0_VAL, &clk->div_cdrex0);
+       writel(CLK_DIV_CDREX1_VAL, &clk->div_cdrex1);
+
+       writel(CLK_SRC_TOP0_VAL, &clk->src_top0);
+       writel(CLK_SRC_TOP1_VAL, &clk->src_top1);
+       writel(CLK_SRC_TOP2_VAL, &clk->src_top2);
+       writel(CLK_SRC_TOP7_VAL, &clk->src_top7);
+
+       writel(CLK_DIV_TOP0_VAL, &clk->div_top0);
+       writel(CLK_DIV_TOP1_VAL, &clk->div_top1);
+       writel(CLK_DIV_TOP2_VAL, &clk->div_top2);
+
+       writel(0, &clk->src_top10);
+       writel(0, &clk->src_top11);
+       writel(0, &clk->src_top12);
+
+       writel(CLK_SRC_TOP3_VAL, &clk->src_top3);
+       writel(CLK_SRC_TOP4_VAL, &clk->src_top4);
+       writel(CLK_SRC_TOP5_VAL, &clk->src_top5);
+
+       /* DISP1 BLK CLK SELECTION */
+       writel(CLK_SRC_DISP1_0_VAL, &clk->src_disp10);
+       writel(CLK_DIV_DISP1_0_VAL, &clk->div_disp10);
+
+       /* AUDIO BLK */
+       writel(AUDIO0_SEL_EPLL, &clk->src_mau);
+       writel(DIV_MAU_VAL, &clk->div_mau);
+
+       /* FSYS */
+       writel(CLK_SRC_FSYS0_VAL, &clk->src_fsys);
+       writel(CLK_DIV_FSYS0_VAL, &clk->div_fsys0);
+       writel(CLK_DIV_FSYS1_VAL, &clk->div_fsys1);
+       writel(CLK_DIV_FSYS2_VAL, &clk->div_fsys2);
+
+       writel(CLK_SRC_ISP_VAL, &clk->src_isp);
+       writel(CLK_DIV_ISP0_VAL, &clk->div_isp0);
+       writel(CLK_DIV_ISP1_VAL, &clk->div_isp1);
+
+       writel(CLK_SRC_PERIC0_VAL, &clk->src_peric0);
+       writel(CLK_SRC_PERIC1_VAL, &clk->src_peric1);
+
+       writel(CLK_DIV_PERIC0_VAL, &clk->div_peric0);
+       writel(CLK_DIV_PERIC1_VAL, &clk->div_peric1);
+       writel(CLK_DIV_PERIC2_VAL, &clk->div_peric2);
+       writel(CLK_DIV_PERIC3_VAL, &clk->div_peric3);
+       writel(CLK_DIV_PERIC4_VAL, &clk->div_peric4);
+
+       writel(CLK_DIV_CPERI1_VAL, &clk->div_cperi1);
+
+       writel(CLK_DIV2_RATIO, &clk->clkdiv2_ratio);
+       writel(CLK_DIV4_RATIO, &clk->clkdiv4_ratio);
+       writel(CLK_DIV_G2D, &clk->div_g2d);
+
+       writel(CLK_SRC_TOP6_VAL, &clk->src_top6);
+       writel(CLK_SRC_CDREX_VAL, &clk->src_cdrex);
+       writel(CLK_SRC_KFC_VAL, &clk->src_kfc);
+}
+
+void system_clock_init(void)
+{
+       if (proid_is_exynos5420())
+               exynos5420_system_clock_init();
+       else
+               exynos5250_system_clock_init();
+}
+
 void clock_init_dp_clock(void)
 {

struct exynos5_clock *clk =

arch/arm/cpu/armv7/exynos/exynos5_setup.h +6 -31
index 696b386..8e05a00 100644
@@ -12,42 +12,16 @@
 #include <config.h>
 #include <asm/arch/dmc.h>
 
-/* APLL_CON1   */
-#define APLL_CON1_VAL  (0x00203800)
-
-/* MPLL_CON1   */
-#define MPLL_CON1_VAL   (0x00203800)
-
-/* CPLL_CON1   */
-#define CPLL_CON1_VAL  (0x00203800)
-
-/* GPLL_CON1   */
-#define GPLL_CON1_VAL  (0x00203800)
-
-/* EPLL_CON1, CON2     */
-#define EPLL_CON1_VAL  0x00000000
-#define EPLL_CON2_VAL  0x00000080
-
-/* VPLL_CON1, CON2     */
-#define VPLL_CON1_VAL  0x00000000
-#define VPLL_CON2_VAL  0x00000080
+#define NOT_AVAILABLE          0
+#define DATA_MASK              0xFFFFF
 
-/* BPLL_CON1   */
-#define BPLL_CON1_VAL  0x00203800
+#define ENABLE_BIT             0x1
+#define DISABLE_BIT            0x0
+#define CA_SWAP_EN             (1 << 0)
 
 /* Set PLL */
 #define set_pll(mdiv, pdiv, sdiv)      (1<<31 | mdiv<<16 | pdiv<<8 | sdiv)
 
-/* CLK_SRC_CPU */
-/* 0 = MOUTAPLL,  1 = SCLKMPLL */
-#define MUX_HPM_SEL             0
-#define MUX_CPU_SEL             0
-#define MUX_APLL_SEL            1
-
-#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
-                               | (MUX_CPU_SEL << 16)  \
-                               | (MUX_APLL_SEL))
-
 /* MEMCONTROL register bit fields */
 #define DMC_MEMCONTROL_CLK_STOP_DISABLE        (0 << 0)
 #define DMC_MEMCONTROL_DPWRDN_DISABLE  (0 << 1)
@@ -78,6 +52,7 @@
 
 /* MEMCONFIG0 register bit fields */
 #define DMC_MEMCONFIGX_CHIP_MAP_INTERLEAVED     (1 << 12)
+#define DMC_MEMCONFIG_CHIP_MAP_SPLIT           (2 << 12)
 #define DMC_MEMCONFIGX_CHIP_COL_10              (3 << 8)
 #define DMC_MEMCONFIGX_CHIP_ROW_14              (2 << 4)
 #define DMC_MEMCONFIGX_CHIP_ROW_15              (3 << 4)

arch/arm/cpu/armv7/exynos/exynos5_setup.h line 74

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +6 -0
@@ -90,6 +65,16 @@
        DMC_MEMBASECONFIGX_CHIP_MASK(0x780)     \
 )
 
+/* As we use channel interleaving, therefore value of the base address
+ * register must be set as half of the bus base address
+ * RAM start addess is 0x2000_0000 which means chip_base is 0x20, so
+ * we need to set half 0x10 to the membaseconfigx registers
+ * see exynos5420 UM section 17.17.3.21 for more
+ */
 

please fix this multiline comment.

Quoted 138 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +101 -13
+#define DMC_CHIP_BASE_0 0x10
+#define DMC_CHIP_BASE_1 0x50
+#define DMC_CHIP_MASK  0x7C0
+
 #define DMC_MEMBASECONFIG0_VAL  DMC_MEMBASECONFIG_VAL(0x40)
 #define DMC_MEMBASECONFIG1_VAL  DMC_MEMBASECONFIG_VAL(0x80)
@@ -113,29 +98,24 @@
 
 /* COJCONTROL register bit fields */
 #define DMC_CONCONTROL_IO_PD_CON_DISABLE       (0 << 3)
+#define DMC_CONCONTROL_IO_PD_CON_ENABLE                (1 << 3)
 #define DMC_CONCONTROL_AREF_EN_DISABLE         (0 << 5)
+#define DMC_CONCONTROL_AREF_EN_ENABLE          (1 << 5)
 #define DMC_CONCONTROL_EMPTY_DISABLE           (0 << 8)
 #define DMC_CONCONTROL_EMPTY_ENABLE            (1 << 8)
 #define DMC_CONCONTROL_RD_FETCH_DISABLE                (0x0 << 12)
 #define DMC_CONCONTROL_TIMEOUT_LEVEL0          (0xFFF << 16)
 #define DMC_CONCONTROL_DFI_INIT_START_DISABLE  (0 << 28)
 
-/* CLK_DIV_CPU0_VAL */
-#define CLK_DIV_CPU0_VAL       ((ARM2_RATIO << 28)             \
-                               | (APLL_RATIO << 24)            \
-                               | (PCLK_DBG_RATIO << 20)        \
-                               | (ATB_RATIO << 16)             \
-                               | (PERIPH_RATIO << 12)          \
-                               | (ACP_RATIO << 8)              \
-                               | (CPUD_RATIO << 4)             \
-                               | (ARM_RATIO))
+#define DMC_CONCONTROL_VAL     0x1FFF2101
 
+#define DREX_CONCONTROL_VAL    DMC_CONCONTROL_VAL                      \
+                               | DMC_CONCONTROL_AREF_EN_ENABLE         \
+                               | DMC_CONCONTROL_IO_PD_CON_ENABLE
 
-/* CLK_FSYS */
-#define CLK_SRC_FSYS0_VAL              0x66666
-#define CLK_DIV_FSYS0_VAL             0x0BB00000
+#define DMC_CONCONTROL_IO_PD_CON(x)            (x << 6)
 
-/* CLK_DIV_CPU1        */
+/* CLK_DIV_CPU1 */
 #define HPM_RATIO               0x2
 #define COPY_RATIO              0x0
 
@@ -164,10 +144,370 @@
 /* CLK_DIV_SYSLFT */
 #define CLK_DIV_SYSLFT_VAL      0x00000311
 
+#define MUX_APLL_SEL_MASK      (1 << 0)
+#define MUX_MPLL_SEL_MASK      (1 << 8)
+#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
+#define MUX_CPLL_SEL_MASK      (1 << 8)
+#define MUX_EPLL_SEL_MASK      (1 << 12)
+#define MUX_VPLL_SEL_MASK      (1 << 16)
+#define MUX_GPLL_SEL_MASK      (1 << 28)
+#define MUX_BPLL_SEL_MASK      (1 << 0)
+#define MUX_HPM_SEL_MASK       (1 << 20)
+#define HPM_SEL_SCLK_MPLL      (1 << 21)
+#define PLL_LOCKED             (1 << 29)
+#define APLL_CON0_LOCKED       (1 << 29)
+#define MPLL_CON0_LOCKED       (1 << 29)
+#define BPLL_CON0_LOCKED       (1 << 29)
+#define CPLL_CON0_LOCKED       (1 << 29)
+#define EPLL_CON0_LOCKED       (1 << 29)
+#define GPLL_CON0_LOCKED       (1 << 29)
+#define VPLL_CON0_LOCKED       (1 << 29)
+#define CLK_REG_DISABLE                0x0
+#define TOP2_VAL               0x0110000
+
+/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
+#define SPI0_ISP_SEL           6
+#define SPI1_ISP_SEL           6
+#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
+                               | (SPI0_ISP_SEL << 0)
+
+/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
+#define SPI0_ISP_RATIO         0xf
+#define SPI1_ISP_RATIO         0xf
+#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
+                               | (SPI0_ISP_RATIO << 0)
+
+/* CLK_DIV_FSYS2 */
+#define MMC2_RATIO_MASK                0xf
+#define MMC2_RATIO_VAL         0x3
+#define MMC2_RATIO_OFFSET      0
+
+#define MMC2_PRE_RATIO_MASK    0xff
+#define MMC2_PRE_RATIO_VAL     0x9
+#define MMC2_PRE_RATIO_OFFSET  8
+
+#define MMC3_RATIO_MASK                0xf
+#define MMC3_RATIO_VAL         0x1
+#define MMC3_RATIO_OFFSET      16
+
+#define MMC3_PRE_RATIO_MASK    0xff
+#define MMC3_PRE_RATIO_VAL     0x0
+#define MMC3_PRE_RATIO_OFFSET  24
+
+/* CLK_SRC_LEX */
+#define CLK_SRC_LEX_VAL         0x0
+
+/* CLK_DIV_LEX */
+#define CLK_DIV_LEX_VAL         0x10
+
+/* CLK_DIV_R0X */
+#define CLK_DIV_R0X_VAL         0x10
+
+/* CLK_DIV_L0X */
+#define CLK_DIV_R1X_VAL         0x10
+
+/* CLK_DIV_ISP2 */
+#define CLK_DIV_ISP2_VAL        0x1
+
+/* CLK_SRC_KFC */
+#define SRC_KFC_HPM_SEL                (1 << 15)
+
+/* CLK_SRC_KFC */
+#define CLK_SRC_KFC_VAL                0x00008001
+
+/* CLK_DIV_KFC */
+#define CLK_DIV_KFC_VAL                0x03300110
+
+/* CLK_DIV2_RATIO */
+#define CLK_DIV2_RATIO         0x10111150
+
+/* CLK_DIV4_RATIO */
+#define CLK_DIV4_RATIO         0x00000003
+
+/* CLK_DIV_G2D */
+#define CLK_DIV_G2D            0x00000010
+
+/*
+ * DIV_DISP1_0
+ * For DP, divisor should be 2
+ */
+#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
+

arch/arm/cpu/armv7/exynos/exynos5_setup.h line 245

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+/* CLK_GATE_IP_DISP1 */
+#define CLK_GATE_DP1_ALLOW     (1 << 4)
+
+/* AUDIO CLK SEL */
+#define AUDIO0_SEL_EPLL                (0x6 << 28)
+#define AUDIO0_RATIO           0x5
+#define PCM0_RATIO             0x3
+#define DIV_MAU_VAL            (PCM0_RATIO << 24 | AUDIO0_RATIO << 20)
+
 

please remove blank line.

Quoted 25 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +25 -0
+
+/* CLK_SRC_CDREX */
+#define MUX_MCLK_CDR_MSPLL     (1 << 4)
+#define MUX_BPLL_SEL_FOUTBPLL   (1 << 0)
+#define BPLL_SEL_MASK   0x7
+#define FOUTBPLL        2
+
+#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
+#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
+
+#define PHY_CON0_RESET_VAL     0x17020a40
+#define P0_CMD_EN              (1 << 14)
+#define BYTE_RDLVL_EN          (1 << 13)
+#define CTRL_SHGATE            (1 << 8)
+
+#define PHY_CON1_RESET_VAL     0x09210100
+#define RDLVL_PASS_ADJ_VAL     0x6
+#define RDLVL_PASS_ADJ_OFFSET  16
+#define CTRL_GATEDURADJ_MASK   (0xf << 20)
+#define READ_LEVELLING_DDR3    0x0100
+
+#define PHY_CON2_RESET_VAL     0x00010004
+#define INIT_DESKEW_EN         (1 << 6)
+#define DLL_DESKEW_EN          (1 << 12)
+#define RDLVL_GATE_EN          (1 << 24)

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+#define RDLVL_EN               (1 << 25)
+#define RDLVL_INCR_ADJ         (0x1 << 16)
+
+/* DREX_PAUSE */
+#define DREX_PAUSE_EN  (1 << 0)
+
+#define BYPASS_EN      (1 << 22)
+
+/********-----MEMMORY VAL----------***/
 

/* MEMORY VAL */

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+#define PHY_CON0_VAL   0x17021A00
+
+#define PHY_CON12_RESET_VAL    0x10100070
+#define PHY_CON12_VAL          0x10107F50
+#define CTRL_START             (1 << 6)
+#define CTRL_DLL_ON            (1 << 5)
+#define CTRL_FORCE_MASK                (0x7F << 8)
+#define CTRL_LOCK_COARSE_MASK  (0x7F << 10)
+
 

please remove blank line.

Quoted 20 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +20 -0
+
+#define CTRL_OFFSETD_RESET_VAL 0x8
+#define CTRL_OFFSETD_VAL       0x7F
+
+#define CTRL_OFFSETR0          0x7F
+#define CTRL_OFFSETR1          0x7F
+#define CTRL_OFFSETR2          0x7F
+#define CTRL_OFFSETR3          0x7F
+#define PHY_CON4_VAL   (CTRL_OFFSETR0 << 0 | \
+                               CTRL_OFFSETR1 << 8 | \
+                               CTRL_OFFSETR2 << 16 | \
+                               CTRL_OFFSETR3 << 24)
+#define PHY_CON4_RESET_VAL     0x08080808
+
+#define CTRL_OFFSETW0          0x7F
+#define CTRL_OFFSETW1          0x7F
+#define CTRL_OFFSETW2          0x7F
+#define CTRL_OFFSETW3          0x7F
+#define PHY_CON6_VAL   (CTRL_OFFSETW0 << 0 | \
+                               CTRL_OFFSETW1 << 8 | \

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+                               CTRL_OFFSETW2 << 16 | \
+                               CTRL_OFFSETW3 << 24)
+#define PHY_CON6_RESET_VAL     0x08080808
+
+#define PHY_CON14_RESET_VAL    0x001F0000
+#define CTRL_PULLD_DQS         0xF
+#define CTRL_PULLD_DQS_OFFSET  0
+
+/*ZQ Configurations */
 

please add space before ZQ.

Quoted 27 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +27 -0
+#define PHY_CON16_RESET_VAL    0x08000304
+
+#define ZQ_CLK_EN              (1 << 27)
+#define ZQ_CLK_DIV_EN          (1 << 18)
+#define ZQ_MANUAL_STR          (1 << 1)
+#define ZQ_DONE                        (1 << 0)
+#define ZQ_MODE_DDS_OFFSET     24
+
+#define CTRL_RDLVL_GATE_ENABLE 1
+#define CTRL_RDLVL_GATE_DISABLE        0
+#define CTRL_RDLVL_DATA_ENABLE 2
+
+/* Direct Command */
+#define DIRECT_CMD_NOP                 0x07000000
+#define DIRECT_CMD_PALL                        0x01000000
+#define DIRECT_CMD_ZQINIT              0x0a000000
+#define DIRECT_CMD_CHANNEL_SHIFT       28
+#define DIRECT_CMD_CHIP_SHIFT          20
+#define DIRECT_CMD_BANK_SHIFT          16
+#define DIRECT_CMD_REFA                (5 << 24)
+#define DIRECT_CMD_MRS1                0x71C00
+#define DIRECT_CMD_MRS2                0x10BFC
+#define DIRECT_CMD_MRS3                0x0050C
+#define DIRECT_CMD_MRS4                0x00868
+#define DIRECT_CMD_MRS5                0x00C04
+
+/* Drive Strength */

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+#define IMPEDANCE_48_OHM       4
+#define IMPEDANCE_40_OHM       5
+#define IMPEDANCE_34_OHM       6
+#define IMPEDANCE_30_OHM       7
+#define PHY_CON39_VAL_48_OHM   0x09240924
+#define PHY_CON39_VAL_40_OHM   0x0B6D0B6D
+#define PHY_CON39_VAL_34_OHM   0x0DB60DB6
+#define PHY_CON39_VAL_30_OHM   0x0FFF0FFF
+
 

please remove blank line.

Quoted 574 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +55 -0
+
+#define CTRL_BSTLEN_OFFSET     8
+#define CTRL_RDLAT_OFFSET      0
+
+#define CMD_DEFAULT_LPDDR3     0xF
+#define CMD_DEFUALT_OFFSET     0
+#define T_WRDATA_EN            0x7
+#define T_WRDATA_EN_DDR3       0x8
+#define T_WRDATA_EN_OFFSET     16
+#define T_WRDATA_EN_MASK       0x1f
+
+#define PHY_CON31_VAL  0x0C183060
+#define PHY_CON32_VAL  0x60C18306
+#define PHY_CON33_VAL  0x00000030
+
+#define PHY_CON31_RESET_VAL    0x0
+#define PHY_CON32_RESET_VAL    0x0
+#define PHY_CON33_RESET_VAL    0x0
+
+#define SL_DLL_DYN_CON_EN      (1 << 1)
+#define FP_RESYNC      (1 << 3)
+#define CTRL_START     (1 << 6)
+
+#define DMC_AREF_EN            (1 << 5)
+#define DMC_CONCONTROL_EMPTY   (1 << 8)
+#define DFI_INIT_START         (1 << 28)
+
+#define DMC_MEMCONTROL_VAL     0x00312700
+#define CLK_STOP_EN            (1 << 0)
+#define DPWRDN_EN              (1 << 1)
+#define DSREF_EN               (1 << 5)
+
+#define MEMBASECONFIG_CHIP_MASK_VAL    0x7E0
+#define MEMBASECONFIG_CHIP_MASK_OFFSET 0
+#define MEMBASECONFIG0_CHIP_BASE_VAL   0x20
+#define MEMBASECONFIG1_CHIP_BASE_VAL   0x40
+#define CHIP_BASE_OFFSET               16
+
+#define MEMCONFIG_VAL  0x1323
+#define PRECHCONFIG_DEFAULT_VAL        0xFF000000
+#define PWRDNCONFIG_DEFAULT_VAL        0xFFFF00FF
+
+#define TIMINGAREF_VAL 0x5d
+#define TIMINGROW_VAL  0x345A8692
+#define TIMINGDATA_VAL 0x3630065C
+#define TIMINGPOWER_VAL        0x50380336
+#define DFI_INIT_COMPLETE      (1 << 3)
+
+#define BRBRSVCONTROL_VAL      0x00000033
+#define BRBRSVCONFIG_VAL       0x88778877
+
+/* Clock Gating Control (CGCONTROL) register */
+#define MEMIF_CG_EN    (1 << 3) /* Memory interface clock gating */
+#define SCG_CG_EN      (1 << 2) /* Scheduler clock gating */
+#define BUSIF_WR_CG_EN (1 << 1) /* Bus interface write channel clock

gating */
+#define BUSIF_RD_CG_EN (1 << 0) /* Bus interface read channel clock gating */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +8 -0
+#define DMC_INTERNAL_CG        (MEMIF_CG_EN | SCG_CG_EN | \
+                                BUSIF_WR_CG_EN | BUSIF_RD_CG_EN)
+
+/* DMC PHY Control0 register */
+#define PHY_CONTROL0_RESET_VAL 0x0
+#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
+#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
+#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating

signal */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +139 -110
+#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
+
+/* Driver strength for CK, CKE, CS & CA */
+#define IMP_OUTPUT_DRV_40_OHM  0x5
+#define IMP_OUTPUT_DRV_30_OHM  0x7
+#define DA_3_DS_OFFSET         25
+#define DA_2_DS_OFFSET         22
+#define DA_1_DS_OFFSET         19
+#define DA_0_DS_OFFSET         16
+#define CA_CK_DRVR_DS_OFFSET   9
+#define CA_CKE_DRVR_DS_OFFSET  6
+#define CA_CS_DRVR_DS_OFFSET   3
+#define CA_ADR_DRVR_DS_OFFSET  0
+
+#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
+#define PHY_CON42_CTRL_RDLAT_SHIFT     0
+
+/*
+ * Definitions that differ with SoC's.
+ * Below is the part defining macros for smdk5250.
+ * Else part introduces macros for smdk5420.
+ */
+#ifndef CONFIG_SMDK5420
+
+/* APLL_CON1 */
+#define APLL_CON1_VAL  (0x00203800)
+
+/* MPLL_CON1 */
+#define MPLL_CON1_VAL   (0x00203800)
+
+/* CPLL_CON1 */
+#define CPLL_CON1_VAL  (0x00203800)
+
+/* DPLL_CON1 */
+#define DPLL_CON1_VAL  (NOT_AVAILABLE)
+
+/* GPLL_CON1 */
+#define GPLL_CON1_VAL  (0x00203800)
+
+/* EPLL_CON1, CON2 */
+#define EPLL_CON1_VAL  0x00000000
+#define EPLL_CON2_VAL  0x00000080
+
+/* VPLL_CON1, CON2 */
+#define VPLL_CON1_VAL  0x00000000
+#define VPLL_CON2_VAL  0x00000080
+
+/* RPLL_CON1, CON2 */
+#define RPLL_CON1_VAL  NOT_AVAILABLE
+#define RPLL_CON2_VAL  NOT_AVAILABLE
+
+/* BPLL_CON1 */
+#define BPLL_CON1_VAL  0x00203800
+
+/* SPLL_CON1 */
+#define SPLL_CON1_VAL  NOT_AVAILABLE
+
+/* IPLL_CON1 */
+#define IPLL_CON1_VAL  NOT_AVAILABLE
+
+/* KPLL_CON1 */
+#define KPLL_CON1_VAL  NOT_AVAILABLE
+
+/* CLK_SRC_ISP */
+#define CLK_SRC_ISP_VAL                NOT_AVAILABLE
+#define CLK_DIV_ISP0_VAL       0x31
+#define CLK_DIV_ISP1_VAL       0x0
+
+/* CLK_FSYS */
+#define CLK_SRC_FSYS0_VAL              0x66666
+#define CLK_DIV_FSYS0_VAL             0x0BB00000
+#define CLK_DIV_FSYS1_VAL             NOT_AVAILABLE
+#define CLK_DIV_FSYS2_VAL             NOT_AVAILABLE
+
+/* CLK_SRC_CPU */
+/* 0 = MOUTAPLL,  1 = SCLKMPLL */
+#define MUX_HPM_SEL             0
+#define MUX_CPU_SEL             0
+#define MUX_APLL_SEL            1
+
+#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
+                               | (MUX_CPU_SEL << 16)  \
+                               | (MUX_APLL_SEL))
+
 /* CLK_SRC_CDREX */
 #define CLK_SRC_CDREX_VAL       0x1
 
 /* CLK_DIV_CDREX */
+#define CLK_DIV_CDREX0_VAL     NOT_AVAILABLE
+#define CLK_DIV_CDREX1_VAL     NOT_AVAILABLE
+
+/* CLK_DIV_CPU0_VAL */
+#define CLK_DIV_CPU0_VAL       NOT_AVAILABLE
+
 #define MCLK_CDREX2_RATIO       0x0
 #define ACLK_EFCON_RATIO        0x1
 #define MCLK_DPHY_RATIO                0x1
@@ -247,6 +587,11 @@
                                | (MUX_ACLK_300_DISP1_SUB_SEL << 6)     \
                                | (MUX_ACLK_200_DISP1_SUB_SEL << 4))
 
+#define CLK_SRC_TOP4_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP5_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP6_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP7_VAL       NOT_AVAILABLE
+
 /* CLK_DIV_TOP0        */
 #define ACLK_300_DISP1_RATIO   0x2
 #define ACLK_400_G3D_RATIO     0x0
@@ -279,40 +624,11 @@
                                | (ACLK_400_IOP_RATIO << 16)            \
                                | (ACLK_300_GSCL_RATIO << 12))
 
-/* APLL_LOCK   */
-#define APLL_LOCK_VAL  (0x546)
-/* MPLL_LOCK   */
-#define MPLL_LOCK_VAL  (0x546)
-/* CPLL_LOCK   */
-#define CPLL_LOCK_VAL  (0x546)
-/* GPLL_LOCK   */
-#define GPLL_LOCK_VAL  (0x546)
-/* EPLL_LOCK   */
-#define EPLL_LOCK_VAL  (0x3A98)
-/* VPLL_LOCK   */
-#define VPLL_LOCK_VAL  (0x3A98)
-/* BPLL_LOCK   */
-#define BPLL_LOCK_VAL  (0x546)
+#define CLK_DIV_TOP2_VAL       NOT_AVAILABLE
 
-#define MUX_APLL_SEL_MASK      (1 << 0)
-#define MUX_MPLL_SEL_MASK      (1 << 8)
-#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
-#define MUX_CPLL_SEL_MASK      (1 << 8)
-#define MUX_EPLL_SEL_MASK      (1 << 12)
-#define MUX_VPLL_SEL_MASK      (1 << 16)
-#define MUX_GPLL_SEL_MASK      (1 << 28)
-#define MUX_BPLL_SEL_MASK      (1 << 0)
-#define MUX_HPM_SEL_MASK       (1 << 20)
-#define HPM_SEL_SCLK_MPLL      (1 << 21)
-#define APLL_CON0_LOCKED       (1 << 29)
-#define MPLL_CON0_LOCKED       (1 << 29)
-#define BPLL_CON0_LOCKED       (1 << 29)
-#define CPLL_CON0_LOCKED       (1 << 29)
-#define EPLL_CON0_LOCKED       (1 << 29)
-#define GPLL_CON0_LOCKED       (1 << 29)
-#define VPLL_CON0_LOCKED       (1 << 29)
-#define CLK_REG_DISABLE                0x0
-#define TOP2_VAL               0x0110000
+/* PLL Lock Value Factor */
+#define PLL_LOCK_FACTOR                250
+#define PLL_X_LOCK_FACTOR      3000
 
 /* CLK_SRC_PERIC0 */
 #define PWM_SEL                6
@@ -336,18 +652,6 @@
                                | (SPI1_SEL << 20) \
                                | (SPI0_SEL << 16))
 
-/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
-#define SPI0_ISP_SEL           6
-#define SPI1_ISP_SEL           6
-#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
-                               | (SPI0_ISP_SEL << 0)
-
-/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
-#define SPI0_ISP_RATIO         0xf
-#define SPI1_ISP_RATIO         0xf
-#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
-                               | (SPI0_ISP_RATIO << 0)
-
 /* CLK_DIV_PERIL0      */
 #define UART5_RATIO    7
 #define UART4_RATIO    7
@@ -380,105 +684,200 @@
 #define PWM_RATIO              8
 #define CLK_DIV_PERIC3_VAL     (PWM_RATIO << 0)
 
-/* CLK_DIV_FSYS2 */
-#define MMC2_RATIO_MASK                0xf
-#define MMC2_RATIO_VAL         0x3
-#define MMC2_RATIO_OFFSET      0
 
-#define MMC2_PRE_RATIO_MASK    0xff
-#define MMC2_PRE_RATIO_VAL     0x9
-#define MMC2_PRE_RATIO_OFFSET  8
+/* CLK_DIV_PERIC4 */
+#define CLK_DIV_PERIC4_VAL     NOT_AVAILABLE
 
-#define MMC3_RATIO_MASK                0xf
-#define MMC3_RATIO_VAL         0x1
-#define MMC3_RATIO_OFFSET      16
+/* CLK_SRC_DISP1_0 */
+#define CLK_SRC_DISP1_0_VAL    0x6
+#define CLK_DIV_DISP1_0_VAL    NOT_AVAILABLE
 
-#define MMC3_PRE_RATIO_MASK    0xff
-#define MMC3_PRE_RATIO_VAL     0x0
-#define MMC3_PRE_RATIO_OFFSET  24
+#define APLL_FOUT              (1 << 0)
+#define KPLL_FOUT              NOT_AVAILABLE
 
-/* CLK_SRC_LEX */
-#define CLK_SRC_LEX_VAL         0x0
+#define CLK_DIV_CPERI1_VAL     NOT_AVAILABLE
 
-/* CLK_DIV_LEX */
-#define CLK_DIV_LEX_VAL         0x10
+#else
 
-/* CLK_DIV_R0X */
-#define CLK_DIV_R0X_VAL         0x10
+/* APLL_CON1 */
+#define APLL_CON1_VAL  (0x0020F300)
 
-/* CLK_DIV_L0X */
-#define CLK_DIV_R1X_VAL         0x10
+/* MPLL_CON1 */
+#define MPLL_CON1_VAL   (0x0020F300)
 
-/* CLK_DIV_ISP0 */
-#define CLK_DIV_ISP0_VAL        0x31
 
-/* CLK_DIV_ISP1 */
-#define CLK_DIV_ISP1_VAL        0x0
+/* CPLL_CON1 */
+#define CPLL_CON1_VAL  0x0020f300
 
-/* CLK_DIV_ISP2 */
-#define CLK_DIV_ISP2_VAL        0x1
+/* DPLL_CON1 */
+#define DPLL_CON1_VAL  (0x0020F300)
 
-/* CLK_SRC_DISP1_0 */
-#define CLK_SRC_DISP1_0_VAL    0x6
+/* GPLL_CON1 */
+#define GPLL_CON1_VAL  (NOT_AVAILABLE)
 
-/*
- * DIV_DISP1_0
- * For DP, divisor should be 2
- */
-#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
 
-/* CLK_GATE_IP_DISP1 */
-#define CLK_GATE_DP1_ALLOW     (1 << 4)
+/* EPLL_CON1, CON2 */
+#define EPLL_CON1_VAL  0x00000000
+#define EPLL_CON2_VAL  0x00000080
 
-#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
-#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
+/* VPLL_CON1, CON2 */
+#define VPLL_CON1_VAL  0x0020f300
+#define VPLL_CON2_VAL  NOT_AVAILABLE
 
-#define PHY_CON0_RESET_VAL     0x17020a40
-#define P0_CMD_EN              (1 << 14)
-#define BYTE_RDLVL_EN          (1 << 13)
-#define CTRL_SHGATE            (1 << 8)
+/* RPLL_CON1, CON2 */
+#define RPLL_CON1_VAL  0x00000000
+#define RPLL_CON2_VAL  0x00000080
 
-#define PHY_CON1_RESET_VAL     0x09210100
-#define CTRL_GATEDURADJ_MASK   (0xf << 20)
+/* BPLL_CON1 */
+#define BPLL_CON1_VAL  0x0020f300
 
-#define PHY_CON2_RESET_VAL     0x00010004
-#define INIT_DESKEW_EN         (1 << 6)
-#define RDLVL_GATE_EN          (1 << 24)
+/* SPLL_CON1 */
+#define SPLL_CON1_VAL  0x0020f300
 
-/*ZQ Configurations */
-#define PHY_CON16_RESET_VAL    0x08000304
+/* IPLL_CON1 */
+#define IPLL_CON1_VAL  0x00000080
 
-#define ZQ_CLK_DIV_EN          (1 << 18)
-#define ZQ_MANUAL_STR          (1 << 1)
-#define ZQ_DONE                        (1 << 0)
+/* KPLL_CON1 */
+#define KPLL_CON1_VAL  0x200000
 
-#define CTRL_RDLVL_GATE_ENABLE 1
-#define CTRL_RDLVL_GATE_DISABLE        1
+/* CLK_SRC_ISP */
+#define CLK_SRC_ISP_VAL                0x33366000
+#define CLK_DIV_ISP0_VAL       0x13131300
+#define CLK_DIV_ISP1_VAL       0xbb110202
 
-/* Direct Command */
-#define DIRECT_CMD_NOP                 0x07000000
-#define DIRECT_CMD_PALL                        0x01000000
-#define DIRECT_CMD_ZQINIT              0x0a000000
-#define DIRECT_CMD_CHANNEL_SHIFT       28
-#define DIRECT_CMD_CHIP_SHIFT          20
 
-/* DMC PHY Control0 register */
-#define PHY_CONTROL0_RESET_VAL 0x0
-#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
-#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
-#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating

signal */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +131 -11
-#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
+/* CLK_FSYS */
+#define CLK_SRC_FSYS0_VAL              0x33033300
+#define CLK_DIV_FSYS0_VAL             0x0
+#define CLK_DIV_FSYS1_VAL             0x04f13c4f
+#define CLK_DIV_FSYS2_VAL             0x041d0000
+
+/* CLK_SRC_CPU */
+/* 0 = MOUTAPLL,  1 = SCLKMPLL */
+#define MUX_HPM_SEL             1
+#define MUX_CPU_SEL             0
+#define MUX_APLL_SEL            1
 
-/* Driver strength for CK, CKE, CS & CA */
-#define IMP_OUTPUT_DRV_40_OHM  0x5
-#define IMP_OUTPUT_DRV_30_OHM  0x7
-#define CA_CK_DRVR_DS_OFFSET   9
-#define CA_CKE_DRVR_DS_OFFSET  6
-#define CA_CS_DRVR_DS_OFFSET   3
-#define CA_ADR_DRVR_DS_OFFSET  0
+#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
+                               | (MUX_CPU_SEL << 16)  \
+                               | (MUX_APLL_SEL))
 
-#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
-#define PHY_CON42_CTRL_RDLAT_SHIFT     0
+/* CLK_SRC_CDREX */
+#define CLK_SRC_CDREX_VAL       0x00000011
+
+/* CLK_DIV_CDREX */
+#define CLK_DIV_CDREX0_VAL     0x30010100
+#define CLK_DIV_CDREX1_VAL     0x300
+
+#define CLK_DIV_CDREX_VAL       0x17010100
+
+/* CLK_DIV_CPU0_VAL */
+#define CLK_DIV_CPU0_VAL       0x01440020
+
+/* CLK_SRC_TOP */
+#define CLK_SRC_TOP0_VAL       0x12221222
+#define CLK_SRC_TOP1_VAL       0x00100200
+#define CLK_SRC_TOP2_VAL       0x11101000
+#define CLK_SRC_TOP3_VAL       0x11111111
+#define CLK_SRC_TOP4_VAL       0x11110111
+#define CLK_SRC_TOP5_VAL       0x11111100
+#define CLK_SRC_TOP6_VAL       0x11110111
+#define CLK_SRC_TOP7_VAL       0x00022200
+
+/* CLK_DIV_TOP */
+#define CLK_DIV_TOP0_VAL       0x23712311
+#define CLK_DIV_TOP1_VAL       0x13100B00
+#define CLK_DIV_TOP2_VAL       0x11101100
+
+/* PLL Lock Value Factor */
+#define PLL_LOCK_FACTOR                200
+#define PLL_X_LOCK_FACTOR      3000
+
+/* CLK_SRC_PERIC0 */
+#define SPDIF_SEL      1
+#define PWM_SEL                3
+#define UART4_SEL      3
+#define UART3_SEL      3
+#define UART2_SEL      3
+#define UART1_SEL      3
+#define UART0_SEL      3
+/* SRC_CLOCK = SCLK_RPLL */
+#define CLK_SRC_PERIC0_VAL     ((SPDIF_SEL << 28)      \
+                               | (PWM_SEL << 24)       \
+                               | (UART4_SEL << 20)     \
+                               | (UART3_SEL << 16)     \
+                               | (UART2_SEL << 12)     \
+                               | (UART1_SEL << 8)      \
+                               | (UART0_SEL << 4))
+
+/* CLK_SRC_PERIC1 */
+/* SRC_CLOCK = SCLK_EPLL */
+#define SPI0_SEL               6
+#define SPI1_SEL               6
+#define SPI2_SEL               6
+#define AUDIO0_SEL             6
+#define AUDIO1_SEL             6
+#define AUDIO2_SEL             6
+#define CLK_SRC_PERIC1_VAL     ((SPI2_SEL << 28)       \
+                               | (SPI1_SEL << 24)      \
+                               | (SPI0_SEL << 20)      \
+                               | (AUDIO2_SEL << 16)    \
+                               | (AUDIO2_SEL << 12)    \
+                               | (AUDIO2_SEL << 8))
+
+/* CLK_DIV_PERIC0 */
+#define PWM_RATIO      8
+#define UART4_RATIO    9
+#define UART3_RATIO    9
+#define UART2_RATIO    9
+#define UART1_RATIO    9
+#define UART0_RATIO    9
+
+#define CLK_DIV_PERIC0_VAL     ((PWM_RATIO << 28)      \
+                               | (UART4_RATIO << 24)   \
+                               | (UART3_RATIO << 20)    \
+                               | (UART2_RATIO << 16)    \
+                               | (UART1_RATIO << 12)    \
+                               | (UART0_RATIO << 8))
+/* CLK_DIV_PERIC1 */
+#define SPI2_RATIO             0x1
+#define SPI1_RATIO             0x1
+#define SPI0_RATIO             0x1
+#define CLK_DIV_PERIC1_VAL     ((SPI2_RATIO << 28)     \
+                               | (SPI1_RATIO << 24)    \
+                               | (SPI0_RATIO << 20))
+
+/* CLK_DIV_PERIC2 */
+#define PCM2_RATIO             0x3
+#define PCM1_RATIO             0x3
+#define CLK_DIV_PERIC2_VAL     ((PCM2_RATIO << 24) \
+                               | (PCM1_RATIO << 16))
+
+/* CLK_DIV_PERIC3 */
+#define AUDIO2_RATIO           0x5
+#define AUDIO1_RATIO           0x5
+#define AUDIO0_RATIO           0x5
+#define CLK_DIV_PERIC3_VAL     ((AUDIO2_RATIO << 28)   \
+                               | (AUDIO1_RATIO << 24)  \
+                               | (AUDIO0_RATIO << 20))
+
+/* CLK_DIV_PERIC4 */
+#define SPI2_PRE_RATIO         0x2
+#define SPI1_PRE_RATIO         0x2
+#define SPI0_PRE_RATIO         0x2
+#define CLK_DIV_PERIC4_VAL     ((SPI2_PRE_RATIO << 24) \
+                               | (SPI1_PRE_RATIO << 16) \
+                               | (SPI0_PRE_RATIO << 8))
+
+/* CLK_SRC_DISP1_0 */
+#define CLK_SRC_DISP1_0_VAL    0x10666600
+#define CLK_DIV_DISP1_0_VAL    0x01050211
+
+#define APLL_FOUT              (1 << 0)
+#define KPLL_FOUT              (1 << 0)
+
+#define CLK_DIV_CPERI1_VAL     0x3f3f0000
+#endif
 
 struct mem_timings;
@@ -490,7 +889,7 @@ enum {
 };
 
 /*
- * Memory variant specific initialization code
+ * Memory variant specific initialization code for DDR3
  *
  * @param mem          Memory timings for this memory type.
  * @param mem_iv_size  Memory interleaving size is a configurable

parameter

arch/arm/cpu/armv7/exynos/exynos5_setup.h +3 -8
@@ -503,6 +902,9 @@ enum {
 int ddr3_mem_ctrl_init(struct mem_timings *mem, unsigned long mem_iv_size,
                        int reset);
 
+/* Memory variant specific initialization code for LPDDR3 */
+void lpddr3_mem_ctrl_init(void);
+
 /*
  * Configure ZQ I/O interface
  *
@@ -532,14 +934,6 @@ void dmc_config_mrs(struct mem_timings *mem, struct
 exynos5_dmc *dmc);
 void dmc_config_prech(struct mem_timings *mem, struct exynos5_dmc *dmc);
 
 /*
- * Configure the memconfig and membaseconfig registers
- *
- * @param mem          Memory timings for this memory type.
- * @param exynos5_dmc  Pointer to struct of DMC registers
- */
-void dmc_config_memory(struct mem_timings *mem, struct exynos5_dmc *dmc);
-
-/*
  * Reset the DLL. This function is common between DDR3 and LPDDR2.
  * However, the reset value is different. So we are passing a flag

* ddr_mode to distinguish between LPDDR2 and DDR3.

arch/arm/include/asm/arch-exynos/clk.h +1 -1
index 1d6fa93..cdeef32 100644
@@ -14,6 +14,7 @@
 #define HPLL   3
 #define VPLL   4
 #define BPLL   5
+#define RPLL   6
 
 enum pll_src_bit {
        EXYNOS_SRC_MPLL = 6,
--

1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
from. prom.
www.promsoft.net
#12 lore raw

PATCH v6 3/10 Exynos5420: Add clock initialization for 5420

Hi Minkyu Kang,

Thank you for comments,

Quoted 41 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 36 lines · Rajeshwari S Shinde

This patch adds code for clock initialization and clock settings of various IP's and controllers, required for Exynos5420

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Corrected the multiline commenting style
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740
+++++++++++++++++++------
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 6 files changed, 1673 insertions(+), 201 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +0 -0
index 36fedd6..b52e61a 100644
@@ -96,7 +96,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
 r, unsigned int k)
 
        freq = CONFIG_SYS_CLK_FREQ;
 
Quoted 15 lines

arch/arm/cpu/armv7/exynos/clock.c static int exynos_get_pll_clk(int pllreg, unsigned int · line 122

Quoted 13 lines
arch/arm/cpu/armv7/exynos/clock.c +1 -1
-       if (pllreg == EPLL) {
+       if (pllreg == EPLL || pllreg == RPLL) {
                k = k & 0xffff;
                /* FOUT = (MDIV + K / 65536) * FIN / (PDIV * 2^SDIV) */
                fout = (m + k / PLL_DIV_65536) * (freq / (p * (1 << s)));
arch/arm/cpu/armv7/exynos/clock.c +1 -1
@@ -117,7 +117,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
 r, unsigned int k)
                        div = PLL_DIV_1024;
                else if (proid_is_exynos4412())
                        div = PLL_DIV_65535;
-               else if (proid_is_exynos5250())
+               else if (cpu_is_exynos5())
 

please don't mix proid_is... and cpu_is...

Since both 5420 and 5250 need same value added cpu_is_exynos5(), instead of doing a or of both.

Quoted 246 lines
Quoted 246 lines
arch/arm/cpu/armv7/exynos/clock.c +0 -0
                        div = PLL_DIV_65536;
                else
                        return 0;
arch/arm/cpu/armv7/exynos/clock.c +105 -0
@@ -362,6 +362,43 @@ unsigned long clock_get_periph_rate(int peripheral)
                return 0;
 }
 
+/* exynos5420: return pll clock frequency */
+static unsigned long exynos5420_get_pll_clk(int pllreg)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long r, k = 0;
+
+       switch (pllreg) {
+       case APLL:
+               r = readl(&clk->apll_con0);
+               break;
+       case MPLL:
+               r = readl(&clk->mpll_con0);
+               break;
+       case EPLL:
+               r = readl(&clk->epll_con0);
+               k = readl(&clk->epll_con1);
+               break;
+       case VPLL:
+               r = readl(&clk->vpll_con0);
+               k = readl(&clk->vpll_con1);
+               break;
+       case BPLL:
+               r = readl(&clk->bpll_con0);
+               break;
+       case RPLL:
+               r = readl(&clk->rpll_con0);
+               k = readl(&clk->rpll_con1);
+               break;
+       default:
+               printf("Unsupported PLL (%d)\n", pllreg);
+               return 0;
+       }
+
+       return exynos_get_pll_clk(pllreg, r, k);
+}
+
 /* exynos4: return ARM clock frequency */
 static unsigned long exynos4_get_arm_clk(void)
 {
@@ -485,6 +522,27 @@ static unsigned long exynos4x12_get_pwm_clk(void)
        return pclk;
 }
 
+/* exynos5420: return pwm clock frequency */
+static unsigned long exynos5420_get_pwm_clk(void)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long pclk, sclk;
+       unsigned int ratio;
+
+       /*
+        * CLK_DIV_PERIC3
+        * PWM_RATIO [3:0]
+        */
+       ratio = readl(&clk->div_peric0);
+       ratio = (ratio >> 28) & 0xf;
+       sclk = get_pll_clk(MPLL);
+
+       pclk = sclk / (ratio + 1);
+
+       return pclk;
+}
+
 /* exynos4: return uart clock frequency */
 static unsigned long exynos4_get_uart_clk(int dev_index)
 {
@@ -624,6 +682,53 @@ static unsigned long exynos5_get_uart_clk(int
 dev_index)
        return uclk;
 }
 
+/* exynos5420: return uart clock frequency */
+static unsigned long exynos5420_get_uart_clk(int dev_index)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long uclk, sclk;
+       unsigned int sel;
+       unsigned int ratio;
+
+       /*
+        * CLK_SRC_PERIC0
+        * UART0_SEL [3:0]
+        * UART1_SEL [7:4]
+        * UART2_SEL [8:11]
+        * UART3_SEL [12:15]
+        * UART4_SEL [16:19]
+        * UART5_SEL [23:20]
+        */
+       sel = readl(&clk->src_peric0);
+       sel = (sel >> ((dev_index * 4) + 4)) & 0x7;
+
+       if (sel == 0x3)
+               sclk = get_pll_clk(MPLL);
+       else if (sel == 0x6)
+               sclk = get_pll_clk(EPLL);
+       else if (sel == 0x7)
+               sclk = get_pll_clk(RPLL);
+       else
+               return 0;
+
+       /*
+        * CLK_DIV_PERIC0
+        * UART0_RATIO [3:0]
+        * UART1_RATIO [7:4]
+        * UART2_RATIO [8:11]
+        * UART3_RATIO [12:15]
+        * UART4_RATIO [16:19]
+        * UART5_RATIO [23:20]
+        */
+       ratio = readl(&clk->div_peric0);
+       ratio = (ratio >> ((dev_index * 4) + 8)) & 0xf;
+
+       uclk = sclk / (ratio + 1);
+
+       return uclk;
+}
+
 static unsigned long exynos4_get_mmc_clk(int dev_index)
 {

struct exynos4_clock *clk =

arch/arm/cpu/armv7/exynos/clock.c +28 -0
@@ -718,6 +823,34 @@ static unsigned long exynos5_get_mmc_clk(int
 dev_index)
        return uclk;
 }
 
+static unsigned long exynos5420_get_mmc_clk(int dev_index)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned long uclk, sclk;
+       unsigned int sel, ratio;
+       int shift = 0;
+
+       sel = readl(&clk->src_fsys);
+       sel = (sel >> ((dev_index * 4) + 8)) & 0x7;
+
+       if (sel == 0x3)
+               sclk = get_pll_clk(MPLL);
+       else if (sel == 0x6)
+               sclk = get_pll_clk(EPLL);
+       else
+               return 0;
+
+       ratio = readl(&clk->div_fsys1);
+
+       shift = dev_index * 10;
+
+       ratio = (ratio >> shift) & 0x3ff;
+       uclk = (sclk / (ratio + 1));
+
+       return uclk;
+}
+
 /* exynos4: set the mmc clock */
 static void exynos4_set_mmc_clk(int dev_index, unsigned int div)

{

arch/arm/cpu/armv7/exynos/clock.c +17 -0
@@ -804,6 +937,23 @@ static void exynos5_set_mmc_clk(int dev_index,
 unsigned int div)
        writel(val, addr);
 }
 
+/* exynos5: set the mmc clock */
+static void exynos5420_set_mmc_clk(int dev_index, unsigned int div)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       unsigned int addr;
+       unsigned int val, shift;
+
+       addr = (unsigned int)&clk->div_fsys1;
+       shift = dev_index * 10;
+
+       val = readl(addr);
+       val &= ~(0x3ff << shift);
+       val |= (div & 0x3ff) << shift;
+       writel(val, addr);
+}
+
 /* get_lcd_clk: return lcd clock frequency */
 static unsigned long exynos4_get_lcd_clk(void)

{

arch/arm/cpu/armv7/exynos/clock.c +48 -0
@@ -1324,6 +1474,84 @@ static int exynos5_set_spi_clk(enum periph_id
 periph_id,
        return 0;
 }
 
+static int exynos5420_set_spi_clk(enum periph_id periph_id,
+                                       unsigned int rate)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)samsung_get_base_clock();
+       int main;
+       unsigned int fine, val;
+       unsigned shift, pre_shift;
+       unsigned div_mask = 0xf, pre_div_mask = 0xff;
+
+       main = clock_calc_best_scalar(4, 8, 400000000, rate, &fine);
+       if (main < 0) {
+               debug("%s: Cannot set clock rate for periph %d",
+                     __func__, periph_id);
+               return -1;
+       }
+       main = main - 1;
+       fine = fine - 1;
+
+       switch (periph_id) {
+       case PERIPH_ID_SPI0:
+               val = readl(&clk->div_peric1);
+               val &= ~(div_mask << 20);
+               val |= (main << 20);
+               writel(val, &clk->div_peric1);
+
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 8);
+               val |= (fine << 8);
+               writel(val, &clk->div_peric4);
+               break;
+       case PERIPH_ID_SPI1:
+               val = readl(&clk->div_peric1);
+               val &= ~(div_mask << 24);
+               val |= (main << 24);
+               writel(val, &clk->div_peric1);
+
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 16);
+               val |= (fine << 16);
+               writel(val, &clk->div_peric4);
+               break;
+       case PERIPH_ID_SPI2:
+               val = readl(&clk->div_peric1);
+               val &= ~(div_mask << 28);
+               val |= (main << 28);
+               writel(val, &clk->div_peric1);
+
Quoted 8 lines

arch/arm/cpu/armv7/exynos/clock.c static int exynos5_set_spi_clk(enum periph_id periph_id,

Quoted 6 lines
arch/arm/cpu/armv7/exynos/clock.c +5 -0
+               val = readl(&clk->div_peric4);
+               val &= ~(pre_div_mask << 24);
+               val |= (fine << 24);
+               writel(val, &clk->div_peric4);
+               break;
 

I think we can use same code for SPI0/1/2.

will correct this.

Quoted 628 lines
Quoted 628 lines
arch/arm/cpu/armv7/exynos/clock.c +25 -0
+       case PERIPH_ID_SPI3:
+               shift = 16;
+               pre_shift = 0;
+               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+                               (main & div_mask) << shift);
+               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+                               (fine & pre_div_mask) << pre_shift);
+               break;
+       case PERIPH_ID_SPI4:
+               shift = 20;
+               pre_shift = 8;
+               clrsetbits_le32(&clk->div_isp1, div_mask << shift,
+                               (main & div_mask) << shift);
+               clrsetbits_le32(&clk->div_isp1, pre_div_mask << pre_shift,
+                               (fine & pre_div_mask) << pre_shift);
+               break;
+       default:
+               debug("%s: Unsupported peripheral ID %d\n", __func__,
+                     periph_id);
+               return -1;
+       }
+
+       return 0;
+}
+
 static unsigned long exynos4_get_i2c_clk(void)

{
struct exynos4_clock *clk =

arch/arm/cpu/armv7/exynos/clock.c +26 -12
@@ -1341,9 +1569,11 @@ static unsigned long exynos4_get_i2c_clk(void)
 
 unsigned long get_pll_clk(int pllreg)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_pll_clk(pllreg);
                return exynos5_get_pll_clk(pllreg);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_pll_clk(pllreg);
                return exynos4_get_pll_clk(pllreg);
@@ -1375,9 +1605,11 @@ unsigned long get_i2c_clk(void)
 
 unsigned long get_pwm_clk(void)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_pwm_clk();
                return clock_get_periph_rate(PERIPH_ID_PWM0);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_pwm_clk();
                return exynos4_get_pwm_clk();
@@ -1386,9 +1618,11 @@ unsigned long get_pwm_clk(void)
 
 unsigned long get_uart_clk(int dev_index)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_uart_clk(dev_index);
                return exynos5_get_uart_clk(dev_index);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        return exynos4x12_get_uart_clk(dev_index);
                return exynos4_get_uart_clk(dev_index);
@@ -1397,17 +1631,22 @@ unsigned long get_uart_clk(int dev_index)
 
 unsigned long get_mmc_clk(int dev_index)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_get_mmc_clk(dev_index);
                return exynos5_get_mmc_clk(dev_index);
-       else
+       } else {
                return exynos4_get_mmc_clk(dev_index);
+       }
 }
 
 void set_mmc_clk(int dev_index, unsigned int div)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_set_mmc_clk(dev_index, div);
                exynos5_set_mmc_clk(dev_index, div);
-       else {
+       } else {
                if (proid_is_exynos4412())
                        exynos4x12_set_mmc_clk(dev_index, div);
                exynos4_set_mmc_clk(dev_index, div);
@@ -1438,10 +1677,13 @@ void set_mipi_clk(void)
 
 int set_spi_clk(int periph_id, unsigned int rate)
 {
-       if (cpu_is_exynos5())
+       if (cpu_is_exynos5()) {
+               if (proid_is_exynos5420())
+                       return exynos5420_set_spi_clk(periph_id, rate);
                return exynos5_set_spi_clk(periph_id, rate);
-       else
+       } else {
                return 0;
+       }
 }
 
 int set_i2s_clk_prescaler(unsigned int src_frq, unsigned int dst_frq,
arch/arm/cpu/armv7/exynos/clock_init.h +17 -0
index c28ff3a..a875d0b 100644
@@ -10,7 +10,11 @@
 #define __EXYNOS_CLOCK_INIT_H
 
 enum {
+#ifdef CONFIG_EXYNOS5420
+       MEM_TIMINGS_MSR_COUNT   = 5,
+#else
        MEM_TIMINGS_MSR_COUNT   = 4,
+#endif
 };
 
 /* These are the ratio's for configuring ARM clock */
@@ -59,6 +63,18 @@ struct mem_timings {
        unsigned bpll_mdiv;
        unsigned bpll_pdiv;
        unsigned bpll_sdiv;
+       unsigned kpll_mdiv;
+       unsigned kpll_pdiv;
+       unsigned kpll_sdiv;
+       unsigned dpll_mdiv;
+       unsigned dpll_pdiv;
+       unsigned dpll_sdiv;
+       unsigned ipll_mdiv;
+       unsigned ipll_pdiv;
+       unsigned ipll_sdiv;
+       unsigned spll_mdiv;
+       unsigned spll_pdiv;
+       unsigned spll_sdiv;
        unsigned pclk_cdrex_ratio;
        unsigned direct_cmd_msr[MEM_TIMINGS_MSR_COUNT];
 
@@ -115,6 +131,7 @@ struct mem_timings {
        uint8_t send_zq_init;           /* 1 to send this command */
        unsigned impedance;             /* drive strength impedeance */
        uint8_t gate_leveling_enable;   /* check gate leveling is enabled
 */
+       uint8_t read_leveling_enable;   /* check h/w read leveling is

enabled */
};

/**

arch/arm/cpu/armv7/exynos/clock_init_exynos5.c +338 -14
index a24c2f3..e7f1496 100644
@@ -24,6 +24,24 @@
 DECLARE_GLOBAL_DATA_PTR;
 
 struct arm_clk_ratios arm_clk_ratios[] = {
+#ifdef CONFIG_EXYNOS5420
+       {
+               .arm_freq_mhz = 900,
+
+               .apll_mdiv = 0x96,
+               .apll_pdiv = 0x2,
+               .apll_sdiv = 0x1,
+
+               .arm2_ratio = 0x0,
+               .apll_ratio = 0x3,
+               .pclk_dbg_ratio = 0x6,
+               .atb_ratio = 0x6,
+               .periph_ratio = 0x7,
+               .acp_ratio = 0x0,
+               .cpud_ratio = 0x2,
+               .arm_ratio = 0x0,
+       }
+#else
        {
                .arm_freq_mhz = 600,
 
@@ -115,8 +133,133 @@ struct arm_clk_ratios arm_clk_ratios[] = {
                .cpud_ratio = 0x3,
                .arm_ratio = 0x0,
        }
+#endif
 };
+
 struct mem_timings mem_timings[] = {
+#ifdef CONFIG_EXYNOS5420
+       {
+               .mem_manuf = MEM_MANUF_SAMSUNG,
+               .mem_type = DDR_MODE_DDR3,
+               .frequency_mhz = 800,
+
+               /* MPLL @800MHz*/
+               .mpll_mdiv = 0xc8,
+               .mpll_pdiv = 0x3,
+               .mpll_sdiv = 0x1,
+               /* CPLL @666MHz */
+               .cpll_mdiv = 0xde,
+               .cpll_pdiv = 0x4,
+               .cpll_sdiv = 0x1,
+               /* EPLL @600MHz */
+               .epll_mdiv = 0x64,
+               .epll_pdiv = 0x2,
+               .epll_sdiv = 0x1,
+               /* VPLL @430MHz */
+               .vpll_mdiv = 0xd7,
+               .vpll_pdiv = 0x3,
+               .vpll_sdiv = 0x2,
+               /* BPLL @800MHz */
+               .bpll_mdiv = 0xc8,
+               .bpll_pdiv = 0x3,
+               .bpll_sdiv = 0x1,
+               /* KPLL @600MHz */
+               .kpll_mdiv = 0x190,
+               .kpll_pdiv = 0x4,
+               .kpll_sdiv = 0x2,
+               /* DPLL @600MHz */
+               .dpll_mdiv = 0x190,
+               .dpll_pdiv = 0x4,
+               .dpll_sdiv = 0x2,
+               /* IPLL @370MHz */
+               .ipll_mdiv = 0xb9,
+               .ipll_pdiv = 0x3,
+               .ipll_sdiv = 0x2,
+               /* SPLL @400MHz */
+               .spll_mdiv = 0xc8,
+               .spll_pdiv = 0x3,
+               .spll_sdiv = 0x2,
+
+               .direct_cmd_msr = {
+                       0x00020018, 0x00030000, 0x00010046, 0x00000d70,
+                       0x00000c70
+               },
+               .timing_ref = 0x000000bb,
+               .timing_row = 0x6836650f,
+               .timing_data = 0x3630580b,
+               .timing_power = 0x41000a26,
+               .phy0_dqs = 0x08080808,
+               .phy1_dqs = 0x08080808,
+               .phy0_dq = 0x08080808,
+               .phy1_dq = 0x08080808,
+               .phy0_tFS = 0x8,
+               .phy1_tFS = 0x8,
+               .phy0_pulld_dqs = 0xf,
+               .phy1_pulld_dqs = 0xf,
+
+               .lpddr3_ctrl_phy_reset = 0x1,
+               .ctrl_start_point = 0x10,
+               .ctrl_inc = 0x10,
+               .ctrl_start = 0x1,
+               .ctrl_dll_on = 0x1,
+               .ctrl_ref = 0x8,
+
+               .ctrl_force = 0x1a,
+               .ctrl_rdlat = 0x0b,
+               .ctrl_bstlen = 0x08,
+
+               .fp_resync = 0x8,
+               .iv_size = 0x7,
+               .dfi_init_start = 1,
+               .aref_en = 1,
+
+               .rd_fetch = 0x3,
+
+               .zq_mode_dds = 0x7,
+               .zq_mode_term = 0x1,
+               .zq_mode_noterm = 1,
+
+               /*
+               * Dynamic Clock: Always Running
+               * Memory Burst length: 8
+               * Number of chips: 1
+               * Memory Bus width: 32 bit
+               * Memory Type: DDR3
+               * Additional Latancy for PLL: 0 Cycle
+               */
+               .memcontrol = DMC_MEMCONTROL_CLK_STOP_DISABLE |
+                       DMC_MEMCONTROL_DPWRDN_DISABLE |
+                       DMC_MEMCONTROL_DPWRDN_ACTIVE_PRECHARGE |
+                       DMC_MEMCONTROL_TP_DISABLE |
+                       DMC_MEMCONTROL_DSREF_DISABLE |
+                       DMC_MEMCONTROL_ADD_LAT_PALL_CYCLE(0) |
+                       DMC_MEMCONTROL_MEM_TYPE_DDR3 |
+                       DMC_MEMCONTROL_MEM_WIDTH_32BIT |
+                       DMC_MEMCONTROL_NUM_CHIP_1 |
+                       DMC_MEMCONTROL_BL_8 |
+                       DMC_MEMCONTROL_PZQ_DISABLE |
+                       DMC_MEMCONTROL_MRR_BYTE_7_0,
+               .memconfig = DMC_MEMCONFIG_CHIP_MAP_SPLIT |
+                       DMC_MEMCONFIGX_CHIP_COL_10 |
+                       DMC_MEMCONFIGX_CHIP_ROW_15 |
+                       DMC_MEMCONFIGX_CHIP_BANK_8,
+               .prechconfig_tp_cnt = 0xff,
+               .dpwrdn_cyc = 0xff,
+               .dsref_cyc = 0xffff,
+               .concontrol = DMC_CONCONTROL_DFI_INIT_START_DISABLE |
+                       DMC_CONCONTROL_TIMEOUT_LEVEL0 |
+                       DMC_CONCONTROL_RD_FETCH_DISABLE |
+                       DMC_CONCONTROL_EMPTY_DISABLE |
+                       DMC_CONCONTROL_AREF_EN_DISABLE |
+                       DMC_CONCONTROL_IO_PD_CON_DISABLE,
+               .dmc_channels = 1,
+               .chips_per_channel = 1,
+               .chips_to_configure = 1,
+               .send_zq_init = 1,
+               .gate_leveling_enable = 1,
+               .read_leveling_enable = 0,
+       }
+#else
        {
                .mem_manuf = MEM_MANUF_ELPIDA,
                .mem_type = DDR_MODE_DDR3,
@@ -324,6 +467,7 @@ struct mem_timings mem_timings[] = {
                .impedance = IMP_OUTPUT_DRV_40_OHM,
                .gate_leveling_enable = 1,
        }
+#endif
 };
 
 /**
@@ -399,7 +543,7 @@ struct mem_timings *clock_get_mem_timings(void)
        return NULL;
 }
 
-void system_clock_init()
+static void exynos5250_system_clock_init(void)
 {
        struct exynos5_clock *clk =
                (struct exynos5_clock *)samsung_get_base_clock();
@@ -436,19 +580,13 @@ void system_clock_init()
        } while ((val | MUX_BPLL_SEL_MASK) != val);
 
        /* PLL locktime */
-       writel(APLL_LOCK_VAL, &clk->apll_lock);
-
-       writel(MPLL_LOCK_VAL, &clk->mpll_lock);
-
-       writel(BPLL_LOCK_VAL, &clk->bpll_lock);
-
-       writel(CPLL_LOCK_VAL, &clk->cpll_lock);
-
-       writel(GPLL_LOCK_VAL, &clk->gpll_lock);
-
-       writel(EPLL_LOCK_VAL, &clk->epll_lock);
-
-       writel(VPLL_LOCK_VAL, &clk->vpll_lock);
+       writel(mem->apll_pdiv * PLL_LOCK_FACTOR, &clk->apll_lock);
+       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
+       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
+       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
+       writel(mem->gpll_pdiv * PLL_X_LOCK_FACTOR, &clk->gpll_lock);
+       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
+       writel(mem->vpll_pdiv * PLL_X_LOCK_FACTOR, &clk->vpll_lock);
 
        writel(CLK_REG_DISABLE, &clk->pll_div2_sel);
 
@@ -640,6 +778,192 @@ void system_clock_init()
        writel(val, &clk->div_fsys2);
 }
 
+static void exynos5420_system_clock_init(void)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)EXYNOS5_CLOCK_BASE;
+       struct mem_timings *mem;
+       struct arm_clk_ratios *arm_clk_ratio;
+       u32 val;
+
+       mem = clock_get_mem_timings();
+       arm_clk_ratio = get_arm_ratios();
+
+       /* PLL locktime */
+       writel(arm_clk_ratio->apll_pdiv * PLL_LOCK_FACTOR,
 &clk->apll_lock);
+       writel(mem->mpll_pdiv * PLL_LOCK_FACTOR, &clk->mpll_lock);
+       writel(mem->bpll_pdiv * PLL_LOCK_FACTOR, &clk->bpll_lock);
+       writel(mem->cpll_pdiv * PLL_LOCK_FACTOR, &clk->cpll_lock);
+       writel(mem->dpll_pdiv * PLL_LOCK_FACTOR, &clk->dpll_lock);
+       writel(mem->epll_pdiv * PLL_X_LOCK_FACTOR, &clk->epll_lock);
+       writel(mem->vpll_pdiv * PLL_LOCK_FACTOR, &clk->vpll_lock);
+       writel(mem->ipll_pdiv * PLL_LOCK_FACTOR, &clk->ipll_lock);
+       writel(mem->spll_pdiv * PLL_LOCK_FACTOR, &clk->spll_lock);
+       writel(mem->kpll_pdiv * PLL_LOCK_FACTOR, &clk->kpll_lock);
+
+       setbits_le32(&clk->src_cpu, MUX_HPM_SEL_MASK);
+
+       writel(0, &clk->src_top6);
+
+       writel(0, &clk->src_cdrex);
+       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
+       writel(HPM_RATIO,  &clk->div_cpu1);
+       writel(CLK_DIV_CPU0_VAL,  &clk->div_cpu0);
+
+       /* switch A15 clock source to OSC clock before changing APLL */
+       clrbits_le32(&clk->src_cpu, APLL_FOUT);
+
+       /* Set APLL */
+       writel(APLL_CON1_VAL, &clk->apll_con1);
+       val = set_pll(arm_clk_ratio->apll_mdiv,
+                     arm_clk_ratio->apll_pdiv,
+                     arm_clk_ratio->apll_sdiv);
+       writel(val, &clk->apll_con0);
+       while ((readl(&clk->apll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* now it is safe to switch to APLL */
+       setbits_le32(&clk->src_cpu, APLL_FOUT);
+
+       writel(SRC_KFC_HPM_SEL, &clk->src_kfc);
+       writel(CLK_DIV_KFC_VAL, &clk->div_kfc0);
+
+       /* switch A7 clock source to OSC clock before changing KPLL */
+       clrbits_le32(&clk->src_kfc, KPLL_FOUT);
+
+       /* Set KPLL*/
+       writel(KPLL_CON1_VAL, &clk->kpll_con1);
+       val = set_pll(mem->kpll_mdiv, mem->kpll_pdiv, mem->kpll_sdiv);
+       writel(val, &clk->kpll_con0);
+       while ((readl(&clk->kpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* now it is safe to switch to KPLL */
+       setbits_le32(&clk->src_kfc, KPLL_FOUT);
+
+       /* Set MPLL */
+       writel(MPLL_CON1_VAL, &clk->mpll_con1);
+       val = set_pll(mem->mpll_mdiv, mem->mpll_pdiv, mem->mpll_sdiv);
+       writel(val, &clk->mpll_con0);
+       while ((readl(&clk->mpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set DPLL */
+       writel(DPLL_CON1_VAL, &clk->dpll_con1);
+       val = set_pll(mem->dpll_mdiv, mem->dpll_pdiv, mem->dpll_sdiv);
+       writel(val, &clk->dpll_con0);
+       while ((readl(&clk->dpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set EPLL */
+       writel(EPLL_CON2_VAL, &clk->epll_con2);
+       writel(EPLL_CON1_VAL, &clk->epll_con1);
+       val = set_pll(mem->epll_mdiv, mem->epll_pdiv, mem->epll_sdiv);
+       writel(val, &clk->epll_con0);
+       while ((readl(&clk->epll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set CPLL */
+       writel(CPLL_CON1_VAL, &clk->cpll_con1);
+       val = set_pll(mem->cpll_mdiv, mem->cpll_pdiv, mem->cpll_sdiv);
+       writel(val, &clk->cpll_con0);
+       while ((readl(&clk->cpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set IPLL */
+       writel(IPLL_CON1_VAL, &clk->ipll_con1);
+       val = set_pll(mem->ipll_mdiv, mem->ipll_pdiv, mem->ipll_sdiv);
+       writel(val, &clk->ipll_con0);
+       while ((readl(&clk->ipll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set VPLL */
+       writel(VPLL_CON1_VAL, &clk->vpll_con1);
+       val = set_pll(mem->vpll_mdiv, mem->vpll_pdiv, mem->vpll_sdiv);
+       writel(val, &clk->vpll_con0);
+       while ((readl(&clk->vpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set BPLL */
+       writel(BPLL_CON1_VAL, &clk->bpll_con1);
+       val = set_pll(mem->bpll_mdiv, mem->bpll_pdiv, mem->bpll_sdiv);
+       writel(val, &clk->bpll_con0);
+       while ((readl(&clk->bpll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       /* Set SPLL */
+       writel(SPLL_CON1_VAL, &clk->spll_con1);
+       val = set_pll(mem->spll_mdiv, mem->spll_pdiv, mem->spll_sdiv);
+       writel(val, &clk->spll_con0);
+       while ((readl(&clk->spll_con0) & PLL_LOCKED) == 0)
+               ;
+
+       writel(CLK_DIV_CDREX0_VAL, &clk->div_cdrex0);
+       writel(CLK_DIV_CDREX1_VAL, &clk->div_cdrex1);
+
+       writel(CLK_SRC_TOP0_VAL, &clk->src_top0);
+       writel(CLK_SRC_TOP1_VAL, &clk->src_top1);
+       writel(CLK_SRC_TOP2_VAL, &clk->src_top2);
+       writel(CLK_SRC_TOP7_VAL, &clk->src_top7);
+
+       writel(CLK_DIV_TOP0_VAL, &clk->div_top0);
+       writel(CLK_DIV_TOP1_VAL, &clk->div_top1);
+       writel(CLK_DIV_TOP2_VAL, &clk->div_top2);
+
+       writel(0, &clk->src_top10);
+       writel(0, &clk->src_top11);
+       writel(0, &clk->src_top12);
+
+       writel(CLK_SRC_TOP3_VAL, &clk->src_top3);
+       writel(CLK_SRC_TOP4_VAL, &clk->src_top4);
+       writel(CLK_SRC_TOP5_VAL, &clk->src_top5);
+
+       /* DISP1 BLK CLK SELECTION */
+       writel(CLK_SRC_DISP1_0_VAL, &clk->src_disp10);
+       writel(CLK_DIV_DISP1_0_VAL, &clk->div_disp10);
+
+       /* AUDIO BLK */
+       writel(AUDIO0_SEL_EPLL, &clk->src_mau);
+       writel(DIV_MAU_VAL, &clk->div_mau);
+
+       /* FSYS */
+       writel(CLK_SRC_FSYS0_VAL, &clk->src_fsys);
+       writel(CLK_DIV_FSYS0_VAL, &clk->div_fsys0);
+       writel(CLK_DIV_FSYS1_VAL, &clk->div_fsys1);
+       writel(CLK_DIV_FSYS2_VAL, &clk->div_fsys2);
+
+       writel(CLK_SRC_ISP_VAL, &clk->src_isp);
+       writel(CLK_DIV_ISP0_VAL, &clk->div_isp0);
+       writel(CLK_DIV_ISP1_VAL, &clk->div_isp1);
+
+       writel(CLK_SRC_PERIC0_VAL, &clk->src_peric0);
+       writel(CLK_SRC_PERIC1_VAL, &clk->src_peric1);
+
+       writel(CLK_DIV_PERIC0_VAL, &clk->div_peric0);
+       writel(CLK_DIV_PERIC1_VAL, &clk->div_peric1);
+       writel(CLK_DIV_PERIC2_VAL, &clk->div_peric2);
+       writel(CLK_DIV_PERIC3_VAL, &clk->div_peric3);
+       writel(CLK_DIV_PERIC4_VAL, &clk->div_peric4);
+
+       writel(CLK_DIV_CPERI1_VAL, &clk->div_cperi1);
+
+       writel(CLK_DIV2_RATIO, &clk->clkdiv2_ratio);
+       writel(CLK_DIV4_RATIO, &clk->clkdiv4_ratio);
+       writel(CLK_DIV_G2D, &clk->div_g2d);
+
+       writel(CLK_SRC_TOP6_VAL, &clk->src_top6);
+       writel(CLK_SRC_CDREX_VAL, &clk->src_cdrex);
+       writel(CLK_SRC_KFC_VAL, &clk->src_kfc);
+}
+
+void system_clock_init(void)
+{
+       if (proid_is_exynos5420())
+               exynos5420_system_clock_init();
+       else
+               exynos5250_system_clock_init();
+}
+
 void clock_init_dp_clock(void)
 {

struct exynos5_clock *clk =

arch/arm/cpu/armv7/exynos/exynos5_setup.h +6 -31
index 696b386..8e05a00 100644
@@ -12,42 +12,16 @@
 #include <config.h>
 #include <asm/arch/dmc.h>
 
-/* APLL_CON1   */
-#define APLL_CON1_VAL  (0x00203800)
-
-/* MPLL_CON1   */
-#define MPLL_CON1_VAL   (0x00203800)
-
-/* CPLL_CON1   */
-#define CPLL_CON1_VAL  (0x00203800)
-
-/* GPLL_CON1   */
-#define GPLL_CON1_VAL  (0x00203800)
-
-/* EPLL_CON1, CON2     */
-#define EPLL_CON1_VAL  0x00000000
-#define EPLL_CON2_VAL  0x00000080
-
-/* VPLL_CON1, CON2     */
-#define VPLL_CON1_VAL  0x00000000
-#define VPLL_CON2_VAL  0x00000080
+#define NOT_AVAILABLE          0
+#define DATA_MASK              0xFFFFF
 
-/* BPLL_CON1   */
-#define BPLL_CON1_VAL  0x00203800
+#define ENABLE_BIT             0x1
+#define DISABLE_BIT            0x0
+#define CA_SWAP_EN             (1 << 0)
 
 /* Set PLL */
 #define set_pll(mdiv, pdiv, sdiv)      (1<<31 | mdiv<<16 | pdiv<<8 | sdiv)
 
-/* CLK_SRC_CPU */
-/* 0 = MOUTAPLL,  1 = SCLKMPLL */
-#define MUX_HPM_SEL             0
-#define MUX_CPU_SEL             0
-#define MUX_APLL_SEL            1
-
-#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
-                               | (MUX_CPU_SEL << 16)  \
-                               | (MUX_APLL_SEL))
-
 /* MEMCONTROL register bit fields */
 #define DMC_MEMCONTROL_CLK_STOP_DISABLE        (0 << 0)
 #define DMC_MEMCONTROL_DPWRDN_DISABLE  (0 << 1)
@@ -78,6 +52,7 @@
 
 /* MEMCONFIG0 register bit fields */
 #define DMC_MEMCONFIGX_CHIP_MAP_INTERLEAVED     (1 << 12)
+#define DMC_MEMCONFIG_CHIP_MAP_SPLIT           (2 << 12)
 #define DMC_MEMCONFIGX_CHIP_COL_10              (3 << 8)
 #define DMC_MEMCONFIGX_CHIP_ROW_14              (2 << 4)
 #define DMC_MEMCONFIGX_CHIP_ROW_15              (3 << 4)
@@ -90,6 +65,16 @@
        DMC_MEMBASECONFIGX_CHIP_MASK(0x780)     \
 )
 
Quoted 9 lines

arch/arm/cpu/armv7/exynos/exynos5_setup.h line 80

Quoted 7 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +6 -0
+/* As we use channel interleaving, therefore value of the base address
+ * register must be set as half of the bus base address
+ * RAM start addess is 0x2000_0000 which means chip_base is 0x20, so
+ * we need to set half 0x10 to the membaseconfigx registers
+ * see exynos5420 UM section 17.17.3.21 for more
+ */
 

please fix this multiline comment.

Will correct this

Quoted 193 lines
Quoted 140 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +101 -13
+#define DMC_CHIP_BASE_0 0x10
+#define DMC_CHIP_BASE_1 0x50
+#define DMC_CHIP_MASK  0x7C0
+
 #define DMC_MEMBASECONFIG0_VAL  DMC_MEMBASECONFIG_VAL(0x40)
 #define DMC_MEMBASECONFIG1_VAL  DMC_MEMBASECONFIG_VAL(0x80)
@@ -113,29 +98,24 @@
 
 /* COJCONTROL register bit fields */
 #define DMC_CONCONTROL_IO_PD_CON_DISABLE       (0 << 3)
+#define DMC_CONCONTROL_IO_PD_CON_ENABLE                (1 << 3)
 #define DMC_CONCONTROL_AREF_EN_DISABLE         (0 << 5)
+#define DMC_CONCONTROL_AREF_EN_ENABLE          (1 << 5)
 #define DMC_CONCONTROL_EMPTY_DISABLE           (0 << 8)
 #define DMC_CONCONTROL_EMPTY_ENABLE            (1 << 8)
 #define DMC_CONCONTROL_RD_FETCH_DISABLE                (0x0 << 12)
 #define DMC_CONCONTROL_TIMEOUT_LEVEL0          (0xFFF << 16)
 #define DMC_CONCONTROL_DFI_INIT_START_DISABLE  (0 << 28)
 
-/* CLK_DIV_CPU0_VAL */
-#define CLK_DIV_CPU0_VAL       ((ARM2_RATIO << 28)             \
-                               | (APLL_RATIO << 24)            \
-                               | (PCLK_DBG_RATIO << 20)        \
-                               | (ATB_RATIO << 16)             \
-                               | (PERIPH_RATIO << 12)          \
-                               | (ACP_RATIO << 8)              \
-                               | (CPUD_RATIO << 4)             \
-                               | (ARM_RATIO))
+#define DMC_CONCONTROL_VAL     0x1FFF2101
 
+#define DREX_CONCONTROL_VAL    DMC_CONCONTROL_VAL                      \
+                               | DMC_CONCONTROL_AREF_EN_ENABLE         \
+                               | DMC_CONCONTROL_IO_PD_CON_ENABLE
 
-/* CLK_FSYS */
-#define CLK_SRC_FSYS0_VAL              0x66666
-#define CLK_DIV_FSYS0_VAL             0x0BB00000
+#define DMC_CONCONTROL_IO_PD_CON(x)            (x << 6)
 
-/* CLK_DIV_CPU1        */
+/* CLK_DIV_CPU1 */
 #define HPM_RATIO               0x2
 #define COPY_RATIO              0x0
 
@@ -164,10 +144,370 @@
 /* CLK_DIV_SYSLFT */
 #define CLK_DIV_SYSLFT_VAL      0x00000311
 
+#define MUX_APLL_SEL_MASK      (1 << 0)
+#define MUX_MPLL_SEL_MASK      (1 << 8)
+#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
+#define MUX_CPLL_SEL_MASK      (1 << 8)
+#define MUX_EPLL_SEL_MASK      (1 << 12)
+#define MUX_VPLL_SEL_MASK      (1 << 16)
+#define MUX_GPLL_SEL_MASK      (1 << 28)
+#define MUX_BPLL_SEL_MASK      (1 << 0)
+#define MUX_HPM_SEL_MASK       (1 << 20)
+#define HPM_SEL_SCLK_MPLL      (1 << 21)
+#define PLL_LOCKED             (1 << 29)
+#define APLL_CON0_LOCKED       (1 << 29)
+#define MPLL_CON0_LOCKED       (1 << 29)
+#define BPLL_CON0_LOCKED       (1 << 29)
+#define CPLL_CON0_LOCKED       (1 << 29)
+#define EPLL_CON0_LOCKED       (1 << 29)
+#define GPLL_CON0_LOCKED       (1 << 29)
+#define VPLL_CON0_LOCKED       (1 << 29)
+#define CLK_REG_DISABLE                0x0
+#define TOP2_VAL               0x0110000
+
+/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
+#define SPI0_ISP_SEL           6
+#define SPI1_ISP_SEL           6
+#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
+                               | (SPI0_ISP_SEL << 0)
+
+/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
+#define SPI0_ISP_RATIO         0xf
+#define SPI1_ISP_RATIO         0xf
+#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
+                               | (SPI0_ISP_RATIO << 0)
+
+/* CLK_DIV_FSYS2 */
+#define MMC2_RATIO_MASK                0xf
+#define MMC2_RATIO_VAL         0x3
+#define MMC2_RATIO_OFFSET      0
+
+#define MMC2_PRE_RATIO_MASK    0xff
+#define MMC2_PRE_RATIO_VAL     0x9
+#define MMC2_PRE_RATIO_OFFSET  8
+
+#define MMC3_RATIO_MASK                0xf
+#define MMC3_RATIO_VAL         0x1
+#define MMC3_RATIO_OFFSET      16
+
+#define MMC3_PRE_RATIO_MASK    0xff
+#define MMC3_PRE_RATIO_VAL     0x0
+#define MMC3_PRE_RATIO_OFFSET  24
+
+/* CLK_SRC_LEX */
+#define CLK_SRC_LEX_VAL         0x0
+
+/* CLK_DIV_LEX */
+#define CLK_DIV_LEX_VAL         0x10
+
+/* CLK_DIV_R0X */
+#define CLK_DIV_R0X_VAL         0x10
+
+/* CLK_DIV_L0X */
+#define CLK_DIV_R1X_VAL         0x10
+
+/* CLK_DIV_ISP2 */
+#define CLK_DIV_ISP2_VAL        0x1
+
+/* CLK_SRC_KFC */
+#define SRC_KFC_HPM_SEL                (1 << 15)
+
+/* CLK_SRC_KFC */
+#define CLK_SRC_KFC_VAL                0x00008001
+
+/* CLK_DIV_KFC */
+#define CLK_DIV_KFC_VAL                0x03300110
+
+/* CLK_DIV2_RATIO */
+#define CLK_DIV2_RATIO         0x10111150
+
+/* CLK_DIV4_RATIO */
+#define CLK_DIV4_RATIO         0x00000003
+
+/* CLK_DIV_G2D */
+#define CLK_DIV_G2D            0x00000010
+
+/*
+ * DIV_DISP1_0
+ * For DP, divisor should be 2
+ */
+#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
+

arch/arm/cpu/armv7/exynos/exynos5_setup.h line 245

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+/* CLK_GATE_IP_DISP1 */
+#define CLK_GATE_DP1_ALLOW     (1 << 4)
+
+/* AUDIO CLK SEL */
+#define AUDIO0_SEL_EPLL                (0x6 << 28)
+#define AUDIO0_RATIO           0x5
+#define PCM0_RATIO             0x3
+#define DIV_MAU_VAL            (PCM0_RATIO << 24 | AUDIO0_RATIO << 20)
+
 

please remove blank line.

Quoted 25 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +25 -0
+
+/* CLK_SRC_CDREX */
+#define MUX_MCLK_CDR_MSPLL     (1 << 4)
+#define MUX_BPLL_SEL_FOUTBPLL   (1 << 0)
+#define BPLL_SEL_MASK   0x7
+#define FOUTBPLL        2
+
+#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
+#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
+
+#define PHY_CON0_RESET_VAL     0x17020a40
+#define P0_CMD_EN              (1 << 14)
+#define BYTE_RDLVL_EN          (1 << 13)
+#define CTRL_SHGATE            (1 << 8)
+
+#define PHY_CON1_RESET_VAL     0x09210100
+#define RDLVL_PASS_ADJ_VAL     0x6
+#define RDLVL_PASS_ADJ_OFFSET  16
+#define CTRL_GATEDURADJ_MASK   (0xf << 20)
+#define READ_LEVELLING_DDR3    0x0100
+
+#define PHY_CON2_RESET_VAL     0x00010004
+#define INIT_DESKEW_EN         (1 << 6)
+#define DLL_DESKEW_EN          (1 << 12)
+#define RDLVL_GATE_EN          (1 << 24)

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+#define RDLVL_EN               (1 << 25)
+#define RDLVL_INCR_ADJ         (0x1 << 16)
+
+/* DREX_PAUSE */
+#define DREX_PAUSE_EN  (1 << 0)
+
+#define BYPASS_EN      (1 << 22)
+
+/********-----MEMMORY VAL----------***/
 

/* MEMORY VAL */

Quoted 12 lines

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+#define PHY_CON0_VAL   0x17021A00
+
+#define PHY_CON12_RESET_VAL    0x10100070
+#define PHY_CON12_VAL          0x10107F50
+#define CTRL_START             (1 << 6)
+#define CTRL_DLL_ON            (1 << 5)
+#define CTRL_FORCE_MASK                (0x7F << 8)
+#define CTRL_LOCK_COARSE_MASK  (0x7F << 10)
+
 

please remove blank line.

Will correct this

Quoted 67 lines
Quoted 22 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +20 -0
+
+#define CTRL_OFFSETD_RESET_VAL 0x8
+#define CTRL_OFFSETD_VAL       0x7F
+
+#define CTRL_OFFSETR0          0x7F
+#define CTRL_OFFSETR1          0x7F
+#define CTRL_OFFSETR2          0x7F
+#define CTRL_OFFSETR3          0x7F
+#define PHY_CON4_VAL   (CTRL_OFFSETR0 << 0 | \
+                               CTRL_OFFSETR1 << 8 | \
+                               CTRL_OFFSETR2 << 16 | \
+                               CTRL_OFFSETR3 << 24)
+#define PHY_CON4_RESET_VAL     0x08080808
+
+#define CTRL_OFFSETW0          0x7F
+#define CTRL_OFFSETW1          0x7F
+#define CTRL_OFFSETW2          0x7F
+#define CTRL_OFFSETW3          0x7F
+#define PHY_CON6_VAL   (CTRL_OFFSETW0 << 0 | \
+                               CTRL_OFFSETW1 << 8 | \

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 10 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +9 -0
+                               CTRL_OFFSETW2 << 16 | \
+                               CTRL_OFFSETW3 << 24)
+#define PHY_CON6_RESET_VAL     0x08080808
+
+#define PHY_CON14_RESET_VAL    0x001F0000
+#define CTRL_PULLD_DQS         0xF
+#define CTRL_PULLD_DQS_OFFSET  0
+
+/*ZQ Configurations */
 

please add space before ZQ.

Quoted 31 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +31 -0
+#define PHY_CON16_RESET_VAL    0x08000304
+
+#define ZQ_CLK_EN              (1 << 27)
+#define ZQ_CLK_DIV_EN          (1 << 18)
+#define ZQ_MANUAL_STR          (1 << 1)
+#define ZQ_DONE                        (1 << 0)
+#define ZQ_MODE_DDS_OFFSET     24
+
+#define CTRL_RDLVL_GATE_ENABLE 1
+#define CTRL_RDLVL_GATE_DISABLE        0
+#define CTRL_RDLVL_DATA_ENABLE 2
+
+/* Direct Command */
+#define DIRECT_CMD_NOP                 0x07000000
+#define DIRECT_CMD_PALL                        0x01000000
+#define DIRECT_CMD_ZQINIT              0x0a000000
+#define DIRECT_CMD_CHANNEL_SHIFT       28
+#define DIRECT_CMD_CHIP_SHIFT          20
+#define DIRECT_CMD_BANK_SHIFT          16
+#define DIRECT_CMD_REFA                (5 << 24)
+#define DIRECT_CMD_MRS1                0x71C00
+#define DIRECT_CMD_MRS2                0x10BFC
+#define DIRECT_CMD_MRS3                0x0050C
+#define DIRECT_CMD_MRS4                0x00868
+#define DIRECT_CMD_MRS5                0x00C04
+
+/* Drive Strength */
+#define IMPEDANCE_48_OHM       4
+#define IMPEDANCE_40_OHM       5
+#define IMPEDANCE_34_OHM       6
+#define IMPEDANCE_30_OHM       7
Quoted 8 lines

arch/arm/cpu/armv7/exynos/exynos5_setup.h

Quoted 6 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +5 -0
+#define PHY_CON39_VAL_48_OHM   0x09240924
+#define PHY_CON39_VAL_40_OHM   0x0B6D0B6D
+#define PHY_CON39_VAL_34_OHM   0x0DB60DB6
+#define PHY_CON39_VAL_30_OHM   0x0FFF0FFF
+
 

please remove blank line.

Will correct this

Quoted 588 lines
Quoted 571 lines
arch/arm/cpu/armv7/exynos/exynos5_setup.h +55 -0
+
+#define CTRL_BSTLEN_OFFSET     8
+#define CTRL_RDLAT_OFFSET      0
+
+#define CMD_DEFAULT_LPDDR3     0xF
+#define CMD_DEFUALT_OFFSET     0
+#define T_WRDATA_EN            0x7
+#define T_WRDATA_EN_DDR3       0x8
+#define T_WRDATA_EN_OFFSET     16
+#define T_WRDATA_EN_MASK       0x1f
+
+#define PHY_CON31_VAL  0x0C183060
+#define PHY_CON32_VAL  0x60C18306
+#define PHY_CON33_VAL  0x00000030
+
+#define PHY_CON31_RESET_VAL    0x0
+#define PHY_CON32_RESET_VAL    0x0
+#define PHY_CON33_RESET_VAL    0x0
+
+#define SL_DLL_DYN_CON_EN      (1 << 1)
+#define FP_RESYNC      (1 << 3)
+#define CTRL_START     (1 << 6)
+
+#define DMC_AREF_EN            (1 << 5)
+#define DMC_CONCONTROL_EMPTY   (1 << 8)
+#define DFI_INIT_START         (1 << 28)
+
+#define DMC_MEMCONTROL_VAL     0x00312700
+#define CLK_STOP_EN            (1 << 0)
+#define DPWRDN_EN              (1 << 1)
+#define DSREF_EN               (1 << 5)
+
+#define MEMBASECONFIG_CHIP_MASK_VAL    0x7E0
+#define MEMBASECONFIG_CHIP_MASK_OFFSET 0
+#define MEMBASECONFIG0_CHIP_BASE_VAL   0x20
+#define MEMBASECONFIG1_CHIP_BASE_VAL   0x40
+#define CHIP_BASE_OFFSET               16
+
+#define MEMCONFIG_VAL  0x1323
+#define PRECHCONFIG_DEFAULT_VAL        0xFF000000
+#define PWRDNCONFIG_DEFAULT_VAL        0xFFFF00FF
+
+#define TIMINGAREF_VAL 0x5d
+#define TIMINGROW_VAL  0x345A8692
+#define TIMINGDATA_VAL 0x3630065C
+#define TIMINGPOWER_VAL        0x50380336
+#define DFI_INIT_COMPLETE      (1 << 3)
+
+#define BRBRSVCONTROL_VAL      0x00000033
+#define BRBRSVCONFIG_VAL       0x88778877
+
+/* Clock Gating Control (CGCONTROL) register */
+#define MEMIF_CG_EN    (1 << 3) /* Memory interface clock gating */
+#define SCG_CG_EN      (1 << 2) /* Scheduler clock gating */
+#define BUSIF_WR_CG_EN (1 << 1) /* Bus interface write channel clock

gating */
+#define BUSIF_RD_CG_EN (1 << 0) /* Bus interface read channel clock gating */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +8 -0
+#define DMC_INTERNAL_CG        (MEMIF_CG_EN | SCG_CG_EN | \
+                                BUSIF_WR_CG_EN | BUSIF_RD_CG_EN)
+
+/* DMC PHY Control0 register */
+#define PHY_CONTROL0_RESET_VAL 0x0
+#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
+#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
+#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating

signal */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +139 -110
+#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
+
+/* Driver strength for CK, CKE, CS & CA */
+#define IMP_OUTPUT_DRV_40_OHM  0x5
+#define IMP_OUTPUT_DRV_30_OHM  0x7
+#define DA_3_DS_OFFSET         25
+#define DA_2_DS_OFFSET         22
+#define DA_1_DS_OFFSET         19
+#define DA_0_DS_OFFSET         16
+#define CA_CK_DRVR_DS_OFFSET   9
+#define CA_CKE_DRVR_DS_OFFSET  6
+#define CA_CS_DRVR_DS_OFFSET   3
+#define CA_ADR_DRVR_DS_OFFSET  0
+
+#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
+#define PHY_CON42_CTRL_RDLAT_SHIFT     0
+
+/*
+ * Definitions that differ with SoC's.
+ * Below is the part defining macros for smdk5250.
+ * Else part introduces macros for smdk5420.
+ */
+#ifndef CONFIG_SMDK5420
+
+/* APLL_CON1 */
+#define APLL_CON1_VAL  (0x00203800)
+
+/* MPLL_CON1 */
+#define MPLL_CON1_VAL   (0x00203800)
+
+/* CPLL_CON1 */
+#define CPLL_CON1_VAL  (0x00203800)
+
+/* DPLL_CON1 */
+#define DPLL_CON1_VAL  (NOT_AVAILABLE)
+
+/* GPLL_CON1 */
+#define GPLL_CON1_VAL  (0x00203800)
+
+/* EPLL_CON1, CON2 */
+#define EPLL_CON1_VAL  0x00000000
+#define EPLL_CON2_VAL  0x00000080
+
+/* VPLL_CON1, CON2 */
+#define VPLL_CON1_VAL  0x00000000
+#define VPLL_CON2_VAL  0x00000080
+
+/* RPLL_CON1, CON2 */
+#define RPLL_CON1_VAL  NOT_AVAILABLE
+#define RPLL_CON2_VAL  NOT_AVAILABLE
+
+/* BPLL_CON1 */
+#define BPLL_CON1_VAL  0x00203800
+
+/* SPLL_CON1 */
+#define SPLL_CON1_VAL  NOT_AVAILABLE
+
+/* IPLL_CON1 */
+#define IPLL_CON1_VAL  NOT_AVAILABLE
+
+/* KPLL_CON1 */
+#define KPLL_CON1_VAL  NOT_AVAILABLE
+
+/* CLK_SRC_ISP */
+#define CLK_SRC_ISP_VAL                NOT_AVAILABLE
+#define CLK_DIV_ISP0_VAL       0x31
+#define CLK_DIV_ISP1_VAL       0x0
+
+/* CLK_FSYS */
+#define CLK_SRC_FSYS0_VAL              0x66666
+#define CLK_DIV_FSYS0_VAL             0x0BB00000
+#define CLK_DIV_FSYS1_VAL             NOT_AVAILABLE
+#define CLK_DIV_FSYS2_VAL             NOT_AVAILABLE
+
+/* CLK_SRC_CPU */
+/* 0 = MOUTAPLL,  1 = SCLKMPLL */
+#define MUX_HPM_SEL             0
+#define MUX_CPU_SEL             0
+#define MUX_APLL_SEL            1
+
+#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
+                               | (MUX_CPU_SEL << 16)  \
+                               | (MUX_APLL_SEL))
+
 /* CLK_SRC_CDREX */
 #define CLK_SRC_CDREX_VAL       0x1
 
 /* CLK_DIV_CDREX */
+#define CLK_DIV_CDREX0_VAL     NOT_AVAILABLE
+#define CLK_DIV_CDREX1_VAL     NOT_AVAILABLE
+
+/* CLK_DIV_CPU0_VAL */
+#define CLK_DIV_CPU0_VAL       NOT_AVAILABLE
+
 #define MCLK_CDREX2_RATIO       0x0
 #define ACLK_EFCON_RATIO        0x1
 #define MCLK_DPHY_RATIO                0x1
@@ -247,6 +587,11 @@
                                | (MUX_ACLK_300_DISP1_SUB_SEL << 6)     \
                                | (MUX_ACLK_200_DISP1_SUB_SEL << 4))
 
+#define CLK_SRC_TOP4_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP5_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP6_VAL       NOT_AVAILABLE
+#define CLK_SRC_TOP7_VAL       NOT_AVAILABLE
+
 /* CLK_DIV_TOP0        */
 #define ACLK_300_DISP1_RATIO   0x2
 #define ACLK_400_G3D_RATIO     0x0
@@ -279,40 +624,11 @@
                                | (ACLK_400_IOP_RATIO << 16)            \
                                | (ACLK_300_GSCL_RATIO << 12))
 
-/* APLL_LOCK   */
-#define APLL_LOCK_VAL  (0x546)
-/* MPLL_LOCK   */
-#define MPLL_LOCK_VAL  (0x546)
-/* CPLL_LOCK   */
-#define CPLL_LOCK_VAL  (0x546)
-/* GPLL_LOCK   */
-#define GPLL_LOCK_VAL  (0x546)
-/* EPLL_LOCK   */
-#define EPLL_LOCK_VAL  (0x3A98)
-/* VPLL_LOCK   */
-#define VPLL_LOCK_VAL  (0x3A98)
-/* BPLL_LOCK   */
-#define BPLL_LOCK_VAL  (0x546)
+#define CLK_DIV_TOP2_VAL       NOT_AVAILABLE
 
-#define MUX_APLL_SEL_MASK      (1 << 0)
-#define MUX_MPLL_SEL_MASK      (1 << 8)
-#define MPLL_SEL_MOUT_MPLLFOUT (2 << 8)
-#define MUX_CPLL_SEL_MASK      (1 << 8)
-#define MUX_EPLL_SEL_MASK      (1 << 12)
-#define MUX_VPLL_SEL_MASK      (1 << 16)
-#define MUX_GPLL_SEL_MASK      (1 << 28)
-#define MUX_BPLL_SEL_MASK      (1 << 0)
-#define MUX_HPM_SEL_MASK       (1 << 20)
-#define HPM_SEL_SCLK_MPLL      (1 << 21)
-#define APLL_CON0_LOCKED       (1 << 29)
-#define MPLL_CON0_LOCKED       (1 << 29)
-#define BPLL_CON0_LOCKED       (1 << 29)
-#define CPLL_CON0_LOCKED       (1 << 29)
-#define EPLL_CON0_LOCKED       (1 << 29)
-#define GPLL_CON0_LOCKED       (1 << 29)
-#define VPLL_CON0_LOCKED       (1 << 29)
-#define CLK_REG_DISABLE                0x0
-#define TOP2_VAL               0x0110000
+/* PLL Lock Value Factor */
+#define PLL_LOCK_FACTOR                250
+#define PLL_X_LOCK_FACTOR      3000
 
 /* CLK_SRC_PERIC0 */
 #define PWM_SEL                6
@@ -336,18 +652,6 @@
                                | (SPI1_SEL << 20) \
                                | (SPI0_SEL << 16))
 
-/* SCLK_SRC_ISP - set SPI0/1 to 6 = SCLK_MPLL_USER */
-#define SPI0_ISP_SEL           6
-#define SPI1_ISP_SEL           6
-#define SCLK_SRC_ISP_VAL       (SPI1_ISP_SEL << 4) \
-                               | (SPI0_ISP_SEL << 0)
-
-/* SCLK_DIV_ISP - set SPI0/1 to 0xf = divide by 16 */
-#define SPI0_ISP_RATIO         0xf
-#define SPI1_ISP_RATIO         0xf
-#define SCLK_DIV_ISP_VAL       (SPI1_ISP_RATIO << 12) \
-                               | (SPI0_ISP_RATIO << 0)
-
 /* CLK_DIV_PERIL0      */
 #define UART5_RATIO    7
 #define UART4_RATIO    7
@@ -380,105 +684,200 @@
 #define PWM_RATIO              8
 #define CLK_DIV_PERIC3_VAL     (PWM_RATIO << 0)
 
-/* CLK_DIV_FSYS2 */
-#define MMC2_RATIO_MASK                0xf
-#define MMC2_RATIO_VAL         0x3
-#define MMC2_RATIO_OFFSET      0
 
-#define MMC2_PRE_RATIO_MASK    0xff
-#define MMC2_PRE_RATIO_VAL     0x9
-#define MMC2_PRE_RATIO_OFFSET  8
+/* CLK_DIV_PERIC4 */
+#define CLK_DIV_PERIC4_VAL     NOT_AVAILABLE
 
-#define MMC3_RATIO_MASK                0xf
-#define MMC3_RATIO_VAL         0x1
-#define MMC3_RATIO_OFFSET      16
+/* CLK_SRC_DISP1_0 */
+#define CLK_SRC_DISP1_0_VAL    0x6
+#define CLK_DIV_DISP1_0_VAL    NOT_AVAILABLE
 
-#define MMC3_PRE_RATIO_MASK    0xff
-#define MMC3_PRE_RATIO_VAL     0x0
-#define MMC3_PRE_RATIO_OFFSET  24
+#define APLL_FOUT              (1 << 0)
+#define KPLL_FOUT              NOT_AVAILABLE
 
-/* CLK_SRC_LEX */
-#define CLK_SRC_LEX_VAL         0x0
+#define CLK_DIV_CPERI1_VAL     NOT_AVAILABLE
 
-/* CLK_DIV_LEX */
-#define CLK_DIV_LEX_VAL         0x10
+#else
 
-/* CLK_DIV_R0X */
-#define CLK_DIV_R0X_VAL         0x10
+/* APLL_CON1 */
+#define APLL_CON1_VAL  (0x0020F300)
 
-/* CLK_DIV_L0X */
-#define CLK_DIV_R1X_VAL         0x10
+/* MPLL_CON1 */
+#define MPLL_CON1_VAL   (0x0020F300)
 
-/* CLK_DIV_ISP0 */
-#define CLK_DIV_ISP0_VAL        0x31
 
-/* CLK_DIV_ISP1 */
-#define CLK_DIV_ISP1_VAL        0x0
+/* CPLL_CON1 */
+#define CPLL_CON1_VAL  0x0020f300
 
-/* CLK_DIV_ISP2 */
-#define CLK_DIV_ISP2_VAL        0x1
+/* DPLL_CON1 */
+#define DPLL_CON1_VAL  (0x0020F300)
 
-/* CLK_SRC_DISP1_0 */
-#define CLK_SRC_DISP1_0_VAL    0x6
+/* GPLL_CON1 */
+#define GPLL_CON1_VAL  (NOT_AVAILABLE)
 
-/*
- * DIV_DISP1_0
- * For DP, divisor should be 2
- */
-#define CLK_DIV_DISP1_0_FIMD1  (2 << 0)
 
-/* CLK_GATE_IP_DISP1 */
-#define CLK_GATE_DP1_ALLOW     (1 << 4)
+/* EPLL_CON1, CON2 */
+#define EPLL_CON1_VAL  0x00000000
+#define EPLL_CON2_VAL  0x00000080
 
-#define DDR3PHY_CTRL_PHY_RESET (1 << 0)
-#define DDR3PHY_CTRL_PHY_RESET_OFF     (0 << 0)
+/* VPLL_CON1, CON2 */
+#define VPLL_CON1_VAL  0x0020f300
+#define VPLL_CON2_VAL  NOT_AVAILABLE
 
-#define PHY_CON0_RESET_VAL     0x17020a40
-#define P0_CMD_EN              (1 << 14)
-#define BYTE_RDLVL_EN          (1 << 13)
-#define CTRL_SHGATE            (1 << 8)
+/* RPLL_CON1, CON2 */
+#define RPLL_CON1_VAL  0x00000000
+#define RPLL_CON2_VAL  0x00000080
 
-#define PHY_CON1_RESET_VAL     0x09210100
-#define CTRL_GATEDURADJ_MASK   (0xf << 20)
+/* BPLL_CON1 */
+#define BPLL_CON1_VAL  0x0020f300
 
-#define PHY_CON2_RESET_VAL     0x00010004
-#define INIT_DESKEW_EN         (1 << 6)
-#define RDLVL_GATE_EN          (1 << 24)
+/* SPLL_CON1 */
+#define SPLL_CON1_VAL  0x0020f300
 
-/*ZQ Configurations */
-#define PHY_CON16_RESET_VAL    0x08000304
+/* IPLL_CON1 */
+#define IPLL_CON1_VAL  0x00000080
 
-#define ZQ_CLK_DIV_EN          (1 << 18)
-#define ZQ_MANUAL_STR          (1 << 1)
-#define ZQ_DONE                        (1 << 0)
+/* KPLL_CON1 */
+#define KPLL_CON1_VAL  0x200000
 
-#define CTRL_RDLVL_GATE_ENABLE 1
-#define CTRL_RDLVL_GATE_DISABLE        1
+/* CLK_SRC_ISP */
+#define CLK_SRC_ISP_VAL                0x33366000
+#define CLK_DIV_ISP0_VAL       0x13131300
+#define CLK_DIV_ISP1_VAL       0xbb110202
 
-/* Direct Command */
-#define DIRECT_CMD_NOP                 0x07000000
-#define DIRECT_CMD_PALL                        0x01000000
-#define DIRECT_CMD_ZQINIT              0x0a000000
-#define DIRECT_CMD_CHANNEL_SHIFT       28
-#define DIRECT_CMD_CHIP_SHIFT          20
 
-/* DMC PHY Control0 register */
-#define PHY_CONTROL0_RESET_VAL 0x0
-#define MEM_TERM_EN    (1 << 31)       /* Termination enable for memory */
-#define PHY_TERM_EN    (1 << 30)       /* Termination enable for PHY */
-#define DMC_CTRL_SHGATE        (1 << 29)       /* Duration of DQS gating

signal */

arch/arm/cpu/armv7/exynos/exynos5_setup.h +131 -11
-#define FP_RSYNC       (1 << 3)        /* Force DLL resyncronization */
+/* CLK_FSYS */
+#define CLK_SRC_FSYS0_VAL              0x33033300
+#define CLK_DIV_FSYS0_VAL             0x0
+#define CLK_DIV_FSYS1_VAL             0x04f13c4f
+#define CLK_DIV_FSYS2_VAL             0x041d0000
+
+/* CLK_SRC_CPU */
+/* 0 = MOUTAPLL,  1 = SCLKMPLL */
+#define MUX_HPM_SEL             1
+#define MUX_CPU_SEL             0
+#define MUX_APLL_SEL            1
 
-/* Driver strength for CK, CKE, CS & CA */
-#define IMP_OUTPUT_DRV_40_OHM  0x5
-#define IMP_OUTPUT_DRV_30_OHM  0x7
-#define CA_CK_DRVR_DS_OFFSET   9
-#define CA_CKE_DRVR_DS_OFFSET  6
-#define CA_CS_DRVR_DS_OFFSET   3
-#define CA_ADR_DRVR_DS_OFFSET  0
+#define CLK_SRC_CPU_VAL                ((MUX_HPM_SEL << 20)    \
+                               | (MUX_CPU_SEL << 16)  \
+                               | (MUX_APLL_SEL))
 
-#define PHY_CON42_CTRL_BSTLEN_SHIFT    8
-#define PHY_CON42_CTRL_RDLAT_SHIFT     0
+/* CLK_SRC_CDREX */
+#define CLK_SRC_CDREX_VAL       0x00000011
+
+/* CLK_DIV_CDREX */
+#define CLK_DIV_CDREX0_VAL     0x30010100
+#define CLK_DIV_CDREX1_VAL     0x300
+
+#define CLK_DIV_CDREX_VAL       0x17010100
+
+/* CLK_DIV_CPU0_VAL */
+#define CLK_DIV_CPU0_VAL       0x01440020
+
+/* CLK_SRC_TOP */
+#define CLK_SRC_TOP0_VAL       0x12221222
+#define CLK_SRC_TOP1_VAL       0x00100200
+#define CLK_SRC_TOP2_VAL       0x11101000
+#define CLK_SRC_TOP3_VAL       0x11111111
+#define CLK_SRC_TOP4_VAL       0x11110111
+#define CLK_SRC_TOP5_VAL       0x11111100
+#define CLK_SRC_TOP6_VAL       0x11110111
+#define CLK_SRC_TOP7_VAL       0x00022200
+
+/* CLK_DIV_TOP */
+#define CLK_DIV_TOP0_VAL       0x23712311
+#define CLK_DIV_TOP1_VAL       0x13100B00
+#define CLK_DIV_TOP2_VAL       0x11101100
+
+/* PLL Lock Value Factor */
+#define PLL_LOCK_FACTOR                200
+#define PLL_X_LOCK_FACTOR      3000
+
+/* CLK_SRC_PERIC0 */
+#define SPDIF_SEL      1
+#define PWM_SEL                3
+#define UART4_SEL      3
+#define UART3_SEL      3
+#define UART2_SEL      3
+#define UART1_SEL      3
+#define UART0_SEL      3
+/* SRC_CLOCK = SCLK_RPLL */
+#define CLK_SRC_PERIC0_VAL     ((SPDIF_SEL << 28)      \
+                               | (PWM_SEL << 24)       \
+                               | (UART4_SEL << 20)     \
+                               | (UART3_SEL << 16)     \
+                               | (UART2_SEL << 12)     \
+                               | (UART1_SEL << 8)      \
+                               | (UART0_SEL << 4))
+
+/* CLK_SRC_PERIC1 */
+/* SRC_CLOCK = SCLK_EPLL */
+#define SPI0_SEL               6
+#define SPI1_SEL               6
+#define SPI2_SEL               6
+#define AUDIO0_SEL             6
+#define AUDIO1_SEL             6
+#define AUDIO2_SEL             6
+#define CLK_SRC_PERIC1_VAL     ((SPI2_SEL << 28)       \
+                               | (SPI1_SEL << 24)      \
+                               | (SPI0_SEL << 20)      \
+                               | (AUDIO2_SEL << 16)    \
+                               | (AUDIO2_SEL << 12)    \
+                               | (AUDIO2_SEL << 8))
+
+/* CLK_DIV_PERIC0 */
+#define PWM_RATIO      8
+#define UART4_RATIO    9
+#define UART3_RATIO    9
+#define UART2_RATIO    9
+#define UART1_RATIO    9
+#define UART0_RATIO    9
+
+#define CLK_DIV_PERIC0_VAL     ((PWM_RATIO << 28)      \
+                               | (UART4_RATIO << 24)   \
+                               | (UART3_RATIO << 20)    \
+                               | (UART2_RATIO << 16)    \
+                               | (UART1_RATIO << 12)    \
+                               | (UART0_RATIO << 8))
+/* CLK_DIV_PERIC1 */
+#define SPI2_RATIO             0x1
+#define SPI1_RATIO             0x1
+#define SPI0_RATIO             0x1
+#define CLK_DIV_PERIC1_VAL     ((SPI2_RATIO << 28)     \
+                               | (SPI1_RATIO << 24)    \
+                               | (SPI0_RATIO << 20))
+
+/* CLK_DIV_PERIC2 */
+#define PCM2_RATIO             0x3
+#define PCM1_RATIO             0x3
+#define CLK_DIV_PERIC2_VAL     ((PCM2_RATIO << 24) \
+                               | (PCM1_RATIO << 16))
+
+/* CLK_DIV_PERIC3 */
+#define AUDIO2_RATIO           0x5
+#define AUDIO1_RATIO           0x5
+#define AUDIO0_RATIO           0x5
+#define CLK_DIV_PERIC3_VAL     ((AUDIO2_RATIO << 28)   \
+                               | (AUDIO1_RATIO << 24)  \
+                               | (AUDIO0_RATIO << 20))
+
+/* CLK_DIV_PERIC4 */
+#define SPI2_PRE_RATIO         0x2
+#define SPI1_PRE_RATIO         0x2
+#define SPI0_PRE_RATIO         0x2
+#define CLK_DIV_PERIC4_VAL     ((SPI2_PRE_RATIO << 24) \
+                               | (SPI1_PRE_RATIO << 16) \
+                               | (SPI0_PRE_RATIO << 8))
+
+/* CLK_SRC_DISP1_0 */
+#define CLK_SRC_DISP1_0_VAL    0x10666600
+#define CLK_DIV_DISP1_0_VAL    0x01050211
+
+#define APLL_FOUT              (1 << 0)
+#define KPLL_FOUT              (1 << 0)
+
+#define CLK_DIV_CPERI1_VAL     0x3f3f0000
+#endif
 
 struct mem_timings;
@@ -490,7 +889,7 @@ enum {
 };
 
 /*
- * Memory variant specific initialization code
+ * Memory variant specific initialization code for DDR3
  *
  * @param mem          Memory timings for this memory type.
  * @param mem_iv_size  Memory interleaving size is a configurable

parameter

arch/arm/cpu/armv7/exynos/exynos5_setup.h +3 -8
@@ -503,6 +902,9 @@ enum {
 int ddr3_mem_ctrl_init(struct mem_timings *mem, unsigned long mem_iv_size,
                        int reset);
 
+/* Memory variant specific initialization code for LPDDR3 */
+void lpddr3_mem_ctrl_init(void);
+
 /*
  * Configure ZQ I/O interface
  *
@@ -532,14 +934,6 @@ void dmc_config_mrs(struct mem_timings *mem, struct
 exynos5_dmc *dmc);
 void dmc_config_prech(struct mem_timings *mem, struct exynos5_dmc *dmc);
 
 /*
- * Configure the memconfig and membaseconfig registers
- *
- * @param mem          Memory timings for this memory type.
- * @param exynos5_dmc  Pointer to struct of DMC registers
- */
-void dmc_config_memory(struct mem_timings *mem, struct exynos5_dmc *dmc);
-
-/*
  * Reset the DLL. This function is common between DDR3 and LPDDR2.
  * However, the reset value is different. So we are passing a flag

* ddr_mode to distinguish between LPDDR2 and DDR3.

arch/arm/include/asm/arch-exynos/clk.h +1 -1
index 1d6fa93..cdeef32 100644
@@ -14,6 +14,7 @@
 #define HPLL   3
 #define VPLL   4
 #define BPLL   5
+#define RPLL   6
 
 enum pll_src_bit {
        EXYNOS_SRC_MPLL = 6,
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
from. prom.
www.promsoft.net

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
Regards,
Rajeshwari Shinde
#13 lore raw

PATCH v6 3/10 Exynos5420: Add clock initialization for 5420

Dear Rajeshwari,

Quoted 63 lines · Rajeshwari Birje

Hi Minkyu Kang,

Thank you for comments,

Quoted 40 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 34 lines · On 29 October 2013 16:23, Rajeshwari S Shinde <[email protected] wrote:

This patch adds code for clock initialization and clock settings of various IP's and controllers, required for Exynos5420

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Corrected the multiline commenting style
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740
+++++++++++++++++++------
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 6 files changed, 1673 insertions(+), 201 deletions(-)
arch/arm/cpu/armv7/exynos/clock.c +0 -0
index 36fedd6..b52e61a 100644
@@ -96,7 +96,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned int
 r, unsigned int k)
 
Quoted 7 lines
Quoted 7 lines
arch/arm/cpu/armv7/exynos/clock.c +1 -1
        freq = CONFIG_SYS_CLK_FREQ;
 
-       if (pllreg == EPLL) {
+       if (pllreg == EPLL || pllreg == RPLL) {
                k = k & 0xffff;
                /* FOUT = (MDIV + K / 65536) * FIN / (PDIV * 2^SDIV) */
                fout = (m + k / PLL_DIV_65536) * (freq / (p * (1 <<

s)));

Quoted 1 line

arch/arm/cpu/armv7/exynos/clock.c static int exynos_get_pll_clk(int pllreg, unsigned

Quoted 1 line
arch/arm/cpu/armv7/exynos/clock.c +0 -0
@@ -117,7 +117,7 @@ static int exynos_get_pll_clk(int pllreg, unsigned

int

Quoted 8 lines
Quoted 7 lines
arch/arm/cpu/armv7/exynos/clock.c +1 -1
 r, unsigned int k)
                        div = PLL_DIV_1024;
                else if (proid_is_exynos4412())
                        div = PLL_DIV_65535;
-               else if (proid_is_exynos5250())
+               else if (cpu_is_exynos5())
 
Quoted 4 lines
Quoted 1 line

please don't mix proid_is... and cpu_is...

Since both 5420 and 5250 need same value added cpu_is_exynos5(), instead of doing a or of both.

I know, but this if statement for proid..
then, you should use same statement.

you can do this.

else if (proid_is_exynos5250() || prois_is_exynos5420())

or

if (cpu_is_exynos4()) {
    if (proid_is....) {
    } else if (proid_is....) {
    }
} else if (cpu_is_exynos5()) {
    .....
}

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#14 lore raw

PATCH v6 4/10 Exynos5420: Add DDR3 initialization for 5420

In reply to Rajeshwari S Shinde

This patch intends to add DDR3 initialization code for Exynos5420.

---
Changes in V2:
- Corrected a compilation issue for SMDK5250.
Changes in V3:
- None
Changes in V4:
- None
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/dmc_common.c    |  10 +-
 arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c | 421 +++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/cpu.h    |   4 +
 arch/arm/include/asm/arch-exynos/dmc.h    | 121 ++++++---
 4 files changed, 511 insertions(+), 45 deletions(-)
arch/arm/cpu/armv7/exynos/dmc_common.c +1 -9
index 53cfe6e..9e432c2 100644
@@ -1,5 +1,5 @@
 /*
- * Mem setup common file for different types of DDR present on SMDK5250 boards.
+ * Mem setup common file for different types of DDR present on Exynos boards.
  *
  * Copyright (C) 2012 Samsung Electronics
  *
@@ -152,14 +152,6 @@ void dmc_config_prech(struct mem_timings *mem, struct exynos5_dmc *dmc)
 	}
 }
 
-void dmc_config_memory(struct mem_timings *mem, struct exynos5_dmc *dmc)
-{
-	writel(mem->memconfig, &dmc->memconfig0);
-	writel(mem->memconfig, &dmc->memconfig1);
-	writel(DMC_MEMBASECONFIG0_VAL, &dmc->membaseconfig0);
-	writel(DMC_MEMBASECONFIG1_VAL, &dmc->membaseconfig1);
-}
-
 void mem_ctrl_init(int reset)
 {
 	struct spl_machine_param *param = spl_get_machine_params();
arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +417 -4

447 lines not on this page · raw message

arch/arm/include/asm/arch-exynos/cpu.h +4 -0
index 10a2ac3..a75dccf 100644
@@ -164,6 +164,10 @@
 #define EXYNOS5420_ADC_BASE		DEVICE_NOT_AVAILABLE
 #define EXYNOS5420_MODEM_BASE		DEVICE_NOT_AVAILABLE
 
+#define PAD_RETENTION_DRAM_STATUS	(EXYNOS5420_POWER_BASE + 0x3004)
+#define PAD_RETENTION_DRAM_COREBLK_OPTION	(EXYNOS5420_POWER_BASE + 0x31E8)
+#define PAD_RETENTION_DRAM_COREBLK_VAL	0x10000000
+
 #ifndef __ASSEMBLY__
 #include <asm/io.h>
 /* CPU detection macros */
arch/arm/include/asm/arch-exynos/dmc.h +89 -32

184 lines not on this page · raw message

Signature · 1 line
1.7.12.4
#15 lore raw

PATCH v6 4/10 Exynos5420: Add DDR3 initialization for 5420

Dear Rajeshwari S Shinde,

Quoted 562 lines · Rajeshwari S Shinde

This patch intends to add DDR3 initialization code for Exynos5420.

---
Changes in V2:
- Corrected a compilation issue for SMDK5250.
Changes in V3:
- None
Changes in V4:
- None
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/dmc_common.c    |  10 +-
 arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c | 421
+++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/cpu.h    |   4 +
 arch/arm/include/asm/arch-exynos/dmc.h    | 121 ++++++---
 4 files changed, 511 insertions(+), 45 deletions(-)
arch/arm/cpu/armv7/exynos/dmc_common.c +0 -1
index 53cfe6e..9e432c2 100644
@@ -1,5 +1,5 @@
 /*
- * Mem setup common file for different types of DDR present on SMDK5250

boards.
+ * Mem setup common file for different types of DDR present on Exynos boards.
*
* Copyright (C) 2012 Samsung Electronics
*

arch/arm/cpu/armv7/exynos/dmc_common.c +0 -8
@@ -152,14 +152,6 @@ void dmc_config_prech(struct mem_timings *mem, struct
 exynos5_dmc *dmc)
        }
 }
 
-void dmc_config_memory(struct mem_timings *mem, struct exynos5_dmc *dmc)
-{
-       writel(mem->memconfig, &dmc->memconfig0);
-       writel(mem->memconfig, &dmc->memconfig1);
-       writel(DMC_MEMBASECONFIG0_VAL, &dmc->membaseconfig0);
-       writel(DMC_MEMBASECONFIG1_VAL, &dmc->membaseconfig1);
-}
-
 void mem_ctrl_init(int reset)
 {
        struct spl_machine_param *param = spl_get_machine_params();
arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +4 -3
index 5f5914e..3fab50b 100644
@@ -1,5 +1,5 @@
 /*
- * DDR3 mem setup file for SMDK5250 board based on EXYNOS5
+ * DDR3 mem setup file for board based on EXYNOS5
  *
  * Copyright (C) 2012 Samsung Electronics
  *
@@ -15,8 +15,9 @@
 #include "exynos5_setup.h"
 #include "clock_init.h"
 
-#define RDLVL_COMPLETE_TIMEOUT 10000
+#define TIMEOUT        10000
 
+#ifdef CONFIG_EXYNOS5250
 static void reset_phy_ctrl(void)
 {
        struct exynos5_clock *clk =
@@ -108,7 +109,7 @@ int ddr3_mem_ctrl_init(struct mem_timings *mem,
 unsigned long mem_iv_size,
 
        /* Precharge Configuration */
        writel(mem->prechconfig_tp_cnt << PRECHCONFIG_TP_CNT_SHIFT,
-              &dmc->prechconfig);
+              &dmc->prechconfig0);
 
        /* Power Down mode Configuration */
        writel(mem->dpwrdn_cyc << PWRDNCONFIG_DPWRDN_CYC_SHIFT |
arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +1 -1
@@ -174,7 +175,7 @@ int ddr3_mem_ctrl_init(struct mem_timings *mem,
 unsigned long mem_iv_size,
                writel(val, &phy1_ctrl->phy_con1);
 
                writel(CTRL_RDLVL_GATE_ENABLE, &dmc->rdlvl_config);
-               i = RDLVL_COMPLETE_TIMEOUT;
+               i = TIMEOUT;
                while ((readl(&dmc->phystatus) &
                        (RDLVL_COMPLETE_CHO | RDLVL_COMPLETE_CH1)) !=
                        (RDLVL_COMPLETE_CHO | RDLVL_COMPLETE_CH1) && i >

0) {

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +16 -0
@@ -215,3 +216,415 @@ int ddr3_mem_ctrl_init(struct mem_timings *mem,
 unsigned long mem_iv_size,
                | (mem->aref_en << CONCONTROL_AREF_EN_SHIFT),
 &dmc->concontrol);
        return 0;
 }
+#endif
+
+#ifdef CONFIG_EXYNOS5420
+int ddr3_mem_ctrl_init(struct mem_timings *mem, unsigned long mem_iv_size,
+                      int reset)
+{
+       struct exynos5420_clock *clk =
+               (struct exynos5420_clock *)EXYNOS5_CLOCK_BASE;
+       struct exynos5_phy_control *phy0_ctrl, *phy1_ctrl;
+       struct exynos5_dmc *drex0, *drex1;
+       struct exynos5_tzasc *tzasc0, *tzasc1;
+       uint32_t val, n_lock_r, n_lock_w_phy0, n_lock_w_phy1;
+       int chip;
+       int i;
+
+       phy0_ctrl = (struct exynos5_phy_control

*)samsung_get_base_dmc_phy();
+ phy1_ctrl = (struct exynos5_phy_control
*)(samsung_get_base_dmc_phy()

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +24 -0
+                                                       + DMC_OFFSET);
+       drex0 = (struct exynos5_dmc *)samsung_get_base_dmc_ctrl();
+       drex1 = (struct exynos5_dmc *)(samsung_get_base_dmc_ctrl()
+                                                       + DMC_OFFSET);
+       tzasc0 = (struct exynos5_tzasc *)EXYNOS5420_DMC_TZASC0_BASE;
+       tzasc1 = (struct exynos5_tzasc *)EXYNOS5420_DMC_TZASC1_BASE;
+
+       /* Enable PAUSE for DREX */
+       setbits_le32(&clk->pause, ENABLE_BIT);
+
+       /* Enable BYPASS mode */
+       setbits_le32(&clk->bpll_con1, BYPASS_EN);
+
+       writel(MUX_BPLL_SEL_FOUTBPLL, &clk->src_cdrex);
+       do {
+               val = readl(&clk->mux_stat_cdrex);
+               val &= BPLL_SEL_MASK;
+       } while (val != FOUTBPLL);
+
+       clrbits_le32(&clk->bpll_con1, BYPASS_EN);
+
+       /* Specify the DDR memory type as DDR3 */
+       val = readl(&phy0_ctrl->phy_con0);
+       val &= ~(PHY_CON0_CTRL_DDR_MODE_MASK <<

PHY_CON0_CTRL_DDR_MODE_SHIFT);

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +5 -0
+       val |= (DDR_MODE_DDR3 << PHY_CON0_CTRL_DDR_MODE_SHIFT);
+       writel(val, &phy0_ctrl->phy_con0);
+
+       val = readl(&phy1_ctrl->phy_con0);
+       val &= ~(PHY_CON0_CTRL_DDR_MODE_MASK <<

PHY_CON0_CTRL_DDR_MODE_SHIFT);

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +24 -0
+       val |= (DDR_MODE_DDR3 << PHY_CON0_CTRL_DDR_MODE_SHIFT);
+       writel(val, &phy1_ctrl->phy_con0);
+
+       /* Set Read Latency and Burst Length for PHY0 and PHY1 */
+       val = (mem->ctrl_bstlen << PHY_CON42_CTRL_BSTLEN_SHIFT) |
+               (mem->ctrl_rdlat << PHY_CON42_CTRL_RDLAT_SHIFT);
+       writel(val, &phy0_ctrl->phy_con42);
+       writel(val, &phy1_ctrl->phy_con42);
+
+       val = readl(&phy0_ctrl->phy_con26);
+       val &= ~(T_WRDATA_EN_MASK << T_WRDATA_EN_OFFSET);
+       val |= (T_WRDATA_EN_DDR3 << T_WRDATA_EN_OFFSET);
+       writel(val, &phy0_ctrl->phy_con26);
+
+       val = readl(&phy1_ctrl->phy_con26);
+       val &= ~(T_WRDATA_EN_MASK << T_WRDATA_EN_OFFSET);
+       val |= (T_WRDATA_EN_DDR3 << T_WRDATA_EN_OFFSET);
+       writel(val, &phy1_ctrl->phy_con26);
+
+       /*
+        * Set Driver strength for CK, CKE, CS & CA to 0x7
+        * Set Driver strength for Data Slice 0~3 to 0x7
+        */
+       val = (0x7 << CA_CK_DRVR_DS_OFFSET) | (0x7 <<

CA_CKE_DRVR_DS_OFFSET) |
+ (0x7 << CA_CS_DRVR_DS_OFFSET) | (0x7 <<
CA_ADR_DRVR_DS_OFFSET);

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +96 -0
+       val |= (0x7 << DA_3_DS_OFFSET) | (0x7 << DA_2_DS_OFFSET) |
+               (0x7 << DA_1_DS_OFFSET) | (0x7 << DA_0_DS_OFFSET);
+       writel(val, &phy0_ctrl->phy_con39);
+       writel(val, &phy1_ctrl->phy_con39);
+
+       /* ZQ Calibration */
+       if (dmc_config_zq(mem, phy0_ctrl, phy1_ctrl))
+               return SETUP_ERR_ZQ_CALIBRATION_FAILURE;
+
+       clrbits_le32(&phy0_ctrl->phy_con16, ZQ_CLK_DIV_EN);
+       clrbits_le32(&phy1_ctrl->phy_con16, ZQ_CLK_DIV_EN);
+
+       /* DQ Signal */
+       val = readl(&phy0_ctrl->phy_con14);
+       val |= mem->phy0_pulld_dqs;
+       writel(val, &phy0_ctrl->phy_con14);
+       val = readl(&phy1_ctrl->phy_con14);
+       val |= mem->phy1_pulld_dqs;
+       writel(val, &phy1_ctrl->phy_con14);
+
+       val = MEM_TERM_EN | PHY_TERM_EN;
+       writel(val, &drex0->phycontrol0);
+       writel(val, &drex1->phycontrol0);
+
+       writel(mem->concontrol |
+               (mem->dfi_init_start << CONCONTROL_DFI_INIT_START_SHIFT) |
+               (mem->rd_fetch << CONCONTROL_RD_FETCH_SHIFT),
+               &drex0->concontrol);
+       writel(mem->concontrol |
+               (mem->dfi_init_start << CONCONTROL_DFI_INIT_START_SHIFT) |
+               (mem->rd_fetch << CONCONTROL_RD_FETCH_SHIFT),
+               &drex1->concontrol);
+
+       do {
+               val = readl(&drex0->phystatus);
+       } while ((val & DFI_INIT_COMPLETE) != DFI_INIT_COMPLETE);
+       do {
+               val = readl(&drex1->phystatus);
+       } while ((val & DFI_INIT_COMPLETE) != DFI_INIT_COMPLETE);
+
+       clrbits_le32(&drex0->concontrol, DFI_INIT_START);
+       clrbits_le32(&drex1->concontrol, DFI_INIT_START);
+
+       update_reset_dll(drex0, DDR_MODE_DDR3);
+       update_reset_dll(drex1, DDR_MODE_DDR3);
+
+       /*
+        * Set Base Address:
+        * 0x2000_0000 ~ 0x5FFF_FFFF
+        * 0x6000_0000 ~ 0x9FFF_FFFF
+        */
+       /* MEMBASECONFIG0 */
+       val = DMC_MEMBASECONFIGX_CHIP_BASE(DMC_CHIP_BASE_0) |
+               DMC_MEMBASECONFIGX_CHIP_MASK(DMC_CHIP_MASK);
+       writel(val, &tzasc0->membaseconfig0);
+       writel(val, &tzasc1->membaseconfig0);
+
+       /* MEMBASECONFIG1 */
+       val = DMC_MEMBASECONFIGX_CHIP_BASE(DMC_CHIP_BASE_1) |
+               DMC_MEMBASECONFIGX_CHIP_MASK(DMC_CHIP_MASK);
+       writel(val, &tzasc0->membaseconfig1);
+       writel(val, &tzasc1->membaseconfig1);
+
+       /*
+        * Memory Channel Inteleaving Size
+        * Ares Channel interleaving = 128 bytes
+        */
+       /* MEMCONFIG0/1 */
+       writel(mem->memconfig, &tzasc0->memconfig0);
+       writel(mem->memconfig, &tzasc1->memconfig0);
+       writel(mem->memconfig, &tzasc0->memconfig1);
+       writel(mem->memconfig, &tzasc1->memconfig1);
+
+       /* Precharge Configuration */
+       writel(mem->prechconfig_tp_cnt << PRECHCONFIG_TP_CNT_SHIFT,
+              &drex0->prechconfig0);
+       writel(mem->prechconfig_tp_cnt << PRECHCONFIG_TP_CNT_SHIFT,
+              &drex1->prechconfig0);
+
+       /*
+        * TimingRow, TimingData, TimingPower and Timingaref
+        * values as per Memory AC parameters
+        */
+       writel(mem->timing_ref, &drex0->timingref);
+       writel(mem->timing_ref, &drex1->timingref);
+       writel(mem->timing_row, &drex0->timingrow);
+       writel(mem->timing_row, &drex1->timingrow);
+       writel(mem->timing_data, &drex0->timingdata);
+       writel(mem->timing_data, &drex1->timingdata);
+       writel(mem->timing_power, &drex0->timingpower);
+       writel(mem->timing_power, &drex1->timingpower);
+
+       if (reset) {
+               /*
+                * Send NOP, MRS and ZQINIT commands
+                * Sending MRS command will reset the DRAM. We should not

be

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +8 -0
+                * reseting the DRAM after resume, this will lead to memory
+                * corruption as DRAM content is lost after DRAM reset
+                */
+               dmc_config_mrs(mem, drex0);
+               dmc_config_mrs(mem, drex1);
+       } else {
+               /*
+                * During Suspend-Resume & S/W-Reset, as soon as PMU

releases
+ * pad retention, CKE goes high. This causes memory
contents

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +2 -0
+                * not to be retained during DRAM initialization. Therfore,
+                * there is a new control register(0x100431e8[28]) which

lets us
+ * release pad retention and retain the memory content
until the

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +14 -0
+                * initialization is complete.
+                */
+               writel(PAD_RETENTION_DRAM_COREBLK_VAL,
+                      PAD_RETENTION_DRAM_COREBLK_OPTION);
+               do {
+                       val = readl(PAD_RETENTION_DRAM_STATUS);
+               } while (val != 0x1);
+
+               /*
+                * CKE PAD retention disables DRAM self-refresh mode.
+                * Send auto refresh command for DRAM refresh.
+                */
+               for (i = 0; i < 128; i++) {
+                       for (chip = 0; chip < mem->chips_to_configure;

chip++) {

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +111 -0
+                               writel(DIRECT_CMD_REFA |
+                                      (chip << DIRECT_CMD_CHIP_SHIFT),
+                                      &drex0->directcmd);
+                               writel(DIRECT_CMD_REFA |
+                                      (chip << DIRECT_CMD_CHIP_SHIFT),
+                                      &drex1->directcmd);
+                       }
+               }
+       }
+
+       if (mem->gate_leveling_enable) {
+               writel(PHY_CON0_RESET_VAL, &phy0_ctrl->phy_con0);
+               writel(PHY_CON0_RESET_VAL, &phy1_ctrl->phy_con0);
+
+               setbits_le32(&phy0_ctrl->phy_con0, P0_CMD_EN);
+               setbits_le32(&phy1_ctrl->phy_con0, P0_CMD_EN);
+
+               val = PHY_CON2_RESET_VAL;
+               val |= INIT_DESKEW_EN;
+               writel(val, &phy0_ctrl->phy_con2);
+               writel(val, &phy1_ctrl->phy_con2);
+
+               val =  readl(&phy0_ctrl->phy_con1);
+               val |= (RDLVL_PASS_ADJ_VAL << RDLVL_PASS_ADJ_OFFSET);
+               writel(val, &phy0_ctrl->phy_con1);
+
+               val =  readl(&phy1_ctrl->phy_con1);
+               val |= (RDLVL_PASS_ADJ_VAL << RDLVL_PASS_ADJ_OFFSET);
+               writel(val, &phy1_ctrl->phy_con1);
+
+               n_lock_r = readl(&phy0_ctrl->phy_con13);
+               n_lock_w_phy0 = (n_lock_r & CTRL_LOCK_COARSE_MASK) >> 2;
+               n_lock_r = readl(&phy0_ctrl->phy_con12);
+               n_lock_r &= ~CTRL_DLL_ON;
+               n_lock_r |= n_lock_w_phy0;
+               writel(n_lock_r, &phy0_ctrl->phy_con12);
+
+               n_lock_r = readl(&phy1_ctrl->phy_con13);
+               n_lock_w_phy1 = (n_lock_r & CTRL_LOCK_COARSE_MASK) >> 2;
+               n_lock_r = readl(&phy1_ctrl->phy_con12);
+               n_lock_r &= ~CTRL_DLL_ON;
+               n_lock_r |= n_lock_w_phy1;
+               writel(n_lock_r, &phy1_ctrl->phy_con12);
+
+               val = (0x3 << DIRECT_CMD_BANK_SHIFT) | 0x4;
+               for (chip = 0; chip < mem->chips_to_configure; chip++) {
+                       writel(val | (chip << DIRECT_CMD_CHIP_SHIFT),
+                              &drex0->directcmd);
+                       writel(val | (chip << DIRECT_CMD_CHIP_SHIFT),
+                              &drex1->directcmd);
+               }
+
+               setbits_le32(&phy0_ctrl->phy_con2, RDLVL_GATE_EN);
+               setbits_le32(&phy1_ctrl->phy_con2, RDLVL_GATE_EN);
+
+               setbits_le32(&phy0_ctrl->phy_con0, CTRL_SHGATE);
+               setbits_le32(&phy1_ctrl->phy_con0, CTRL_SHGATE);
+
+               val = readl(&phy0_ctrl->phy_con1);
+               val &= ~(CTRL_GATEDURADJ_MASK);
+               writel(val, &phy0_ctrl->phy_con1);
+
+               val = readl(&phy1_ctrl->phy_con1);
+               val &= ~(CTRL_GATEDURADJ_MASK);
+               writel(val, &phy1_ctrl->phy_con1);
+
+               writel(CTRL_RDLVL_GATE_ENABLE, &drex0->rdlvl_config);
+               i = TIMEOUT;
+               while (((readl(&drex0->phystatus) & RDLVL_COMPLETE_CHO) !=
+                       RDLVL_COMPLETE_CHO) && (i > 0)) {
+                       /*
+                        * TODO(waihong): Comment on how long this take to
+                        * timeout
+                        */
+                       sdelay(100);
+                       i--;
+               }
+               if (!i)
+                       return SETUP_ERR_RDLV_COMPLETE_TIMEOUT;
+               writel(CTRL_RDLVL_GATE_DISABLE, &drex0->rdlvl_config);
+
+               writel(CTRL_RDLVL_GATE_ENABLE, &drex1->rdlvl_config);
+               i = TIMEOUT;
+               while (((readl(&drex1->phystatus) & RDLVL_COMPLETE_CHO) !=
+                       RDLVL_COMPLETE_CHO) && (i > 0)) {
+                       /*
+                        * TODO(waihong): Comment on how long this take to
+                        * timeout
+                        */
+                       sdelay(100);
+                       i--;
+               }
+               if (!i)
+                       return SETUP_ERR_RDLV_COMPLETE_TIMEOUT;
+               writel(CTRL_RDLVL_GATE_DISABLE, &drex1->rdlvl_config);
+
+               writel(0, &phy0_ctrl->phy_con14);
+               writel(0, &phy1_ctrl->phy_con14);
+
+               val = (0x3 << DIRECT_CMD_BANK_SHIFT);
+               for (chip = 0; chip < mem->chips_to_configure; chip++) {
+                       writel(val | (chip << DIRECT_CMD_CHIP_SHIFT),
+                              &drex0->directcmd);
+                       writel(val | (chip << DIRECT_CMD_CHIP_SHIFT),
+                              &drex1->directcmd);
+               }
+
+               if (mem->read_leveling_enable) {
+                       /* Set Read DQ Calibration */
+                       val = (0x3 << DIRECT_CMD_BANK_SHIFT) | 0x4;
+                       for (chip = 0; chip < mem->chips_to_configure;

chip++) {
+ writel(val | (chip <<
DIRECT_CMD_CHIP_SHIFT),

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +2 -0
+                                      &drex0->directcmd);
+                               writel(val | (chip <<

DIRECT_CMD_CHIP_SHIFT),

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +21 -0
+                                      &drex1->directcmd);
+                       }
+
+                       val = readl(&phy0_ctrl->phy_con1);
+                       val |= READ_LEVELLING_DDR3;
+                       writel(val, &phy0_ctrl->phy_con1);
+                       val = readl(&phy1_ctrl->phy_con1);
+                       val |= READ_LEVELLING_DDR3;
+                       writel(val, &phy1_ctrl->phy_con1);
+
+                       val = readl(&phy0_ctrl->phy_con2);
+                       val |= (RDLVL_EN | RDLVL_INCR_ADJ);
+                       writel(val, &phy0_ctrl->phy_con2);
+                       val = readl(&phy1_ctrl->phy_con2);
+                       val |= (RDLVL_EN | RDLVL_INCR_ADJ);
+                       writel(val, &phy1_ctrl->phy_con2);
+
+                       setbits_le32(&drex0->rdlvl_config,
+                                    CTRL_RDLVL_DATA_ENABLE);
+                       i = TIMEOUT;
+                       while (((readl(&drex0->phystatus) &

RDLVL_COMPLETE_CHO)

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +3 -0
+                                != RDLVL_COMPLETE_CHO) && (i > 0)) {
+                               /*
+                                * TODO(waihong): Comment on how long this

take

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +14 -0
+                                * to timeout
+                                */
+                               sdelay(100);
+                               i--;
+                       }
+                       if (!i)
+                               return SETUP_ERR_RDLV_COMPLETE_TIMEOUT;
+
+                       clrbits_le32(&drex0->rdlvl_config,
+                                    CTRL_RDLVL_DATA_ENABLE);
+                       setbits_le32(&drex1->rdlvl_config,
+                                    CTRL_RDLVL_DATA_ENABLE);
+                       i = TIMEOUT;
+                       while (((readl(&drex1->phystatus) &

RDLVL_COMPLETE_CHO)

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +3 -0
+                                != RDLVL_COMPLETE_CHO) && (i > 0)) {
+                               /*
+                                * TODO(waihong): Comment on how long this

take

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +13 -0
+                                * to timeout
+                                */
+                               sdelay(100);
+                               i--;
+                       }
+                       if (!i)
+                               return SETUP_ERR_RDLV_COMPLETE_TIMEOUT;
+
+                       clrbits_le32(&drex1->rdlvl_config,
+                                    CTRL_RDLVL_DATA_ENABLE);
+
+                       val = (0x3 << DIRECT_CMD_BANK_SHIFT);
+                       for (chip = 0; chip < mem->chips_to_configure;

chip++) {
+ writel(val | (chip <<
DIRECT_CMD_CHIP_SHIFT),

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +2 -0
+                                      &drex0->directcmd);
+                               writel(val | (chip <<

DIRECT_CMD_CHIP_SHIFT),

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +29 -0
+                                      &drex1->directcmd);
+                       }
+
+                       update_reset_dll(drex0, DDR_MODE_DDR3);
+                       update_reset_dll(drex1, DDR_MODE_DDR3);
+               }
+
+               /* Common Settings for Leveling */
+               val = PHY_CON12_RESET_VAL;
+               writel((val + n_lock_w_phy0), &phy0_ctrl->phy_con12);
+               writel((val + n_lock_w_phy1), &phy1_ctrl->phy_con12);
+
+               setbits_le32(&phy0_ctrl->phy_con2, DLL_DESKEW_EN);
+               setbits_le32(&phy1_ctrl->phy_con2, DLL_DESKEW_EN);
+       }
+
+       /* Send PALL command */
+       dmc_config_prech(mem, drex0);
+       dmc_config_prech(mem, drex1);
+
+       writel(mem->memcontrol, &drex0->memcontrol);
+       writel(mem->memcontrol, &drex1->memcontrol);
+
+       /*
+        * Set DMC Concontrol: Enable auto-refresh counter, provide
+        * read data fetch cycles and enable DREX auto set powerdown
+        * for input buffer of I/O in none read memory state.
+        */
+       writel(mem->concontrol | (mem->aref_en <<

CONCONTROL_AREF_EN_SHIFT) |

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +4 -0
+               (mem->rd_fetch << CONCONTROL_RD_FETCH_SHIFT)|
+               DMC_CONCONTROL_IO_PD_CON(0x2),
+               &drex0->concontrol);
+       writel(mem->concontrol | (mem->aref_en <<

CONCONTROL_AREF_EN_SHIFT) |

arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c +15 -0
+               (mem->rd_fetch << CONCONTROL_RD_FETCH_SHIFT)|
+               DMC_CONCONTROL_IO_PD_CON(0x2),
+               &drex1->concontrol);
+
+       /*
+        * Enable Clock Gating Control for DMC
+        * this saves around 25 mw dmc power as compared to the power
+        * consumption without these bits enabled
+        */
+       setbits_le32(&drex0->cgcontrol, DMC_INTERNAL_CG);
+       setbits_le32(&drex1->cgcontrol, DMC_INTERNAL_CG);
+
+       return 0;
+}
+#endif
arch/arm/include/asm/arch-exynos/cpu.h +4 -0
index 10a2ac3..a75dccf 100644
@@ -164,6 +164,10 @@
 #define EXYNOS5420_ADC_BASE            DEVICE_NOT_AVAILABLE
 #define EXYNOS5420_MODEM_BASE          DEVICE_NOT_AVAILABLE
 
+#define PAD_RETENTION_DRAM_STATUS      (EXYNOS5420_POWER_BASE + 0x3004)
+#define PAD_RETENTION_DRAM_COREBLK_OPTION      (EXYNOS5420_POWER_BASE +
 0x31E8)
+#define PAD_RETENTION_DRAM_COREBLK_VAL 0x10000000
+
 #ifndef __ASSEMBLY__
 #include <asm/io.h>

/* CPU detection macros */

arch/arm/include/asm/arch-exynos/dmc.h +0 -0
index f65c676..b947de1 100644

arch/arm/include/asm/arch-exynos/dmc.h struct exynos4_dmc { · line 121

Quoted 8 lines
arch/arm/include/asm/arch-exynos/dmc.h +4 -0
@@ -114,13 +114,22 @@ struct exynos4_dmc {
 struct exynos5_dmc {
        unsigned int concontrol;
        unsigned int memcontrol;
+
+/* Between 5250 and 5420, the DMC Register differs only at 0x8 offset.
+ * So to use the same structure and simplify the code put a define to
+ * distinguish between memconfig0 and cgcontrol register */
 

please fix multiline comment.

Quoted 191 lines
arch/arm/include/asm/arch-exynos/dmc.h +8 -3
+#ifdef CONFIG_EXYNOS5250
        unsigned int memconfig0;
+#else
+       unsigned int cgcontrol;
+#endif
        unsigned int memconfig1;
        unsigned int directcmd;
-       unsigned int prechconfig;
+       unsigned int prechconfig0;
        unsigned int phycontrol0;
-       unsigned char res1[0xc];
-       unsigned int pwrdnconfig;
+       unsigned int prechconfig1;
+       unsigned char res1[0x8];
+       unsigned int pwrdnconfig;       /* 0x0028*/
        unsigned int timingpzq;
        unsigned int timingref;
        unsigned int timingrow;
arch/arm/include/asm/arch-exynos/dmc.h +77 -29
@@ -128,12 +137,12 @@ struct exynos5_dmc {
        unsigned int timingpower;
        unsigned int phystatus;
        unsigned char res2[0x4];
-       unsigned int chipstatus_ch0;
+       unsigned int chipstatus_ch0;    /* 0x0048 */
        unsigned int chipstatus_ch1;
        unsigned char res3[0x4];
        unsigned int mrstatus;
        unsigned char res4[0x8];
-       unsigned int qoscontrol0;
+       unsigned int qoscontrol0;       /* 0x0060 */
        unsigned char resr5[0x4];
        unsigned int qoscontrol1;
        unsigned char res6[0x4];
@@ -164,45 +173,83 @@ struct exynos5_dmc {
        unsigned int qoscontrol14;
        unsigned char res19[0x4];
        unsigned int qoscontrol15;
-       unsigned char res20[0x14];
+       unsigned char res20[0x4];
+       unsigned int timing_set_sw;     /* 0x00e0 */
+       unsigned int timingrow1;
+       unsigned int timingdata1;
+       unsigned int timingpower1;
        unsigned int ivcontrol;
        unsigned int wrtra_config;
        unsigned int rdlvl_config;
-       unsigned char res21[0x8];
+       unsigned char res21[0x4];
+       unsigned int brbrsvcontrol;     /* 0x0100*/
        unsigned int brbrsvconfig;
        unsigned int brbqosconfig;
        unsigned int membaseconfig0;
-       unsigned int membaseconfig1;
+       unsigned int membaseconfig1;    /* 0x0110 */
        unsigned char res22[0xc];
-       unsigned int wrlvl_config;
-       unsigned char res23[0xc];
-       unsigned int perevcontrol;
+       unsigned int wrlvl_config0;     /* 0x0120 */
+       unsigned int wrlvl_config1;
+       unsigned int wrlvl_status;
+       unsigned char res23[0x4];
+       unsigned int perevcontrol;      /* 0x0130 */
        unsigned int perev0config;
        unsigned int perev1config;
        unsigned int perev2config;
        unsigned int perev3config;
-       unsigned char res24[0xdebc];
-       unsigned int pmnc_ppc_a;
-       unsigned char res25[0xc];
-       unsigned int cntens_ppc_a;
-       unsigned char res26[0xc];
-       unsigned int cntenc_ppc_a;
-       unsigned char res27[0xc];
-       unsigned int intens_ppc_a;
-       unsigned char res28[0xc];
-       unsigned int intenc_ppc_a;
-       unsigned char res29[0xc];
-       unsigned int flag_ppc_a;
-       unsigned char res30[0xac];
-       unsigned int ccnt_ppc_a;
-       unsigned char res31[0xc];
-       unsigned int pmcnt0_ppc_a;
+       unsigned char res22a[0xc];
+       unsigned int ctrl_io_rdata_ch0;
+       unsigned int ctrl_io_rdata_ch1;
+       unsigned char res23a[0x8];
+       unsigned int cacal_config0;
+       unsigned int cacal_config1;
+       unsigned int cacal_status;
+       unsigned char res24[0x94];
+       unsigned int emergent_config0;  /* 0x0200 */
+       unsigned int emergent_config1;
+       unsigned char res25[0x8];
+       unsigned int bp_control0;
+       unsigned int bp_control0_r;
+       unsigned int bp_control0_w;
+       unsigned char res26[0x4];
+       unsigned int bp_control1;
+       unsigned int bp_control1_r;
+       unsigned int bp_control1_w;
+       unsigned char res27[0x4];
+       unsigned int bp_control2;
+       unsigned int bp_control2_r;
+       unsigned int bp_control2_w;
+       unsigned char res28[0x4];
+       unsigned int bp_control3;
+       unsigned int bp_control3_r;
+       unsigned int bp_control3_w;
+       unsigned char res29[0xb4];
+       unsigned int winconfig_odt_w;   /* 0x0300 */
+       unsigned char res30[0x4];
+       unsigned int winconfig_ctrl_read;
+       unsigned int winconfig_ctrl_gate;
+       unsigned char res31[0xdcf0];
+       unsigned int pmnc_ppc;
        unsigned char res32[0xc];
-       unsigned int pmcnt1_ppc_a;
+       unsigned int cntens_ppc;
        unsigned char res33[0xc];
-       unsigned int pmcnt2_ppc_a;
+       unsigned int cntenc_ppc;
        unsigned char res34[0xc];
-       unsigned int pmcnt3_ppc_a;
+       unsigned int intens_ppc;
+       unsigned char res35[0xc];
+       unsigned int intenc_ppc;
+       unsigned char res36[0xc];
+       unsigned int flag_ppc;          /* 0xe050 */
+       unsigned char res37[0xac];
+       unsigned int ccnt_ppc;
+       unsigned char res38[0xc];
+       unsigned int pmcnt0_ppc;
+       unsigned char res39[0xc];
+       unsigned int pmcnt1_ppc;
+       unsigned char res40[0xc];
+       unsigned int pmcnt2_ppc;
+       unsigned char res41[0xc];
+       unsigned int pmcnt3_ppc;        /* 0xe140 */
 };
 
 struct exynos5_phy_control {
@@ -211,13 +258,13 @@ struct exynos5_phy_control {
        unsigned int phy_con2;
        unsigned int phy_con3;
        unsigned int phy_con4;
-       unsigned char res1[4];
+       unsigned int phy_con5;
        unsigned int phy_con6;
        unsigned char res2[4];
        unsigned int phy_con8;
        unsigned int phy_con9;
        unsigned int phy_con10;
-       unsigned char res3[4];
+       unsigned int phy_con11;
        unsigned int phy_con12;
        unsigned int phy_con13;
        unsigned int phy_con14;
@@ -252,6 +299,15 @@ struct exynos5_phy_control {
        unsigned int phy_con42;
 };
 
+struct exynos5_tzasc {
+       unsigned char res1[0xf00];
+       unsigned int membaseconfig0;
+       unsigned int membaseconfig1;
+       unsigned char res2[0x8];
+       unsigned int memconfig0;
+       unsigned int memconfig1;
+};
+
 enum ddr_mode {
        DDR_MODE_DDR2,
        DDR_MODE_DDR3,
@@ -286,6 +342,7 @@ enum mem_manuf {
 #define PHY_CON0_T_WRRDCMD_SHIFT       17
 #define PHY_CON0_T_WRRDCMD_MASK                (0x7 <<
 PHY_CON0_T_WRRDCMD_SHIFT)
 #define PHY_CON0_CTRL_DDR_MODE_SHIFT   11
+#define PHY_CON0_CTRL_DDR_MODE_MASK    0x3
 
 /* PHY_CON1 register fields */

#define PHY_CON1_RDLVL_RDDATA_ADJ_SHIFT 0
--
1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
from. prom.
www.promsoft.net
#16 lore raw

PATCH v6 5/10 Exynos5420: Add support for 5420 in pinmux and gpio

In reply to Rajeshwari S Shinde

Adds code in pinmux and gpio framework to support Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added correct calculation of gpio based addresses.
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/pinmux.c        | 241 +++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/gpio.h   | 143 ++++++++++++++++--
 arch/arm/include/asm/arch-exynos/periph.h |   3 +
 3 files changed, 372 insertions(+), 15 deletions(-)
arch/arm/cpu/armv7/exynos/pinmux.c +240 -1
index 8002bce..417ecae 100644
@@ -46,6 +46,41 @@ static void exynos5_uart_config(int peripheral)
 	}
 }
 
+static void exynos5420_uart_config(int peripheral)
+{
+	struct exynos5420_gpio_part1 *gpio1 =
+		(struct exynos5420_gpio_part1 *)samsung_get_base_gpio_part1();
+	struct s5p_gpio_bank *bank;
+	int i, start, count;
+
+	switch (peripheral) {
+	case PERIPH_ID_UART0:
+		bank = &gpio1->a0;
+		start = 0;
+		count = 4;
+		break;
+	case PERIPH_ID_UART1:
+		bank = &gpio1->a0;
+		start = 4;
+		count = 4;
+		break;
+	case PERIPH_ID_UART2:
+		bank = &gpio1->a1;
+		start = 0;
+		count = 4;
+		break;
+	case PERIPH_ID_UART3:
+		bank = &gpio1->a1;
+		start = 4;
+		count = 2;
+		break;
+	}
+	for (i = start; i < start + count; i++) {
+		s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+		s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+	}
+}
+
 static int exynos5_mmc_config(int peripheral, int flags)
 {
 	struct exynos5_gpio_part1 *gpio1 =
@@ -101,6 +136,70 @@ static int exynos5_mmc_config(int peripheral, int flags)
 	return 0;
 }
 
+static int exynos5420_mmc_config(int peripheral, int flags)
+{
+	struct exynos5420_gpio_part3 *gpio3 =
+		(struct exynos5420_gpio_part3 *)samsung_get_base_gpio_part3();
+	struct s5p_gpio_bank *bank = NULL, *bank_ext = NULL;
+	int i, start = 0, gpio_func = 0;
+
+	switch (peripheral) {
+	case PERIPH_ID_SDMMC0:
+		bank = &gpio3->c0;
+		bank_ext = &gpio3->c3;
+		start = 0;
+		gpio_func = GPIO_FUNC(0x2);
+		break;
+	case PERIPH_ID_SDMMC1:
+		bank = &gpio3->c1;
+		bank_ext = &gpio3->d1;
+		start = 4;
+		gpio_func = GPIO_FUNC(0x2);
+		break;
+	case PERIPH_ID_SDMMC2:
+		bank = &gpio3->c2;
+		bank_ext = NULL;
+		gpio_func = GPIO_FUNC(0x2);
+		break;
+	}
+	if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
+		debug("SDMMC device %d does not support 8bit mode",
+		      peripheral);
+		return -1;
+	}
+	if (flags & PINMUX_FLAG_8BIT_MODE) {
+		for (i = start; i <= (start + 3); i++) {
+			s5p_gpio_cfg_pin(bank_ext, i, gpio_func);
+			s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
+			s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+		}
+	}
+	for (i = 0; i < 3; i++) {
+		/*
+		 * MMC0 is intended to be used for eMMC. The
+		 * card detect pin is used as a VDDEN signal to
+		 * power on the eMMC. The 5420 iROM makes
+		 * this same assumption.
+		 */
+		if ((peripheral == PERIPH_ID_SDMMC0) && (i == 2)) {
+			s5p_gpio_set_value(bank, i, 1);
+			s5p_gpio_cfg_pin(bank, i, GPIO_OUTPUT);
+		} else {
+			s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+		}
+		s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+		s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+	}
+
+	for (i = 3; i <= 6; i++) {
+		s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+		s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
+		s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+	}
+
+	return 0;
+}
+
 static void exynos5_sromc_config(int flags)
 {
 	struct exynos5_gpio_part1 *gpio1 =
@@ -216,6 +315,59 @@ static void exynos5_i2c_config(int peripheral, int flags)
 	}
 }
 
+static void exynos5420_i2c_config(int peripheral)
+{
+	struct exynos5420_gpio_part1 *gpio1 =
+		(struct exynos5420_gpio_part1 *)samsung_get_base_gpio_part1();
+
+	switch (peripheral) {
+	case PERIPH_ID_I2C0:
+		s5p_gpio_cfg_pin(&gpio1->b3, 0, GPIO_FUNC(0x2));
+		s5p_gpio_cfg_pin(&gpio1->b3, 1, GPIO_FUNC(0x2));
+		break;
+	case PERIPH_ID_I2C1:
+		s5p_gpio_cfg_pin(&gpio1->b3, 2, GPIO_FUNC(0x2));
+		s5p_gpio_cfg_pin(&gpio1->b3, 3, GPIO_FUNC(0x2));
+		break;
+	case PERIPH_ID_I2C2:
+		s5p_gpio_cfg_pin(&gpio1->a0, 6, GPIO_FUNC(0x3));
+		s5p_gpio_cfg_pin(&gpio1->a0, 7, GPIO_FUNC(0x3));
+		break;
+	case PERIPH_ID_I2C3:
+		s5p_gpio_cfg_pin(&gpio1->a1, 2, GPIO_FUNC(0x3));
+		s5p_gpio_cfg_pin(&gpio1->a1, 3, GPIO_FUNC(0x3));
+		break;
+	case PERIPH_ID_I2C4:
+		s5p_gpio_cfg_pin(&gpio1->a2, 0, GPIO_FUNC(0x3));
+		s5p_gpio_cfg_pin(&gpio1->a2, 1, GPIO_FUNC(0x3));
+		break;
+	case PERIPH_ID_I2C5:
+		s5p_gpio_cfg_pin(&gpio1->a2, 2, GPIO_FUNC(0x3));
+		s5p_gpio_cfg_pin(&gpio1->a2, 3, GPIO_FUNC(0x3));
+		break;
+	case PERIPH_ID_I2C6:
+		s5p_gpio_cfg_pin(&gpio1->b1, 3, GPIO_FUNC(0x4));
+		s5p_gpio_cfg_pin(&gpio1->b1, 4, GPIO_FUNC(0x4));
+		break;
+	case PERIPH_ID_I2C7:
+		s5p_gpio_cfg_pin(&gpio1->b2, 2, GPIO_FUNC(0x3));
+		s5p_gpio_cfg_pin(&gpio1->b2, 3, GPIO_FUNC(0x3));
+		break;
+	case PERIPH_ID_I2C8:
+		s5p_gpio_cfg_pin(&gpio1->b3, 4, GPIO_FUNC(0x2));
+		s5p_gpio_cfg_pin(&gpio1->b3, 5, GPIO_FUNC(0x2));
+		break;
+	case PERIPH_ID_I2C9:
+		s5p_gpio_cfg_pin(&gpio1->b3, 6, GPIO_FUNC(0x2));
+		s5p_gpio_cfg_pin(&gpio1->b3, 7, GPIO_FUNC(0x2));
+		break;
+	case PERIPH_ID_I2C10:
+		s5p_gpio_cfg_pin(&gpio1->b4, 0, GPIO_FUNC(0x2));
+		s5p_gpio_cfg_pin(&gpio1->b4, 1, GPIO_FUNC(0x2));
+		break;
+	}
+}
+
 static void exynos5_i2s_config(int peripheral)
 {
 	int i;
@@ -279,6 +431,49 @@ void exynos5_spi_config(int peripheral)
 	}
 }
 
+void exynos5420_spi_config(int peripheral)
+{
+	int cfg = 0, pin = 0, i;
+	struct s5p_gpio_bank *bank = NULL;
+	struct exynos5420_gpio_part1 *gpio1 =
+		(struct exynos5420_gpio_part1 *)samsung_get_base_gpio_part1();
+	struct exynos5420_gpio_part4 *gpio4 =
+		(struct exynos5420_gpio_part4 *)samsung_get_base_gpio_part4();
+
+	switch (peripheral) {
+	case PERIPH_ID_SPI0:
+		bank = &gpio1->a2;
+		cfg = GPIO_FUNC(0x2);
+		pin = 0;
+		break;
+	case PERIPH_ID_SPI1:
+		bank = &gpio1->a2;
+		cfg = GPIO_FUNC(0x2);
+		pin = 4;
+		break;
+	case PERIPH_ID_SPI2:
+		bank = &gpio1->b1;
+		cfg = GPIO_FUNC(0x5);
+		pin = 1;
+		break;
+	case PERIPH_ID_SPI3:
+		bank = &gpio4->f1;
+		cfg = GPIO_FUNC(0x2);
+		pin = 0;
+		break;
+	case PERIPH_ID_SPI4:
+		for (i = 0; i < 2; i++) {
+			s5p_gpio_cfg_pin(&gpio4->f0, i + 2, GPIO_FUNC(0x4));
+			s5p_gpio_cfg_pin(&gpio4->e0, i + 4, GPIO_FUNC(0x4));
+		}
+		break;
+	}
+	if (peripheral != PERIPH_ID_SPI4) {
+		for (i = pin; i < pin + 4; i++)
+			s5p_gpio_cfg_pin(bank, i, cfg);
+	}
+}
+
 static int exynos5_pinmux_config(int peripheral, int flags)
 {
 	switch (peripheral) {
@@ -325,6 +520,48 @@ static int exynos5_pinmux_config(int peripheral, int flags)
 	return 0;
 }
 
+static int exynos5420_pinmux_config(int peripheral, int flags)
+{
+	switch (peripheral) {
+	case PERIPH_ID_UART0:
+	case PERIPH_ID_UART1:
+	case PERIPH_ID_UART2:
+	case PERIPH_ID_UART3:
+		exynos5420_uart_config(peripheral);
+		break;
+	case PERIPH_ID_SDMMC0:
+	case PERIPH_ID_SDMMC1:
+	case PERIPH_ID_SDMMC2:
+	case PERIPH_ID_SDMMC3:
+		return exynos5420_mmc_config(peripheral, flags);
+	case PERIPH_ID_SPI0:
+	case PERIPH_ID_SPI1:
+	case PERIPH_ID_SPI2:
+	case PERIPH_ID_SPI3:
+	case PERIPH_ID_SPI4:
+		exynos5420_spi_config(peripheral);
+		break;
+	case PERIPH_ID_I2C0:
+	case PERIPH_ID_I2C1:
+	case PERIPH_ID_I2C2:
+	case PERIPH_ID_I2C3:
+	case PERIPH_ID_I2C4:
+	case PERIPH_ID_I2C5:
+	case PERIPH_ID_I2C6:
+	case PERIPH_ID_I2C7:
+	case PERIPH_ID_I2C8:
+	case PERIPH_ID_I2C9:
+	case PERIPH_ID_I2C10:
+		exynos5420_i2c_config(peripheral);
+		break;
+	default:
+		debug("%s: invalid peripheral %d", __func__, peripheral);
+		return -1;
+	}
+
+	return 0;
+}
+
 static void exynos4_i2c_config(int peripheral, int flags)
 {
 	struct exynos4_gpio_part1 *gpio1 =
@@ -474,7 +711,9 @@ static int exynos4_pinmux_config(int peripheral, int flags)
 
 int exynos_pinmux_config(int peripheral, int flags)
 {
-	if (cpu_is_exynos5()) {
+	if (proid_is_exynos5420()) {
+		return exynos5420_pinmux_config(peripheral, flags);
+	} else if (proid_is_exynos5250()) {
 		return exynos5_pinmux_config(peripheral, flags);
 	} else if (cpu_is_exynos4()) {
 		return exynos4_pinmux_config(peripheral, flags);
arch/arm/include/asm/arch-exynos/gpio.h +129 -14

164 lines not on this page · raw message

arch/arm/include/asm/arch-exynos/periph.h +3 -0
index 64bd8b7..30c7f18 100644
@@ -34,6 +34,9 @@ enum periph_id {
 	PERIPH_ID_SDMMC1,
 	PERIPH_ID_SDMMC2,
 	PERIPH_ID_SDMMC3,
+	PERIPH_ID_I2C8 = 87,
+	PERIPH_ID_I2C9,
+	PERIPH_ID_I2C10 = 203,
 	PERIPH_ID_I2S0 = 98,
 	PERIPH_ID_I2S1 = 99,
 
Signature · 1 line
1.7.12.4
#17 lore raw

PATCH v6 5/10 Exynos5420: Add support for 5420 in pinmux and gpio

Dear Rajeshwari S Shinde,

Quoted 51 lines · Rajeshwari S Shinde

Adds code in pinmux and gpio framework to support Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added correct calculation of gpio based addresses.
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/pinmux.c        | 241
+++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/gpio.h   | 143 ++++++++++++++++--
 arch/arm/include/asm/arch-exynos/periph.h |   3 +
 3 files changed, 372 insertions(+), 15 deletions(-)
arch/arm/cpu/armv7/exynos/pinmux.c +18 -0
index 8002bce..417ecae 100644
@@ -46,6 +46,41 @@ static void exynos5_uart_config(int peripheral)
        }
 }
 
+static void exynos5420_uart_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct s5p_gpio_bank *bank;
+       int i, start, count;
+
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+               bank = &gpio1->a0;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART1:
+               bank = &gpio1->a0;
+               start = 4;
+               count = 4;
+               break;

arch/arm/cpu/armv7/exynos/pinmux.c static void exynos5_uart_config(int peripheral) · line 77

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+       case PERIPH_ID_UART2:
+               bank = &gpio1->a1;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART3:
+               bank = &gpio1->a1;
+               start = 4;
+               count = 2;
+               break;

+ }

Quoted 1 line

please add blank line.

Quoted 12 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+       for (i = start; i < start + count; i++) {
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+       }
+}
+
 static int exynos5_mmc_config(int peripheral, int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -101,6 +136,70 @@ static int exynos5_mmc_config(int peripheral, int
 flags)
        return 0;

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int · line 147

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
 }
 
+static int exynos5420_mmc_config(int peripheral, int flags)
+{
+       struct exynos5420_gpio_part3 *gpio3 =
+               (struct exynos5420_gpio_part3
 *)samsung_get_base_gpio_part3();
+       struct s5p_gpio_bank *bank = NULL, *bank_ext = NULL;
+       int i, start = 0, gpio_func = 0;
 

I think we don' have to set to 0 to start and gpio_func.

Quoted 9 lines
arch/arm/cpu/armv7/exynos/pinmux.c +9 -0
+
+       switch (peripheral) {
+       case PERIPH_ID_SDMMC0:
+               bank = &gpio3->c0;
+               bank_ext = &gpio3->c3;
+               start = 0;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC1:

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 163

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+               bank = &gpio3->c1;
+               bank_ext = &gpio3->d1;
+               start = 4;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC2:
+               bank = &gpio3->c2;
+               bank_ext = NULL;
+               gpio_func = GPIO_FUNC(0x2);
+               break;

+ }

Quoted 1 line

please add blank line.

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 169

Quoted 6 lines
arch/arm/cpu/armv7/exynos/pinmux.c +5 -0
+       if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
+               debug("SDMMC device %d does not support 8bit mode",
+                     peripheral);
+               return -1;
+       }

please add blank line.

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 172

Quoted 4 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
+       if (flags & PINMUX_FLAG_8BIT_MODE) {
+               for (i = start; i <= (start + 3); i++) {
+                       s5p_gpio_cfg_pin(bank_ext, i, gpio_func);

gpio_func is always GPIO_FUNC(0x2).
I think gpio_func is unnecessary.

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 176

Quoted 5 lines
arch/arm/cpu/armv7/exynos/pinmux.c +4 -0
+                       s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
+                       s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+               }
+       }

please add blank line.

Quoted 92 lines
arch/arm/cpu/armv7/exynos/pinmux.c +79 -0
+       for (i = 0; i < 3; i++) {
+               /*
+                * MMC0 is intended to be used for eMMC. The
+                * card detect pin is used as a VDDEN signal to
+                * power on the eMMC. The 5420 iROM makes
+                * this same assumption.
+                */
+               if ((peripheral == PERIPH_ID_SDMMC0) && (i == 2)) {
+                       s5p_gpio_set_value(bank, i, 1);
+                       s5p_gpio_cfg_pin(bank, i, GPIO_OUTPUT);
+               } else {
+                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               }
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       for (i = 3; i <= 6; i++) {
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       return 0;
+}
+
 static void exynos5_sromc_config(int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -216,6 +315,59 @@ static void exynos5_i2c_config(int peripheral, int
 flags)
        }
 }
 
+static void exynos5420_i2c_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+
+       switch (peripheral) {
+       case PERIPH_ID_I2C0:
+               s5p_gpio_cfg_pin(&gpio1->b3, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 1, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C1:
+               s5p_gpio_cfg_pin(&gpio1->b3, 2, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 3, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C2:
+               s5p_gpio_cfg_pin(&gpio1->a0, 6, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a0, 7, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C3:
+               s5p_gpio_cfg_pin(&gpio1->a1, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a1, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C4:
+               s5p_gpio_cfg_pin(&gpio1->a2, 0, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 1, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C5:
+               s5p_gpio_cfg_pin(&gpio1->a2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C6:
+               s5p_gpio_cfg_pin(&gpio1->b1, 3, GPIO_FUNC(0x4));
+               s5p_gpio_cfg_pin(&gpio1->b1, 4, GPIO_FUNC(0x4));
+               break;
+       case PERIPH_ID_I2C7:
+               s5p_gpio_cfg_pin(&gpio1->b2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->b2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C8:
+               s5p_gpio_cfg_pin(&gpio1->b3, 4, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 5, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C9:
+               s5p_gpio_cfg_pin(&gpio1->b3, 6, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 7, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C10:
+               s5p_gpio_cfg_pin(&gpio1->b4, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b4, 1, GPIO_FUNC(0x2));
+               break;
+       }
+}
+
 static void exynos5_i2s_config(int peripheral)
 {
        int i;

arch/arm/cpu/armv7/exynos/pinmux.c void exynos5_spi_config(int peripheral) · line 437

Quoted 7 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
@@ -279,6 +431,49 @@ void exynos5_spi_config(int peripheral)
        }
 }
 
+void exynos5420_spi_config(int peripheral)
+{
+       int cfg = 0, pin = 0, i;
 

please don't set to 0 at here.
We should set some values at switch..case.

Quoted 32 lines
arch/arm/cpu/armv7/exynos/pinmux.c +30 -0
+       struct s5p_gpio_bank *bank = NULL;
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct exynos5420_gpio_part4 *gpio4 =
+               (struct exynos5420_gpio_part4
 *)samsung_get_base_gpio_part4();
+
+       switch (peripheral) {
+       case PERIPH_ID_SPI0:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI1:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 4;
+               break;
+       case PERIPH_ID_SPI2:
+               bank = &gpio1->b1;
+               cfg = GPIO_FUNC(0x5);
+               pin = 1;
+               break;
+       case PERIPH_ID_SPI3:
+               bank = &gpio4->f1;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI4:
+               for (i = 0; i < 2; i++) {
+                       s5p_gpio_cfg_pin(&gpio4->f0, i + 2,
Quoted 5 lines

GPIO_FUNC(0x4));
+ s5p_gpio_cfg_pin(&gpio4->e0, i + 4,
GPIO_FUNC(0x4));
+ }

OK. I understood SPI4 is different with other SPIs. but, it was another context.
just break and move it to out of this switch..case.

Quoted 1 line

+ break;

+ }

Quoted 1 line

please add blank line.

Quoted 60 lines
arch/arm/cpu/armv7/exynos/pinmux.c +48 -0
+       if (peripheral != PERIPH_ID_SPI4) {
+               for (i = pin; i < pin + 4; i++)
+                       s5p_gpio_cfg_pin(bank, i, cfg);
+       }
+}
+
 static int exynos5_pinmux_config(int peripheral, int flags)
 {
        switch (peripheral) {
@@ -325,6 +520,48 @@ static int exynos5_pinmux_config(int peripheral, int
 flags)
        return 0;
 }
 
+static int exynos5420_pinmux_config(int peripheral, int flags)
+{
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+       case PERIPH_ID_UART1:
+       case PERIPH_ID_UART2:
+       case PERIPH_ID_UART3:
+               exynos5420_uart_config(peripheral);
+               break;
+       case PERIPH_ID_SDMMC0:
+       case PERIPH_ID_SDMMC1:
+       case PERIPH_ID_SDMMC2:
+       case PERIPH_ID_SDMMC3:
+               return exynos5420_mmc_config(peripheral, flags);
+       case PERIPH_ID_SPI0:
+       case PERIPH_ID_SPI1:
+       case PERIPH_ID_SPI2:
+       case PERIPH_ID_SPI3:
+       case PERIPH_ID_SPI4:
+               exynos5420_spi_config(peripheral);
+               break;
+       case PERIPH_ID_I2C0:
+       case PERIPH_ID_I2C1:
+       case PERIPH_ID_I2C2:
+       case PERIPH_ID_I2C3:
+       case PERIPH_ID_I2C4:
+       case PERIPH_ID_I2C5:
+       case PERIPH_ID_I2C6:
+       case PERIPH_ID_I2C7:
+       case PERIPH_ID_I2C8:
+       case PERIPH_ID_I2C9:
+       case PERIPH_ID_I2C10:
+               exynos5420_i2c_config(peripheral);
+               break;
+       default:
+               debug("%s: invalid peripheral %d", __func__, peripheral);
+               return -1;
+       }
+
+       return 0;
+}
+
 static void exynos4_i2c_config(int peripheral, int flags)
 {

struct exynos4_gpio_part1 *gpio1 =

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos4_pinmux_config(int peripheral, int · line 718

Quoted 9 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -1
@@ -474,7 +711,9 @@ static int exynos4_pinmux_config(int peripheral, int
 flags)
 
 int exynos_pinmux_config(int peripheral, int flags)
 {
-       if (cpu_is_exynos5()) {
+       if (proid_is_exynos5420()) {
+               return exynos5420_pinmux_config(peripheral, flags);
+       } else if (proid_is_exynos5250()) {
 

please don't mix cpu_is.. and proid_is..

Quoted 199 lines
arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
                return exynos5_pinmux_config(peripheral, flags);
        } else if (cpu_is_exynos4()) {
                return exynos4_pinmux_config(peripheral, flags);
arch/arm/include/asm/arch-exynos/gpio.h +129 -14
index a1a7439..2a19852 100644
@@ -127,6 +127,58 @@ struct exynos4x12_gpio_part4 {
        struct s5p_gpio_bank v4;
 };
 
+struct exynos5420_gpio_part1 {
+       struct s5p_gpio_bank a0;
+       struct s5p_gpio_bank a1;
+       struct s5p_gpio_bank a2;
+       struct s5p_gpio_bank b0;
+       struct s5p_gpio_bank b1;
+       struct s5p_gpio_bank b2;
+       struct s5p_gpio_bank b3;
+       struct s5p_gpio_bank b4;
+       struct s5p_gpio_bank h0;
+};
+
+struct exynos5420_gpio_part2 {
+       struct s5p_gpio_bank y7; /* 0x1340_0000 */
+       struct s5p_gpio_bank res[0x5f]; /*  */
+       struct s5p_gpio_bank x0; /* 0x1340_0C00 */
+       struct s5p_gpio_bank x1; /* 0x1340_0C20 */
+       struct s5p_gpio_bank x2; /* 0x1340_0C40 */
+       struct s5p_gpio_bank x3; /* 0x1340_0C60 */
+};
+
+struct exynos5420_gpio_part3 {
+       struct s5p_gpio_bank c0;
+       struct s5p_gpio_bank c1;
+       struct s5p_gpio_bank c2;
+       struct s5p_gpio_bank c3;
+       struct s5p_gpio_bank c4;
+       struct s5p_gpio_bank d1;
+       struct s5p_gpio_bank y0;
+       struct s5p_gpio_bank y1;
+       struct s5p_gpio_bank y2;
+       struct s5p_gpio_bank y3;
+       struct s5p_gpio_bank y4;
+       struct s5p_gpio_bank y5;
+       struct s5p_gpio_bank y6;
+};
+
+struct exynos5420_gpio_part4 {
+       struct s5p_gpio_bank e0; /* 0x1400_0000 */
+       struct s5p_gpio_bank e1; /* 0x1400_0020 */
+       struct s5p_gpio_bank f0; /* 0x1400_0040 */
+       struct s5p_gpio_bank f1; /* 0x1400_0060 */
+       struct s5p_gpio_bank g0; /* 0x1400_0080 */
+       struct s5p_gpio_bank g1; /* 0x1400_00A0 */
+       struct s5p_gpio_bank g2; /* 0x1400_00C0 */
+       struct s5p_gpio_bank j4; /* 0x1400_00E0 */
+};
+
+struct exynos5420_gpio_part5 {
+       struct s5p_gpio_bank z0; /* 0x0386_0000 */
+};
+
 struct exynos5_gpio_part1 {
        struct s5p_gpio_bank a0;
        struct s5p_gpio_bank a1;
@@ -259,16 +311,67 @@ void s5p_gpio_set_rate(struct s5p_gpio_bank *bank,
 int gpio, int mode);
            - EXYNOS5_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
          * GPIO_PER_BANK) + pin) + EXYNOS5_GPIO_PART2_MAX)
 
+
+/* EXYNOS5420 */
+#define exynos5420_gpio_part1_get_nr(bank, pin) \
+       ((((((unsigned int) &(((struct exynos5420_gpio_part1 *)\
+                              EXYNOS5420_GPIO_PART1_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART1_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin)
+
+#define EXYNOS5420_GPIO_PART1_MAX ((sizeof(struct exynos5420_gpio_part1) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part2_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part2 *)\
+                               EXYNOS5420_GPIO_PART2_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART2_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART1_MAX)
+
+#define EXYNOS5420_GPIO_PART2_MAX ((sizeof(struct exynos5420_gpio_part2) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part3_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part3 *)\
+                               EXYNOS5420_GPIO_PART3_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART2_MAX)
+
+#define EXYNOS5420_GPIO_PART3_MAX ((sizeof(struct exynos5420_gpio_part3) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part4_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part4 *)\
+                               EXYNOS5420_GPIO_PART4_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART4_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART3_MAX)
+
+#define EXYNOS5420_GPIO_PART4_MAX ((sizeof(struct exynos5420_gpio_part4) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define EXYNOS5420_GPIO_PART5_MAX ((sizeof(struct exynos5420_gpio_part5) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
 static inline unsigned int s5p_gpio_base(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return EXYNOS5_GPIO_PART1_BASE;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART2_BASE;
-               else
-                       return EXYNOS5_GPIO_PART3_BASE;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return EXYNOS5420_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART2_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART3_BASE;
+                       else
+                               return EXYNOS5420_GPIO_PART4_BASE;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return EXYNOS5_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART2_BASE;
+                       else
+                               return EXYNOS5_GPIO_PART3_BASE;
+               }
        } else if (cpu_is_exynos4()) {
                if (nr < EXYNOS4_GPIO_PART1_MAX)
                        return EXYNOS4_GPIO_PART1_BASE;
@@ -282,13 +385,25 @@ static inline unsigned int s5p_gpio_base(int nr)
 static inline unsigned int s5p_gpio_part_max(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return 0;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART1_MAX;
-               else
-                       return EXYNOS5_GPIO_PART2_MAX;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART1_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART2_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART4_MAX)
+                               return EXYNOS5420_GPIO_PART3_MAX;
+                       else
+                               return EXYNOS5420_GPIO_PART4_MAX;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART1_MAX;
+                       else
+                               return EXYNOS5_GPIO_PART2_MAX;
+               }
        } else if (cpu_is_exynos4()) {
                if (proid_is_exynos4412()) {
                        if (nr < EXYNOS4X12_GPIO_PART1_MAX)
arch/arm/include/asm/arch-exynos/periph.h +3 -1
index 64bd8b7..30c7f18 100644
@@ -34,6 +34,9 @@ enum periph_id {
        PERIPH_ID_SDMMC1,
        PERIPH_ID_SDMMC2,
        PERIPH_ID_SDMMC3,
+       PERIPH_ID_I2C8 = 87,
+       PERIPH_ID_I2C9,
+       PERIPH_ID_I2C10 = 203,
        PERIPH_ID_I2S0 = 98,
        PERIPH_ID_I2S1 = 99,
 
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#18 lore raw

PATCH v6 5/10 Exynos5420: Add support for 5420 in pinmux and gpio

Hi Minkyu Kang,

Thank you for comments.

Quoted 70 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 51 lines · Rajeshwari S Shinde

Adds code in pinmux and gpio framework to support Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added correct calculation of gpio based addresses.
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/pinmux.c        | 241
+++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/gpio.h   | 143 ++++++++++++++++--
 arch/arm/include/asm/arch-exynos/periph.h |   3 +
 3 files changed, 372 insertions(+), 15 deletions(-)
arch/arm/cpu/armv7/exynos/pinmux.c +18 -0
index 8002bce..417ecae 100644
@@ -46,6 +46,41 @@ static void exynos5_uart_config(int peripheral)
        }
 }
 
+static void exynos5420_uart_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct s5p_gpio_bank *bank;
+       int i, start, count;
+
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+               bank = &gpio1->a0;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART1:
+               bank = &gpio1->a0;
+               start = 4;
+               count = 4;
+               break;

arch/arm/cpu/armv7/exynos/pinmux.c static void exynos5_uart_config(int peripheral) · line 77

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+       case PERIPH_ID_UART2:
+               bank = &gpio1->a1;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART3:
+               bank = &gpio1->a1;
+               start = 4;
+               count = 2;
+               break;

+ }

Quoted 1 line
Quoted 1 line

please add blank line.

will correct this

Quoted 16 lines
Quoted 16 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+       for (i = start; i < start + count; i++) {
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+       }
+}
+
 static int exynos5_mmc_config(int peripheral, int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -101,6 +136,70 @@ static int exynos5_mmc_config(int peripheral, int
 flags)
        return 0;
 }
 
Quoted 10 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags)

Quoted 8 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+static int exynos5420_mmc_config(int peripheral, int flags)
+{
+       struct exynos5420_gpio_part3 *gpio3 =
+               (struct exynos5420_gpio_part3
 *)samsung_get_base_gpio_part3();
+       struct s5p_gpio_bank *bank = NULL, *bank_ext = NULL;
+       int i, start = 0, gpio_func = 0;
 

I think we don' have to set to 0 to start and gpio_func.

Will remove gpio_func, but if I dont set start to 0 I get following error:

pinmux.c: In function ?exynos_pinmux_config?:
pinmux.c:173:20: warning: ?start? may be used uninitialized in this function [-Wmaybe-uninitialized]
pinmux.c:145:9: note: ?start? was declared here

Quoted 22 lines
Quoted 11 lines
arch/arm/cpu/armv7/exynos/pinmux.c +9 -0
+
+       switch (peripheral) {
+       case PERIPH_ID_SDMMC0:
+               bank = &gpio3->c0;
+               bank_ext = &gpio3->c3;
+               start = 0;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC1:

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 163

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+               bank = &gpio3->c1;
+               bank_ext = &gpio3->d1;
+               start = 4;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC2:
+               bank = &gpio3->c2;
+               bank_ext = NULL;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
Quoted 4 lines

+ }

Quoted 1 line

please add blank line.

Will correct this

Quoted 10 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 169

Quoted 8 lines
arch/arm/cpu/armv7/exynos/pinmux.c +5 -0
+       if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
+               debug("SDMMC device %d does not support 8bit mode",
+                     peripheral);
+               return -1;
+       }

please add blank line.

Will correct this

Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 172

Quoted 6 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
+       if (flags & PINMUX_FLAG_8BIT_MODE) {
+               for (i = start; i <= (start + 3); i++) {
+                       s5p_gpio_cfg_pin(bank_ext, i, gpio_func);

gpio_func is always GPIO_FUNC(0x2).
I think gpio_func is unnecessary.

will remove this

Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 176

Quoted 7 lines
arch/arm/cpu/armv7/exynos/pinmux.c +4 -0
+                       s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
+                       s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+               }
+       }

please add blank line.

Will correct this

Quoted 97 lines
Quoted 97 lines
arch/arm/cpu/armv7/exynos/pinmux.c +79 -0
+       for (i = 0; i < 3; i++) {
+               /*
+                * MMC0 is intended to be used for eMMC. The
+                * card detect pin is used as a VDDEN signal to
+                * power on the eMMC. The 5420 iROM makes
+                * this same assumption.
+                */
+               if ((peripheral == PERIPH_ID_SDMMC0) && (i == 2)) {
+                       s5p_gpio_set_value(bank, i, 1);
+                       s5p_gpio_cfg_pin(bank, i, GPIO_OUTPUT);
+               } else {
+                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               }
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       for (i = 3; i <= 6; i++) {
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       return 0;
+}
+
 static void exynos5_sromc_config(int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -216,6 +315,59 @@ static void exynos5_i2c_config(int peripheral, int
 flags)
        }
 }
 
+static void exynos5420_i2c_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+
+       switch (peripheral) {
+       case PERIPH_ID_I2C0:
+               s5p_gpio_cfg_pin(&gpio1->b3, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 1, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C1:
+               s5p_gpio_cfg_pin(&gpio1->b3, 2, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 3, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C2:
+               s5p_gpio_cfg_pin(&gpio1->a0, 6, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a0, 7, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C3:
+               s5p_gpio_cfg_pin(&gpio1->a1, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a1, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C4:
+               s5p_gpio_cfg_pin(&gpio1->a2, 0, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 1, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C5:
+               s5p_gpio_cfg_pin(&gpio1->a2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C6:
+               s5p_gpio_cfg_pin(&gpio1->b1, 3, GPIO_FUNC(0x4));
+               s5p_gpio_cfg_pin(&gpio1->b1, 4, GPIO_FUNC(0x4));
+               break;
+       case PERIPH_ID_I2C7:
+               s5p_gpio_cfg_pin(&gpio1->b2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->b2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C8:
+               s5p_gpio_cfg_pin(&gpio1->b3, 4, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 5, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C9:
+               s5p_gpio_cfg_pin(&gpio1->b3, 6, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 7, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C10:
+               s5p_gpio_cfg_pin(&gpio1->b4, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b4, 1, GPIO_FUNC(0x2));
+               break;
+       }
+}
+
 static void exynos5_i2s_config(int peripheral)
 {
        int i;
arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
@@ -279,6 +431,49 @@ void exynos5_spi_config(int peripheral)
        }
 }
 
Quoted 7 lines

arch/arm/cpu/armv7/exynos/pinmux.c void exynos5_spi_config(int peripheral)

Quoted 4 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
+void exynos5420_spi_config(int peripheral)
+{
+       int cfg = 0, pin = 0, i;
 

please don't set to 0 at here.
We should set some values at switch..case.

Get the following warning:
pinmux.c: In function ?exynos5420_spi_config?:
pinmux.c:471:3: warning: ?pin? may be used uninitialized in this function [-Wmaybe-uninitialized]
pinmux.c:472:20: warning: ?cfg? may be used uninitialized in this function [-Wmaybe-uninitialized]

Quoted 114 lines
Quoted 33 lines
arch/arm/cpu/armv7/exynos/pinmux.c +30 -0
+       struct s5p_gpio_bank *bank = NULL;
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct exynos5420_gpio_part4 *gpio4 =
+               (struct exynos5420_gpio_part4
 *)samsung_get_base_gpio_part4();
+
+       switch (peripheral) {
+       case PERIPH_ID_SPI0:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI1:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 4;
+               break;
+       case PERIPH_ID_SPI2:
+               bank = &gpio1->b1;
+               cfg = GPIO_FUNC(0x5);
+               pin = 1;
+               break;
+       case PERIPH_ID_SPI3:
+               bank = &gpio4->f1;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI4:
+               for (i = 0; i < 2; i++) {
+                       s5p_gpio_cfg_pin(&gpio4->f0, i + 2,
Quoted 5 lines

GPIO_FUNC(0x4));
+ s5p_gpio_cfg_pin(&gpio4->e0, i + 4,
GPIO_FUNC(0x4));
+ }

OK. I understood SPI4 is different with other SPIs. but, it was another context.
just break and move it to out of this switch..case.

Quoted 1 line

+ break;

+ }

Quoted 1 line

please add blank line.

Quoted 62 lines
arch/arm/cpu/armv7/exynos/pinmux.c +48 -0
+       if (peripheral != PERIPH_ID_SPI4) {
+               for (i = pin; i < pin + 4; i++)
+                       s5p_gpio_cfg_pin(bank, i, cfg);
+       }
+}
+
 static int exynos5_pinmux_config(int peripheral, int flags)
 {
        switch (peripheral) {
@@ -325,6 +520,48 @@ static int exynos5_pinmux_config(int peripheral, int
 flags)
        return 0;
 }
 
+static int exynos5420_pinmux_config(int peripheral, int flags)
+{
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+       case PERIPH_ID_UART1:
+       case PERIPH_ID_UART2:
+       case PERIPH_ID_UART3:
+               exynos5420_uart_config(peripheral);
+               break;
+       case PERIPH_ID_SDMMC0:
+       case PERIPH_ID_SDMMC1:
+       case PERIPH_ID_SDMMC2:
+       case PERIPH_ID_SDMMC3:
+               return exynos5420_mmc_config(peripheral, flags);
+       case PERIPH_ID_SPI0:
+       case PERIPH_ID_SPI1:
+       case PERIPH_ID_SPI2:
+       case PERIPH_ID_SPI3:
+       case PERIPH_ID_SPI4:
+               exynos5420_spi_config(peripheral);
+               break;
+       case PERIPH_ID_I2C0:
+       case PERIPH_ID_I2C1:
+       case PERIPH_ID_I2C2:
+       case PERIPH_ID_I2C3:
+       case PERIPH_ID_I2C4:
+       case PERIPH_ID_I2C5:
+       case PERIPH_ID_I2C6:
+       case PERIPH_ID_I2C7:
+       case PERIPH_ID_I2C8:
+       case PERIPH_ID_I2C9:
+       case PERIPH_ID_I2C10:
+               exynos5420_i2c_config(peripheral);
+               break;
+       default:
+               debug("%s: invalid peripheral %d", __func__, peripheral);
+               return -1;
+       }
+
+       return 0;
+}
+
 static void exynos4_i2c_config(int peripheral, int flags)
 {

struct exynos4_gpio_part1 *gpio1 =

arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
@@ -474,7 +711,9 @@ static int exynos4_pinmux_config(int peripheral, int
 flags)
 
Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos4_pinmux_config(int peripheral, int flags)

Quoted 7 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -1
 int exynos_pinmux_config(int peripheral, int flags)
 {
-       if (cpu_is_exynos5()) {
+       if (proid_is_exynos5420()) {
+               return exynos5420_pinmux_config(peripheral, flags);
+       } else if (proid_is_exynos5250()) {
 

please don't mix cpu_is.. and proid_is..

Will correct this.

Quoted 218 lines
Quoted 201 lines
arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
                return exynos5_pinmux_config(peripheral, flags);
        } else if (cpu_is_exynos4()) {
                return exynos4_pinmux_config(peripheral, flags);
arch/arm/include/asm/arch-exynos/gpio.h +129 -14
index a1a7439..2a19852 100644
@@ -127,6 +127,58 @@ struct exynos4x12_gpio_part4 {
        struct s5p_gpio_bank v4;
 };
 
+struct exynos5420_gpio_part1 {
+       struct s5p_gpio_bank a0;
+       struct s5p_gpio_bank a1;
+       struct s5p_gpio_bank a2;
+       struct s5p_gpio_bank b0;
+       struct s5p_gpio_bank b1;
+       struct s5p_gpio_bank b2;
+       struct s5p_gpio_bank b3;
+       struct s5p_gpio_bank b4;
+       struct s5p_gpio_bank h0;
+};
+
+struct exynos5420_gpio_part2 {
+       struct s5p_gpio_bank y7; /* 0x1340_0000 */
+       struct s5p_gpio_bank res[0x5f]; /*  */
+       struct s5p_gpio_bank x0; /* 0x1340_0C00 */
+       struct s5p_gpio_bank x1; /* 0x1340_0C20 */
+       struct s5p_gpio_bank x2; /* 0x1340_0C40 */
+       struct s5p_gpio_bank x3; /* 0x1340_0C60 */
+};
+
+struct exynos5420_gpio_part3 {
+       struct s5p_gpio_bank c0;
+       struct s5p_gpio_bank c1;
+       struct s5p_gpio_bank c2;
+       struct s5p_gpio_bank c3;
+       struct s5p_gpio_bank c4;
+       struct s5p_gpio_bank d1;
+       struct s5p_gpio_bank y0;
+       struct s5p_gpio_bank y1;
+       struct s5p_gpio_bank y2;
+       struct s5p_gpio_bank y3;
+       struct s5p_gpio_bank y4;
+       struct s5p_gpio_bank y5;
+       struct s5p_gpio_bank y6;
+};
+
+struct exynos5420_gpio_part4 {
+       struct s5p_gpio_bank e0; /* 0x1400_0000 */
+       struct s5p_gpio_bank e1; /* 0x1400_0020 */
+       struct s5p_gpio_bank f0; /* 0x1400_0040 */
+       struct s5p_gpio_bank f1; /* 0x1400_0060 */
+       struct s5p_gpio_bank g0; /* 0x1400_0080 */
+       struct s5p_gpio_bank g1; /* 0x1400_00A0 */
+       struct s5p_gpio_bank g2; /* 0x1400_00C0 */
+       struct s5p_gpio_bank j4; /* 0x1400_00E0 */
+};
+
+struct exynos5420_gpio_part5 {
+       struct s5p_gpio_bank z0; /* 0x0386_0000 */
+};
+
 struct exynos5_gpio_part1 {
        struct s5p_gpio_bank a0;
        struct s5p_gpio_bank a1;
@@ -259,16 +311,67 @@ void s5p_gpio_set_rate(struct s5p_gpio_bank *bank,
 int gpio, int mode);
            - EXYNOS5_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
          * GPIO_PER_BANK) + pin) + EXYNOS5_GPIO_PART2_MAX)
 
+
+/* EXYNOS5420 */
+#define exynos5420_gpio_part1_get_nr(bank, pin) \
+       ((((((unsigned int) &(((struct exynos5420_gpio_part1 *)\
+                              EXYNOS5420_GPIO_PART1_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART1_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin)
+
+#define EXYNOS5420_GPIO_PART1_MAX ((sizeof(struct exynos5420_gpio_part1) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part2_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part2 *)\
+                               EXYNOS5420_GPIO_PART2_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART2_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART1_MAX)
+
+#define EXYNOS5420_GPIO_PART2_MAX ((sizeof(struct exynos5420_gpio_part2) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part3_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part3 *)\
+                               EXYNOS5420_GPIO_PART3_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART2_MAX)
+
+#define EXYNOS5420_GPIO_PART3_MAX ((sizeof(struct exynos5420_gpio_part3) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part4_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part4 *)\
+                               EXYNOS5420_GPIO_PART4_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART4_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART3_MAX)
+
+#define EXYNOS5420_GPIO_PART4_MAX ((sizeof(struct exynos5420_gpio_part4) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define EXYNOS5420_GPIO_PART5_MAX ((sizeof(struct exynos5420_gpio_part5) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
 static inline unsigned int s5p_gpio_base(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return EXYNOS5_GPIO_PART1_BASE;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART2_BASE;
-               else
-                       return EXYNOS5_GPIO_PART3_BASE;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return EXYNOS5420_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART2_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART3_BASE;
+                       else
+                               return EXYNOS5420_GPIO_PART4_BASE;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return EXYNOS5_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART2_BASE;
+                       else
+                               return EXYNOS5_GPIO_PART3_BASE;
+               }
        } else if (cpu_is_exynos4()) {
                if (nr < EXYNOS4_GPIO_PART1_MAX)
                        return EXYNOS4_GPIO_PART1_BASE;
@@ -282,13 +385,25 @@ static inline unsigned int s5p_gpio_base(int nr)
 static inline unsigned int s5p_gpio_part_max(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return 0;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART1_MAX;
-               else
-                       return EXYNOS5_GPIO_PART2_MAX;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART1_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART2_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART4_MAX)
+                               return EXYNOS5420_GPIO_PART3_MAX;
+                       else
+                               return EXYNOS5420_GPIO_PART4_MAX;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART1_MAX;
+                       else
+                               return EXYNOS5_GPIO_PART2_MAX;
+               }
        } else if (cpu_is_exynos4()) {
                if (proid_is_exynos4412()) {
                        if (nr < EXYNOS4X12_GPIO_PART1_MAX)
arch/arm/include/asm/arch-exynos/periph.h +3 -1
index 64bd8b7..30c7f18 100644
@@ -34,6 +34,9 @@ enum periph_id {
        PERIPH_ID_SDMMC1,
        PERIPH_ID_SDMMC2,
        PERIPH_ID_SDMMC3,
+       PERIPH_ID_I2C8 = 87,
+       PERIPH_ID_I2C9,
+       PERIPH_ID_I2C10 = 203,
        PERIPH_ID_I2S0 = 98,
        PERIPH_ID_I2S1 = 99,
 
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
Regards,
Rajeshwari Shinde
#19 lore raw

PATCH v6 5/10 Exynos5420: Add support for 5420 in pinmux and gpio

Hi Minkyu Kang,

Quoted 400 lines · Rajeshwari Birje

Hi Minkyu Kang,

Thank you for comments.

Quoted 70 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 51 lines · Rajeshwari S Shinde

Adds code in pinmux and gpio framework to support Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added correct calculation of gpio based addresses.
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/pinmux.c        | 241
+++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/gpio.h   | 143 ++++++++++++++++--
 arch/arm/include/asm/arch-exynos/periph.h |   3 +
 3 files changed, 372 insertions(+), 15 deletions(-)
arch/arm/cpu/armv7/exynos/pinmux.c +18 -0
index 8002bce..417ecae 100644
@@ -46,6 +46,41 @@ static void exynos5_uart_config(int peripheral)
        }
 }
 
+static void exynos5420_uart_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct s5p_gpio_bank *bank;
+       int i, start, count;
+
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+               bank = &gpio1->a0;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART1:
+               bank = &gpio1->a0;
+               start = 4;
+               count = 4;
+               break;

arch/arm/cpu/armv7/exynos/pinmux.c static void exynos5_uart_config(int peripheral) · line 77

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+       case PERIPH_ID_UART2:
+               bank = &gpio1->a1;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART3:
+               bank = &gpio1->a1;
+               start = 4;
+               count = 2;
+               break;

+ }

Quoted 1 line
Quoted 1 line

please add blank line.

will correct this

Quoted 16 lines
Quoted 16 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+       for (i = start; i < start + count; i++) {
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+       }
+}
+
 static int exynos5_mmc_config(int peripheral, int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -101,6 +136,70 @@ static int exynos5_mmc_config(int peripheral, int
 flags)
        return 0;
 }
 
Quoted 10 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags)

Quoted 8 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+static int exynos5420_mmc_config(int peripheral, int flags)
+{
+       struct exynos5420_gpio_part3 *gpio3 =
+               (struct exynos5420_gpio_part3
 *)samsung_get_base_gpio_part3();
+       struct s5p_gpio_bank *bank = NULL, *bank_ext = NULL;
+       int i, start = 0, gpio_func = 0;
 

I think we don' have to set to 0 to start and gpio_func.

Will remove gpio_func, but if I dont set start to 0 I get following error:

pinmux.c: In function ?exynos_pinmux_config?:
pinmux.c:173:20: warning: ?start? may be used uninitialized in this function [-Wmaybe-uninitialized]
pinmux.c:145:9: note: ?start? was declared here

Quoted 22 lines
Quoted 11 lines
arch/arm/cpu/armv7/exynos/pinmux.c +9 -0
+
+       switch (peripheral) {
+       case PERIPH_ID_SDMMC0:
+               bank = &gpio3->c0;
+               bank_ext = &gpio3->c3;
+               start = 0;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC1:

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 163

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+               bank = &gpio3->c1;
+               bank_ext = &gpio3->d1;
+               start = 4;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
+       case PERIPH_ID_SDMMC2:
+               bank = &gpio3->c2;
+               bank_ext = NULL;
+               gpio_func = GPIO_FUNC(0x2);
+               break;
Quoted 4 lines

+ }

Quoted 1 line

please add blank line.

Will correct this

Quoted 10 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 169

Quoted 8 lines
arch/arm/cpu/armv7/exynos/pinmux.c +5 -0
+       if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
+               debug("SDMMC device %d does not support 8bit mode",
+                     peripheral);
+               return -1;
+       }

please add blank line.

Will correct this

Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 172

Quoted 6 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
+       if (flags & PINMUX_FLAG_8BIT_MODE) {
+               for (i = start; i <= (start + 3); i++) {
+                       s5p_gpio_cfg_pin(bank_ext, i, gpio_func);

gpio_func is always GPIO_FUNC(0x2).
I think gpio_func is unnecessary.

will remove this

Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags) · line 176

Quoted 7 lines
arch/arm/cpu/armv7/exynos/pinmux.c +4 -0
+                       s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
+                       s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+               }
+       }

please add blank line.

Will correct this

Quoted 97 lines
Quoted 97 lines
arch/arm/cpu/armv7/exynos/pinmux.c +79 -0
+       for (i = 0; i < 3; i++) {
+               /*
+                * MMC0 is intended to be used for eMMC. The
+                * card detect pin is used as a VDDEN signal to
+                * power on the eMMC. The 5420 iROM makes
+                * this same assumption.
+                */
+               if ((peripheral == PERIPH_ID_SDMMC0) && (i == 2)) {
+                       s5p_gpio_set_value(bank, i, 1);
+                       s5p_gpio_cfg_pin(bank, i, GPIO_OUTPUT);
+               } else {
+                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               }
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       for (i = 3; i <= 6; i++) {
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
+               s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+       }
+
+       return 0;
+}
+
 static void exynos5_sromc_config(int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -216,6 +315,59 @@ static void exynos5_i2c_config(int peripheral, int
 flags)
        }
 }
 
+static void exynos5420_i2c_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+
+       switch (peripheral) {
+       case PERIPH_ID_I2C0:
+               s5p_gpio_cfg_pin(&gpio1->b3, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 1, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C1:
+               s5p_gpio_cfg_pin(&gpio1->b3, 2, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 3, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C2:
+               s5p_gpio_cfg_pin(&gpio1->a0, 6, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a0, 7, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C3:
+               s5p_gpio_cfg_pin(&gpio1->a1, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a1, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C4:
+               s5p_gpio_cfg_pin(&gpio1->a2, 0, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 1, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C5:
+               s5p_gpio_cfg_pin(&gpio1->a2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->a2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C6:
+               s5p_gpio_cfg_pin(&gpio1->b1, 3, GPIO_FUNC(0x4));
+               s5p_gpio_cfg_pin(&gpio1->b1, 4, GPIO_FUNC(0x4));
+               break;
+       case PERIPH_ID_I2C7:
+               s5p_gpio_cfg_pin(&gpio1->b2, 2, GPIO_FUNC(0x3));
+               s5p_gpio_cfg_pin(&gpio1->b2, 3, GPIO_FUNC(0x3));
+               break;
+       case PERIPH_ID_I2C8:
+               s5p_gpio_cfg_pin(&gpio1->b3, 4, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 5, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C9:
+               s5p_gpio_cfg_pin(&gpio1->b3, 6, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b3, 7, GPIO_FUNC(0x2));
+               break;
+       case PERIPH_ID_I2C10:
+               s5p_gpio_cfg_pin(&gpio1->b4, 0, GPIO_FUNC(0x2));
+               s5p_gpio_cfg_pin(&gpio1->b4, 1, GPIO_FUNC(0x2));
+               break;
+       }
+}
+
 static void exynos5_i2s_config(int peripheral)
 {
        int i;
arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
@@ -279,6 +431,49 @@ void exynos5_spi_config(int peripheral)
        }
 }
 
Quoted 7 lines

arch/arm/cpu/armv7/exynos/pinmux.c void exynos5_spi_config(int peripheral)

Quoted 4 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -0
+void exynos5420_spi_config(int peripheral)
+{
+       int cfg = 0, pin = 0, i;
 

please don't set to 0 at here.
We should set some values at switch..case.

Get the following warning:
pinmux.c: In function ?exynos5420_spi_config?:
pinmux.c:471:3: warning: ?pin? may be used uninitialized in this function [-Wmaybe-uninitialized]
pinmux.c:472:20: warning: ?cfg? may be used uninitialized in this function [-Wmaybe-uninitialized]

Quoted 114 lines
Quoted 33 lines
arch/arm/cpu/armv7/exynos/pinmux.c +30 -0
+       struct s5p_gpio_bank *bank = NULL;
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct exynos5420_gpio_part4 *gpio4 =
+               (struct exynos5420_gpio_part4
 *)samsung_get_base_gpio_part4();
+
+       switch (peripheral) {
+       case PERIPH_ID_SPI0:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI1:
+               bank = &gpio1->a2;
+               cfg = GPIO_FUNC(0x2);
+               pin = 4;
+               break;
+       case PERIPH_ID_SPI2:
+               bank = &gpio1->b1;
+               cfg = GPIO_FUNC(0x5);
+               pin = 1;
+               break;
+       case PERIPH_ID_SPI3:
+               bank = &gpio4->f1;
+               cfg = GPIO_FUNC(0x2);
+               pin = 0;
+               break;
+       case PERIPH_ID_SPI4:
+               for (i = 0; i < 2; i++) {
+                       s5p_gpio_cfg_pin(&gpio4->f0, i + 2,
Quoted 5 lines

GPIO_FUNC(0x4));
+ s5p_gpio_cfg_pin(&gpio4->e0, i + 4,
GPIO_FUNC(0x4));
+ }

OK. I understood SPI4 is different with other SPIs. but, it was another context.
just break and move it to out of this switch..case.

Quoted 1 line

+ break;

+ }

Quoted 1 line

please add blank line.

Quoted 62 lines
arch/arm/cpu/armv7/exynos/pinmux.c +48 -0
+       if (peripheral != PERIPH_ID_SPI4) {
+               for (i = pin; i < pin + 4; i++)
+                       s5p_gpio_cfg_pin(bank, i, cfg);
+       }
+}
+
 static int exynos5_pinmux_config(int peripheral, int flags)
 {
        switch (peripheral) {
@@ -325,6 +520,48 @@ static int exynos5_pinmux_config(int peripheral, int
 flags)
        return 0;
 }
 
+static int exynos5420_pinmux_config(int peripheral, int flags)
+{
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+       case PERIPH_ID_UART1:
+       case PERIPH_ID_UART2:
+       case PERIPH_ID_UART3:
+               exynos5420_uart_config(peripheral);
+               break;
+       case PERIPH_ID_SDMMC0:
+       case PERIPH_ID_SDMMC1:
+       case PERIPH_ID_SDMMC2:
+       case PERIPH_ID_SDMMC3:
+               return exynos5420_mmc_config(peripheral, flags);
+       case PERIPH_ID_SPI0:
+       case PERIPH_ID_SPI1:
+       case PERIPH_ID_SPI2:
+       case PERIPH_ID_SPI3:
+       case PERIPH_ID_SPI4:
+               exynos5420_spi_config(peripheral);
+               break;
+       case PERIPH_ID_I2C0:
+       case PERIPH_ID_I2C1:
+       case PERIPH_ID_I2C2:
+       case PERIPH_ID_I2C3:
+       case PERIPH_ID_I2C4:
+       case PERIPH_ID_I2C5:
+       case PERIPH_ID_I2C6:
+       case PERIPH_ID_I2C7:
+       case PERIPH_ID_I2C8:
+       case PERIPH_ID_I2C9:
+       case PERIPH_ID_I2C10:
+               exynos5420_i2c_config(peripheral);
+               break;
+       default:
+               debug("%s: invalid peripheral %d", __func__, peripheral);
+               return -1;
+       }
+
+       return 0;
+}
+
 static void exynos4_i2c_config(int peripheral, int flags)
 {

struct exynos4_gpio_part1 *gpio1 =

arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
@@ -474,7 +711,9 @@ static int exynos4_pinmux_config(int peripheral, int
 flags)
 
Quoted 9 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos4_pinmux_config(int peripheral, int flags)

Quoted 7 lines
arch/arm/cpu/armv7/exynos/pinmux.c +3 -1
 int exynos_pinmux_config(int peripheral, int flags)
 {
-       if (cpu_is_exynos5()) {
+       if (proid_is_exynos5420()) {
+               return exynos5420_pinmux_config(peripheral, flags);
+       } else if (proid_is_exynos5250()) {
 

please don't mix cpu_is.. and proid_is..

Quoted 1 line

Will correct this.

Since we have both 5250 and 5420 in exynos5 used proid_is, to reduce a extra if loop.

Quoted 224 lines
Quoted 213 lines
Quoted 201 lines
arch/arm/cpu/armv7/exynos/pinmux.c +0 -0
                return exynos5_pinmux_config(peripheral, flags);
        } else if (cpu_is_exynos4()) {
                return exynos4_pinmux_config(peripheral, flags);
arch/arm/include/asm/arch-exynos/gpio.h +129 -14
index a1a7439..2a19852 100644
@@ -127,6 +127,58 @@ struct exynos4x12_gpio_part4 {
        struct s5p_gpio_bank v4;
 };
 
+struct exynos5420_gpio_part1 {
+       struct s5p_gpio_bank a0;
+       struct s5p_gpio_bank a1;
+       struct s5p_gpio_bank a2;
+       struct s5p_gpio_bank b0;
+       struct s5p_gpio_bank b1;
+       struct s5p_gpio_bank b2;
+       struct s5p_gpio_bank b3;
+       struct s5p_gpio_bank b4;
+       struct s5p_gpio_bank h0;
+};
+
+struct exynos5420_gpio_part2 {
+       struct s5p_gpio_bank y7; /* 0x1340_0000 */
+       struct s5p_gpio_bank res[0x5f]; /*  */
+       struct s5p_gpio_bank x0; /* 0x1340_0C00 */
+       struct s5p_gpio_bank x1; /* 0x1340_0C20 */
+       struct s5p_gpio_bank x2; /* 0x1340_0C40 */
+       struct s5p_gpio_bank x3; /* 0x1340_0C60 */
+};
+
+struct exynos5420_gpio_part3 {
+       struct s5p_gpio_bank c0;
+       struct s5p_gpio_bank c1;
+       struct s5p_gpio_bank c2;
+       struct s5p_gpio_bank c3;
+       struct s5p_gpio_bank c4;
+       struct s5p_gpio_bank d1;
+       struct s5p_gpio_bank y0;
+       struct s5p_gpio_bank y1;
+       struct s5p_gpio_bank y2;
+       struct s5p_gpio_bank y3;
+       struct s5p_gpio_bank y4;
+       struct s5p_gpio_bank y5;
+       struct s5p_gpio_bank y6;
+};
+
+struct exynos5420_gpio_part4 {
+       struct s5p_gpio_bank e0; /* 0x1400_0000 */
+       struct s5p_gpio_bank e1; /* 0x1400_0020 */
+       struct s5p_gpio_bank f0; /* 0x1400_0040 */
+       struct s5p_gpio_bank f1; /* 0x1400_0060 */
+       struct s5p_gpio_bank g0; /* 0x1400_0080 */
+       struct s5p_gpio_bank g1; /* 0x1400_00A0 */
+       struct s5p_gpio_bank g2; /* 0x1400_00C0 */
+       struct s5p_gpio_bank j4; /* 0x1400_00E0 */
+};
+
+struct exynos5420_gpio_part5 {
+       struct s5p_gpio_bank z0; /* 0x0386_0000 */
+};
+
 struct exynos5_gpio_part1 {
        struct s5p_gpio_bank a0;
        struct s5p_gpio_bank a1;
@@ -259,16 +311,67 @@ void s5p_gpio_set_rate(struct s5p_gpio_bank *bank,
 int gpio, int mode);
            - EXYNOS5_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
          * GPIO_PER_BANK) + pin) + EXYNOS5_GPIO_PART2_MAX)
 
+
+/* EXYNOS5420 */
+#define exynos5420_gpio_part1_get_nr(bank, pin) \
+       ((((((unsigned int) &(((struct exynos5420_gpio_part1 *)\
+                              EXYNOS5420_GPIO_PART1_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART1_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin)
+
+#define EXYNOS5420_GPIO_PART1_MAX ((sizeof(struct exynos5420_gpio_part1) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part2_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part2 *)\
+                               EXYNOS5420_GPIO_PART2_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART2_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART1_MAX)
+
+#define EXYNOS5420_GPIO_PART2_MAX ((sizeof(struct exynos5420_gpio_part2) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part3_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part3 *)\
+                               EXYNOS5420_GPIO_PART3_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART3_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART2_MAX)
+
+#define EXYNOS5420_GPIO_PART3_MAX ((sizeof(struct exynos5420_gpio_part3) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define exynos5420_gpio_part4_get_nr(bank, pin) \
+       (((((((unsigned int) &(((struct exynos5420_gpio_part4 *)\
+                               EXYNOS5420_GPIO_PART4_BASE)->bank)) \
+           - EXYNOS5420_GPIO_PART4_BASE) / sizeof(struct s5p_gpio_bank)) \
+         * GPIO_PER_BANK) + pin) + EXYNOS5420_GPIO_PART3_MAX)
+
+#define EXYNOS5420_GPIO_PART4_MAX ((sizeof(struct exynos5420_gpio_part4) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
+#define EXYNOS5420_GPIO_PART5_MAX ((sizeof(struct exynos5420_gpio_part5) \
+                           / sizeof(struct s5p_gpio_bank)) *
 GPIO_PER_BANK)
+
 static inline unsigned int s5p_gpio_base(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return EXYNOS5_GPIO_PART1_BASE;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART2_BASE;
-               else
-                       return EXYNOS5_GPIO_PART3_BASE;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return EXYNOS5420_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART2_BASE;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART3_BASE;
+                       else
+                               return EXYNOS5420_GPIO_PART4_BASE;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return EXYNOS5_GPIO_PART1_BASE;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART2_BASE;
+                       else
+                               return EXYNOS5_GPIO_PART3_BASE;
+               }
        } else if (cpu_is_exynos4()) {
                if (nr < EXYNOS4_GPIO_PART1_MAX)
                        return EXYNOS4_GPIO_PART1_BASE;
@@ -282,13 +385,25 @@ static inline unsigned int s5p_gpio_base(int nr)
 static inline unsigned int s5p_gpio_part_max(int nr)
 {
        if (cpu_is_exynos5()) {
-               if (nr < EXYNOS5_GPIO_PART1_MAX)
-                       return 0;
-               else if (nr < EXYNOS5_GPIO_PART2_MAX)
-                       return EXYNOS5_GPIO_PART1_MAX;
-               else
-                       return EXYNOS5_GPIO_PART2_MAX;
-
+               if (proid_is_exynos5420()) {
+                       if (nr < EXYNOS5420_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5420_GPIO_PART2_MAX)
+                               return EXYNOS5420_GPIO_PART1_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART3_MAX)
+                               return EXYNOS5420_GPIO_PART2_MAX;
+                       else if (nr < EXYNOS5420_GPIO_PART4_MAX)
+                               return EXYNOS5420_GPIO_PART3_MAX;
+                       else
+                               return EXYNOS5420_GPIO_PART4_MAX;
+               } else {
+                       if (nr < EXYNOS5_GPIO_PART1_MAX)
+                               return 0;
+                       else if (nr < EXYNOS5_GPIO_PART2_MAX)
+                               return EXYNOS5_GPIO_PART1_MAX;
+                       else
+                               return EXYNOS5_GPIO_PART2_MAX;
+               }
        } else if (cpu_is_exynos4()) {
                if (proid_is_exynos4412()) {
                        if (nr < EXYNOS4X12_GPIO_PART1_MAX)
arch/arm/include/asm/arch-exynos/periph.h +3 -1
index 64bd8b7..30c7f18 100644
@@ -34,6 +34,9 @@ enum periph_id {
        PERIPH_ID_SDMMC1,
        PERIPH_ID_SDMMC2,
        PERIPH_ID_SDMMC3,
+       PERIPH_ID_I2C8 = 87,
+       PERIPH_ID_I2C9,
+       PERIPH_ID_I2C10 = 203,
        PERIPH_ID_I2S0 = 98,
        PERIPH_ID_I2S1 = 99,
 
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Regards,
Rajeshwari Shinde

Signature · 2 lines
Regards,
Rajeshwari Shinde
#20 lore raw

PATCH v6 5/10 Exynos5420: Add support for 5420 in pinmux and gpio

In reply to Rajeshwari Birje
Quoted 104 lines · Rajeshwari Birje

Hi Minkyu Kang,

Thank you for comments.

Quoted 71 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 51 lines · On 29 October 2013 16:23, Rajeshwari S Shinde <[email protected] wrote:

Adds code in pinmux and gpio framework to support Exynos5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added correct calculation of gpio based addresses.
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/cpu/armv7/exynos/pinmux.c        | 241
+++++++++++++++++++++++++++++-
 arch/arm/include/asm/arch-exynos/gpio.h   | 143 ++++++++++++++++--
 arch/arm/include/asm/arch-exynos/periph.h |   3 +
 3 files changed, 372 insertions(+), 15 deletions(-)
arch/arm/cpu/armv7/exynos/pinmux.c +18 -0
index 8002bce..417ecae 100644
@@ -46,6 +46,41 @@ static void exynos5_uart_config(int peripheral)
        }
 }
 
+static void exynos5420_uart_config(int peripheral)
+{
+       struct exynos5420_gpio_part1 *gpio1 =
+               (struct exynos5420_gpio_part1
 *)samsung_get_base_gpio_part1();
+       struct s5p_gpio_bank *bank;
+       int i, start, count;
+
+       switch (peripheral) {
+       case PERIPH_ID_UART0:
+               bank = &gpio1->a0;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART1:
+               bank = &gpio1->a0;
+               start = 4;
+               count = 4;
+               break;

arch/arm/cpu/armv7/exynos/pinmux.c static void exynos5_uart_config(int peripheral) · line 77

Quoted 10 lines
arch/arm/cpu/armv7/exynos/pinmux.c +10 -0
+       case PERIPH_ID_UART2:
+               bank = &gpio1->a1;
+               start = 0;
+               count = 4;
+               break;
+       case PERIPH_ID_UART3:
+               bank = &gpio1->a1;
+               start = 4;
+               count = 2;
+               break;

+ }

Quoted 1 line
Quoted 1 line

please add blank line.

will correct this

Quoted 16 lines
Quoted 16 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+       for (i = start; i < start + count; i++) {
+               s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+               s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+       }
+}
+
 static int exynos5_mmc_config(int peripheral, int flags)
 {
        struct exynos5_gpio_part1 *gpio1 =
@@ -101,6 +136,70 @@ static int exynos5_mmc_config(int peripheral, int
 flags)
        return 0;
 }
 
Quoted 10 lines

arch/arm/cpu/armv7/exynos/pinmux.c static int exynos5_mmc_config(int peripheral, int flags)

Quoted 8 lines
arch/arm/cpu/armv7/exynos/pinmux.c +6 -0
+static int exynos5420_mmc_config(int peripheral, int flags)
+{
+       struct exynos5420_gpio_part3 *gpio3 =
+               (struct exynos5420_gpio_part3
 *)samsung_get_base_gpio_part3();
+       struct s5p_gpio_bank *bank = NULL, *bank_ext = NULL;
+       int i, start = 0, gpio_func = 0;
 

I think we don' have to set to 0 to start and gpio_func.

Quoted 7 lines

Will remove gpio_func, but if I dont set start to 0 I get following error:

pinmux.c: In function ?exynos_pinmux_config?:
pinmux.c:173:20: warning: ?start? may be used uninitialized in this function [-Wmaybe-uninitialized]
pinmux.c:145:9: note: ?start? was declared here

because you missing start = 0 at MMC2.
Actually I like to set values explicitly at every conditions instead of initial value.
It looks more clearly.

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#21 lore raw

PATCH v6 6/10 Exynos5420: Add base patch for SMDK5420

In reply to Rajeshwari S Shinde

Adding the base patch for Exynos based SMDK5420. This shall enable compilation and basic boot support for SMDK5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Rebased on latest u-boot-samsung tree.
Changes in V5:
- Removed functions board_eth_init and board_mmc_init as they were moved to common/board.c
Changes in V6:
- None

 board/samsung/common/board.c          |   2 +
 board/samsung/smdk5420/Makefile       |  34 ++++++++
 board/samsung/smdk5420/smdk5420.c     | 159 ++++++++++++++++++++++++++++++++++
 board/samsung/smdk5420/smdk5420_spl.c |  52 +++++++++++
 boards.cfg                            |   1 +
 tools/Makefile                        |   2 +
 6 files changed, 250 insertions(+)
 create mode 100644 board/samsung/smdk5420/Makefile
 create mode 100644 board/samsung/smdk5420/smdk5420.c
 create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
board/samsung/common/board.c +2 -0
index 9ebfc42..2512a59 100644
@@ -143,6 +143,7 @@ struct cros_ec_dev *board_get_cros_ec_dev(void)
 	return local.cros_ec_dev;
 }
 
+#ifdef CONFIG_CROS_EC
 static int board_init_cros_ec_devices(const void *blob)
 {
 	local.cros_ec_err = cros_ec_init(blob, &local.cros_ec_dev);
@@ -151,6 +152,7 @@ static int board_init_cros_ec_devices(const void *blob)
 
 	return 0;
 }
+#endif
 
 #if defined(CONFIG_POWER)
 #ifdef CONFIG_POWER_MAX77686
board/samsung/smdk5420/Makefile new file +34 -0
new file mode 100644
index 0000000..be538ec
@@ -0,0 +1,34 @@
+#
+# Copyright (C) 2013 Samsung Electronics
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	+= smdk5420_spl.o
+
+ifndef CONFIG_SPL_BUILD
+COBJS	+= smdk5420.o
+endif
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS) $(SOBJS))
+
+ALL	:=	 $(obj).depend $(LIB)
+
+all:	$(ALL)
+
+$(LIB):	$(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/samsung/smdk5420/smdk5420.c new file +159 -0

159 lines not on this page · raw message

board/samsung/smdk5420/smdk5420_spl.c new file +52 -0

52 lines not on this page · raw message

boards.cfg +1 -0
index aa2ee64..e476ebc 100644
@@ -272,6 +272,7 @@ Active  arm         armv7          exynos      samsung         arndale
 Active  arm         armv7          exynos      samsung         origen              origen                               -                                                                                                                                 Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         smdk5250            smdk5250                             -                                                                                                                                 Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         smdk5250            snow                                 -                                                                                                                                 Rajeshwari Shinde <[email protected]>
+Active  arm         armv7          exynos      samsung         smdk5420            smdk5420                                 -                                                                                                                                 Rajeshwari Shinde <[email protected]>
 Active  arm         armv7          exynos      samsung         smdkv310            smdkv310                             -                                                                                                                                 Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         trats               trats                                -                                                                                                                                 Lukasz Majewski <[email protected]>
 Active  arm         armv7          exynos      samsung         trats2              trats2                               -                                                                                                                                 Piotr Wilczek <[email protected]>
tools/Makefile +2 -0
index ca76f94..fcff6be 100644
@@ -53,6 +53,7 @@ BIN_FILES-$(CONFIG_XWAY_SWAP_BYTES) += xway-swap-bytes$(SFX)
 BIN_FILES-y += mkenvimage$(SFX)
 BIN_FILES-y += mkimage$(SFX)
 BIN_FILES-$(CONFIG_EXYNOS5250) += mk$(BOARD)spl$(SFX)
+BIN_FILES-$(CONFIG_EXYNOS5420) += mk$(BOARD)spl$(SFX)
 BIN_FILES-$(CONFIG_MX23) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
@@ -88,6 +89,7 @@ OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += envcrc.o
 OBJ_FILES-$(CONFIG_CMD_LOADS) += img2srec.o
 OBJ_FILES-$(CONFIG_CMD_NET) += gen_eth_addr.o
 OBJ_FILES-$(CONFIG_EXYNOS5250) += mkexynosspl.o
+OBJ_FILES-$(CONFIG_EXYNOS5420) += mkexynosspl.o
 OBJ_FILES-$(CONFIG_KIRKWOOD) += kwboot.o
 OBJ_FILES-$(CONFIG_LCD_LOGO) += bmp_logo.o
 OBJ_FILES-$(CONFIG_MX23) += mxsboot.o
Signature · 1 line
1.7.12.4
#22 lore raw

PATCH v6 6/10 Exynos5420: Add base patch for SMDK5420

Dear Rajeshwari S Shinde,

Quoted 368 lines · Rajeshwari S Shinde

Adding the base patch for Exynos based SMDK5420. This shall enable compilation and basic boot support for SMDK5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Rebased on latest u-boot-samsung tree.
Changes in V5:
- Removed functions board_eth_init and board_mmc_init as they were moved to common/board.c
Changes in V6:
- None

 board/samsung/common/board.c          |   2 +
 board/samsung/smdk5420/Makefile       |  34 ++++++++
 board/samsung/smdk5420/smdk5420.c     | 159
++++++++++++++++++++++++++++++++++
 board/samsung/smdk5420/smdk5420_spl.c |  52 +++++++++++
 boards.cfg                            |   1 +
 tools/Makefile                        |   2 +
 6 files changed, 250 insertions(+)
 create mode 100644 board/samsung/smdk5420/Makefile
 create mode 100644 board/samsung/smdk5420/smdk5420.c
 create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
board/samsung/common/board.c +2 -0
index 9ebfc42..2512a59 100644
@@ -143,6 +143,7 @@ struct cros_ec_dev *board_get_cros_ec_dev(void)
        return local.cros_ec_dev;
 }
 
+#ifdef CONFIG_CROS_EC
 static int board_init_cros_ec_devices(const void *blob)
 {
        local.cros_ec_err = cros_ec_init(blob, &local.cros_ec_dev);
@@ -151,6 +152,7 @@ static int board_init_cros_ec_devices(const void *blob)
 
        return 0;
 }
+#endif
 
 #if defined(CONFIG_POWER)
 #ifdef CONFIG_POWER_MAX77686
board/samsung/smdk5420/Makefile new file +34 -0
new file mode 100644
index 0000000..be538ec
@@ -0,0 +1,34 @@
+#
+# Copyright (C) 2013 Samsung Electronics
+#
+# SPDX-License-Identifier:     GPL-2.0+
+#
+
+include $(TOPDIR)/config.mk
+
+LIB    = $(obj)lib$(BOARD).o
+
+COBJS  += smdk5420_spl.o
+
+ifndef CONFIG_SPL_BUILD
+COBJS  += smdk5420.o
+endif
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS) $(SOBJS))
+
+ALL    :=       $(obj).depend $(LIB)
+
+all:   $(ALL)
+
+$(LIB):        $(OBJS)
+       $(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/samsung/smdk5420/smdk5420.c new file +25 -0
new file mode 100644
index 0000000..d85b953
@@ -0,0 +1,159 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <asm/io.h>
+#include <i2c.h>
+#include <lcd.h>
+#include <spi.h>
+#include <asm/arch/board.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/gpio.h>
+#include <asm/arch/pinmux.h>
+#include <asm/arch/dp_info.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#ifdef CONFIG_USB_EHCI_EXYNOS
+static int board_usb_vbus_init(void)
+{
+       struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *)
+

samsung_get_base_gpio_part1();

board/samsung/smdk5420/smdk5420.c new file +48 -0
+
+       /* Enable VBUS power switch */
+       s5p_gpio_direction_output(&gpio1->x2, 6, 1);
+
+       /* VBUS turn ON time */
+       mdelay(3);
+
+       return 0;
+}
+#endif
+
+int exynos_init(void)
+{
+#ifdef CONFIG_USB_EHCI_EXYNOS
+       board_usb_vbus_init();
+#endif
+       return 0;
+}
+
+#ifdef CONFIG_LCD
+void cfg_lcd_gpio(void)
+{
+       struct exynos5_gpio_part1 *gpio1 =
+               (struct exynos5_gpio_part1 *)samsung_get_base_gpio_part1();
+
+       /* For Backlight */
+       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
+       s5p_gpio_set_value(&gpio1->b2, 0, 1);
+
+       /* LCD power on */
+       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
+       s5p_gpio_set_value(&gpio1->x1, 5, 1);
+
+       /* Set Hotplug detect for DP */
+       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
+}
+
+vidinfo_t panel_info = {
+       .vl_freq        = 60,
+       .vl_col         = 2560,
+       .vl_row         = 1600,
+       .vl_width       = 2560,
+       .vl_height      = 1600,
+       .vl_clkp        = CONFIG_SYS_LOW,
+       .vl_hsp         = CONFIG_SYS_LOW,
+       .vl_vsp         = CONFIG_SYS_LOW,
+       .vl_dp          = CONFIG_SYS_LOW,
+       .vl_bpix        = 4,    /* LCD_BPP = 2^4, for output conosle on

LCD */

board/samsung/smdk5420/smdk5420.c new file +86 -0
+
+       /* wDP panel timing infomation */
+       .vl_hspw        = 32,
+       .vl_hbpd        = 80,
+       .vl_hfpd        = 48,
+
+       .vl_vspw        = 6,
+       .vl_vbpd        = 37,
+       .vl_vfpd        = 3,
+       .vl_cmd_allow_len = 0xf,
+
+       .win_id         = 3,
+       .cfg_gpio       = cfg_lcd_gpio,
+       .backlight_on   = NULL,
+       .lcd_power_on   = NULL,
+       .reset_lcd      = NULL,
+       .dual_lcd_enabled = 0,
+
+       .init_delay     = 0,
+       .power_on_delay = 0,
+       .reset_delay    = 0,
+       .interface_mode = FIMD_RGB_INTERFACE,
+       .dp_enabled     = 1,
+};
+
+static struct edp_device_info edp_info = {
+       .disp_info = {
+               .h_res = 2560,
+               .h_sync_width = 32,
+               .h_back_porch = 80,
+               .h_front_porch = 48,
+               .v_res = 1600,
+               .v_sync_width  = 6,
+               .v_back_porch = 37,
+               .v_front_porch = 3,
+               .v_sync_rate = 60,
+       },
+       .lt_info = {
+               .lt_status = DP_LT_NONE,
+       },
+       .video_info = {
+               .master_mode = 0,
+               .bist_mode = DP_DISABLE,
+               .bist_pattern = NO_PATTERN,
+               .h_sync_polarity = 0,
+               .v_sync_polarity = 0,
+               .interlaced = 0,
+               .color_space = COLOR_RGB,
+               .dynamic_range = VESA,
+               .ycbcr_coeff = COLOR_YCBCR601,
+               .color_depth = COLOR_8,
+       },
+};
+
+static struct exynos_dp_platform_data dp_platform_data = {
+       .phy_enable     = set_dp_phy_ctrl,
+       .edp_dev_info   = &edp_info,
+};
+
+void init_panel_info(vidinfo_t *vid)
+{
+       vid->rgb_mode   = MODE_RGB_P,
+
+       exynos_set_dp_platform_data(&dp_platform_data);
+}
+#endif
+
+int board_get_revision(void)
+{
+       return 0;
+}
+
+#ifdef CONFIG_DISPLAY_BOARDINFO
+int checkboard(void)
+{
+       const char *board_name;
+
+       board_name = fdt_getprop(gd->fdt_blob, 0, "model", NULL);
+       if (board_name == NULL)
+               printf("\nUnknown Board\n");
+       else
+               printf("\nBoard: %s\n", board_name);
+
+       return 0;
+}
+#endif
board/samsung/smdk5420/smdk5420_spl.c new file +30 -0
new file mode 100644
index 0000000..73359f7
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2013 The Chromium OS Authors.
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#include <common.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/spl.h>
+#include <asm/arch/clk.h>
+
+#define SIGNATURE      0xdeadbeef
+
+/* Parameters of early board initialization in SPL */
+static struct spl_machine_param machine_param
+               __attribute__((section(".machine_param"))) = {
+       .signature      = SIGNATURE,
+       .version        = 1,
+       .params         = "vmubfasirM",
+       .size           = sizeof(machine_param),
+
+       .mem_iv_size    = 0x1f,
+       .mem_type       = DDR_MODE_DDR3,
+
+       /*
+        * Set uboot_size to 0x100000 bytes.
+        *
+        * This is an overly conservative value chosen to accommodate all
+        * possible U-Boot image.  You are advised to set this value to a
+        * smaller realistic size via scripts that modifies the

.machine_param

board/samsung/smdk5420/smdk5420_spl.c new file +22 -0
+        * section of output U-Boot image.
+        */
+       .uboot_size     = 0x100000,
+
+       .boot_source    = BOOT_MODE_OM,
+       .frequency_mhz  = 800,
+       .arm_freq_mhz   = 900,
+       .serial_base    = 0x12c30000,
+       .i2c_base       = 0x12c60000,
+       .mem_manuf      = MEM_MANUF_SAMSUNG,
+};
+
+struct spl_machine_param *spl_get_machine_params(void)
+{
+       if (machine_param.signature != SIGNATURE) {
+               /* Will hang if SIGNATURE dont match */
+               while (1)
+                       ;
+       }
+
+       return &machine_param;
+}
boards.cfg +1 -0
index aa2ee64..e476ebc 100644
@@ -272,6 +272,7 @@ Active  arm         armv7          exynos      samsung
        arndale
 Active  arm         armv7          exynos      samsung         origen
         origen                               -
 
                        Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         smdk5250
         smdk5250                             -
 
                        Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         smdk5250
         snow                                 -
 
                        Rajeshwari Shinde <[email protected]>
+Active  arm         armv7          exynos      samsung         smdk5420
         smdk5420                                 -
 
                            Rajeshwari Shinde <[email protected]>
 Active  arm         armv7          exynos      samsung         smdkv310
         smdkv310                             -
 
                        Chander Kashyap <[email protected]>
 Active  arm         armv7          exynos      samsung         trats
          trats                                -
 
                          Lukasz Majewski <[email protected]>
 Active  arm         armv7          exynos      samsung         trats2
         trats2                               -
 
                        Piotr Wilczek <[email protected]>
tools/Makefile +1 -0
index ca76f94..fcff6be 100644
@@ -53,6 +53,7 @@ BIN_FILES-$(CONFIG_XWAY_SWAP_BYTES) +=
 xway-swap-bytes$(SFX)
 BIN_FILES-y += mkenvimage$(SFX)
 BIN_FILES-y += mkimage$(SFX)
 BIN_FILES-$(CONFIG_EXYNOS5250) += mk$(BOARD)spl$(SFX)
+BIN_FILES-$(CONFIG_EXYNOS5420) += mk$(BOARD)spl$(SFX)
 BIN_FILES-$(CONFIG_MX23) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)

BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)

tools/Makefile OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += envcrc.o · line 93

Quoted 5 lines
tools/Makefile +1 -0
@@ -88,6 +89,7 @@ OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += envcrc.o
 OBJ_FILES-$(CONFIG_CMD_LOADS) += img2srec.o
 OBJ_FILES-$(CONFIG_CMD_NET) += gen_eth_addr.o
 OBJ_FILES-$(CONFIG_EXYNOS5250) += mkexynosspl.o
+OBJ_FILES-$(CONFIG_EXYNOS5420) += mkexynosspl.o
 

How about use same configuration for making mkexynosspl? e.g) CONFIG_EXYNOS_SPL?

Quoted 11 lines
tools/Makefile +0 -0
 OBJ_FILES-$(CONFIG_KIRKWOOD) += kwboot.o
 OBJ_FILES-$(CONFIG_LCD_LOGO) += bmp_logo.o

OBJ_FILES-$(CONFIG_MX23) += mxsboot.o
--
1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#23 lore raw

PATCH v6 7/10 DTS: Add dts support for SMDK5420

In reply to Rajeshwari S Shinde

This patch adds support for SMDK5420.
exynos5.dtsi created is a common file which has the nodes common to both 5420 and 5250.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added /include/ "exynos5420.dtsi
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/dts/exynos5.dtsi                 | 211 ++++++++++++++++++++++++++++++
 arch/arm/dts/exynos5250.dtsi              | 178 +------------------------
 arch/arm/dts/exynos5420.dtsi              |  74 +++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts | 172 ++++++++++++++++++++++++
 4 files changed, 458 insertions(+), 177 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
arch/arm/dts/exynos5.dtsi new file +211 -0
new file mode 100644
index 0000000..de86a06
@@ -0,0 +1,211 @@
+/*
+ * SAMSUNG EXYNOS5 SoC device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * SAMSUNG EXYNOS5 SoC device nodes are listed in this file.
+ * EXYNOS5 based board files can include this file and provide
+ * values for board specfic bindings.
+ *
+ * Note: This file does not include device nodes for all the controllers in
+ * EXYNOS5 SoC. As device tree coverage for EXYNOS5 increases,
+ * additional nodes can be added to this file.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/include/ "skeleton.dtsi"
+
+/ {
+	compatible = "samsung,exynos5";
+
+	sromc at 12250000 {
+		compatible = "samsung,exynos-sromc";
+		reg = <0x12250000 0x20>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
+
+	i2c at 12c60000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C60000 0x100>;
+		interrupts = <0 56 0>;
+	};
+
+	i2c at 12c70000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C70000 0x100>;
+		interrupts = <0 57 0>;
+	};
+
+	i2c at 12c80000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C80000 0x100>;
+		interrupts = <0 58 0>;
+	};
+
+	i2c at 12c90000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,s3c2440-i2c";
+		reg = <0x12C90000 0x100>;
+		interrupts = <0 59 0>;
+	};
+
+	spi at 12d20000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos-spi";
+		reg = <0x12d20000 0x30>;
+		interrupts = <0 68 0>;
+	};
+
+	spi at 12d30000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos-spi";
+		reg = <0x12d30000 0x30>;
+		interrupts = <0 69 0>;
+	};
+
+	spi at 12d40000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos-spi";
+		reg = <0x12d40000 0x30>;
+		clock-frequency = <50000000>;
+		interrupts = <0 70 0>;
+        };
+
+	spi at 131a0000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos-spi";
+		reg = <0x131a0000 0x30>;
+		interrupts = <0 129 0>;
+	};
+
+	spi at 131b0000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos-spi";
+		reg = <0x131b0000 0x30>;
+		interrupts = <0 130 0>;
+	};
+
+	ehci at 12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		phy {
+			compatible = "samsung,exynos-usb-phy";
+			reg = <0x12130000 0x100>;
+		};
+	};
+
+	tmu at 10060000 {
+		compatible = "samsung,exynos-tmu";
+		reg = <0x10060000 0x10000>;
+	};
+
+	fimd at 14400000 {
+		compatible = "samsung,exynos-fimd";
+		reg = <0x14400000 0x10000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+
+	dp at 145b0000 {
+		compatible = "samsung,exynos5-dp";
+		reg = <0x145b0000 0x1000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+
+	xhci0: xhci at 12000000 {
+		compatible = "samsung,exynos5250-xhci";
+		reg = <0x12000000 0x10000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		phy {
+			compatible = "samsung,exynos5250-usb3-phy";
+			reg = <0x12100000 0x100>;
+		};
+	};
+
+
+	mmc at 12200000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12200000 0x1000>;
+		interrupts = <0 75 0>;
+	};
+
+	mmc at 12210000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12210000 0x1000>;
+		interrupts = <0 76 0>;
+	};
+
+	mmc at 12220000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12220000 0x1000>;
+		interrupts = <0 77 0>;
+	};
+
+	mmc at 12230000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,exynos5250-dwmmc";
+		reg = <0x12230000 0x1000>;
+		interrupts = <0 78 0>;
+	};
+
+	serial at 12C00000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C00000 0x100>;
+		interrupts = <0 51 0>;
+		id = <0>;
+	};
+
+	serial at 12C10000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C10000 0x100>;
+		interrupts = <0 52 0>;
+		id = <1>;
+	};
+
+	serial at 12C20000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C20000 0x100>;
+		interrupts = <0 53 0>;
+		id = <2>;
+	};
+
+	serial at 12C30000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x12C30000 0x100>;
+		interrupts = <0 54 0>;
+		id = <3>;
+	};
+
+	gpio: gpio {
+	};
+};
arch/arm/dts/exynos5250.dtsi +1 -177

190 lines not on this page · raw message

arch/arm/dts/exynos5420.dtsi new file +74 -0

74 lines not on this page · raw message

board/samsung/dts/exynos5420-smdk5420.dts new file +172 -0

172 lines not on this page · raw message

Signature · 1 line
1.7.12.4
#24 lore raw

PATCH v6 7/10 DTS: Add dts support for SMDK5420

Dear Rajeshwari S Shinde,

Quoted 45 lines · Rajeshwari S Shinde

This patch adds support for SMDK5420.
exynos5.dtsi created is a common file which has the nodes common to both 5420 and 5250.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added /include/ "exynos5420.dtsi
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/dts/exynos5.dtsi                 | 211
++++++++++++++++++++++++++++++
 arch/arm/dts/exynos5250.dtsi              | 178 +------------------------
 arch/arm/dts/exynos5420.dtsi              |  74 +++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts | 172 ++++++++++++++++++++++++
 4 files changed, 458 insertions(+), 177 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
arch/arm/dts/exynos5.dtsi new file +11 -0
new file mode 100644
index 0000000..de86a06
@@ -0,0 +1,211 @@
+/*
+ * SAMSUNG EXYNOS5 SoC device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * SAMSUNG EXYNOS5 SoC device nodes are listed in this file.
+ * EXYNOS5 based board files can include this file and provide
+ * values for board specfic bindings.
+ *
+ * Note: This file does not include device nodes for all the controllers
Quoted 8 lines

in
+ * EXYNOS5 SoC. As device tree coverage for EXYNOS5 increases,
+ * additional nodes can be added to this file.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.

please fix the license.

Quoted 121 lines
arch/arm/dts/exynos5.dtsi new file +120 -0
+*/
+
+/include/ "skeleton.dtsi"
+
+/ {
+       compatible = "samsung,exynos5";
+
+       sromc at 12250000 {
+               compatible = "samsung,exynos-sromc";
+               reg = <0x12250000 0x20>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
+
+       i2c at 12c60000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C60000 0x100>;
+               interrupts = <0 56 0>;
+       };
+
+       i2c at 12c70000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C70000 0x100>;
+               interrupts = <0 57 0>;
+       };
+
+       i2c at 12c80000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C80000 0x100>;
+               interrupts = <0 58 0>;
+       };
+
+       i2c at 12c90000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C90000 0x100>;
+               interrupts = <0 59 0>;
+       };
+
+       spi at 12d20000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d20000 0x30>;
+               interrupts = <0 68 0>;
+       };
+
+       spi at 12d30000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d30000 0x30>;
+               interrupts = <0 69 0>;
+       };
+
+       spi at 12d40000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d40000 0x30>;
+               clock-frequency = <50000000>;
+               interrupts = <0 70 0>;
+        };
+
+       spi at 131a0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x131a0000 0x30>;
+               interrupts = <0 129 0>;
+       };
+
+       spi at 131b0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x131b0000 0x30>;
+               interrupts = <0 130 0>;
+       };
+
+       ehci at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos-usb-phy";
+                       reg = <0x12130000 0x100>;
+               };
+       };
+
+       tmu at 10060000 {
+               compatible = "samsung,exynos-tmu";
+               reg = <0x10060000 0x10000>;
+       };
+
+       fimd at 14400000 {
+               compatible = "samsung,exynos-fimd";
+               reg = <0x14400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+       };
+
+       dp at 145b0000 {
+               compatible = "samsung,exynos5-dp";
+               reg = <0x145b0000 0x1000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+       };
+
+       xhci0: xhci at 12000000 {
+               compatible = "samsung,exynos5250-xhci";

arch/arm/dts/exynos5.dtsi line 147

Quoted 10 lines
arch/arm/dts/exynos5.dtsi new file +10 -0
+               reg = <0x12000000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12100000 0x100>;
+               };
+       };
+

please remove blank line.

Quoted 267 lines
arch/arm/dts/exynos5.dtsi new file +64 -0
+
+       mmc at 12200000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12200000 0x1000>;
+               interrupts = <0 75 0>;
+       };
+
+       mmc at 12210000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12210000 0x1000>;
+               interrupts = <0 76 0>;
+       };
+
+       mmc at 12220000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12220000 0x1000>;
+               interrupts = <0 77 0>;
+       };
+
+       mmc at 12230000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12230000 0x1000>;
+               interrupts = <0 78 0>;
+       };
+
+       serial at 12C00000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C00000 0x100>;
+               interrupts = <0 51 0>;
+               id = <0>;
+       };
+
+       serial at 12C10000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C10000 0x100>;
+               interrupts = <0 52 0>;
+               id = <1>;
+       };
+
+       serial at 12C20000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C20000 0x100>;
+               interrupts = <0 53 0>;
+               id = <2>;
+       };
+
+       serial at 12C30000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C30000 0x100>;
+               interrupts = <0 54 0>;
+               id = <3>;
+       };
+
+       gpio: gpio {
+       };
+};
arch/arm/dts/exynos5250.dtsi +1 -177
index 44cbb5a..4533481 100644
@@ -17,50 +17,9 @@
  * published by the Free Software Foundation.
 */
 
-/include/ "skeleton.dtsi"
+/include/ "exynos5.dtsi"
 
 / {
-       compatible = "samsung,exynos5250";
-
-       sromc at 12250000 {
-               compatible = "samsung,exynos-sromc";
-               reg = <0x12250000 0x20>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-       };
-
-       i2c at 12c60000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C60000 0x100>;
-               interrupts = <0 56 0>;
-       };
-
-       i2c at 12c70000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C70000 0x100>;
-               interrupts = <0 57 0>;
-       };
-
-       i2c at 12c80000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C80000 0x100>;
-               interrupts = <0 58 0>;
-       };
-
-       i2c at 12c90000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C90000 0x100>;
-               interrupts = <0 59 0>;
-       };
-
        i2c at 12ca0000 {
                #address-cells = <1>;
                #size-cells = <0>;
@@ -116,139 +75,4 @@
                samsung,i2s-bit-clk-framesize = <32>;
                samsung,i2s-id = <1>;
        };
-
-       spi at 12d20000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d20000 0x30>;
-               interrupts = <0 68 0>;
-       };
-
-       spi at 12d30000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d30000 0x30>;
-               interrupts = <0 69 0>;
-       };
-
-       spi at 12d40000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d40000 0x30>;
-               clock-frequency = <50000000>;
-               interrupts = <0 70 0>;
-       };
-
-       spi at 131a0000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x131a0000 0x30>;
-               interrupts = <0 129 0>;
-       };
-
-       spi at 131b0000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x131b0000 0x30>;
-               interrupts = <0 130 0>;
-       };
-
-       ehci at 12110000 {
-               compatible = "samsung,exynos-ehci";
-               reg = <0x12110000 0x100>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-
-               phy {
-                       compatible = "samsung,exynos-usb-phy";
-                       reg = <0x12130000 0x100>;
-               };
-       };
-
-       tmu at 10060000 {
-               compatible = "samsung,exynos-tmu";
-               reg = <0x10060000 0x10000>;
-       };
-
-       fimd at 14400000 {
-               compatible = "samsung,exynos-fimd";
-               reg = <0x14400000 0x10000>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-       };
-
-       dp at 145b0000 {
-               compatible = "samsung,exynos5-dp";
-               reg = <0x145b0000 0x1000>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-       };
-
-       mmc at 12200000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12200000 0x1000>;
-               interrupts = <0 75 0>;
-       };
-
-       mmc at 12210000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12210000 0x1000>;
-               interrupts = <0 76 0>;
-       };
-
-       mmc at 12220000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12220000 0x1000>;
-               interrupts = <0 77 0>;
-       };
-
-       mmc at 12230000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12230000 0x1000>;
-               interrupts = <0 78 0>;
-       };
-
-       serial at 12C00000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C00000 0x100>;
-               interrupts = <0 51 0>;
-               id = <0>;
-       };
-
-       serial at 12C10000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C10000 0x100>;
-               interrupts = <0 52 0>;
-               id = <1>;
-       };
-
-       serial at 12C20000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C20000 0x100>;
-               interrupts = <0 53 0>;
-               id = <2>;
-       };
-
-       serial at 12C30000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C30000 0x100>;
-               interrupts = <0 54 0>;
-               id = <3>;
-       };
-
-       gpio: gpio {
-       };
 };
arch/arm/dts/exynos5420.dtsi new file +0 -0
new file mode 100644
index 0000000..ca6c605

arch/arm/dts/exynos5420.dtsi line 9

Quoted 9 lines
arch/arm/dts/exynos5420.dtsi new file +9 -0
@@ -0,0 +1,74 @@
+/*
+ * SAMSUNG Peach board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.

please fix the license.

Quoted 73 lines
arch/arm/dts/exynos5420.dtsi new file +65 -0
+*/
+
+/include/ "exynos5.dtsi"
+
+/ {
+       config {
+               machine-arch-id = <4151>;
+       };
+
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CA0000 0x100>;
+               interrupts = <0 60 0>;
+       };
+
+       i2c at 12cb0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CB0000 0x100>;
+               interrupts = <0 61 0>;
+       };
+
+       i2c at 12cc0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CC0000 0x100>;
+               interrupts = <0 62 0>;
+       };
+
+       i2c at 12cd0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CD0000 0x100>;
+               interrupts = <0 63 0>;
+       };
+
+       i2c at 12e00000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E00000 0x100>;
+               interrupts = <0 87 0>;
+       };
+
+       i2c at 12e10000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E10000 0x100>;
+               interrupts = <0 88 0>;
+       };
+
+       i2c at 12e20000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E20000 0x100>;
+               interrupts = <0 203 0>;
+       };
+};
board/samsung/dts/exynos5420-smdk5420.dts new file +0 -0
new file mode 100644
index 0000000..5ef0c92

board/samsung/dts/exynos5420-smdk5420.dts line 6

Quoted 6 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +6 -0
@@ -0,0 +1,172 @@
+/*
+ * SAMSUNG SMDK5420 board device tree source
+ *
+ * Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.

is it right?

Quoted 169 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +166 -1
+ */
+
+/dts-v1/;
+/include/ "exynos5420.dtsi"
+
+/ {
+       model = "SAMSUNG SMDK5420 board based on EXYNOS5420";
+       compatible = "samsung,smdk5420", "samsung,exynos5";
+
+       config {
+               hwid = "smdk5420 TEST A-A 9382";
+       };
+
+       aliases {
+               i2c0 = "/i2c at 12c60000";
+               i2c1 = "/i2c at 12c70000";
+               i2c2 = "/i2c at 12c80000";
+               i2c3 = "/i2c at 12c90000";
+               i2c4 = "/i2c at 12ca0000";
+               i2c5 = "/i2c at 12cb0000";
+               i2c6 = "/i2c at 12cc0000";
+               i2c7 = "/i2c at 12cd0000";
+               i2c8 = "/i2c at 12e00000";
+               i2c9 = "/i2c at 12e10000";
+               i2c10 = "/i2c at 12e20000";
+               spi0 = "/spi at 12d20000";
+               spi1 = "/spi at 12d30000";
+               spi2 = "/spi at 12d40000";
+               spi3 = "/spi at 131a0000";
+               spi4 = "/spi at 131b0000";
+               mmc0 = "/mmc at 12200000";
+               mmc1 = "/mmc at 12210000";
+               mmc2 = "/mmc at 12220000";
+               xhci0 = "/xhci at 12000000";
+               xhci1 = "/xhci at 12400000";
+               serial0 = "/serial at 12C30000";
+               console = "/serial at 12C30000";
+       };
+
+       tmu at 10060000 {
+               samsung,min-temp        = <25>;
+               samsung,max-temp        = <125>;
+               samsung,start-warning   = <95>;
+               samsung,start-tripping  = <105>;
+               samsung,hw-tripping     = <110>;
+               samsung,efuse-min-value = <40>;
+               samsung,efuse-value     = <55>;
+               samsung,efuse-max-value = <100>;
+               samsung,slope           = <274761730>;
+               samsung,dc-value        = <25>;
+       };
+
+       /* s2mps11 is on i2c bus 4 */
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               pmic at 66 {
+                       reg = <0x66>;
+                       compatible = "samsung,s2mps11-pmic";
+               };
+       };
+
+       spi at 12d20000 { /* spi0 */
+               spi-max-frequency = <50000000>;
+               firmware_storage_spi: flash at 0 {
+                       reg = <0>;
+               };
+       };
+
+       fimd at 14400000 {
+               samsung,vl-freq = <60>;
+               samsung,vl-col = <2560>;
+               samsung,vl-row = <1600>;
+               samsung,vl-width = <2560>;
+               samsung,vl-height = <1600>;
+
+               samsung,vl-clkp;
+               samsung,vl-dp;
+               samsung,vl-bpix = <4>;
+
+               samsung,vl-hspw = <32>;
+               samsung,vl-hbpd = <80>;
+               samsung,vl-hfpd = <48>;
+               samsung,vl-vspw = <6>;
+               samsung,vl-vbpd = <37>;
+               samsung,vl-vfpd = <3>;
+               samsung,vl-cmd-allow-len = <0xf>;
+
+               samsung,winid = <3>;
+               samsung,interface-mode = <1>;
+               samsung,dp-enabled = <1>;
+               samsung,dual-lcd-enabled = <0>;
+       };
+
+       dmc {
+               mem-type = "lpddr3";
+       };
+
+       sound at 3830000 {
+               samsung,codec-type = "wm8994";
+       };
+
+       i2c at 12c70000 {
+               soundcodec at 1a {
+                       reg = <0x1a>;
+                       compatible = "wolfson,wm8994-codec";
+               };
+       };
+
+       mmc at 12200000 {
+               samsung,bus-width = <8>;
+               samsung,timing = <1 3 3>;
+               samsung,removable = <0>;
+               samsung,pre-init;
+       };
+
+       mmc at 12210000 {
+               status = "disabled";
+       };
+
+       mmc at 12220000 {
+               samsung,bus-width = <4>;
+               samsung,timing = <1 2 3>;
+               samsung,removable = <1>;
+       };
+
+       mmc at 12230000 {
+               status = "disabled";
+       };
+
+       fimd at 14400000 {
+               /* sysmmu is not used in U-Boot */
+               samsung,disable-sysmmu;
+       };
+
+       dp at 145b0000 {
+               samsung,lt-status = <0>;
+
+               samsung,master-mode = <0>;
+               samsung,bist-mode = <0>;
+               samsung,bist-pattern = <0>;
+               samsung,h-sync-polarity = <0>;
+               samsung,v-sync-polarity = <0>;
+               samsung,interlaced = <0>;
+               samsung,color-space = <0>;
+               samsung,dynamic-range = <0>;
+               samsung,ycbcr-coeff = <0>;
+               samsung,color-depth = <1>;
+       };
+
+       dmc {
+               mem-type = "ddr3";
+       };
+
+       xhci1: xhci at 12400000 {
+               compatible = "samsung,exynos5250-xhci";
+               reg = <0x12400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12500000 0x100>;
+               };
+       };
+};
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#25 lore raw

PATCH v6 7/10 DTS: Add dts support for SMDK5420

Hi Minkyu Kang,

Thank you for comments.

Quoted 550 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 45 lines · Rajeshwari S Shinde

This patch adds support for SMDK5420.
exynos5.dtsi created is a common file which has the nodes common to both 5420 and 5250.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added /include/ "exynos5420.dtsi
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/dts/exynos5.dtsi                 | 211
++++++++++++++++++++++++++++++
 arch/arm/dts/exynos5250.dtsi              | 178 +------------------------
 arch/arm/dts/exynos5420.dtsi              |  74 +++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts | 172 ++++++++++++++++++++++++
 4 files changed, 458 insertions(+), 177 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
arch/arm/dts/exynos5.dtsi new file +11 -0
new file mode 100644
index 0000000..de86a06
@@ -0,0 +1,211 @@
+/*
+ * SAMSUNG EXYNOS5 SoC device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * SAMSUNG EXYNOS5 SoC device nodes are listed in this file.
+ * EXYNOS5 based board files can include this file and provide
+ * values for board specfic bindings.
+ *
+ * Note: This file does not include device nodes for all the controllers
Quoted 8 lines

in
+ * EXYNOS5 SoC. As device tree coverage for EXYNOS5 increases,
+ * additional nodes can be added to this file.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.

please fix the license.

Quoted 121 lines
arch/arm/dts/exynos5.dtsi new file +120 -0
+*/
+
+/include/ "skeleton.dtsi"
+
+/ {
+       compatible = "samsung,exynos5";
+
+       sromc at 12250000 {
+               compatible = "samsung,exynos-sromc";
+               reg = <0x12250000 0x20>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+       };
+
+       i2c at 12c60000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C60000 0x100>;
+               interrupts = <0 56 0>;
+       };
+
+       i2c at 12c70000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C70000 0x100>;
+               interrupts = <0 57 0>;
+       };
+
+       i2c at 12c80000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C80000 0x100>;
+               interrupts = <0 58 0>;
+       };
+
+       i2c at 12c90000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,s3c2440-i2c";
+               reg = <0x12C90000 0x100>;
+               interrupts = <0 59 0>;
+       };
+
+       spi at 12d20000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d20000 0x30>;
+               interrupts = <0 68 0>;
+       };
+
+       spi at 12d30000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d30000 0x30>;
+               interrupts = <0 69 0>;
+       };
+
+       spi at 12d40000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x12d40000 0x30>;
+               clock-frequency = <50000000>;
+               interrupts = <0 70 0>;
+        };
+
+       spi at 131a0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x131a0000 0x30>;
+               interrupts = <0 129 0>;
+       };
+
+       spi at 131b0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos-spi";
+               reg = <0x131b0000 0x30>;
+               interrupts = <0 130 0>;
+       };
+
+       ehci at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos-usb-phy";
+                       reg = <0x12130000 0x100>;
+               };
+       };
+
+       tmu at 10060000 {
+               compatible = "samsung,exynos-tmu";
+               reg = <0x10060000 0x10000>;
+       };
+
+       fimd at 14400000 {
+               compatible = "samsung,exynos-fimd";
+               reg = <0x14400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+       };
+
+       dp at 145b0000 {
+               compatible = "samsung,exynos5-dp";
+               reg = <0x145b0000 0x1000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+       };
+
+       xhci0: xhci at 12000000 {
+               compatible = "samsung,exynos5250-xhci";

arch/arm/dts/exynos5.dtsi line 147

Quoted 10 lines
arch/arm/dts/exynos5.dtsi new file +10 -0
+               reg = <0x12000000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12100000 0x100>;
+               };
+       };
+

please remove blank line.

Quoted 267 lines
arch/arm/dts/exynos5.dtsi new file +64 -0
+
+       mmc at 12200000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12200000 0x1000>;
+               interrupts = <0 75 0>;
+       };
+
+       mmc at 12210000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12210000 0x1000>;
+               interrupts = <0 76 0>;
+       };
+
+       mmc at 12220000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12220000 0x1000>;
+               interrupts = <0 77 0>;
+       };
+
+       mmc at 12230000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5250-dwmmc";
+               reg = <0x12230000 0x1000>;
+               interrupts = <0 78 0>;
+       };
+
+       serial at 12C00000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C00000 0x100>;
+               interrupts = <0 51 0>;
+               id = <0>;
+       };
+
+       serial at 12C10000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C10000 0x100>;
+               interrupts = <0 52 0>;
+               id = <1>;
+       };
+
+       serial at 12C20000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C20000 0x100>;
+               interrupts = <0 53 0>;
+               id = <2>;
+       };
+
+       serial at 12C30000 {
+               compatible = "samsung,exynos4210-uart";
+               reg = <0x12C30000 0x100>;
+               interrupts = <0 54 0>;
+               id = <3>;
+       };
+
+       gpio: gpio {
+       };
+};
arch/arm/dts/exynos5250.dtsi +1 -177
index 44cbb5a..4533481 100644
@@ -17,50 +17,9 @@
  * published by the Free Software Foundation.
 */
 
-/include/ "skeleton.dtsi"
+/include/ "exynos5.dtsi"
 
 / {
-       compatible = "samsung,exynos5250";
-
-       sromc at 12250000 {
-               compatible = "samsung,exynos-sromc";
-               reg = <0x12250000 0x20>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-       };
-
-       i2c at 12c60000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C60000 0x100>;
-               interrupts = <0 56 0>;
-       };
-
-       i2c at 12c70000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C70000 0x100>;
-               interrupts = <0 57 0>;
-       };
-
-       i2c at 12c80000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C80000 0x100>;
-               interrupts = <0 58 0>;
-       };
-
-       i2c at 12c90000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,s3c2440-i2c";
-               reg = <0x12C90000 0x100>;
-               interrupts = <0 59 0>;
-       };
-
        i2c at 12ca0000 {
                #address-cells = <1>;
                #size-cells = <0>;
@@ -116,139 +75,4 @@
                samsung,i2s-bit-clk-framesize = <32>;
                samsung,i2s-id = <1>;
        };
-
-       spi at 12d20000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d20000 0x30>;
-               interrupts = <0 68 0>;
-       };
-
-       spi at 12d30000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d30000 0x30>;
-               interrupts = <0 69 0>;
-       };
-
-       spi at 12d40000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x12d40000 0x30>;
-               clock-frequency = <50000000>;
-               interrupts = <0 70 0>;
-       };
-
-       spi at 131a0000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x131a0000 0x30>;
-               interrupts = <0 129 0>;
-       };
-
-       spi at 131b0000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos-spi";
-               reg = <0x131b0000 0x30>;
-               interrupts = <0 130 0>;
-       };
-
-       ehci at 12110000 {
-               compatible = "samsung,exynos-ehci";
-               reg = <0x12110000 0x100>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-
-               phy {
-                       compatible = "samsung,exynos-usb-phy";
-                       reg = <0x12130000 0x100>;
-               };
-       };
-
-       tmu at 10060000 {
-               compatible = "samsung,exynos-tmu";
-               reg = <0x10060000 0x10000>;
-       };
-
-       fimd at 14400000 {
-               compatible = "samsung,exynos-fimd";
-               reg = <0x14400000 0x10000>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-       };
-
-       dp at 145b0000 {
-               compatible = "samsung,exynos5-dp";
-               reg = <0x145b0000 0x1000>;
-               #address-cells = <1>;
-               #size-cells = <1>;
-       };
-
-       mmc at 12200000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12200000 0x1000>;
-               interrupts = <0 75 0>;
-       };
-
-       mmc at 12210000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12210000 0x1000>;
-               interrupts = <0 76 0>;
-       };
-
-       mmc at 12220000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12220000 0x1000>;
-               interrupts = <0 77 0>;
-       };
-
-       mmc at 12230000 {
-               #address-cells = <1>;
-               #size-cells = <0>;
-               compatible = "samsung,exynos5250-dwmmc";
-               reg = <0x12230000 0x1000>;
-               interrupts = <0 78 0>;
-       };
-
-       serial at 12C00000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C00000 0x100>;
-               interrupts = <0 51 0>;
-               id = <0>;
-       };
-
-       serial at 12C10000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C10000 0x100>;
-               interrupts = <0 52 0>;
-               id = <1>;
-       };
-
-       serial at 12C20000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C20000 0x100>;
-               interrupts = <0 53 0>;
-               id = <2>;
-       };
-
-       serial at 12C30000 {
-               compatible = "samsung,exynos4210-uart";
-               reg = <0x12C30000 0x100>;
-               interrupts = <0 54 0>;
-               id = <3>;
-       };
-
-       gpio: gpio {
-       };
 };
arch/arm/dts/exynos5420.dtsi new file +0 -0
new file mode 100644
index 0000000..ca6c605

arch/arm/dts/exynos5420.dtsi line 9

Quoted 9 lines
arch/arm/dts/exynos5420.dtsi new file +9 -0
@@ -0,0 +1,74 @@
+/*
+ * SAMSUNG Peach board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.

please fix the license.

Quoted 73 lines
arch/arm/dts/exynos5420.dtsi new file +65 -0
+*/
+
+/include/ "exynos5.dtsi"
+
+/ {
+       config {
+               machine-arch-id = <4151>;
+       };
+
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CA0000 0x100>;
+               interrupts = <0 60 0>;
+       };
+
+       i2c at 12cb0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CB0000 0x100>;
+               interrupts = <0 61 0>;
+       };
+
+       i2c at 12cc0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CC0000 0x100>;
+               interrupts = <0 62 0>;
+       };
+
+       i2c at 12cd0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12CD0000 0x100>;
+               interrupts = <0 63 0>;
+       };
+
+       i2c at 12e00000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E00000 0x100>;
+               interrupts = <0 87 0>;
+       };
+
+       i2c at 12e10000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E10000 0x100>;
+               interrupts = <0 88 0>;
+       };
+
+       i2c at 12e20000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "samsung,exynos5-hsi2c";
+               reg = <0x12E20000 0x100>;
+               interrupts = <0 203 0>;
+       };
+};
board/samsung/dts/exynos5420-smdk5420.dts new file +1 -0
new file mode 100644
index 0000000..5ef0c92
@@ -0,0 +1,172 @@
+/*
Quoted 8 lines

board/samsung/dts/exynos5420-smdk5420.dts line 6

Quoted 6 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +5 -0
+ * SAMSUNG SMDK5420 board device tree source
+ *
+ * Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.

is it right?

Iam sorry did not get your question, about what are you pointing to?.

Quoted 189 lines
Quoted 171 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +166 -1
+ */
+
+/dts-v1/;
+/include/ "exynos5420.dtsi"
+
+/ {
+       model = "SAMSUNG SMDK5420 board based on EXYNOS5420";
+       compatible = "samsung,smdk5420", "samsung,exynos5";
+
+       config {
+               hwid = "smdk5420 TEST A-A 9382";
+       };
+
+       aliases {
+               i2c0 = "/i2c at 12c60000";
+               i2c1 = "/i2c at 12c70000";
+               i2c2 = "/i2c at 12c80000";
+               i2c3 = "/i2c at 12c90000";
+               i2c4 = "/i2c at 12ca0000";
+               i2c5 = "/i2c at 12cb0000";
+               i2c6 = "/i2c at 12cc0000";
+               i2c7 = "/i2c at 12cd0000";
+               i2c8 = "/i2c at 12e00000";
+               i2c9 = "/i2c at 12e10000";
+               i2c10 = "/i2c at 12e20000";
+               spi0 = "/spi at 12d20000";
+               spi1 = "/spi at 12d30000";
+               spi2 = "/spi at 12d40000";
+               spi3 = "/spi at 131a0000";
+               spi4 = "/spi at 131b0000";
+               mmc0 = "/mmc at 12200000";
+               mmc1 = "/mmc at 12210000";
+               mmc2 = "/mmc at 12220000";
+               xhci0 = "/xhci at 12000000";
+               xhci1 = "/xhci at 12400000";
+               serial0 = "/serial at 12C30000";
+               console = "/serial at 12C30000";
+       };
+
+       tmu at 10060000 {
+               samsung,min-temp        = <25>;
+               samsung,max-temp        = <125>;
+               samsung,start-warning   = <95>;
+               samsung,start-tripping  = <105>;
+               samsung,hw-tripping     = <110>;
+               samsung,efuse-min-value = <40>;
+               samsung,efuse-value     = <55>;
+               samsung,efuse-max-value = <100>;
+               samsung,slope           = <274761730>;
+               samsung,dc-value        = <25>;
+       };
+
+       /* s2mps11 is on i2c bus 4 */
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               pmic at 66 {
+                       reg = <0x66>;
+                       compatible = "samsung,s2mps11-pmic";
+               };
+       };
+
+       spi at 12d20000 { /* spi0 */
+               spi-max-frequency = <50000000>;
+               firmware_storage_spi: flash at 0 {
+                       reg = <0>;
+               };
+       };
+
+       fimd at 14400000 {
+               samsung,vl-freq = <60>;
+               samsung,vl-col = <2560>;
+               samsung,vl-row = <1600>;
+               samsung,vl-width = <2560>;
+               samsung,vl-height = <1600>;
+
+               samsung,vl-clkp;
+               samsung,vl-dp;
+               samsung,vl-bpix = <4>;
+
+               samsung,vl-hspw = <32>;
+               samsung,vl-hbpd = <80>;
+               samsung,vl-hfpd = <48>;
+               samsung,vl-vspw = <6>;
+               samsung,vl-vbpd = <37>;
+               samsung,vl-vfpd = <3>;
+               samsung,vl-cmd-allow-len = <0xf>;
+
+               samsung,winid = <3>;
+               samsung,interface-mode = <1>;
+               samsung,dp-enabled = <1>;
+               samsung,dual-lcd-enabled = <0>;
+       };
+
+       dmc {
+               mem-type = "lpddr3";
+       };
+
+       sound at 3830000 {
+               samsung,codec-type = "wm8994";
+       };
+
+       i2c at 12c70000 {
+               soundcodec at 1a {
+                       reg = <0x1a>;
+                       compatible = "wolfson,wm8994-codec";
+               };
+       };
+
+       mmc at 12200000 {
+               samsung,bus-width = <8>;
+               samsung,timing = <1 3 3>;
+               samsung,removable = <0>;
+               samsung,pre-init;
+       };
+
+       mmc at 12210000 {
+               status = "disabled";
+       };
+
+       mmc at 12220000 {
+               samsung,bus-width = <4>;
+               samsung,timing = <1 2 3>;
+               samsung,removable = <1>;
+       };
+
+       mmc at 12230000 {
+               status = "disabled";
+       };
+
+       fimd at 14400000 {
+               /* sysmmu is not used in U-Boot */
+               samsung,disable-sysmmu;
+       };
+
+       dp at 145b0000 {
+               samsung,lt-status = <0>;
+
+               samsung,master-mode = <0>;
+               samsung,bist-mode = <0>;
+               samsung,bist-pattern = <0>;
+               samsung,h-sync-polarity = <0>;
+               samsung,v-sync-polarity = <0>;
+               samsung,interlaced = <0>;
+               samsung,color-space = <0>;
+               samsung,dynamic-range = <0>;
+               samsung,ycbcr-coeff = <0>;
+               samsung,color-depth = <1>;
+       };
+
+       dmc {
+               mem-type = "ddr3";
+       };
+
+       xhci1: xhci at 12400000 {
+               compatible = "samsung,exynos5250-xhci";
+               reg = <0x12400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12500000 0x100>;
+               };
+       };
+};
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
Regards,
Rajeshwari Shinde
#26 lore raw

PATCH v6 7/10 DTS: Add dts support for SMDK5420

Dear Rajeshwari,

Quoted 54 lines · Rajeshwari Birje

Hi Minkyu Kang,

Thank you for comments.

Quoted 27 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 21 lines · On 29 October 2013 16:23, Rajeshwari S Shinde <[email protected] wrote:

This patch adds support for SMDK5420.
exynos5.dtsi created is a common file which has the nodes common to both 5420 and 5250.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added /include/ "exynos5420.dtsi
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/dts/exynos5.dtsi                 | 211
++++++++++++++++++++++++++++++
 arch/arm/dts/exynos5250.dtsi              | 178
+------------------------
>>  arch/arm/dts/exynos5420.dtsi              |  74 +++++++++++
>>  board/samsung/dts/exynos5420-smdk5420.dts | 172

++++++++++++++++++++++++

Quoted 5 lines
Quoted 5 lines
 4 files changed, 458 insertions(+), 177 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
Quoted 12 lines

board/samsung/dts/exynos5420-smdk5420.dts line 5

Quoted 12 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +5 -0
new file mode 100644
index 0000000..5ef0c92
@@ -0,0 +1,172 @@
+/*
+ * SAMSUNG SMDK5420 board device tree source
+ *
+ * Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can

be

Quoted 6 lines
Quoted 4 lines

board/samsung/dts/exynos5420-smdk5420.dts line 6

Quoted 2 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +1 -0
+ * found in the LICENSE file.

is it right?

Iam sorry did not get your question, about what are you pointing to?.

The Copyright and License.

Quoted 197 lines
Quoted 185 lines
Quoted 172 lines
board/samsung/dts/exynos5420-smdk5420.dts new file +166 -1
+ */
+
+/dts-v1/;
+/include/ "exynos5420.dtsi"
+
+/ {
+       model = "SAMSUNG SMDK5420 board based on EXYNOS5420";
+       compatible = "samsung,smdk5420", "samsung,exynos5";
+
+       config {
+               hwid = "smdk5420 TEST A-A 9382";
+       };
+
+       aliases {
+               i2c0 = "/i2c at 12c60000";
+               i2c1 = "/i2c at 12c70000";
+               i2c2 = "/i2c at 12c80000";
+               i2c3 = "/i2c at 12c90000";
+               i2c4 = "/i2c at 12ca0000";
+               i2c5 = "/i2c at 12cb0000";
+               i2c6 = "/i2c at 12cc0000";
+               i2c7 = "/i2c at 12cd0000";
+               i2c8 = "/i2c at 12e00000";
+               i2c9 = "/i2c at 12e10000";
+               i2c10 = "/i2c at 12e20000";
+               spi0 = "/spi at 12d20000";
+               spi1 = "/spi at 12d30000";
+               spi2 = "/spi at 12d40000";
+               spi3 = "/spi at 131a0000";
+               spi4 = "/spi at 131b0000";
+               mmc0 = "/mmc at 12200000";
+               mmc1 = "/mmc at 12210000";
+               mmc2 = "/mmc at 12220000";
+               xhci0 = "/xhci at 12000000";
+               xhci1 = "/xhci at 12400000";
+               serial0 = "/serial at 12C30000";
+               console = "/serial at 12C30000";
+       };
+
+       tmu at 10060000 {
+               samsung,min-temp        = <25>;
+               samsung,max-temp        = <125>;
+               samsung,start-warning   = <95>;
+               samsung,start-tripping  = <105>;
+               samsung,hw-tripping     = <110>;
+               samsung,efuse-min-value = <40>;
+               samsung,efuse-value     = <55>;
+               samsung,efuse-max-value = <100>;
+               samsung,slope           = <274761730>;
+               samsung,dc-value        = <25>;
+       };
+
+       /* s2mps11 is on i2c bus 4 */
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               pmic at 66 {
+                       reg = <0x66>;
+                       compatible = "samsung,s2mps11-pmic";
+               };
+       };
+
+       spi at 12d20000 { /* spi0 */
+               spi-max-frequency = <50000000>;
+               firmware_storage_spi: flash at 0 {
+                       reg = <0>;
+               };
+       };
+
+       fimd at 14400000 {
+               samsung,vl-freq = <60>;
+               samsung,vl-col = <2560>;
+               samsung,vl-row = <1600>;
+               samsung,vl-width = <2560>;
+               samsung,vl-height = <1600>;
+
+               samsung,vl-clkp;
+               samsung,vl-dp;
+               samsung,vl-bpix = <4>;
+
+               samsung,vl-hspw = <32>;
+               samsung,vl-hbpd = <80>;
+               samsung,vl-hfpd = <48>;
+               samsung,vl-vspw = <6>;
+               samsung,vl-vbpd = <37>;
+               samsung,vl-vfpd = <3>;
+               samsung,vl-cmd-allow-len = <0xf>;
+
+               samsung,winid = <3>;
+               samsung,interface-mode = <1>;
+               samsung,dp-enabled = <1>;
+               samsung,dual-lcd-enabled = <0>;
+       };
+
+       dmc {
+               mem-type = "lpddr3";
+       };
+
+       sound at 3830000 {
+               samsung,codec-type = "wm8994";
+       };
+
+       i2c at 12c70000 {
+               soundcodec at 1a {
+                       reg = <0x1a>;
+                       compatible = "wolfson,wm8994-codec";
+               };
+       };
+
+       mmc at 12200000 {
+               samsung,bus-width = <8>;
+               samsung,timing = <1 3 3>;
+               samsung,removable = <0>;
+               samsung,pre-init;
+       };
+
+       mmc at 12210000 {
+               status = "disabled";
+       };
+
+       mmc at 12220000 {
+               samsung,bus-width = <4>;
+               samsung,timing = <1 2 3>;
+               samsung,removable = <1>;
+       };
+
+       mmc at 12230000 {
+               status = "disabled";
+       };
+
+       fimd at 14400000 {
+               /* sysmmu is not used in U-Boot */
+               samsung,disable-sysmmu;
+       };
+
+       dp at 145b0000 {
+               samsung,lt-status = <0>;
+
+               samsung,master-mode = <0>;
+               samsung,bist-mode = <0>;
+               samsung,bist-pattern = <0>;
+               samsung,h-sync-polarity = <0>;
+               samsung,v-sync-polarity = <0>;
+               samsung,interlaced = <0>;
+               samsung,color-space = <0>;
+               samsung,dynamic-range = <0>;
+               samsung,ycbcr-coeff = <0>;
+               samsung,color-depth = <1>;
+       };
+
+       dmc {
+               mem-type = "ddr3";
+       };
+
+       xhci1: xhci at 12400000 {
+               compatible = "samsung,exynos5250-xhci";
+               reg = <0x12400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12500000 0x100>;
+               };
+       };
+};
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Regards,
Rajeshwari Shinde

Signature · 2 lines
from. prom.
www.promsoft.net
#27 lore raw

PATCH v6 7/10 DTS: Add dts support for SMDK5420

Hi Minkyu Kang,

Quoted 64 lines · Minkyu Kang

Dear Rajeshwari,

Quoted 59 lines · Rajeshwari Birje

Hi Minkyu Kang,

Thank you for comments.

Quoted 53 lines · Minkyu Kang

Dear Rajeshwari S Shinde,

Quoted 42 lines · Rajeshwari S Shinde

This patch adds support for SMDK5420.
exynos5.dtsi created is a common file which has the nodes common to both 5420 and 5250.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Added /include/ "exynos5420.dtsi
Changes in V5:
- None
Changes in V6:
- None

 arch/arm/dts/exynos5.dtsi                 | 211
++++++++++++++++++++++++++++++
 arch/arm/dts/exynos5250.dtsi              | 178
+------------------------
 arch/arm/dts/exynos5420.dtsi              |  74 +++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts | 172
++++++++++++++++++++++++
 4 files changed, 458 insertions(+), 177 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
board/samsung/dts/exynos5420-smdk5420.dts new file +5 -0
new file mode 100644
index 0000000..5ef0c92
@@ -0,0 +1,172 @@
+/*
+ * SAMSUNG SMDK5420 board device tree source
+ *
+ * Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can
Quoted 3 lines

be
+ * found in the LICENSE file.

is it right?

Quoted 4 lines
Quoted 1 line

Iam sorry did not get your question, about what are you pointing to?.

The Copyright and License.

Have corrected this in V7.

Quoted 205 lines
Quoted 195 lines
Quoted 187 lines
Quoted 174 lines

+ */

board/samsung/dts/exynos5420-smdk5420.dts new file +165 -1
+
+/dts-v1/;
+/include/ "exynos5420.dtsi"
+
+/ {
+       model = "SAMSUNG SMDK5420 board based on EXYNOS5420";
+       compatible = "samsung,smdk5420", "samsung,exynos5";
+
+       config {
+               hwid = "smdk5420 TEST A-A 9382";
+       };
+
+       aliases {
+               i2c0 = "/i2c at 12c60000";
+               i2c1 = "/i2c at 12c70000";
+               i2c2 = "/i2c at 12c80000";
+               i2c3 = "/i2c at 12c90000";
+               i2c4 = "/i2c at 12ca0000";
+               i2c5 = "/i2c at 12cb0000";
+               i2c6 = "/i2c at 12cc0000";
+               i2c7 = "/i2c at 12cd0000";
+               i2c8 = "/i2c at 12e00000";
+               i2c9 = "/i2c at 12e10000";
+               i2c10 = "/i2c at 12e20000";
+               spi0 = "/spi at 12d20000";
+               spi1 = "/spi at 12d30000";
+               spi2 = "/spi at 12d40000";
+               spi3 = "/spi at 131a0000";
+               spi4 = "/spi at 131b0000";
+               mmc0 = "/mmc at 12200000";
+               mmc1 = "/mmc at 12210000";
+               mmc2 = "/mmc at 12220000";
+               xhci0 = "/xhci at 12000000";
+               xhci1 = "/xhci at 12400000";
+               serial0 = "/serial at 12C30000";
+               console = "/serial at 12C30000";
+       };
+
+       tmu at 10060000 {
+               samsung,min-temp        = <25>;
+               samsung,max-temp        = <125>;
+               samsung,start-warning   = <95>;
+               samsung,start-tripping  = <105>;
+               samsung,hw-tripping     = <110>;
+               samsung,efuse-min-value = <40>;
+               samsung,efuse-value     = <55>;
+               samsung,efuse-max-value = <100>;
+               samsung,slope           = <274761730>;
+               samsung,dc-value        = <25>;
+       };
+
+       /* s2mps11 is on i2c bus 4 */
+       i2c at 12ca0000 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               pmic at 66 {
+                       reg = <0x66>;
+                       compatible = "samsung,s2mps11-pmic";
+               };
+       };
+
+       spi at 12d20000 { /* spi0 */
+               spi-max-frequency = <50000000>;
+               firmware_storage_spi: flash at 0 {
+                       reg = <0>;
+               };
+       };
+
+       fimd at 14400000 {
+               samsung,vl-freq = <60>;
+               samsung,vl-col = <2560>;
+               samsung,vl-row = <1600>;
+               samsung,vl-width = <2560>;
+               samsung,vl-height = <1600>;
+
+               samsung,vl-clkp;
+               samsung,vl-dp;
+               samsung,vl-bpix = <4>;
+
+               samsung,vl-hspw = <32>;
+               samsung,vl-hbpd = <80>;
+               samsung,vl-hfpd = <48>;
+               samsung,vl-vspw = <6>;
+               samsung,vl-vbpd = <37>;
+               samsung,vl-vfpd = <3>;
+               samsung,vl-cmd-allow-len = <0xf>;
+
+               samsung,winid = <3>;
+               samsung,interface-mode = <1>;
+               samsung,dp-enabled = <1>;
+               samsung,dual-lcd-enabled = <0>;
+       };
+
+       dmc {
+               mem-type = "lpddr3";
+       };
+
+       sound at 3830000 {
+               samsung,codec-type = "wm8994";
+       };
+
+       i2c at 12c70000 {
+               soundcodec at 1a {
+                       reg = <0x1a>;
+                       compatible = "wolfson,wm8994-codec";
+               };
+       };
+
+       mmc at 12200000 {
+               samsung,bus-width = <8>;
+               samsung,timing = <1 3 3>;
+               samsung,removable = <0>;
+               samsung,pre-init;
+       };
+
+       mmc at 12210000 {
+               status = "disabled";
+       };
+
+       mmc at 12220000 {
+               samsung,bus-width = <4>;
+               samsung,timing = <1 2 3>;
+               samsung,removable = <1>;
+       };
+
+       mmc at 12230000 {
+               status = "disabled";
+       };
+
+       fimd at 14400000 {
+               /* sysmmu is not used in U-Boot */
+               samsung,disable-sysmmu;
+       };
+
+       dp at 145b0000 {
+               samsung,lt-status = <0>;
+
+               samsung,master-mode = <0>;
+               samsung,bist-mode = <0>;
+               samsung,bist-pattern = <0>;
+               samsung,h-sync-polarity = <0>;
+               samsung,v-sync-polarity = <0>;
+               samsung,interlaced = <0>;
+               samsung,color-space = <0>;
+               samsung,dynamic-range = <0>;
+               samsung,ycbcr-coeff = <0>;
+               samsung,color-depth = <1>;
+       };
+
+       dmc {
+               mem-type = "ddr3";
+       };
+
+       xhci1: xhci at 12400000 {
+               compatible = "samsung,exynos5250-xhci";
+               reg = <0x12400000 0x10000>;
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               phy {
+                       compatible = "samsung,exynos5250-usb3-phy";
+                       reg = <0x12500000 0x100>;
+               };
+       };
+};
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Quoted 3 lines

--
Regards,
Rajeshwari Shinde

--
from. prom.
www.promsoft.net

Signature · 2 lines
Regards,
Rajeshwari Shinde
#28 lore raw

PATCH v6 8/10 Config: Add initial config for SMDK5420

In reply to Rajeshwari S Shinde

Adding initial config for SMDK5420 to build and boot U-Boot over Exynos based SMDK5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Created a common exynos5-dt.h
Changes in V5:
- None
Changes in V6:
- None

 include/configs/exynos5-dt.h    | 302 +++++++++++++++++++++++++++++++++++++
 include/configs/exynos5250-dt.h | 319 +---------------------------------------
 include/configs/smdk5420.h      |  49 ++++++
 3 files changed, 359 insertions(+), 311 deletions(-)
 create mode 100644 include/configs/exynos5-dt.h
 create mode 100644 include/configs/smdk5420.h
include/configs/exynos5-dt.h new file +302 -0
new file mode 100644
index 0000000..fa6bb89
@@ -0,0 +1,302 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ *
+ * Configuration settings for the SAMSUNG EXYNOS5 board.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* High Level Configuration Options */
+#define CONFIG_SAMSUNG			/* in a SAMSUNG core */
+#define CONFIG_S5P			/* S5P Family */
+#define CONFIG_EXYNOS5			/* which is in a Exynos5 Family */
+
+#include <asm/arch/cpu.h>		/* get chip and board defs */
+
+#define CONFIG_SYS_GENERIC_BOARD
+#define CONFIG_ARCH_CPU_INIT
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_BOARD_COMMON
+#define CONFIG_ARCH_EARLY_INIT_R
+
+/* Enable fdt support for Exynos5250 */
+#define CONFIG_OF_CONTROL
+#define CONFIG_OF_SEPARATE
+
+/* Allow tracing to be enabled */
+#define CONFIG_TRACE
+#define CONFIG_CMD_TRACE
+#define CONFIG_TRACE_BUFFER_SIZE	(16 << 20)
+#define CONFIG_TRACE_EARLY_SIZE		(8 << 20)
+#define CONFIG_TRACE_EARLY
+#define CONFIG_TRACE_EARLY_ADDR		0x50000000
+
+/* Keep L2 Cache Disabled */
+#define CONFIG_SYS_DCACHE_OFF
+
+/* Enable ACE acceleration for SHA1 and SHA256 */
+#define CONFIG_EXYNOS_ACE_SHA
+#define CONFIG_SHA_HW_ACCEL
+
+
+/* input clock of PLL: SMDK5250 has 24MHz input clock */
+#define CONFIG_SYS_CLK_FREQ		24000000
+
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_INITRD_TAG
+#define CONFIG_CMDLINE_EDITING
+
+
+/* Power Down Modes */
+#define S5P_CHECK_SLEEP			0x00000BAD
+#define S5P_CHECK_DIDLE			0xBAD00000
+#define S5P_CHECK_LPA			0xABAD0000
+
+/* Offset for inform registers */
+#define INFORM0_OFFSET			0x800
+#define INFORM1_OFFSET			0x804
+#define INFORM2_OFFSET			0x808
+#define INFORM3_OFFSET			0x80c
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (4 << 20))
+
+/* select serial console configuration */
+#define CONFIG_BAUDRATE			115200
+#define EXYNOS5_DEFAULT_UART_OFFSET	0x010000
+#define CONFIG_SILENT_CONSOLE
+
+/* Enable keyboard */
+#define CONFIG_CROS_EC		/* CROS_EC protocol */
+#define CONFIG_CROS_EC_SPI		/* Support CROS_EC over SPI */
+#define CONFIG_CROS_EC_I2C		/* Support CROS_EC over I2C */
+#define CONFIG_CROS_EC_KEYB	/* CROS_EC keyboard input */
+#define CONFIG_CMD_CROS_EC
+#define CONFIG_KEYBOARD
+
+/* Console configuration */
+#define CONFIG_CONSOLE_MUX
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV
+#define EXYNOS_DEVICE_SETTINGS \
+		"stdin=serial,cros-ec-keyb\0" \
+		"stdout=serial,lcd\0" \
+		"stderr=serial,lcd\0"
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	EXYNOS_DEVICE_SETTINGS
+
+/* SD/MMC configuration */
+#define CONFIG_GENERIC_MMC
+#define CONFIG_MMC
+#define CONFIG_SDHCI
+#define CONFIG_S5P_SDHCI
+#define CONFIG_DWMMC
+#define CONFIG_EXYNOS_DWMMC
+#define CONFIG_SUPPORT_EMMC_BOOT
+
+
+#define CONFIG_BOARD_EARLY_INIT_F
+#define CONFIG_SKIP_LOWLEVEL_INIT
+
+/* PWM */
+#define CONFIG_PWM
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+
+/* Command definition*/
+#include <config_cmd_default.h>
+
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_ELF
+#define CONFIG_CMD_MMC
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_HASH
+
+#define CONFIG_BOOTDELAY		3
+#define CONFIG_ZERO_BOOTDELAY_CHECK
+
+/* Thermal Management Unit */
+#define CONFIG_EXYNOS_TMU
+#define CONFIG_CMD_DTT
+#define CONFIG_TMU_CMD_DTT
+
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+
+/* USB boot mode */
+#define CONFIG_USB_BOOTING
+#define EXYNOS_COPY_USB_FNPTR_ADDR	0x02020070
+#define EXYNOS_USB_SECONDARY_BOOT	0xfeed0002
+#define EXYNOS_IRAM_SECONDARY_BASE	0x02020018
+
+/* TPM */
+#define CONFIG_TPM
+#define CONFIG_CMD_TPM
+#define CONFIG_TPM_TIS_I2C
+#define CONFIG_TPM_TIS_I2C_BUS_NUMBER	3
+#define CONFIG_TPM_TIS_I2C_SLAVE_ADDR	0x20
+
+/* MMC SPL */
+#define CONFIG_SPL
+#define COPY_BL2_FNPTR_ADDR	0x02020030
+
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+
+/* specific .lds file */
+#define CONFIG_SPL_LDSCRIPT	"board/samsung/common/exynos-uboot-spl.lds"
+#define CONFIG_SPL_MAX_FOOTPRINT	(14 * 1024)
+
+
+/* Miscellaneous configurable options */
+#define CONFIG_SYS_LONGHELP		/* undef to save memory */
+#define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser	*/
+#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
+#define CONFIG_SYS_PBSIZE		384	/* Print Buffer Size */
+#define CONFIG_SYS_MAXARGS		16	/* max number of command args */
+#define CONFIG_DEFAULT_CONSOLE		"console=ttySAC1,115200n8\0"
+/* Boot Argument Buffer Size */
+#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
+/* memtest works on */
+#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x5E00000)
+#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x3E00000)
+
+#define CONFIG_SYS_HZ			1000
+
+#define CONFIG_RD_LVL
+
+#define CONFIG_NR_DRAM_BANKS	8
+#define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
+#define PHYS_SDRAM_1		CONFIG_SYS_SDRAM_BASE
+#define PHYS_SDRAM_1_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_2		(CONFIG_SYS_SDRAM_BASE + SDRAM_BANK_SIZE)
+#define PHYS_SDRAM_2_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_3		(CONFIG_SYS_SDRAM_BASE + (2 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_3_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_4		(CONFIG_SYS_SDRAM_BASE + (3 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_4_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_5		(CONFIG_SYS_SDRAM_BASE + (4 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_5_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_6		(CONFIG_SYS_SDRAM_BASE + (5 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_6_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_7		(CONFIG_SYS_SDRAM_BASE + (6 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_7_SIZE	SDRAM_BANK_SIZE
+#define PHYS_SDRAM_8		(CONFIG_SYS_SDRAM_BASE + (7 * SDRAM_BANK_SIZE))
+#define PHYS_SDRAM_8_SIZE	SDRAM_BANK_SIZE
+
+#define CONFIG_SYS_MONITOR_BASE	0x00000000
+
+/* FLASH and environment organization */
+#define CONFIG_SYS_NO_FLASH
+#undef CONFIG_CMD_IMLS
+
+#define CONFIG_SYS_MMC_ENV_DEV		0
+
+#define CONFIG_SECURE_BL1_ONLY
+
+/* Secure FW size configuration */
+#ifdef	CONFIG_SECURE_BL1_ONLY
+#define	CONFIG_SEC_FW_SIZE		(8 << 10)	/* 8KB */
+#else
+#define	CONFIG_SEC_FW_SIZE		0
+#endif
+
+/* Configuration of BL1, BL2, ENV Blocks on mmc */
+#define CONFIG_RES_BLOCK_SIZE	(512)
+#define CONFIG_BL1_SIZE		(16 << 10) /*16 K reserved for BL1*/
+#define	CONFIG_BL2_SIZE		(512UL << 10UL)	/* 512 KB */
+#define CONFIG_ENV_SIZE		(16 << 10)	/* 16 KB */
+
+#define CONFIG_BL1_OFFSET	(CONFIG_RES_BLOCK_SIZE + CONFIG_SEC_FW_SIZE)
+#define CONFIG_BL2_OFFSET	(CONFIG_BL1_OFFSET + CONFIG_BL1_SIZE)
+#define CONFIG_ENV_OFFSET	(CONFIG_BL2_OFFSET + CONFIG_BL2_SIZE)
+
+/* U-boot copy size from boot Media to DRAM.*/
+#define BL2_START_OFFSET	(CONFIG_BL2_OFFSET/512)
+#define BL2_SIZE_BLOC_COUNT	(CONFIG_BL2_SIZE/512)
+
+#define CONFIG_SPI_BOOTING
+#define EXYNOS_COPY_SPI_FNPTR_ADDR	0x02020058
+#define SPI_FLASH_UBOOT_POS		(CONFIG_SEC_FW_SIZE + CONFIG_BL1_SIZE)
+
+#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_PART
+#define CONFIG_PARTITION_UUIDS
+
+/* I2C */
+#define CONFIG_SYS_I2C_INIT_BOARD
+#define CONFIG_HARD_I2C
+#define CONFIG_CMD_I2C
+#define CONFIG_SYS_I2C_SPEED	100000		/* 100 Kbps */
+#define CONFIG_DRIVER_S3C24X0_I2C
+#define CONFIG_I2C_MULTI_BUS
+#define CONFIG_SYS_I2C_SLAVE    0x0
+#define CONFIG_I2C_EDID
+
+/* SPI */
+#define CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_SPI_FLASH
+
+#ifdef CONFIG_SPI_FLASH
+#define CONFIG_EXYNOS_SPI
+#define CONFIG_CMD_SF
+#define CONFIG_CMD_SPI
+#define CONFIG_SPI_FLASH_WINBOND
+#define CONFIG_SPI_FLASH_GIGADEVICE
+#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
+#define CONFIG_SF_DEFAULT_SPEED		50000000
+#define EXYNOS5_SPI_NUM_CONTROLLERS	5
+#endif
+
+#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_ENV_SPI_MODE	SPI_MODE_0
+#define CONFIG_ENV_SECT_SIZE	CONFIG_ENV_SIZE
+#define CONFIG_ENV_SPI_BUS	1
+#define CONFIG_ENV_SPI_MAX_HZ	50000000
+#endif
+
+/* PMIC */
+#define CONFIG_POWER
+#define CONFIG_POWER_I2C
+
+/* Ethernet Controllor Driver */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_SMC911X
+#define CONFIG_SMC911X_BASE		0x5000000
+#define CONFIG_SMC911X_16_BIT
+#define CONFIG_ENV_SROM_BANK		1
+#endif /*CONFIG_CMD_NET*/
+
+/* Enable PXE Support */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_CMD_PXE
+#define CONFIG_MENU
+#endif
+
+/* Enable devicetree support */
+#define CONFIG_OF_LIBFDT
+
+/* SHA hashing */
+#define CONFIG_CMD_HASH
+#define CONFIG_HASH_VERIFY
+#define CONFIG_SHA1
+#define CONFIG_SHA256
+
+/* Enable Time Command */
+#define CONFIG_CMD_TIME
+
+#define CONFIG_CMD_BOOTZ
+
+#endif	/* __CONFIG_H */
include/configs/exynos5250-dt.h +8 -311

359 lines not on this page · raw message

include/configs/smdk5420.h new file +49 -0

49 lines not on this page · raw message

Signature · 1 line
1.7.12.4
#29 lore raw

PATCH v6 8/10 Config: Add initial config for SMDK5420

Dear Rajeshwari S Shinde,

Quoted 68 lines · Rajeshwari S Shinde

Adding initial config for SMDK5420 to build and boot U-Boot over Exynos based SMDK5420.

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Created a common exynos5-dt.h
Changes in V5:
- None
Changes in V6:
- None

 include/configs/exynos5-dt.h    | 302
+++++++++++++++++++++++++++++++++++++
 include/configs/exynos5250-dt.h | 319
+---------------------------------------
 include/configs/smdk5420.h      |  49 ++++++
 3 files changed, 359 insertions(+), 311 deletions(-)
 create mode 100644 include/configs/exynos5-dt.h
 create mode 100644 include/configs/smdk5420.h
include/configs/exynos5-dt.h new file +35 -0
new file mode 100644
index 0000000..fa6bb89
@@ -0,0 +1,302 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ *
+ * Configuration settings for the SAMSUNG EXYNOS5 board.
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* High Level Configuration Options */
+#define CONFIG_SAMSUNG                 /* in a SAMSUNG core */
+#define CONFIG_S5P                     /* S5P Family */
+#define CONFIG_EXYNOS5                 /* which is in a Exynos5 Family */
+
+#include <asm/arch/cpu.h>              /* get chip and board defs */
+
+#define CONFIG_SYS_GENERIC_BOARD
+#define CONFIG_ARCH_CPU_INIT
+#define CONFIG_DISPLAY_CPUINFO
+#define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_BOARD_COMMON
+#define CONFIG_ARCH_EARLY_INIT_R
+
+/* Enable fdt support for Exynos5250 */
+#define CONFIG_OF_CONTROL
+#define CONFIG_OF_SEPARATE
+
+/* Allow tracing to be enabled */
+#define CONFIG_TRACE
+#define CONFIG_CMD_TRACE
+#define CONFIG_TRACE_BUFFER_SIZE       (16 << 20)
+#define CONFIG_TRACE_EARLY_SIZE                (8 << 20)
+#define CONFIG_TRACE_EARLY

include/configs/exynos5-dt.h line 45

Quoted 10 lines
include/configs/exynos5-dt.h new file +10 -0
+#define CONFIG_TRACE_EARLY_ADDR                0x50000000
+
+/* Keep L2 Cache Disabled */
+#define CONFIG_SYS_DCACHE_OFF
+
+/* Enable ACE acceleration for SHA1 and SHA256 */
+#define CONFIG_EXYNOS_ACE_SHA
+#define CONFIG_SHA_HW_ACCEL
+
+

please remove blank line.

include/configs/exynos5-dt.h line 54

Quoted 10 lines
include/configs/exynos5-dt.h new file +9 -0
+/* input clock of PLL: SMDK5250 has 24MHz input clock */
+#define CONFIG_SYS_CLK_FREQ            24000000
+
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_INITRD_TAG
+#define CONFIG_CMDLINE_EDITING
+
+

please remove blank line.

Quoted 39 lines
include/configs/exynos5-dt.h new file +38 -0
+/* Power Down Modes */
+#define S5P_CHECK_SLEEP                        0x00000BAD
+#define S5P_CHECK_DIDLE                        0xBAD00000
+#define S5P_CHECK_LPA                  0xABAD0000
+
+/* Offset for inform registers */
+#define INFORM0_OFFSET                 0x800
+#define INFORM1_OFFSET                 0x804
+#define INFORM2_OFFSET                 0x808
+#define INFORM3_OFFSET                 0x80c
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN          (CONFIG_ENV_SIZE + (4 << 20))
+
+/* select serial console configuration */
+#define CONFIG_BAUDRATE                        115200
+#define EXYNOS5_DEFAULT_UART_OFFSET    0x010000
+#define CONFIG_SILENT_CONSOLE
+
+/* Enable keyboard */
+#define CONFIG_CROS_EC         /* CROS_EC protocol */
+#define CONFIG_CROS_EC_SPI             /* Support CROS_EC over SPI */
+#define CONFIG_CROS_EC_I2C             /* Support CROS_EC over I2C */
+#define CONFIG_CROS_EC_KEYB    /* CROS_EC keyboard input */
+#define CONFIG_CMD_CROS_EC
+#define CONFIG_KEYBOARD
+
+/* Console configuration */
+#define CONFIG_CONSOLE_MUX
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV
+#define EXYNOS_DEVICE_SETTINGS \
+               "stdin=serial,cros-ec-keyb\0" \
+               "stdout=serial,lcd\0" \
+               "stderr=serial,lcd\0"
+
+#define CONFIG_EXTRA_ENV_SETTINGS \
+       EXYNOS_DEVICE_SETTINGS
+

include/configs/exynos5-dt.h line 102

Quoted 10 lines
include/configs/exynos5-dt.h new file +10 -0
+/* SD/MMC configuration */
+#define CONFIG_GENERIC_MMC
+#define CONFIG_MMC
+#define CONFIG_SDHCI
+#define CONFIG_S5P_SDHCI
+#define CONFIG_DWMMC
+#define CONFIG_EXYNOS_DWMMC
+#define CONFIG_SUPPORT_EMMC_BOOT
+
+

please remove blank line.

Quoted 107 lines
include/configs/exynos5-dt.h new file +62 -0
+#define CONFIG_BOARD_EARLY_INIT_F
+#define CONFIG_SKIP_LOWLEVEL_INIT
+
+/* PWM */
+#define CONFIG_PWM
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+
+/* Command definition*/
+#include <config_cmd_default.h>
+
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_ELF
+#define CONFIG_CMD_MMC
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_HASH
+
+#define CONFIG_BOOTDELAY               3
+#define CONFIG_ZERO_BOOTDELAY_CHECK
+
+/* Thermal Management Unit */
+#define CONFIG_EXYNOS_TMU
+#define CONFIG_CMD_DTT
+#define CONFIG_TMU_CMD_DTT
+
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+
+/* USB boot mode */
+#define CONFIG_USB_BOOTING
+#define EXYNOS_COPY_USB_FNPTR_ADDR     0x02020070
+#define EXYNOS_USB_SECONDARY_BOOT      0xfeed0002
+#define EXYNOS_IRAM_SECONDARY_BASE     0x02020018
+
+/* TPM */
+#define CONFIG_TPM
+#define CONFIG_CMD_TPM
+#define CONFIG_TPM_TIS_I2C
+#define CONFIG_TPM_TIS_I2C_BUS_NUMBER  3
+#define CONFIG_TPM_TIS_I2C_SLAVE_ADDR  0x20
+
+/* MMC SPL */
+#define CONFIG_SPL
+#define COPY_BL2_FNPTR_ADDR    0x02020030
+
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+
+/* specific .lds file */
+#define CONFIG_SPL_LDSCRIPT    "board/samsung/common/exynos-uboot-spl.lds"
+#define CONFIG_SPL_MAX_FOOTPRINT       (14 * 1024)
+
+
+/* Miscellaneous configurable options */
+#define CONFIG_SYS_LONGHELP            /* undef to save memory */
+#define CONFIG_SYS_HUSH_PARSER         /* use "hush" command parser    */
+#define CONFIG_SYS_CBSIZE              256     /* Console I/O Buffer Size

*/

include/configs/exynos5-dt.h new file +2 -0
+#define CONFIG_SYS_PBSIZE              384     /* Print Buffer Size */
+#define CONFIG_SYS_MAXARGS             16      /* max number of command

args */

include/configs/exynos5-dt.h new file +19 -0
+#define CONFIG_DEFAULT_CONSOLE         "console=ttySAC1,115200n8\0"
+/* Boot Argument Buffer Size */
+#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
+/* memtest works on */
+#define CONFIG_SYS_MEMTEST_START       CONFIG_SYS_SDRAM_BASE
+#define CONFIG_SYS_MEMTEST_END         (CONFIG_SYS_SDRAM_BASE + 0x5E00000)
+#define CONFIG_SYS_LOAD_ADDR           (CONFIG_SYS_SDRAM_BASE + 0x3E00000)
+
+#define CONFIG_SYS_HZ                  1000
+
+#define CONFIG_RD_LVL
+
+#define CONFIG_NR_DRAM_BANKS   8
+#define SDRAM_BANK_SIZE                (256UL << 20UL) /* 256 MB */
+#define PHYS_SDRAM_1           CONFIG_SYS_SDRAM_BASE
+#define PHYS_SDRAM_1_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_2           (CONFIG_SYS_SDRAM_BASE + SDRAM_BANK_SIZE)
+#define PHYS_SDRAM_2_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_3           (CONFIG_SYS_SDRAM_BASE + (2 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +2 -0
+#define PHYS_SDRAM_3_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_4           (CONFIG_SYS_SDRAM_BASE + (3 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +2 -0
+#define PHYS_SDRAM_4_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_5           (CONFIG_SYS_SDRAM_BASE + (4 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +2 -0
+#define PHYS_SDRAM_5_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_6           (CONFIG_SYS_SDRAM_BASE + (5 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +2 -0
+#define PHYS_SDRAM_6_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_7           (CONFIG_SYS_SDRAM_BASE + (6 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +2 -0
+#define PHYS_SDRAM_7_SIZE      SDRAM_BANK_SIZE
+#define PHYS_SDRAM_8           (CONFIG_SYS_SDRAM_BASE + (7 *

SDRAM_BANK_SIZE))

include/configs/exynos5-dt.h new file +5 -0
+#define PHYS_SDRAM_8_SIZE      SDRAM_BANK_SIZE
+
+#define CONFIG_SYS_MONITOR_BASE        0x00000000
+
+/* FLASH and environment organization */

include/configs/exynos5-dt.h line 210

Quoted 10 lines
include/configs/exynos5-dt.h new file +10 -0
+#define CONFIG_SYS_NO_FLASH
+#undef CONFIG_CMD_IMLS
+
+#define CONFIG_SYS_MMC_ENV_DEV         0
+
+#define CONFIG_SECURE_BL1_ONLY
+
+/* Secure FW size configuration */
+#ifdef CONFIG_SECURE_BL1_ONLY
+#define        CONFIG_SEC_FW_SIZE              (8 << 10)       /* 8KB */

please remove spaces.

+#else

Quoted 2 lines

+#define CONFIG_SEC_FW_SIZE 0

ditto.

Quoted 8 lines
include/configs/exynos5-dt.h new file +5 -0
+#endif
+
+/* Configuration of BL1, BL2, ENV Blocks on mmc */
+#define CONFIG_RES_BLOCK_SIZE  (512)
+#define CONFIG_BL1_SIZE                (16 << 10) /*16 K reserved for

BL1*/
+#define CONFIG_BL2_SIZE (512UL << 10UL) /* 512 KB */

ditto.

Quoted 526 lines
include/configs/exynos5-dt.h new file +3 -0
+#define CONFIG_ENV_SIZE                (16 << 10)      /* 16 KB */
+
+#define CONFIG_BL1_OFFSET      (CONFIG_RES_BLOCK_SIZE +

CONFIG_SEC_FW_SIZE)

include/configs/exynos5-dt.h new file +10 -0
+#define CONFIG_BL2_OFFSET      (CONFIG_BL1_OFFSET + CONFIG_BL1_SIZE)
+#define CONFIG_ENV_OFFSET      (CONFIG_BL2_OFFSET + CONFIG_BL2_SIZE)
+
+/* U-boot copy size from boot Media to DRAM.*/
+#define BL2_START_OFFSET       (CONFIG_BL2_OFFSET/512)
+#define BL2_SIZE_BLOC_COUNT    (CONFIG_BL2_SIZE/512)
+
+#define CONFIG_SPI_BOOTING
+#define EXYNOS_COPY_SPI_FNPTR_ADDR     0x02020058
+#define SPI_FLASH_UBOOT_POS            (CONFIG_SEC_FW_SIZE +

CONFIG_BL1_SIZE)

include/configs/exynos5-dt.h new file +71 -0
+
+#define CONFIG_DOS_PARTITION
+#define CONFIG_EFI_PARTITION
+#define CONFIG_CMD_PART
+#define CONFIG_PARTITION_UUIDS
+
+/* I2C */
+#define CONFIG_SYS_I2C_INIT_BOARD
+#define CONFIG_HARD_I2C
+#define CONFIG_CMD_I2C
+#define CONFIG_SYS_I2C_SPEED   100000          /* 100 Kbps */
+#define CONFIG_DRIVER_S3C24X0_I2C
+#define CONFIG_I2C_MULTI_BUS
+#define CONFIG_SYS_I2C_SLAVE    0x0
+#define CONFIG_I2C_EDID
+
+/* SPI */
+#define CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_SPI_FLASH
+
+#ifdef CONFIG_SPI_FLASH
+#define CONFIG_EXYNOS_SPI
+#define CONFIG_CMD_SF
+#define CONFIG_CMD_SPI
+#define CONFIG_SPI_FLASH_WINBOND
+#define CONFIG_SPI_FLASH_GIGADEVICE
+#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
+#define CONFIG_SF_DEFAULT_SPEED                50000000
+#define EXYNOS5_SPI_NUM_CONTROLLERS    5
+#endif
+
+#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
+#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
+#define CONFIG_ENV_SPI_BUS     1
+#define CONFIG_ENV_SPI_MAX_HZ  50000000
+#endif
+
+/* PMIC */
+#define CONFIG_POWER
+#define CONFIG_POWER_I2C
+
+/* Ethernet Controllor Driver */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_SMC911X
+#define CONFIG_SMC911X_BASE            0x5000000
+#define CONFIG_SMC911X_16_BIT
+#define CONFIG_ENV_SROM_BANK           1
+#endif /*CONFIG_CMD_NET*/
+
+/* Enable PXE Support */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_CMD_PXE
+#define CONFIG_MENU
+#endif
+
+/* Enable devicetree support */
+#define CONFIG_OF_LIBFDT
+
+/* SHA hashing */
+#define CONFIG_CMD_HASH
+#define CONFIG_HASH_VERIFY
+#define CONFIG_SHA1
+#define CONFIG_SHA256
+
+/* Enable Time Command */
+#define CONFIG_CMD_TIME
+
+#define CONFIG_CMD_BOOTZ
+
+#endif /* __CONFIG_H */
include/configs/exynos5250-dt.h +5 -145
index 3736ea8..689919d 100644
@@ -1,3 +1,4 @@
+
 /*
  * Copyright (C) 2012 Samsung Electronics
  *
@@ -6,325 +7,34 @@
  * SPDX-License-Identifier:    GPL-2.0+
  */
 
-#ifndef __CONFIG_H
-#define __CONFIG_H
-
-/* High Level Configuration Options */
-#define CONFIG_SAMSUNG                 /* in a SAMSUNG core */
-#define CONFIG_S5P                     /* S5P Family */
-#define CONFIG_EXYNOS5                 /* which is in a Exynos5 Family */
-#define CONFIG_EXYNOS5250
-
-#include <asm/arch/cpu.h>              /* get chip and board defs */
-
-#define CONFIG_SYS_GENERIC_BOARD
-#define CONFIG_ARCH_CPU_INIT
-#define CONFIG_DISPLAY_CPUINFO
-#define CONFIG_DISPLAY_BOARDINFO
-#define CONFIG_BOARD_COMMON
-#define CONFIG_ARCH_EARLY_INIT_R
+#ifndef __CONFIG_5250_H
+#define __CONFIG_5250_H
 
-/* Enable fdt support for Exynos5250 */
-#define CONFIG_OF_CONTROL
-#define CONFIG_OF_SEPARATE
+#include <configs/exynos5-dt.h>
 
-/* Allow tracing to be enabled */
-#define CONFIG_TRACE
-#define CONFIG_CMD_TRACE
-#define CONFIG_TRACE_BUFFER_SIZE       (16 << 20)
-#define CONFIG_TRACE_EARLY_SIZE                (8 << 20)
-#define CONFIG_TRACE_EARLY
-#define CONFIG_TRACE_EARLY_ADDR                0x50000000
-
-/* Keep L2 Cache Disabled */
-#define CONFIG_SYS_DCACHE_OFF
-
-/* Enable ACE acceleration for SHA1 and SHA256 */
-#define CONFIG_EXYNOS_ACE_SHA
-#define CONFIG_SHA_HW_ACCEL
+#define CONFIG_EXYNOS5250
 
 #define CONFIG_SYS_SDRAM_BASE          0x40000000
 #define CONFIG_SYS_TEXT_BASE           0x43E00000
 
-/* input clock of PLL: SMDK5250 has 24MHz input clock */
-#define CONFIG_SYS_CLK_FREQ            24000000
-
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_INITRD_TAG
-#define CONFIG_CMDLINE_EDITING
-
 /* MACH_TYPE_SMDK5250 macro will be removed once added to mach-types */
 #define MACH_TYPE_SMDK5250             3774
 #define CONFIG_MACH_TYPE               MACH_TYPE_SMDK5250
 
-/* Power Down Modes */
-#define S5P_CHECK_SLEEP                        0x00000BAD
-#define S5P_CHECK_DIDLE                        0xBAD00000
-#define S5P_CHECK_LPA                  0xABAD0000
-
-/* Offset for inform registers */
-#define INFORM0_OFFSET                 0x800
-#define INFORM1_OFFSET                 0x804
-
-/* Size of malloc() pool */
-#define CONFIG_SYS_MALLOC_LEN          (CONFIG_ENV_SIZE + (4 << 20))
-
-/* select serial console configuration */
-#define CONFIG_BAUDRATE                        115200
-#define EXYNOS5_DEFAULT_UART_OFFSET    0x010000
-#define CONFIG_SILENT_CONSOLE
-
-/* Enable keyboard */
-#define CONFIG_CROS_EC         /* CROS_EC protocol */
-#define CONFIG_CROS_EC_SPI             /* Support CROS_EC over SPI */
-#define CONFIG_CROS_EC_I2C             /* Support CROS_EC over I2C */
-#define CONFIG_CROS_EC_KEYB    /* CROS_EC keyboard input */
-#define CONFIG_CMD_CROS_EC
-#define CONFIG_KEYBOARD
-
-/* Console configuration */
-#define CONFIG_CONSOLE_MUX
-#define CONFIG_SYS_CONSOLE_IS_IN_ENV
-#define EXYNOS_DEVICE_SETTINGS \
-               "stdin=serial,cros-ec-keyb\0" \
-               "stdout=serial,lcd\0" \
-               "stderr=serial,lcd\0"
-
-#define CONFIG_EXTRA_ENV_SETTINGS \
-       EXYNOS_DEVICE_SETTINGS
-
-/* SD/MMC configuration */
-#define CONFIG_GENERIC_MMC
-#define CONFIG_MMC
-#define CONFIG_SDHCI
-#define CONFIG_S5P_SDHCI
-#define CONFIG_DWMMC
-#define CONFIG_EXYNOS_DWMMC
-#define CONFIG_SUPPORT_EMMC_BOOT
-
-
-#define CONFIG_BOARD_EARLY_INIT_F
-#define CONFIG_SKIP_LOWLEVEL_INIT
-
-/* PWM */
-#define CONFIG_PWM
-
-/* allow to overwrite serial and ethaddr */
-#define CONFIG_ENV_OVERWRITE
-
-/* Command definition*/
-#include <config_cmd_default.h>
-
-#define CONFIG_CMD_PING
-#define CONFIG_CMD_ELF
-#define CONFIG_CMD_MMC
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_FAT
-#define CONFIG_CMD_NET
-#define CONFIG_CMD_HASH
-
-#define CONFIG_BOOTDELAY               3
-#define CONFIG_ZERO_BOOTDELAY_CHECK
-
-/* Thermal Management Unit */
-#define CONFIG_EXYNOS_TMU
-#define CONFIG_CMD_DTT
-#define CONFIG_TMU_CMD_DTT
-
-/* USB */
-#define CONFIG_CMD_USB
-#define CONFIG_USB_EHCI
-#define CONFIG_USB_EHCI_EXYNOS
-#define CONFIG_USB_STORAGE
-
-/* USB boot mode */
-#define CONFIG_USB_BOOTING
-#define EXYNOS_COPY_USB_FNPTR_ADDR     0x02020070
-#define EXYNOS_USB_SECONDARY_BOOT      0xfeed0002
-#define EXYNOS_IRAM_SECONDARY_BASE     0x02020018
-
-/* TPM */
-#define CONFIG_TPM
-#define CONFIG_CMD_TPM
-#define CONFIG_TPM_TIS_I2C
-#define CONFIG_TPM_TIS_I2C_BUS_NUMBER  3
-#define CONFIG_TPM_TIS_I2C_SLAVE_ADDR  0x20
-
-/* MMC SPL */
-#define CONFIG_SPL
-#define COPY_BL2_FNPTR_ADDR    0x02020030
-
-#define CONFIG_SPL_LIBCOMMON_SUPPORT
-
-/* specific .lds file */
-#define CONFIG_SPL_LDSCRIPT    "board/samsung/common/exynos-uboot-spl.lds"
 #define CONFIG_SPL_TEXT_BASE   0x02023400
-#define CONFIG_SPL_MAX_FOOTPRINT       (14 * 1024)
-
 #define CONFIG_BOOTCOMMAND     "mmc read 40007000 451 2000; bootm

40007000"

include/configs/exynos5250-dt.h +0 -4
-/* Miscellaneous configurable options */
-#define CONFIG_SYS_LONGHELP            /* undef to save memory */
-#define CONFIG_SYS_HUSH_PARSER         /* use "hush" command parser    */
 #define CONFIG_SYS_PROMPT              "SMDK5250 # "
-#define CONFIG_SYS_CBSIZE              256     /* Console I/O Buffer Size

*/

include/configs/exynos5250-dt.h +0 -2
-#define CONFIG_SYS_PBSIZE              384     /* Print Buffer Size */
-#define CONFIG_SYS_MAXARGS             16      /* max number of command

args */

include/configs/exynos5250-dt.h +0 -19
-#define CONFIG_DEFAULT_CONSOLE         "console=ttySAC1,115200n8\0"
-/* Boot Argument Buffer Size */
-#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
-/* memtest works on */
-#define CONFIG_SYS_MEMTEST_START       CONFIG_SYS_SDRAM_BASE
-#define CONFIG_SYS_MEMTEST_END         (CONFIG_SYS_SDRAM_BASE + 0x5E00000)
-#define CONFIG_SYS_LOAD_ADDR           (CONFIG_SYS_SDRAM_BASE + 0x3E00000)
-
-#define CONFIG_SYS_HZ                  1000
-
-#define CONFIG_RD_LVL
-
-#define CONFIG_NR_DRAM_BANKS   8
-#define SDRAM_BANK_SIZE                (256UL << 20UL) /* 256 MB */
-#define PHYS_SDRAM_1           CONFIG_SYS_SDRAM_BASE
-#define PHYS_SDRAM_1_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_2           (CONFIG_SYS_SDRAM_BASE + SDRAM_BANK_SIZE)
-#define PHYS_SDRAM_2_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_3           (CONFIG_SYS_SDRAM_BASE + (2 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -2
-#define PHYS_SDRAM_3_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_4           (CONFIG_SYS_SDRAM_BASE + (3 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -2
-#define PHYS_SDRAM_4_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_5           (CONFIG_SYS_SDRAM_BASE + (4 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -2
-#define PHYS_SDRAM_5_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_6           (CONFIG_SYS_SDRAM_BASE + (5 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -2
-#define PHYS_SDRAM_6_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_7           (CONFIG_SYS_SDRAM_BASE + (6 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -2
-#define PHYS_SDRAM_7_SIZE      SDRAM_BANK_SIZE
-#define PHYS_SDRAM_8           (CONFIG_SYS_SDRAM_BASE + (7 *

SDRAM_BANK_SIZE))

include/configs/exynos5250-dt.h +0 -21
-#define PHYS_SDRAM_8_SIZE      SDRAM_BANK_SIZE
-
-#define CONFIG_SYS_MONITOR_BASE        0x00000000
-
-/* FLASH and environment organization */
-#define CONFIG_SYS_NO_FLASH
-#undef CONFIG_CMD_IMLS
 #define CONFIG_IDENT_STRING            " for SMDK5250"
 
-#define CONFIG_SYS_MMC_ENV_DEV         0
-
-#define CONFIG_SECURE_BL1_ONLY
-
-/* Secure FW size configuration */
-#ifdef CONFIG_SECURE_BL1_ONLY
-#define        CONFIG_SEC_FW_SIZE              (8 << 10)       /* 8KB */
-#else
-#define        CONFIG_SEC_FW_SIZE              0
-#endif
-
-/* Configuration of BL1, BL2, ENV Blocks on mmc */
-#define CONFIG_RES_BLOCK_SIZE  (512)
-#define CONFIG_BL1_SIZE                (16 << 10) /*16 K reserved for

BL1*/

include/configs/exynos5250-dt.h +0 -4
-#define        CONFIG_BL2_SIZE         (512UL << 10UL) /* 512 KB */
-#define CONFIG_ENV_SIZE                (16 << 10)      /* 16 KB */
-
-#define CONFIG_BL1_OFFSET      (CONFIG_RES_BLOCK_SIZE +

CONFIG_SEC_FW_SIZE)

include/configs/exynos5250-dt.h +0 -10
-#define CONFIG_BL2_OFFSET      (CONFIG_BL1_OFFSET + CONFIG_BL1_SIZE)
-#define CONFIG_ENV_OFFSET      (CONFIG_BL2_OFFSET + CONFIG_BL2_SIZE)
-
-/* U-boot copy size from boot Media to DRAM.*/
-#define BL2_START_OFFSET       (CONFIG_BL2_OFFSET/512)
-#define BL2_SIZE_BLOC_COUNT    (CONFIG_BL2_SIZE/512)
-
-#define CONFIG_SPI_BOOTING
-#define EXYNOS_COPY_SPI_FNPTR_ADDR     0x02020058
-#define SPI_FLASH_UBOOT_POS            (CONFIG_SEC_FW_SIZE +

CONFIG_BL1_SIZE)

include/configs/exynos5250-dt.h +3 -96
-
-#define CONFIG_DOS_PARTITION
-#define CONFIG_EFI_PARTITION
-#define CONFIG_CMD_PART
-#define CONFIG_PARTITION_UUIDS
-
-
 #define CONFIG_IRAM_STACK      0x02050000
-
 #define CONFIG_SYS_INIT_SP_ADDR        CONFIG_IRAM_STACK
 
-/* I2C */
-#define CONFIG_SYS_I2C_INIT_BOARD
-#define CONFIG_HARD_I2C
-#define CONFIG_CMD_I2C
-#define CONFIG_SYS_I2C_SPEED   100000          /* 100 Kbps */
-#define CONFIG_DRIVER_S3C24X0_I2C
-#define CONFIG_I2C_MULTI_BUS
-#define CONFIG_MAX_I2C_NUM     8
-#define CONFIG_SYS_I2C_SLAVE    0x0
-#define CONFIG_I2C_EDID
-
 /* PMIC */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_MAX77686
-
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SPI_FLASH_GIGADEVICE
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
-/* PMIC */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
 #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED                50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS    5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE    SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE   CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS     1
-#define CONFIG_ENV_SPI_MAX_HZ  50000000
-#endif
-
-/* Ethernet Controllor Driver */
-#ifdef CONFIG_CMD_NET
-#define CONFIG_SMC911X
-#define CONFIG_SMC911X_BASE            0x5000000
-#define CONFIG_SMC911X_16_BIT
-#define CONFIG_ENV_SROM_BANK           1
-#endif /*CONFIG_CMD_NET*/
-
-/* Enable PXE Support */
-#ifdef CONFIG_CMD_NET
-#define CONFIG_CMD_PXE
-#define CONFIG_MENU
-#endif
+/* I2C */
+#define CONFIG_MAX_I2C_NUM     8
 
 /* Sound */
 #define CONFIG_CMD_SOUND
@@ -335,15 +45,6 @@
 #define CONFIG_SOUND_WM8994
 #endif
 
-/* Enable devicetree support */
-#define CONFIG_OF_LIBFDT
-
-/* SHA hashing */
-#define CONFIG_CMD_HASH
-#define CONFIG_HASH_VERIFY
-#define CONFIG_SHA1
-#define CONFIG_SHA256
-
 /* Display */
 #define CONFIG_LCD
 #ifdef CONFIG_LCD
@@ -353,8 +54,4 @@
 #define LCD_YRES                       1600
 #define LCD_BPP                        LCD_COLOR16
 #endif
-
-/* Enable Time Command */
-#define CONFIG_CMD_TIME
-
-#endif /* __CONFIG_H */
+#endif  /* __CONFIG_5250_H */
include/configs/smdk5420.h new file +15 -0
new file mode 100644
index 0000000..e580049
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ *
+ * Configuration settings for the SAMSUNG EXYNOS5420 board.
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#ifndef __CONFIG_5420_H
+#define __CONFIG_5420_H
+
+#include <configs/exynos5-dt.h>
+
+#define CONFIG_EXYNOS5420              /* which is in a Exynos5 Family */
+#define CONFIG_SMDK5420                        /* which is in a SMDK5420

*/

include/configs/smdk5420.h new file +20 -0
+
+#undef CONFIG_DEFAULT_DEVICE_TREE
+#define CONFIG_DEFAULT_DEVICE_TREE     exynos5420-smdk5420
+
+#define CONFIG_ARCH_DEVICE_TREE                exynos5420
+
+#define CONFIG_SYS_SDRAM_BASE          0x20000000
+#define CONFIG_SYS_TEXT_BASE           0x23E00000
+
+#define CONFIG_BOARD_REV_GPIO_COUNT    2
+
+/* MACH_TYPE_SMDK5420 macro will be removed once added to mach-types */
+#define MACH_TYPE_SMDK5420             8002 /* Temporary number */
+#define CONFIG_MACH_TYPE               MACH_TYPE_SMDK5420
+
+/* select serial console configuration */
+#define CONFIG_SERIAL3                 /* use SERIAL 3 */
+
+#define CONFIG_SPL_TEXT_BASE   0x02024400
+#define CONFIG_BOOTCOMMAND     "mmc read 20007000 451 2000; bootm

20007000"

include/configs/smdk5420.h new file +14 -1
+
+#define CONFIG_SYS_PROMPT              "SMDK5420 # "
+#define CONFIG_IDENT_STRING            " for SMDK5420"
+
+#define CONFIG_IRAM_TOP                0x02074000
+/*
+ * Put the initial stack pointer 1KB below this to allow room for the
+ * SPL marker. This value is arbitrary, but gd_t is placed starting here.
+ */
+#define CONFIG_SYS_INIT_SP_ADDR        (CONFIG_IRAM_TOP - 0x800)
+
+#define CONFIG_MAX_I2C_NUM     11
+
+#endif /* __CONFIG_5420_H */
--

1.7.12.4

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#30 lore raw

PATCH v6 9/10 SPL: EXYNOS: Prepare for variable size SPL support

In reply to Rajeshwari S Shinde

When variable size SPL is used, the BL1 expects the SPL to be encapsulated differently: instead of putting the checksum at a fixed offset in the SPL blob, prepend the blob with a header including the size and the checksum.

The enhancements include
- adding a command line option, '--vs' to indicate the need for the variable size encapsulation
- padding the fixed size encapsulated blob with 0xff instead of random memory contents
- do not silently truncate the input file, report error instead
- no need to explicitly closing files/freeing memory, this all happens on exit; removing cleanups it makes code clearer
- profuse commenting
- modify Makefile to allow enabling the new feature per board

---
Changes in V2:
- None
Changes in V3:
- None
Changes in V4:
- Created a common exynos5-dt.h
Changes in V5:
- None
Changes in V6:
- None.

 include/configs/smdk5420.h |   7 ++
 spl/Makefile               |   7 +-
 tools/mkexynosspl.c        | 167 +++++++++++++++++++++++++++++++++------------
 3 files changed, 137 insertions(+), 44 deletions(-)
include/configs/smdk5420.h +7 -0
index e580049..447f8e5 100644
@@ -19,6 +19,8 @@
 
 #define CONFIG_ARCH_DEVICE_TREE		exynos5420
 
+#define CONFIG_VAR_SIZE_SPL
+
 #define CONFIG_SYS_SDRAM_BASE		0x20000000
 #define CONFIG_SYS_TEXT_BASE		0x23E00000
 
@@ -31,7 +33,12 @@
 /* select serial console configuration */
 #define CONFIG_SERIAL3			/* use SERIAL 3 */
 
+#ifdef CONFIG_VAR_SIZE_SPL
+#define CONFIG_SPL_TEXT_BASE		0x02024410
+#else
 #define CONFIG_SPL_TEXT_BASE	0x02024400
+#endif
+
 #define CONFIG_BOOTCOMMAND	"mmc read 20007000 451 2000; bootm 20007000"
 
 #define CONFIG_SYS_PROMPT		"SMDK5420 # "
spl/Makefile +6 -1
index b366ac2..d5f6ae8 100644
@@ -184,8 +184,13 @@ endif
 all:	$(ALL-y)
 
 ifdef CONFIG_SAMSUNG
+ifdef CONFIG_VAR_SIZE_SPL
+VAR_SIZE_PARAM = --vs
+else
+VAR_SIZE_PARAM =
+endif
 $(obj)$(BOARD)-spl.bin: $(obj)u-boot-spl.bin
-	$(OBJTREE)/tools/mk$(BOARD)spl \
+	$(OBJTREE)/tools/mk$(BOARD)spl $(VAR_SIZE_PARAM) \
 		$(obj)u-boot-spl.bin $(obj)$(BOARD)-spl.bin
 endif
 
tools/mkexynosspl.c +124 -43

217 lines not on this page · raw message

Signature · 1 line
1.7.12.4
#31 lore raw

PATCH v6 10/10 DWMMC: SMDK5420: Disable SMU for eMMC

In reply to Rajeshwari S Shinde

SMDK5420 has a new Security Management Unit added for dwmmc driver, hence, configuring the control registers to support booting via eMMC.

---
Changes in V3:
- New patch.
Changes in V4:
Added flag to dissble SMU
Changes in V5:
- None
Changes in V6:
- Moved the SMU definitions to arch/arm dwmmc.h

 arch/arm/include/asm/arch-exynos/dwmmc.h | 13 +++++++++++++
 drivers/mmc/dw_mmc.c                     | 11 +++++++++++
 drivers/mmc/exynos_dw_mmc.c              |  3 +++
 include/dwmmc.h                          |  3 +++
 4 files changed, 30 insertions(+)
arch/arm/include/asm/arch-exynos/dwmmc.h +13 -0
index b9eca76..d1c5d4f 100644
@@ -14,6 +14,19 @@
 #define DWMCI_SET_DRV_CLK(x)	((x) << 16)
 #define DWMCI_SET_DIV_RATIO(x)	((x) << 24)
 
+#define EMMCP_MPSBEGIN0		0x1200
+#define EMMCP_SEND0		0x1204
+#define EMMCP_CTRL0		0x120C
+
+#define MPSCTRL_SECURE_READ_BIT		(0x1<<7)
+#define MPSCTRL_SECURE_WRITE_BIT	(0x1<<6)
+#define MPSCTRL_NON_SECURE_READ_BIT	(0x1<<5)
+#define MPSCTRL_NON_SECURE_WRITE_BIT	(0x1<<4)
+#define MPSCTRL_USE_FUSE_KEY		(0x1<<3)
+#define MPSCTRL_ECB_MODE		(0x1<<2)
+#define MPSCTRL_ENCRYPTION		(0x1<<1)
+#define MPSCTRL_VALID			(0x1<<0)
+
 #ifdef CONFIG_OF_CONTROL
 int exynos_dwmmc_init(const void *blob);
 #endif
drivers/mmc/dw_mmc.c +11 -0
index 9a803a0..a3506d4 100644
@@ -11,6 +11,7 @@
 #include <mmc.h>
 #include <dwmmc.h>
 #include <asm-generic/errno.h>
+#include <asm/arch/dwmmc.h>
 
 #define PAGE_SIZE 4096
 
@@ -301,6 +302,16 @@ static int dwmci_init(struct mmc *mmc)
 	struct dwmci_host *host = (struct dwmci_host *)mmc->priv;
 	u32 fifo_size;
 
+	if (host->quirks & DWMCI_QUIRK_DISABLE_SMU) {
+		dwmci_writel(host, EMMCP_MPSBEGIN0, 0);
+		dwmci_writel(host, EMMCP_SEND0, 0);
+		dwmci_writel(host, EMMCP_CTRL0,
+			     MPSCTRL_SECURE_READ_BIT |
+			     MPSCTRL_SECURE_WRITE_BIT |
+			     MPSCTRL_NON_SECURE_READ_BIT |
+			     MPSCTRL_NON_SECURE_WRITE_BIT | MPSCTRL_VALID);
+	}
+
 	dwmci_writel(host, DWMCI_PWREN, 1);
 
 	if (!dwmci_wait_reset(host, DWMCI_RESET_ALL)) {
drivers/mmc/exynos_dw_mmc.c +3 -0
index 4ef9fec..f7439a0 100644
@@ -62,6 +62,9 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)
 	host->name = "EXYNOS DWMMC";
 	host->ioaddr = (void *)regbase;
 	host->buswidth = bus_width;
+#ifdef CONFIG_EXYNOS5420
+	host->quirks = DWMCI_QUIRK_DISABLE_SMU;
+#endif
 
 	if (clksel) {
 		host->clksel_val = clksel;
include/dwmmc.h +3 -0
index 08ced0b..6263140 100644
@@ -123,6 +123,9 @@
 #define DWMCI_BMOD_IDMAC_FB	(1 << 1)
 #define DWMCI_BMOD_IDMAC_EN	(1 << 7)
 
+/* quirks */
+#define DWMCI_QUIRK_DISABLE_SMU		(1 << 0)
+
 struct dwmci_host {
 	char *name;
 	void *ioaddr;
Signature · 1 line
1.7.12.4
#32 lore raw

PATCH v6 10/10 DWMMC: SMDK5420: Disable SMU for eMMC

Looks good to me.

Quoted 104 lines · Rajeshwari S Shinde

SMDK5420 has a new Security Management Unit added for dwmmc driver, hence, configuring the control registers to support booting via eMMC.

---
Changes in V3:
- New patch.
Changes in V4:
Added flag to dissble SMU
Changes in V5:
- None
Changes in V6:
- Moved the SMU definitions to arch/arm dwmmc.h

 arch/arm/include/asm/arch-exynos/dwmmc.h | 13 +++++++++++++
 drivers/mmc/dw_mmc.c                     | 11 +++++++++++
 drivers/mmc/exynos_dw_mmc.c              |  3 +++
 include/dwmmc.h                          |  3 +++
 4 files changed, 30 insertions(+)
arch/arm/include/asm/arch-exynos/dwmmc.h +13 -0
index b9eca76..d1c5d4f 100644
@@ -14,6 +14,19 @@
 #define DWMCI_SET_DRV_CLK(x)	((x) << 16)
 #define DWMCI_SET_DIV_RATIO(x)	((x) << 24)
 
+#define EMMCP_MPSBEGIN0		0x1200
+#define EMMCP_SEND0		0x1204
+#define EMMCP_CTRL0		0x120C
+
+#define MPSCTRL_SECURE_READ_BIT		(0x1<<7)
+#define MPSCTRL_SECURE_WRITE_BIT	(0x1<<6)
+#define MPSCTRL_NON_SECURE_READ_BIT	(0x1<<5)
+#define MPSCTRL_NON_SECURE_WRITE_BIT	(0x1<<4)
+#define MPSCTRL_USE_FUSE_KEY		(0x1<<3)
+#define MPSCTRL_ECB_MODE		(0x1<<2)
+#define MPSCTRL_ENCRYPTION		(0x1<<1)
+#define MPSCTRL_VALID			(0x1<<0)
+
 #ifdef CONFIG_OF_CONTROL
 int exynos_dwmmc_init(const void *blob);
 #endif
drivers/mmc/dw_mmc.c +11 -0
index 9a803a0..a3506d4 100644
@@ -11,6 +11,7 @@
 #include <mmc.h>
 #include <dwmmc.h>
 #include <asm-generic/errno.h>
+#include <asm/arch/dwmmc.h>
 
 #define PAGE_SIZE 4096
 
@@ -301,6 +302,16 @@ static int dwmci_init(struct mmc *mmc)
 	struct dwmci_host *host = (struct dwmci_host *)mmc->priv;
 	u32 fifo_size;
 
+	if (host->quirks & DWMCI_QUIRK_DISABLE_SMU) {
+		dwmci_writel(host, EMMCP_MPSBEGIN0, 0);
+		dwmci_writel(host, EMMCP_SEND0, 0);
+		dwmci_writel(host, EMMCP_CTRL0,
+			     MPSCTRL_SECURE_READ_BIT |
+			     MPSCTRL_SECURE_WRITE_BIT |
+			     MPSCTRL_NON_SECURE_READ_BIT |
+			     MPSCTRL_NON_SECURE_WRITE_BIT | MPSCTRL_VALID);
+	}
+
 	dwmci_writel(host, DWMCI_PWREN, 1);
 
 	if (!dwmci_wait_reset(host, DWMCI_RESET_ALL)) {
drivers/mmc/exynos_dw_mmc.c +3 -0
index 4ef9fec..f7439a0 100644
@@ -62,6 +62,9 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)
 	host->name = "EXYNOS DWMMC";
 	host->ioaddr = (void *)regbase;
 	host->buswidth = bus_width;
+#ifdef CONFIG_EXYNOS5420
+	host->quirks = DWMCI_QUIRK_DISABLE_SMU;
+#endif
 
 	if (clksel) {
 		host->clksel_val = clksel;
include/dwmmc.h +3 -0
index 08ced0b..6263140 100644
@@ -123,6 +123,9 @@
 #define DWMCI_BMOD_IDMAC_FB	(1 << 1)
 #define DWMCI_BMOD_IDMAC_EN	(1 << 7)
 
+/* quirks */
+#define DWMCI_QUIRK_DISABLE_SMU		(1 << 0)
+
 struct dwmci_host {
 	char *name;
 	void *ioaddr;
#33 lore raw

PATCH v6 10/10 DWMMC: SMDK5420: Disable SMU for eMMC

In reply to Rajeshwari S Shinde

Hi Rajeshwari,

Quoted 106 lines · Rajeshwari S Shinde

SMDK5420 has a new Security Management Unit added for dwmmc driver, hence, configuring the control registers to support booting via eMMC.

---
Changes in V3:
- New patch.
Changes in V4:
Added flag to dissble SMU
Changes in V5:
- None
Changes in V6:
- Moved the SMU definitions to arch/arm dwmmc.h

arch/arm/include/asm/arch-exynos/dwmmc.h | 13 +++++++++++++
drivers/mmc/dw_mmc.c                     | 11 +++++++++++
drivers/mmc/exynos_dw_mmc.c              |  3 +++
include/dwmmc.h                          |  3 +++
4 files changed, 30 insertions(+)
arch/arm/include/asm/arch-exynos/dwmmc.h +13 -0
index b9eca76..d1c5d4f 100644
@@ -14,6 +14,19 @@
 #define DWMCI_SET_DRV_CLK(x)	((x) << 16)
 #define DWMCI_SET_DIV_RATIO(x)	((x) << 24)
 
+#define EMMCP_MPSBEGIN0		0x1200
+#define EMMCP_SEND0		0x1204
+#define EMMCP_CTRL0		0x120C
+
+#define MPSCTRL_SECURE_READ_BIT		(0x1<<7)
+#define MPSCTRL_SECURE_WRITE_BIT	(0x1<<6)
+#define MPSCTRL_NON_SECURE_READ_BIT	(0x1<<5)
+#define MPSCTRL_NON_SECURE_WRITE_BIT	(0x1<<4)
+#define MPSCTRL_USE_FUSE_KEY		(0x1<<3)
+#define MPSCTRL_ECB_MODE		(0x1<<2)
+#define MPSCTRL_ENCRYPTION		(0x1<<1)
+#define MPSCTRL_VALID			(0x1<<0)
+
 #ifdef CONFIG_OF_CONTROL
 int exynos_dwmmc_init(const void *blob);
 #endif
drivers/mmc/dw_mmc.c +11 -0
index 9a803a0..a3506d4 100644
@@ -11,6 +11,7 @@
 #include <mmc.h>
 #include <dwmmc.h>
 #include <asm-generic/errno.h>
+#include <asm/arch/dwmmc.h>
 
 #define PAGE_SIZE 4096
 
@@ -301,6 +302,16 @@ static int dwmci_init(struct mmc *mmc)
 	struct dwmci_host *host = (struct dwmci_host *)mmc->priv;
 	u32 fifo_size;
 
+	if (host->quirks & DWMCI_QUIRK_DISABLE_SMU) {
+		dwmci_writel(host, EMMCP_MPSBEGIN0, 0);
+		dwmci_writel(host, EMMCP_SEND0, 0);
+		dwmci_writel(host, EMMCP_CTRL0,
+			     MPSCTRL_SECURE_READ_BIT |
+			     MPSCTRL_SECURE_WRITE_BIT |
+			     MPSCTRL_NON_SECURE_READ_BIT |
+			     MPSCTRL_NON_SECURE_WRITE_BIT | MPSCTRL_VALID);
+	}
+
 	dwmci_writel(host, DWMCI_PWREN, 1);
 
 	if (!dwmci_wait_reset(host, DWMCI_RESET_ALL)) {
drivers/mmc/exynos_dw_mmc.c +3 -0
index 4ef9fec..f7439a0 100644
@@ -62,6 +62,9 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)
 	host->name = "EXYNOS DWMMC";
 	host->ioaddr = (void *)regbase;
 	host->buswidth = bus_width;
+#ifdef CONFIG_EXYNOS5420
+	host->quirks = DWMCI_QUIRK_DISABLE_SMU;
+#endif
 
 	if (clksel) {
 		host->clksel_val = clksel;
include/dwmmc.h +3 -0
index 08ced0b..6263140 100644
@@ -123,6 +123,9 @@
 #define DWMCI_BMOD_IDMAC_FB	(1 << 1)
 #define DWMCI_BMOD_IDMAC_EN	(1 << 7)
 
+/* quirks */
+#define DWMCI_QUIRK_DISABLE_SMU		(1 << 0)
+
 struct dwmci_host {
 	char *name;
 	void *ioaddr;
Signature · 1 line
1.7.12.4

Applied, thanks

#34 lore raw

v6 cover EXYNOS5420: Add SMDK5420 board support

In reply to Rajeshwari S Shinde

Hi Minkyu Kang,

Kindly do review the patch set and do let me know if any review comments. Pantelis Antoniou has merged the patch 10 (DWMMC: SMDK5420: Disable SMU for eMMC) into mmc tree.

Regards,
Rajeshwari Shinde.

Quoted 93 lines · Rajeshwari S Shinde

This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420.

Changes in V2:
- Corrected a compilation issue for SMDK5420.

Changes in V3:
- Add patch to support variable size SPL support
- Add patch to disable SMU for eMMC.

Changes in V4:
- Added check for MAX77686 pmic compilation.
- Added correct calculation of gpio based addresses.
- Rebased on the latest u-boot code.
- Removed patches for UART and TZPC changes as they were not needed.
- Added flag to disable SMU for eMMC.

Changes in V5:
- Moved functions board_mmc_init and board_eth_init to common/board.c in case of device tree support.

Changes in V6:
- Rebased on the latest mainline branch.
- Moved the definitions for SMU to arch/arm dwmmc.h

Rajeshwari S Shinde (10):
EXYNOS5: Create a common board file
Exynos5420: Add base addresses for 5420
Exynos5420: Add clock initialization for 5420
Exynos5420: Add DDR3 initialization for 5420
Exynos5420: Add support for 5420 in pinmux and gpio
Exynos5420: Add base patch for SMDK5420
DTS: Add dts support for SMDK5420
Config: Add initial config for SMDK5420
SPL: EXYNOS: Prepare for variable size SPL support
DWMMC: SMDK5420: Disable SMU for eMMC

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/dmc_common.c         |  10 +-
 arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c      | 421 +++++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740 +++++++++++++++++++------
 arch/arm/cpu/armv7/exynos/pinmux.c             | 241 +++++++-
 arch/arm/dts/exynos5.dtsi                      | 211 +++++++
 arch/arm/dts/exynos5250.dtsi                   | 178 +-----
 arch/arm/dts/exynos5420.dtsi                   |  74 +++
 arch/arm/include/asm/arch-exynos/board.h       |  17 +
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 arch/arm/include/asm/arch-exynos/cpu.h         |  53 +-
 arch/arm/include/asm/arch-exynos/dmc.h         | 121 ++--
 arch/arm/include/asm/arch-exynos/dwmmc.h       |  13 +
 arch/arm/include/asm/arch-exynos/gpio.h        | 143 ++++-
 arch/arm/include/asm/arch-exynos/periph.h      |   3 +
 board/samsung/common/Makefile                  |   4 +
 board/samsung/common/board.c                   | 407 ++++++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts      | 172 ++++++
 board/samsung/smdk5250/exynos5-dt.c            | 361 +-----------
 board/samsung/smdk5250/smdk5250.c              | 182 +-----
 board/samsung/smdk5420/Makefile                |  34 ++
 board/samsung/smdk5420/smdk5420.c              | 159 ++++++
 board/samsung/smdk5420/smdk5420_spl.c          |  52 ++
 boards.cfg                                     |   1 +
 drivers/mmc/dw_mmc.c                           |  11 +
 drivers/mmc/exynos_dw_mmc.c                    |   3 +
 include/configs/exynos5-dt.h                   | 302 ++++++++++
 include/configs/exynos5250-dt.h                | 317 +----------
 include/configs/smdk5420.h                     |  56 ++
 include/dwmmc.h                                |   3 +
 spl/Makefile                                   |   7 +-
 tools/Makefile                                 |   2 +
 tools/mkexynosspl.c                            | 167 ++++--
 36 files changed, 4271 insertions(+), 1328 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 arch/arm/include/asm/arch-exynos/board.h
 create mode 100644 board/samsung/common/board.c
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
 create mode 100644 board/samsung/smdk5420/Makefile
 create mode 100644 board/samsung/smdk5420/smdk5420.c
 create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
 create mode 100644 include/configs/exynos5-dt.h
 create mode 100644 include/configs/smdk5420.h

--
1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 2 lines
Regards,
Rajeshwari Shinde
#35 lore raw

v6 cover EXYNOS5420: Add SMDK5420 board support

Hi Minkyu Kang,

Quoted 6 lines · Rajeshwari Birje

Hi Minkyu Kang,

Kindly do review the patch set and do let me know if any review comments. Pantelis Antoniou has merged the patch 10 (DWMMC: SMDK5420: Disable SMU for eMMC) into mmc tree.

We have merge window in next three days, this patches are acked by Simon. Can you please have a look and get it merged if no review comments from your end, or
please do let me know if some rework needed.

Signature · 2 lines
Regards,
Rajeshwari Shinde
Quoted 104 lines

Regards,
Rajeshwari Shinde.

Quoted 86 lines · Rajeshwari S Shinde

This patch adds basic board support for SMDK5420 board. These patches are tested for booting fine on EVT1 SMDK5420.

Changes in V2:
- Corrected a compilation issue for SMDK5420.

Changes in V3:
- Add patch to support variable size SPL support
- Add patch to disable SMU for eMMC.

Changes in V4:
- Added check for MAX77686 pmic compilation.
- Added correct calculation of gpio based addresses.
- Rebased on the latest u-boot code.
- Removed patches for UART and TZPC changes as they were not needed.
- Added flag to disable SMU for eMMC.

Changes in V5:
- Moved functions board_mmc_init and board_eth_init to common/board.c in case of device tree support.

Changes in V6:
- Rebased on the latest mainline branch.
- Moved the definitions for SMU to arch/arm dwmmc.h

Rajeshwari S Shinde (10):
EXYNOS5: Create a common board file
Exynos5420: Add base addresses for 5420
Exynos5420: Add clock initialization for 5420
Exynos5420: Add DDR3 initialization for 5420
Exynos5420: Add support for 5420 in pinmux and gpio
Exynos5420: Add base patch for SMDK5420
DTS: Add dts support for SMDK5420
Config: Add initial config for SMDK5420
SPL: EXYNOS: Prepare for variable size SPL support
DWMMC: SMDK5420: Disable SMU for eMMC

 arch/arm/cpu/armv7/exynos/clock.c              | 270 ++++++++-
 arch/arm/cpu/armv7/exynos/clock_init.h         |  17 +
 arch/arm/cpu/armv7/exynos/clock_init_exynos5.c | 352 +++++++++++-
 arch/arm/cpu/armv7/exynos/dmc_common.c         |  10 +-
 arch/arm/cpu/armv7/exynos/dmc_init_ddr3.c      | 421 +++++++++++++-
 arch/arm/cpu/armv7/exynos/exynos5_setup.h      | 740 +++++++++++++++++++------
 arch/arm/cpu/armv7/exynos/pinmux.c             | 241 +++++++-
 arch/arm/dts/exynos5.dtsi                      | 211 +++++++
 arch/arm/dts/exynos5250.dtsi                   | 178 +-----
 arch/arm/dts/exynos5420.dtsi                   |  74 +++
 arch/arm/include/asm/arch-exynos/board.h       |  17 +
 arch/arm/include/asm/arch-exynos/clk.h         |   1 +
 arch/arm/include/asm/arch-exynos/clock.h       | 494 +++++++++++++++++
 arch/arm/include/asm/arch-exynos/cpu.h         |  53 +-
 arch/arm/include/asm/arch-exynos/dmc.h         | 121 ++--
 arch/arm/include/asm/arch-exynos/dwmmc.h       |  13 +
 arch/arm/include/asm/arch-exynos/gpio.h        | 143 ++++-
 arch/arm/include/asm/arch-exynos/periph.h      |   3 +
 board/samsung/common/Makefile                  |   4 +
 board/samsung/common/board.c                   | 407 ++++++++++++++
 board/samsung/dts/exynos5420-smdk5420.dts      | 172 ++++++
 board/samsung/smdk5250/exynos5-dt.c            | 361 +-----------
 board/samsung/smdk5250/smdk5250.c              | 182 +-----
 board/samsung/smdk5420/Makefile                |  34 ++
 board/samsung/smdk5420/smdk5420.c              | 159 ++++++
 board/samsung/smdk5420/smdk5420_spl.c          |  52 ++
 boards.cfg                                     |   1 +
 drivers/mmc/dw_mmc.c                           |  11 +
 drivers/mmc/exynos_dw_mmc.c                    |   3 +
 include/configs/exynos5-dt.h                   | 302 ++++++++++
 include/configs/exynos5250-dt.h                | 317 +----------
 include/configs/smdk5420.h                     |  56 ++
 include/dwmmc.h                                |   3 +
 spl/Makefile                                   |   7 +-
 tools/Makefile                                 |   2 +
 tools/mkexynosspl.c                            | 167 ++++--
 36 files changed, 4271 insertions(+), 1328 deletions(-)
 create mode 100644 arch/arm/dts/exynos5.dtsi
 create mode 100644 arch/arm/dts/exynos5420.dtsi
 create mode 100644 arch/arm/include/asm/arch-exynos/board.h
 create mode 100644 board/samsung/common/board.c
 create mode 100644 board/samsung/dts/exynos5420-smdk5420.dts
 create mode 100644 board/samsung/smdk5420/Makefile
 create mode 100644 board/samsung/smdk5420/smdk5420.c
 create mode 100644 board/samsung/smdk5420/smdk5420_spl.c
 create mode 100644 include/configs/exynos5-dt.h
 create mode 100644 include/configs/smdk5420.h
Quoted 7 lines

--
1.7.12.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--
Regards,
Rajeshwari Shinde

#36 lore raw

v6 cover EXYNOS5420: Add SMDK5420 board support

Hi,

Quoted 6 lines · Rajeshwari Birje

Hi Minkyu Kang,

Quoted 2 lines · Rajeshwari Birje

Hi Minkyu Kang,

Quoted 9 lines
Quoted 4 lines

Kindly do review the patch set and do let me know if any review comments. Pantelis Antoniou has merged the patch 10 (DWMMC: SMDK5420: Disable SMU for eMMC) into mmc tree.

We have merge window in next three days, this patches are acked by Simon. Can you please have a look and get it merged if no review comments from your end, or
please do let me know if some rework needed.

Since my working schedule, I were away from mailing list. I have plan to review pending patches at next week. So, please wait few days.

Thanks,
Minkyu Kang.