Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi)
Subsystems (3)
PATCH 1/1 Fix scdc implementation missing in GK208B NVidia Card (gk104_sor_hdmi)
I fixed a problem for the GK208B NVidia Card (GT710):
the initialization was broken my card support scdc channel but the implementation was missing.
The problem was tracked by Mathias Anselmann in
https://bugzilla.kernel.org/show_bug.cgi?id=219561 and https://gitlab.freedesktop.org/drm/nouveau/-/issues/402
This patch fix the card initialization and fix audio problem on my card GK208B the code path is shared by
nouveau/nvkm/engine/device/base.c- .name = "GK110", nouveau/nvkm/engine/device/base.c- .name = "GK110B", nouveau/nvkm/engine/device/base.c- .name = "GK208B", nouveau/nvkm/engine/device/base.c- .name = "GK208",
I have done another patch so the code don´t broke anymore the initialization if the scdc implementation is missing when supported by the card. It will raise a DBG message instead.
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c +1 -0
@@ -106,6 +106,7 @@const struct nvkm_ior_func_hdmi gk104_sor_hdmi = { .ctrl = gk104_sor_hdmi_ctrl, + .scdc = gm200_sor_hdmi_scdc, .infoframe_avi = gk104_sor_hdmi_infoframe_avi, .infoframe_vsi = gk104_sor_hdmi_infoframe_vsi, };
Quoted 6 lines · Giuseppe Ranieri
I fixed a problem for the GK208B NVidia Card (GT710):
the initialization was broken my card support scdc channel but the implementation was missing.The problem was tracked by Mathias Anselmann in
https://bugzilla.kernel.org/show_bug.cgi?id=219561 and https://gitlab.freedesktop.org/drm/nouveau/-/issues/402
Those two links should be moved to Closes: tags above your Signed-off- by tag. See the global git log for inspiration.
Quoted 9 lines
This patch fix the card initialization and fix audio problem on my card GK208B the code path is shared by
nouveau/nvkm/engine/device/base.c- .name = "GK110", nouveau/nvkm/engine/device/base.c- .name = "GK110B", nouveau/nvkm/engine/device/base.c- .name = "GK208B", nouveau/nvkm/engine/device/base.c- .name = "GK208",I have done another patch so the code don´t broke anymore the initialization if the scdc implementation is missing when supported by the card. It will raise a DBG message instead.
So the other patch is related to this one here? If so, they should be submitted as a patch series (e.g., git format-patch --histogram HEAD~2).
Also, the commit message could need some grammar improvements ;-)
Greetings,
Philipp
Quoted 18 lines
Signed-off-by Giuseppe Ranieri <[email protected]>---
diff '--color=auto' -ur
a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.cb/drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.cdrivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c +0
-0@@ -106,6 +106,7 @@const struct
nvkm_ior_func_hdmi
gk104_sor_hdmi = {
.ctrl =gk104_sor_hdmi_ctrl,drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c +1
-0+ .scdc = gm200_sor_hdmi_scdc,.infoframe_avi =
gk104_sor_hdmi_infoframe_avi, .infoframe_vsi =gk104_sor_hdmi_infoframe_vsi, };
Add scdc function to gk104_sor_hdmi
Fix the card initialization on card GK208B, the code path is shared by
- "GK110" - "GK110B" - "GK208B" - "GK208"
Fix HDMI audio missing problem.
+https://gitlab.freedesktop.org/drm/nouveau/-/issues/402
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/gk104.c +1 -0
@@ -106,6 +106,7 @@const struct nvkm_ior_func_hdmi gk104_sor_hdmi = { .ctrl = gk104_sor_hdmi_ctrl, + .scdc = gm200_sor_hdmi_scdc, .infoframe_avi = gk104_sor_hdmi_infoframe_avi, .infoframe_vsi = gk104_sor_hdmi_infoframe_vsi, };