Skip to contentSkip to conversation

video: ipu_disp: Fix clock polarity logic

PATCH New Fabio Estevam 4 participants 4 messages Oct 29, 2013 – Oct 30, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: ipu_disp: Fix clock polarity logic

Currently the HDMI splash screen image quality on mx6solo does not show a very stable image.

By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.

#1 lore raw

PATCH 1/1 video: ipu_disp: Fix clock polarity logic

Thanks Fabio,

Quoted 6 lines · Fabio Estevam

Currently the HDMI splash screen image quality on mx6solo does not show a very stable image.

By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.

Quoted 7 lines

From FSL BSP [1] we have:

	if (!sig.clk_pol)
		di_gen |= DI_GEN_POLARITY_DISP_CLK;

Applying the same logic into U-boot fixes the HDMI image stability.

It's odd that this doesn't appear to change things for the i.MX6DQ, but it works on either one, so

#2 lore raw

PATCH 1/1 video: ipu_disp: Fix clock polarity logic

In reply to Fabio Estevam
Quoted 26 lines · Fabio Estevam

Currently the HDMI splash screen image quality on mx6solo does not show a very stable image.

By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.

From FSL BSP [1] we have:

	if (!sig.clk_pol)
		di_gen |= DI_GEN_POLARITY_DISP_CLK;

Applying the same logic into U-boot fixes the HDMI image stability.

[1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0

---
 drivers/video/ipu_disp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/ipu_disp.c +0 -0
index 2e91356..22ac142 100644

drivers/video/ipu_disp.c int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk, · line 1184

Quoted 8 lines
drivers/video/ipu_disp.c +1 -1
@@ -1178,7 +1178,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
 		if (sig.Vsync_pol)
 			di_gen |= DI_GEN_POLARITY_3;
 
-		if (sig.clk_pol)
+		if (!sig.clk_pol)
 			di_gen |= DI_GEN_POL_CLK;
 
 	}

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 video: ipu_disp: Fix clock polarity logic

In reply to Fabio Estevam
Quoted 11 lines · On Tue, 29 Oct 2013 15:46:21 -0200 Fabio Estevam <[email protected]>…

Currently the HDMI splash screen image quality on mx6solo does not show a very stable image.

By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP, we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.

From FSL BSP [1] we have:

	if (!sig.clk_pol)
		di_gen |= DI_GEN_POLARITY_DISP_CLK;
Quoted 8 lines

Applying the same logic into U-boot fixes the HDMI image stability.

[1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0

---
 drivers/video/ipu_disp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master.

Thanks,

Anatolij