Skip to contentSkip to conversation

nitrogen6x.conf: Allow kernel provider override

PATCH In review Gary Thomas 4 participants 16 messages Oct 30, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nitrogen6x.conf: Allow kernel provider override

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

---
 conf/machine/nitrogen6x.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/machine/nitrogen6x.conf +1 -1
index dbf31c5..b292d75 100644
@@ -33,7 +33,7 @@ include conf/machine/include/tune-cortexa9.inc
 SOC_FAMILY = "mx6:mx6q"
  PREFERRED_PROVIDER_u-boot = "u-boot-boundary"
-PREFERRED_PROVIDER_virtual/kernel = "linux-boundary"
+PREFERRED_PROVIDER_virtual/kernel ?= "linux-boundary"
  # Use SPI NOR U-Boot by default
 IMAGE_BOOTLOADER ?= ""
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

---
  conf/machine/nitrogen6x.conf |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
conf/machine/nitrogen6x.conf +0 -0
index dbf31c5..b292d75 100644

conf/machine/nitrogen6x.conf include conf/machine/include/tune-cortexa9.inc · line 37

Quoted 6 lines
conf/machine/nitrogen6x.conf +1 -1
@@ -33,7 +33,7 @@ include conf/machine/include/tune-cortexa9.inc
  SOC_FAMILY = "mx6:mx6q"
   PREFERRED_PROVIDER_u-boot = "u-boot-boundary"
-PREFERRED_PROVIDER_virtual/kernel = "linux-boundary"
+PREFERRED_PROVIDER_virtual/kernel ?= "linux-boundary"
   # Use SPI NOR U-Boot by default
  IMAGE_BOOTLOADER ?= ""

Good catch Gary.

I would warn folks that there are known omissions in the SABRE Lite code and no Nitrogen6X support in the other trees, but you should absolutely be able to override this, especially to use a custom tree, so...

#2 lore raw
In reply to Gary Thomas
Quoted 5 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw
Quoted 11 lines · Otavio Salvador
Quoted 5 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#4 lore raw
Quoted 11 lines · Gary Thomas
Quoted 10 lines · Otavio Salvador
Quoted 6 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 7 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 7 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw
Quoted 33 lines · Otavio Salvador
Quoted 11 lines · Gary Thomas
Quoted 10 lines · Otavio Salvador
Quoted 6 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 7 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 7 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

Quoted 7 lines

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#6 lore raw
Quoted 50 lines · Gary Thomas
Quoted 41 lines · Otavio Salvador
Quoted 15 lines · Gary Thomas
Quoted 13 lines · Otavio Salvador
Quoted 7 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 8 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 7 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

Quoted 7 lines

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

Quoted 2 lines

A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world.

Ok; you guys won :-)

I applied it to dora and master (I manually applied it as it has not applied cleanly).

Eric, please, if you have time do the same change in nitrogen6x-lite so it is kept in sync.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#7 lore raw
Quoted 42 lines · Otavio Salvador
Quoted 38 lines · Gary Thomas
Quoted 30 lines · Otavio Salvador
Quoted 9 lines · Gary Thomas
Quoted 8 lines · Otavio Salvador
Quoted 6 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 7 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 6 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

Quoted 6 lines

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

Quoted 2 lines

A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world.

Quoted 8 lines

Ok; you guys won :-)

I applied it to dora and master (I manually applied it as it has not applied cleanly).

Eric, please, if you have time do the same change in nitrogen6x-lite so it is kept in sync.

Will do.

#8 lore raw
In reply to Otavio Salvador
Quoted 54 lines · Otavio Salvador
Quoted 50 lines · Gary Thomas
Quoted 41 lines · Otavio Salvador
Quoted 15 lines · Gary Thomas
Quoted 13 lines · Otavio Salvador
Quoted 7 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 8 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 7 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

Quoted 7 lines

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

Quoted 2 lines

A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world.

Quoted 7 lines

Ok; you guys won :-)

I applied it to dora and master (I manually applied it as it has not applied cleanly).

Eric, please, if you have time do the same change in nitrogen6x-lite so it is kept in sync.

I do agree with both sides. But I think you didn´t presented the complete set of possibilities. I mean, it´s not a "support" X "flexibility" fight.

If nitrogen-any deserves to be flexible, so all other deserves it the same way.

If it´s "wrong" for one board. It´s "wrong" for any. So, please submit the patch to fix all/every board.

As I really don´t have an strong position for this. I would say, let´s change and see what´s happens.

For support nightmare, we always need to say what is u-boot/kernel/yocto problem in this ML, so the nightmare is already here.

But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora.

Daiane

Quoted 9 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

#9 lore raw
Quoted 64 lines · Daiane Angolini
Quoted 54 lines · Otavio Salvador
Quoted 50 lines · Gary Thomas
Quoted 41 lines · Otavio Salvador
Quoted 15 lines · Gary Thomas
Quoted 13 lines · Otavio Salvador
Quoted 7 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 8 lines
Quoted 4 lines

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Even if I did that (and I have), if I include this config file, I can never override this setting in a soft (user settable) way.

Then you can force it in your machine.

Quoted 7 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Eric has already approved this change.

This is not up to me but I'd like to discuss it a little bit further before merging it...

Quoted 7 lines

My main concern about this is the support. As I said it is a valid use-case but /most/ people will end with a .conf for the custom settings in the end with their internal fork or so. Do it in local.conf or environment is not advised as it is easy to be forgotten or do wrong so for every product it is better to have a .conf in case it needs specific kernel/u-boot patches.

Quoted 2 lines

A reasonable concern. I do note that having this be soft in <MACHINE>.conf seems to be common practice in the rest of the Yocto world.

Quoted 7 lines

Ok; you guys won :-)

I applied it to dora and master (I manually applied it as it has not applied cleanly).

Eric, please, if you have time do the same change in nitrogen6x-lite so it is kept in sync.

Quoted 8 lines

I do agree with both sides. But I think you didn´t presented the complete set of possibilities. I mean, it´s not a "support" X "flexibility" fight.

If nitrogen-any deserves to be flexible, so all other deserves it the same way.

If it´s "wrong" for one board. It´s "wrong" for any. So, please submit the patch to fix all/every board.

Agreed here.

Quoted 6 lines

As I really don´t have an strong position for this. I would say, let´s change and see what´s happens.

For support nightmare, we always need to say what is u-boot/kernel/yocto problem in this ML, so the nightmare is already here.

:-(

Quoted 1 line

But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora.

Yes I agree it is not a bugfix but I think that it'd be better to be consistent with dora and master at this point. Most people will keep using dora for a while and it'd be better to have this deplyed now than see how it goes in 1.6 only.

Comments?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#10 lore raw

Hi Otavio,

Quoted 22 lines · Otavio Salvador
Quoted 21 lines · Daiane Angolini
Quoted 4 lines · Otavio Salvador
Quoted 3 lines · Gary Thomas
Quoted 2 lines · Otavio Salvador
Quoted 1 line · Gary Thomas

On 2013-10-30 08:10, Otavio Salvador wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Gary Thomas
Quoted 6 lines

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

<snip>

I do agree with both sides. But I think you didn´t presented the complete set of possibilities. I mean, it´s not a "support" X "flexibility" fight.

Quoted 7 lines
Quoted 4 lines

If nitrogen-any deserves to be flexible, so all other deserves it the same way.

If it´s "wrong" for one board. It´s "wrong" for any. So, please submit the patch to fix all/every board.

Agreed here.

Works for me.

Gary, do you want to take the patch? Otavio asked me 'cause he was asking about our board...

Quoted 9 lines
Quoted 6 lines

As I really don´t have an strong position for this. I would say, let´s change and see what´s happens.

For support nightmare, we always need to say what is u-boot/kernel/yocto problem in this ML, so the nightmare is already here.

:-(

Aww, it's not a nightmare. It's a jobs program ;)

Quoted 9 lines
Quoted 1 line

But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora.

Yes I agree it is not a bugfix but I think that it'd be better to be consistent with dora and master at this point. Most people will keep using dora for a while and it'd be better to have this deplyed now than see how it goes in 1.6 only.

Comments?

Gary, did you ever think a single question mark would prompt so much discussion?

I wish we had a clean "MAKEALL" to make sure nothing breaks, but that seems unlikely.

Regards,

Eric

#11 lore raw

Hello,

Quoted 11 lines · Eric Nelson
Quoted 10 lines · Otavio Salvador
Quoted 1 line · Daiane Angolini

But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora.

Yes I agree it is not a bugfix but I think that it'd be better to be consistent with dora and master at this point. Most people will keep using dora for a while and it'd be better to have this deplyed now than see how it goes in 1.6 only.

Quoted 5 lines
Quoted 2 lines

Comments?

Gary, did you ever think a single question mark would prompt so much discussion?

The 'question mark' has a very strong meaning in 'bitbake-language'.

Quoted 2 lines

I wish we had a clean "MAKEALL" to make sure nothing breaks, but that seems unlikely.

I do build /all/ board weekly :-) I look for help here ;-)

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#12 lore raw
In reply to Eric Nelson
Quoted 30 lines · Eric Nelson

Hi Otavio,

Quoted 27 lines · Otavio Salvador
Quoted 25 lines · Daiane Angolini
Quoted 4 lines · Otavio Salvador
Quoted 3 lines · Gary Thomas
Quoted 2 lines · Otavio Salvador
Quoted 1 line · Gary Thomas

On 2013-10-30 08:10, Otavio Salvador wrote:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Gary Thomas
Quoted 6 lines

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

<snip>

I do agree with both sides. But I think you didn´t presented the complete set of possibilities. I mean, it´s not a "support" X "flexibility" fight.

If nitrogen-any deserves to be flexible, so all other deserves it the same way.

If it´s "wrong" for one board. It´s "wrong" for any. So, please submit the patch to fix all/every board.

Quoted 6 lines
Quoted 2 lines

Agreed here.

Works for me.

Gary, do you want to take the patch? Otavio asked me 'cause he was asking about our board...

Sure, I'll take this on for all the boards in meta-fsl-arm-* Look for it later today or tomorrow.

Quoted 20 lines
Quoted 10 lines
Quoted 7 lines

As I really don´t have an strong position for this. I would say, let´s change and see what´s happens.

For support nightmare, we always need to say what is u-boot/kernel/yocto problem in this ML, so the nightmare is already here.

:-(

Aww, it's not a nightmare. It's a jobs program ;)

Quoted 7 lines
Quoted 1 line

But, in my opinion, it´s NOT a bug fix, and should NOT be merged in dora.

Yes I agree it is not a bugfix but I think that it'd be better to be consistent with dora and master at this point. Most people will keep using dora for a while and it'd be better to have this deplyed now than see how it goes in 1.6 only.

Quoted 5 lines
Quoted 2 lines

Comments?

Gary, did you ever think a single question mark would prompt so much discussion?

Not unlike the recent headline "Single bit error in Toyota firmware kills ..."

Quoted 3 lines

I wish we had a clean "MAKEALL" to make sure nothing breaks, but that seems unlikely.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#13 lore raw
In reply to Otavio Salvador

Hi Otavio,

Quoted 5 lines · Otavio Salvador
Quoted 4 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 7 lines
Quoted 1 line

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

I'm not sure I understand why. It seems perfectly reasonable to me to build a new kernel recipe and use it, while retaining other information from the machine configuration.

I'm thinking specifically of a user who may have a custom kernel tree with pin-muxing based on their usage.

Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

I'm not sure I understand the concern. This seems pretty straightforward. The default is there, but a user can over-ride it.

Regards,

Eric

#14 lore raw

Hello Eric,

Quoted 17 lines · Eric Nelson
Quoted 7 lines · Otavio Salvador
Quoted 5 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 8 lines
Quoted 1 line

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

Quoted 6 lines

I'm not sure I understand why. It seems perfectly reasonable to me to build a new kernel recipe and use it, while retaining other information from the machine configuration.

I'm thinking specifically of a user who may have a custom kernel tree with pin-muxing based on their usage.

I see the point and I do have this case internally here; the point is if we have it 'soft' and someone reports:

Nitrogen6X is not working. Next question needs to be, are you using linux-boundary or another?

Quoted 9 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

I'm not sure I understand the concern. This seems pretty straightforward. The default is there, but a user can over-ride it.

If user forks the kernel, adding a machine .conf file is the easiest part of it. I'd to avoid support uncertainty regarding settings.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#15 lore raw

Hi Otavio,

Quoted 25 lines · Otavio Salvador

Hello Eric,

Quoted 21 lines · Eric Nelson
Quoted 7 lines · Otavio Salvador
Quoted 5 lines · Gary Thomas

This change lets the user override the choice of kernel in local.conf Without it, there is no way to build any kernel, e.g. linux-imx, other than the linux-boundary version.

Quoted 8 lines
Quoted 1 line

I really dislike this.

I understand your need, and it is a valid one, but it'd be better you to make a new machine (which includes this one) and override it there.

I'm not sure I understand why. It seems perfectly reasonable to me to build a new kernel recipe and use it, while retaining other information from the machine configuration.

Quoted 9 lines
Quoted 2 lines

I'm thinking specifically of a user who may have a custom kernel tree with pin-muxing based on their usage.

I see the point and I do have this case internally here; the point is if we have it 'soft' and someone reports:

Nitrogen6X is not working. Next question needs to be, are you using linux-boundary or another?

I understand your point, but it's going to happen anyway. The beauty (and curse) of flexible hardware is that it's flexible ;)

I think the best we can hope for in terms of support is to always ask if a failure occurs with a "stock" build... Fresh "repo sync", specified U-Boot, et cetera.

I don't know if hard-coding this value will meaningfully change things.

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

If we start allow all kind of override in machine configuration it loses its meaning and complicates the support.

Eric? comments?

Quoted 7 lines
Quoted 3 lines

I'm not sure I understand the concern. This seems pretty straightforward. The default is there, but a user can over-ride it.

If user forks the kernel, adding a machine .conf file is the easiest part of it. I'd to avoid support uncertainty regarding settings.

That's true, too (machine configurations aren't very complicated), but my understanding of that is recent.

Regards,

Eric