Skip to contentSkip to conversation

bmips: fix config warnings from 2019.01

PATCH New Álvaro Fernández Rojas 4 participants 7 messages Jan 1, 2019 – Jan 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

---
 configs/comtrend_ar5315u_ram_defconfig   | 2 +-
 configs/comtrend_ar5387un_ram_defconfig  | 2 +-
 configs/comtrend_ct5361_ram_defconfig    | 2 +-
 configs/comtrend_vr3032u_ram_defconfig   | 2 +-
 configs/comtrend_wap5813n_ram_defconfig  | 2 +-
 configs/huawei_hg556a_ram_defconfig      | 2 +-
 configs/netgear_cg3100d_ram_defconfig    | 1 -
 configs/netgear_dgnd3700v2_ram_defconfig | 2 +-
 configs/sagem_f at st1704_ram_defconfig     | 1 -
 configs/sfr_nb4-ser_ram_defconfig        | 2 +-
 10 files changed, 8 insertions(+), 10 deletions(-)
configs/comtrend_ar5315u_ram_defconfig +1 -1
index 1b8e4e43c4..948bd5206a 100644
@@ -31,10 +31,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ar-5315u"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_ar5387un_ram_defconfig +1 -1
index 5ba401a441..845adafae2 100644
@@ -31,10 +31,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ar-5387un"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_ct5361_ram_defconfig +1 -1
index 6297e78fd9..280323e345 100644
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,ct-5361"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/comtrend_vr3032u_ram_defconfig +1 -1
index 47f53998e1..be9177d741 100644
@@ -29,10 +29,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,vr-3032u"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_LED=y
configs/comtrend_wap5813n_ram_defconfig +1 -1
index fd5107bb7d..68199afb36 100644
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="comtrend,wap-5813n"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/huawei_hg556a_ram_defconfig +1 -1
index d4e6144319..14205142a6 100644
@@ -28,10 +28,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="huawei,hg556a"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/netgear_cg3100d_ram_defconfig +0 -1
index 83e82247ab..5fada57c80 100644
@@ -27,7 +27,6 @@ CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_SF=y
 CONFIG_CMD_SPI=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="netgear,cg3100d"
 # CONFIG_NET is not set
 # CONFIG_DM_DEVICE_REMOVE is not set
configs/netgear_dgnd3700v2_ram_defconfig +1 -1
index 0f3914fe7e..cef0f673b4 100644
@@ -30,10 +30,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="netgear,dgnd3700v2"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
configs/sagem_f at st1704_ram_defconfig +0 -1
index 8c36f5dbf8..da19b613d5 100644
@@ -30,7 +30,6 @@ CONFIG_CMD_SPI=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="sagem,f at st1704"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
configs/sfr_nb4-ser_ram_defconfig +1 -1
index 39622875b1..3df1edc257 100644
@@ -29,10 +29,10 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 # CONFIG_CMD_MISC is not set
-CONFIG_OF_EMBED=y
 CONFIG_DEFAULT_DEVICE_TREE="sfr,nb4-ser"
 CONFIG_NET_RANDOM_ETHADDR=y
 # CONFIG_DM_DEVICE_REMOVE is not set
+CONFIG_BLK=y
 CONFIG_BCM6348_IUDMA=y
 CONFIG_DM_GPIO=y
 CONFIG_BCM6345_GPIO=y
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

Quoted 4 lines · Álvaro Fernández Rojas

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

To be clear, some number of these have been boot tested too, right? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190101/7be1bab7/attachment.sig>
#2 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

I only tested it on Comtrend AR-5387un, I will test it on other boards and report back.

Quoted 9 lines · Tom Rini
Quoted 4 lines · Álvaro Fernández Rojas

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

To be clear, some number of these have been boot tested too, right? Thanks!

#3 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

In reply to Álvaro Fernández Rojas
Quoted 2 lines · Álvaro Fernández Rojas

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

More details on those warnings that are supposedly fixed would be appreciated. It's really unclear what this patch does.

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

Hi Marek,

Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and 109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7

Quoted 6 lines · Marek Vasut
Quoted 2 lines · Álvaro Fernández Rojas

- Fixes CONFIG_OF_EMBED warning.
- Fixes missing CONFIG_BLK warning for CONFIG_USB.

More details on those warnings that are supposedly fixed would be appreciated. It's really unclear what this patch does.

#5 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

Quoted 9 lines · Álvaro Fernández Rojas

Hi Marek,

Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and 109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7

Right. But Marek is asking for something more like:
- Use of CONFIG_OF_EMBED isn't intended for deployment use, switch to CONFIG_OF_SEPARATE instead.
- We can fully migrate to CONIG_DM_USB so enable CONFIG_BLK now.

ie why we're changing things, not just that we're fixing the warning.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/7ea30314/attachment.sig>
#6 lore raw

PATCH 1/1 bmips: fix config warnings from 2019.01

Am 02.01.19 um 23:14 schrieb Tom Rini:

Quoted 10 lines · Álvaro Fernández Rojas
Quoted 9 lines

Hi Marek,

Check commits 841d5fbae4e993476fa87d8933db0cd58d3c2d41 and 109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7.

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=841d5fbae4e993476fa87d8933db0cd58d3c2d41

Quoted 9 lines
Quoted 1 line

http://git.denx.de/?p=u-boot.git;a=commitdiff;h=109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7

Right. But Marek is asking for something more like:
- Use of CONFIG_OF_EMBED isn't intended for deployment use, switch to CONFIG_OF_SEPARATE instead.
- We can fully migrate to CONIG_DM_USB so enable CONFIG_BLK now.

ie why we're changing things, not just that we're fixing the warning.

two patches would be good. In each one you could add a "Fixes:
841d5fbae4e993476fa87d8933db0cd58d3c2d41" or "Fixes:
109d8bf3ac7b9bb04f3c46bb540eb2bb865f3dd7".

Signature · 1 line
- Daniel