Skip to contentSkip to conversation

configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

PATCH Superseded Fabio Estevam 6 participants 8 messages Oct 31, 2013 – Nov 1, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

---
 include/configs/mx25pdk.h         | 2 +-
 include/configs/mx28evk.h         | 2 +-
 include/configs/mx31pdk.h         | 2 +-
 include/configs/mx35pdk.h         | 2 +-
 include/configs/mx51evk.h         | 2 +-
 include/configs/mx53evk.h         | 2 +-
 include/configs/mx53loco.h        | 2 +-
 include/configs/mx53smd.h         | 2 +-
 include/configs/mx6qarm2.h        | 2 +-
 include/configs/mx6sabre_common.h | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)
include/configs/mx25pdk.h +1 -1
index 543c415..5e89168 100644
@@ -65,7 +65,7 @@
 #define CONFIG_SYS_MMC_ENV_DEV 0
 
 /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT	"MX25PDK U-Boot > "
+#define CONFIG_SYS_PROMPT	"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size  */
 /* Print buffer sz */
include/configs/mx28evk.h +1 -1
index 07f88ca..fefd499 100644
@@ -14,7 +14,7 @@
 /* System configurations */
 #define CONFIG_MX28				/* i.MX28 SoC */
 #define CONFIG_MACH_TYPE	MACH_TYPE_MX28EVK
-#define CONFIG_SYS_PROMPT	"MX28EVK U-Boot > "
+#define CONFIG_SYS_PROMPT	"=> "
 
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
include/configs/mx31pdk.h +1 -1
index d41f2cd..72ddab3 100644
@@ -120,7 +120,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
+#define CONFIG_SYS_PROMPT	"=> "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \
include/configs/mx35pdk.h +1 -1
index 2f59104..59a3798 100644
@@ -136,7 +136,7 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX35 U-Boot > "
+#define CONFIG_SYS_PROMPT	"=> "
 #define CONFIG_CMDLINE_EDITING
 #define CONFIG_SYS_HUSH_PARSER	/* Use the HUSH parser */
 
include/configs/mx51evk.h +1 -1
index 04f518a..fca1f49 100644
@@ -219,7 +219,7 @@
  */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX51EVK U-Boot > "
+#define CONFIG_SYS_PROMPT		"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
include/configs/mx53evk.h +1 -1
index fe5cf3c..776a26f 100644
@@ -136,7 +136,7 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53EVK U-Boot > "
+#define CONFIG_SYS_PROMPT		"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
include/configs/mx53loco.h +1 -1
index bd2fa43..d153a4f 100644
@@ -178,7 +178,7 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53LOCO U-Boot > "
+#define CONFIG_SYS_PROMPT		"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
 
include/configs/mx53smd.h +1 -1
index 12b2c0d..25ea71c 100644
@@ -121,7 +121,7 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53SMD U-Boot > "
+#define CONFIG_SYS_PROMPT		"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
include/configs/mx6qarm2.h +1 -1
index ef3058c..f44f3b4 100644
@@ -114,7 +114,7 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
-#define CONFIG_SYS_PROMPT		"MX6QARM2 U-Boot > "
+#define CONFIG_SYS_PROMPT		"=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256
 
include/configs/mx6sabre_common.h +1 -1
index bf6113b..b0bb02c 100644
@@ -171,7 +171,7 @@
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_PROMPT              "U-Boot > "
+#define CONFIG_SYS_PROMPT              "=> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

Quoted 5 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

Great!

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

Quoted 4 lines · Stefano Babic
Quoted 3 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.

Quoted 5 lines
Quoted 3 lines

---

Applied to u-boot-imx, thanks !

Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.

Rob

[1] http://patchwork.ozlabs.org/patch/279334/

#4 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 11 lines · Rob Herring
Quoted 5 lines · Stefano Babic
Quoted 4 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.

Quoted 1 line
Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Applied to u-boot-imx, thanks !

Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.

Um, yes. Barring urgent bugfixes (which this isn't), can you (Stefano) please wait a day or so between patch posted and merged? That's my rule of thumb. Thanks!

And, Rob's right, we should use his overall patch (and it's on my list, just doing some testing of the Kbuild related things right now).

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJScqchAAoJENk4IS6UOR1W53cP/3lKtEkZdcXN/D4f7WE3OgBT UThi39Yt1dbEjqcd6jZyKJu26pQSUW9Ri+pC2U856ecRLqA0cRRGFKXDCYR9KMPS 9RBiB49scfpItChpj1UXBZAfY277luBgsmVLT27bxWMnScXtxOXWWQ/e9D0V7sN1 tVhnGh5ggAB4Sq0VBcOwrP/ofNTXQNa8jOk7/l5bqiCZ58juRKIz6vCALQ8r/j6R f/HuPHJj4bhSis5OI+t0JYiNYxndaC1DDNCPAvywsj3wtmx1RwcviqkslrljlmnG wAsevWnmLIKIowAf9D2+wbafOdI9NaA7fQtDT2WZBmUqRmqbGMwOjWD7bTLQGYGa 2xzdxg+WjIdnvIANlMjWUcnLdV3UmNC0OTEwhEQJYfDKnT8pXYYskdxDVdbeV2CA lazo9RCnHGTPzOQ1XtQCtcJ4c9bLah880EasDFN76PkXzpbmg39jkpQK4QdYe9xm RtfdsOApMmJ9tHb86J8cbv7R0oNNYLaz54mq5vuu7Mf4jojWmcMvysf3D2/G7W6Y N6NEHo8UD5neh8mAHbop1AdsBz+XY+qj/W/XqQswesvPbo2qYHLHXjEKM9gPXwcI mD38NwABkTae//IadaGJN8ZsNaTThTbrbXPFMnCaI5JOyhwg8PnP9AYVuVuEUR5Y Pbn8snL/qdSho2RBknQ5
=ild+
-----END PGP SIGNATURE-----

#5 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

Hi Tom,

Quoted 17 lines · Tom Rini
Quoted 15 lines · Rob Herring
Quoted 5 lines · Stefano Babic
Quoted 4 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.

Quoted 5 lines
Quoted 3 lines

---

Applied to u-boot-imx, thanks !

Quoted 7 lines
Quoted 3 lines

Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.

Um, yes. Barring urgent bugfixes (which this isn't), can you (Stefano) please wait a day or so between patch posted and merged? That's my rule of thumb. Thanks!

Sorry, you're right - I will take as lesson to be more patient for the future ;-)

I revert Fabio's patch on u-boot-imx.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#6 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

In reply to Rob Herring

Hi Rob,

Quoted 10 lines · Rob Herring
Quoted 4 lines · Stefano Babic
Quoted 3 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

It would make more sense to apply my patch[1] first that makes this the default and then you can simply remove the option here.

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

---

Applied to u-boot-imx, thanks !

Quickly applying patches is nice and is not something I see often with u-boot, but 20 minutes is not really sufficient time for comments.

Sorry, you're right. I have quickly estimated Fabio's patch, but again, I had to wait. Sorry for misunderstanding.

I was not aware about your patch, and I agree it should be applied first. I will revert Fabio's patch on u-boot-imx.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

In reply to Fabio Estevam

Dear Fabio Estevam,

include/configs/mx25pdk.h line 68

Quoted 8 lines · In message <[email protected]> you…

There is no real benefit in adding the board name into U-boot's prompt.

Use the simple "=> " prompt across FSL boards.

include/configs/mx25pdk.h +1 -1
-#define CONFIG_SYS_PROMPT	"MX25PDK U-Boot > "
+#define CONFIG_SYS_PROMPT	"=> "

That's the default prompt, so ther eis no need to define that. Please just remove the existing CONFIG_SYS_PROMPT defines, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Intelligence without character is a dangerous thing."   - G. Steinem