clk: Properly initialize reference count
Subsystems (2)
PATCH 1/1 clk: Properly initialize reference count
Commit a336ed7 (clk: Implement clk_unregister()) initializes the kref in clk_set_parent(), which is obviously the wrong place. Further research shows that the original patches initialized it correctly, so it probably ended up in clk_set_parent() by mistake during manual application of the patch.
--- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk.c +1 -1
@@ -1750,7 +1750,6 @@ int clk_set_parent(struct clk *clk, struct clk *parent)else __clk_recalc_rates (clk,POST_RATE_CHANGE ); -kref_init (&clk->ref); out:clk_prepare_unlock ();
@@ -1906,6 +1905,7 @@ int __clk_init(struct device *dev, struct clk *clk)if (clk->ops->init) clk->ops->init (clk->hw); +kref_init (&clk->ref); out:clk_prepare_unlock ();
Signature · 1 line
1.8.4
PATCH 1/1 clk: Properly initialize reference count
Quoted 5 lines · Thierry Reding
Commit a336ed7 (clk: Implement
clk_unregister()) initializes the kref inclk_set_parent(), which is obviously the wrong place. Further research shows that the original patches initialized it correctly, so it probably ended up inclk_set_parent()by mistake during manual application of the patch.
BTW, it'd be nice to Cc fixes like this to linux-next at vger.kernel.org; I /might/ have avoided doing a bisect if I'd seen this patch first!
I see the benefit of that "linux-next plus today's accumulated bug-fixes" tree that I think you proposed:-)
PATCH 1/1 clk: Properly initialize reference count
Quoted 10 lines · Stephen Warren
Quoted 5 lines · Thierry Reding
Commit a336ed7 (clk: Implement
clk_unregister()) initializes the kref inclk_set_parent(), which is obviously the wrong place. Further research shows that the original patches initialized it correctly, so it probably ended up inclk_set_parent()by mistake during manual application of the patch.Tested-by Stephen Warren <[email protected]>BTW, it'd be nice to Cc fixes like this to linux-next at vger.kernel.org;
Yes, perhaps that would've been a good idea.
Quoted 1 line
I /might/ have avoided doing a bisect if I'd seen this patch first!
I get that bisect is a really nice tool. But I don't understand why people seem to rely on it to track down *everything* nowadays. In this particular case there was a fairly obvious warning that pretty clearly pointed at something wrong with the reference counting and some simple code inspection revealed the issue at hand. No need to rebuild and boot the kernel dozens of times to find this out.
But perhaps other people have much faster machines and bisection is actually faster...
Quoted 2 lines
I see the benefit of that "linux-next plus today's accumulated bug-fixes" tree that I think you proposed:-)
Yeah, this is precisely the situation where this would be good to have. Both of these issues together took about 45-60 minutes to track down and fix. I suppose it took Olof and you a similar amount of time. Yet if the fixes were already collected in some standard location it would free you up to do something more productive instead of wasting your time on duplicate work.
I'll ask Stephen (Rothwell) if he'd be willing to set up shared access to linux-next so that I can push collected fixes. Alternatively I could do that in a separate repository.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131101/97b366d5/attachment.sig>
PATCH 1/1 clk: Properly initialize reference count
In reply to Thierry RedingQuoted 7 lines · Thierry Reding
Commit a336ed7 (clk: Implement
clk_unregister()) initializes the kref inclk_set_parent(), which is obviously the wrong place. Further research shows that the original patches initialized it correctly, so it probably ended up inclk_set_parent()by mistake during manual application of the patch.Signed-off-by Thierry Reding <[email protected]>
PATCH 1/1 clk: Properly initialize reference count
In reply to Thierry RedingQuoted 5 lines · Thierry Reding
Commit a336ed7 (clk: Implement
clk_unregister()) initializes the kref inclk_set_parent(), which is obviously the wrong place. Further research shows that the original patches initialized it correctly, so it probably ended up inclk_set_parent()by mistake during manual application of the patch.
Thanks!