Skip to contentSkip to conversation

cryptsetup: Add libintl for UCLIBC toolchain

PATCH Superseded Clayton Shotwell 2 participants 2 messages Oct 31, 2013

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cryptsetup: Add libintl for UCLIBC toolchain

Fixes autobuild error
http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

Adding libintl to the libraries list for cryptsetup when using a uclibc toolchain.

---
Realized an error in original commit. Here is the fix.

Changes v1 -> v2:
- Adding TARGET_LDFLAGS to make sure they are not dropped

 package/cryptsetup/cryptsetup.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/cryptsetup/cryptsetup.mk +4 -0
index 48d37f6..46e75ad 100644
@@ -12,4 +12,8 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 cryptsetup: Add libintl for UCLIBC toolchain

Quoted 21 lines · Clayton Shotwell

Fixes autobuild error
http://autobuild.buildroot.net/results/cc1a65b9554bc2ece1b3ea8b51cd805b9bda7e86/

Adding libintl to the libraries list for cryptsetup when using a uclibc toolchain.

---
Realized an error in original commit. Here is the fix.

Changes v1 -> v2:
- Adding TARGET_LDFLAGS to make sure they are not dropped

 package/cryptsetup/cryptsetup.mk |    4 ++++
 1 file changed, 4 insertions(+)
package/cryptsetup/cryptsetup.mk +0 -0
index 48d37f6..46e75ad 100644

package/cryptsetup/cryptsetup.mk CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf · line 19

Quoted 8 lines
package/cryptsetup/cryptsetup.mk +4 -0
@@ -12,4 +12,8 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt e2fsprogs libgcrypt host-pkgconf
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
 
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
+endif
+
 $(eval $(autotools-package))

You're using libintl without selecting it or adding it to DEPENDENCIES. See docs/manual/adding-packages-gettext.txt for the correct way to do this (libintl is part of gettext and built when there's no libc implementation).
It's probably working because some other dependency is pulling it in. Regards.