Buildroot patchwork: decision on the 10 oldest patches, week 1
Hello,
The oldest patches in patchwork don't get a lot of attention (or even any attention at all). I had a discussion this week with Thomas De Schampheleire, and we would like to progressively clean up the backlog of patches we have in patchwork, especially the oldest one.
So, every week, I'll be posting the list of the 10 oldest patches, with the original patch contributors in Cc. During one week, we have the opportunity to discuss the patch, whether it is still necessary or not, how it should be changed to be merged.
In particular, I'm interested in knowing if the original contributor is still interested by the patch, or if someone else is interested in adopting the patch and sending an updated version, or if the patch no longer makes sense due to other changes made in Buildroot.
All patches that have not received any comment or attention within the week will be removed from patchwork. This is aggressive, but we have patches sitting in patchwork since one year and half, and this cannot work.
So, for this first week, the patches are:
1 New: add lava-test package
http://patchwork.ozlabs.org/patch/155498/
ludovic.desroches at atmel.com
2 [v3] busybox: install S41inetd and inetd.conf if inetd is enabled in busybox.
http://patchwork.ozlabs.org/patch/164551/
keguang.zhang at gmail.com
3 [1/1] ccache: expose control interface via 'make ccache-options'
http://patchwork.ozlabs.org/patch/165382/
roylee17 at gmail.com
4 [V2] p910nd: Add p910nd lightweight printserver
http://patchwork.ozlabs.org/patch/165542/
david.c.purdy at gmail.com
5 Added package v86d which provides a real-mode helper for uvesafb driver.
http://patchwork.ozlabs.org/patch/171840/
golubovsky at gmail.com
6 grub: fix stage2 link with recent binutils
http://patchwork.ozlabs.org/patch/173191/
net147 at gmail.com
7 valgrind: valgrind/valgrind.h missing if --disable-tls enabled
http://patchwork.ozlabs.org/patch/176795/
stefan.froberg at petroprogram.com
8 [2/2] rdiff-backup: new package
http://patchwork.ozlabs.org/patch/176956/
avishorp at gmail.com
9 [1/2,v4] package: pkg-generic: Support building override source without copying in common package infrastructure.
http://patchwork.ozlabs.org/patch/177618/
sonic.adi at gmail.com
10 grub: add host support
http://patchwork.ozlabs.org/patch/177705/
rbraun at sceen.net
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Hello,
On Sun, Oct 06, 2013 at 04:42:27PM +0200, Thomas Petazzoni wrote:
[...]
Quoted 6 lines
So, for this first week, the patches are:
1 New: add lava-test package
http://patchwork.ozlabs.org/patch/155498/
ludovic.desroches at atmel.com
I don't know if this package will be used by many people. The interesting part is to know if the python path is now set correctly (I had something like this #!/home/user/MyProjects/versioned/buildroot/output/host/usr/bin/python instead of #!/usr/bin/python). To be honest I have not tried with newer versions of Buildroot. I'll do the try.
Regards
Ludovic
PATCH 1/1 New: add lava-test package
From: Ludovic Desroches <[email protected]>
---
I have the same issues with latest release of Buildroot.
I have added python path replacement in install target instead of doing it in the post-build script. I have added license stuff too and bump to latest version.
package/Config.in | 1 + package/lava-test/Config.in | 8 ++++++++ package/lava-test/lava-test.mk | 13 +++++++++++++ 3 files changed, 22 insertions(+) create mode 100644 package/lava-test/Config.in create mode 100644 package/lava-test/lava-test.mk
package/Config.in +1 -0
@@ -27,6 +27,7 @@ source "package/gdb/Config.in" source "package/iozone/Config.in" source "package/kexec/Config.in" source "package/latencytop/Config.in" +source "package/lava-test/Config.in" source "package/lmbench/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/lsof/Config.in"
package/lava-test/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LAVA_TEST + bool "lava-test" + depends on BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_SETUPTOOLS + help + LAVA Test is a test execution framework designed to make it easy to + install and run supported tests. Results from testing can be + optionally uploaded to a dashboard running lava-dashboard.
package/lava-test/lava-test.mk new file +13 -0
@@ -0,0 +1,13 @@ +LAVA_TEST_VERSION = 0.14 +LAVA_TEST_SOURCE = lava-test-$(LAVA_TEST_VERSION)-2013.01.tar.gz +LAVA_TEST_SITE = https://launchpad.net/lava-test/trunk/2013.01/+download/ +LAVA_TEST_DEPENDENCIES = python host-python-setuptools +LAVA_TEST_LICENSE = GPLv3 +LAVA_TEST_LICENSE_FILES = COPYING + +define LAVA_TEST_INSTALL_TARGET_CMDS + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=/usr --root=$(TARGET_DIR)) + sed -i '1s|#!.*python.*|#!/usr/bin/env python|' $(TARGET_DIR)/usr/bin/{lava,lava-dashboard-tool,lava-test,lava-tool} +endef + +$(eval $(generic-package))
Signature · 1 line
1.7.11.3
PATCH 1/1 New: add lava-test package
Dear ludovic.desroches at atmel.com,
Quoted 10 lines · ludovic.desroches at atmel.com
From: Ludovic Desroches <[email protected]>
Signed-off-by Ludovic Desroches <[email protected]>---
I have the same issues with latest release of Buildroot.
I have added python path replacement in install target instead of doing it in the post-build script. I have added license stuff too and bump to latest version.
And with this change, does lava-test works for you?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 New: add lava-test package
Hi Thomas,
Quoted 8 lines · Thomas Petazzoni
Dear ludovic.desroches at atmel.com,
Quoted 5 lines · ludovic.desroches at atmel.com
From: Ludovic Desroches <[email protected]>
Signed-off-by Ludovic Desroches <[email protected]>---
Quoted 8 lines
Quoted 5 lines
I have the same issues with latest release of Buildroot.
I have added python path replacement in install target instead of doing it in the post-build script. I have added license stuff too and bump to latest version.
And with this change, does lava-test works for you?
Our lava installation is currently down. I'll see how I can check it. Since the issue was only python path, I hope it should be working.
Regards
Ludovic
All,
Quoted 17 lines · Thomas Petazzoni
Hello,
The oldest patches in patchwork don't get a lot of attention (or even any attention at all). I had a discussion this week with Thomas De Schampheleire, and we would like to progressively clean up the backlog of patches we have in patchwork, especially the oldest one.
So, every week, I'll be posting the list of the 10 oldest patches, with the original patch contributors in Cc. During one week, we have the opportunity to discuss the patch, whether it is still necessary or not, how it should be changed to be merged.
In particular, I'm interested in knowing if the original contributor is still interested by the patch, or if someone else is interested in adopting the patch and sending an updated version, or if the patch no longer makes sense due to other changes made in Buildroot.
Quoted 4 lines
All patches that have not received any comment or attention within the week will be removed from patchwork. This is aggressive, but we have patches sitting in patchwork since one year and half, and this cannot work.
Five days have past already, let's do an intermediate review:
Quoted 6 lines
So, for this first week, the patches are:
1 New: add lava-test package
http://patchwork.ozlabs.org/patch/155498/
ludovic.desroches at atmel.com
Ludovic has rebased this patch and is currently testing this.
Quoted 4 lines
2 [v3] busybox: install S41inetd and inetd.conf if inetd is enabled in busybox.
http://patchwork.ozlabs.org/patch/164551/
keguang.zhang at gmail.com
This patch was already at its third iteration, and has received comments from Peter and Arnout. At first sight, this could be respinned with little effort based on the input of Arnout. I'm reincluding Kelvin Cheung on this mail.
Kelvin, are you interested in resending this based on the input you received on the last version?
Quoted 4 lines
3 [1/1] ccache: expose control interface via 'make ccache-options'
http://patchwork.ozlabs.org/patch/165382/
roylee17 at gmail.com
This patch has been updated by Tzu-Jung Lee and is ready to be merged now.
Quoted 4 lines
4 [V2] p910nd: Add p910nd lightweight printserver
http://patchwork.ozlabs.org/patch/165542/
david.c.purdy at gmail.com
No feedback yet.
In patchwork this is indicated as 'delegated to gustavoz'. Gustavo:
does this mean you are working on this, or plan on working this?
Quoted 4 lines
5 Added package v86d which provides a real-mode helper for uvesafb driver.
http://patchwork.ozlabs.org/patch/171840/
golubovsky at gmail.com
No feedback yet.
Quoted 4 lines
6 grub: fix stage2 link with recent binutils
http://patchwork.ozlabs.org/patch/173191/
net147 at gmail.com
This is supposed to fix a runtime bug (when installing grub). It is including a patch also used on openwrt. This patch applies to grub 0.97 with one 'offset 2 lines' difference, but I'd say this is ok. The patch against buildroot also applies cleanly. Everything builds correctly.
Although I don't have a setup to test this on, I would say we can apply this as-is.
Quoted 4 lines
7 valgrind:
valgrind/valgrind.hmissing if --disable-tls enabled
http://patchwork.ozlabs.org/patch/176795/
stefan.froberg at petroprogram.com
Stefan: is this still a problem? Are you interested in updating this? In fact, there is no commit message and I can't link the title with the actual patch. Some more info would be nice...
Quoted 4 lines
8 [2/2] rdiff-backup: new package
http://patchwork.ozlabs.org/patch/176956/
avishorp at gmail.com
No feedback yet.
Quoted 4 lines
9 [1/2,v4] package: pkg-generic: Support building override source without copying in common package infrastructure.
http://patchwork.ozlabs.org/patch/177618/
sonic.adi at gmail.com
If I understand this correctly, it is changing the OVERRIDE_SRCDIR mechanism to build in the overriden tree, instead of in a copy. I though we would not support this intentionally, or am I wrong?
Quoted 4 lines
10 grub: add host support
http://patchwork.ozlabs.org/patch/177705/
rbraun at sceen.net
Arnout: you gave a positive reply on this patch, is it still valid. Can we merge it as-is, or does the patch need more work? The patch still applies cleanly and builds fine, however I found the output is much larger than I expected (although this may be me not understanding exactly). Is it normal to have grub stages exceeding 100MB ?
$ ls -lh /home/tdescham/repo/contrib/buildroot-review/output/host/boot/grub total 1,7G -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 e2fs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 fat_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ffs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 iso9660_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 jfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 minix_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 reiserfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 stage1 -rw-r--r-- 1 tdescham tdescham 257M okt 11 10:05 stage2 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ufs2_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 vstafs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 xfs_stage1_5
Thanks all for your input,
Thomas
Quoted 13 lines · Thomas De Schampheleire
Quoted 3 lines
10 grub: add host support
Quoted 2 lines
http://patchwork.ozlabs.org/patch/177705/
rbraun at sceen.netArnout: you gave a positive reply on this patch, is it still valid. Can we merge it as-is, or does the patch need more work? The patch still applies cleanly and builds fine, however I found the output is much larger than I expected (although this may be me not understanding exactly). Is it normal to have grub stages exceeding 100MB ?
$ ls -lh /home/tdescham/repo/contrib/buildroot-review/output/host/boot/grub total 1,7G(quoted diff) +0
-2-rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 e2fs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 fat_stage1_5
Review
Quoted 10 lines
(quoted diff) +0
-10-rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ffs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 iso9660_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 jfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 minix_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 reiserfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 stage1 -rw-r--r-- 1 tdescham tdescham 257M okt 11 10:05 stage2 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ufs2_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 vstafs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 xfs_stage1_5
That indeed doesn't look good.
For some reason, the ELF objects have two load addresses: 0x00002000
and 0x080480d4. Therefore objdump generates a full 128MB dump filled with zeroes. It possibly has to do with recent binutils - this grub 0.97 is already more than 8 years old.
I wouldn't spend too much effort on grub anymore, and instead focus on
grub2.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
All,
On Fri, Oct 11, 2013 at 10:11 AM, Thomas De Schampheleire <[email protected]> wrote:
[..]
Here is the outcome of this first patchwork cleanup session:
Quoted 9 lines
Quoted 7 lines
So, for this first week, the patches are:
1 New: add lava-test package
http://patchwork.ozlabs.org/patch/155498/
ludovic.desroches at atmel.comLudovic has rebased this patch and is currently testing this.
Ludovic updated and resubmitted this patch, thanks!
Quoted 6 lines
Quoted 5 lines
2 [v3] busybox: install S41inetd and inetd.conf if inetd is enabled in busybox.
http://patchwork.ozlabs.org/patch/164551/
keguang.zhang at gmail.com
Quoted 6 lines
This patch was already at its third iteration, and has received comments from Peter and Arnout. At first sight, this could be respinned with little effort based on the input of Arnout. I'm reincluding Kelvin Cheung on this mail.
Kelvin, are you interested in resending this based on the input you received on the last version?
No response, marked as Rejected.
Quoted 7 lines
Quoted 5 lines
3 [1/1] ccache: expose control interface via 'make ccache-options'
http://patchwork.ozlabs.org/patch/165382/
roylee17 at gmail.comThis patch has been updated by Tzu-Jung Lee and is ready to be merged now.
Patch has been accepted in buildroot master. Thanks!
Quoted 9 lines
Quoted 5 lines
4 [V2] p910nd: Add p910nd lightweight printserver
http://patchwork.ozlabs.org/patch/165542/
david.c.purdy at gmail.comNo feedback yet.
In patchwork this is indicated as 'delegated to gustavoz'. Gustavo:
does this mean you are working on this, or plan on working this?
Gustavo said he would take this up. Marked as 'Changes requested' in patchwork.
Quoted 62 lines
Quoted 5 lines
5 Added package v86d which provides a real-mode helper for uvesafb driver.
http://patchwork.ozlabs.org/patch/171840/
golubovsky at gmail.comNo feedback yet.
Quoted 4 lines
6 grub: fix stage2 link with recent binutils
http://patchwork.ozlabs.org/patch/173191/
net147 at gmail.comThis is supposed to fix a runtime bug (when installing grub). It is including a patch also used on openwrt. This patch applies to grub 0.97 with one 'offset 2 lines' difference, but I'd say this is ok. The patch against buildroot also applies cleanly. Everything builds correctly.
Although I don't have a setup to test this on, I would say we can apply this as-is.
Quoted 4 lines
7 valgrind:
valgrind/valgrind.hmissing if --disable-tls enabled
http://patchwork.ozlabs.org/patch/176795/
stefan.froberg at petroprogram.comStefan: is this still a problem? Are you interested in updating this? In fact, there is no commit message and I can't link the title with the actual patch. Some more info would be nice...
Quoted 4 lines
8 [2/2] rdiff-backup: new package
http://patchwork.ozlabs.org/patch/176956/
avishorp at gmail.comNo feedback yet.
Quoted 4 lines
9 [1/2,v4] package: pkg-generic: Support building override source without copying in common package infrastructure.
http://patchwork.ozlabs.org/patch/177618/
sonic.adi at gmail.comIf I understand this correctly, it is changing the
OVERRIDE_SRCDIRmechanism to build in the overriden tree, instead of in a copy. I though we would not support this intentionally, or am I wrong?Quoted 4 lines
10 grub: add host support
http://patchwork.ozlabs.org/patch/177705/
rbraun at sceen.netArnout: you gave a positive reply on this patch, is it still valid. Can we merge it as-is, or does the patch need more work? The patch still applies cleanly and builds fine, however I found the output is much larger than I expected (although this may be me not understanding exactly). Is it normal to have grub stages exceeding 100MB ?
$ ls -lh /home/tdescham/repo/contrib/buildroot-review/output/host/boot/grub total 1,7G(quoted diff) +0
-2-rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 e2fs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 fat_stage1_5
Review
Quoted 10 lines
(quoted diff) +0
-10-rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ffs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 iso9660_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 jfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 minix_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 reiserfs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:04 stage1 -rw-r--r-- 1 tdescham tdescham 257M okt 11 10:05 stage2 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 ufs2_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 vstafs_stage1_5 -rwxr-xr-x 1 tdescham tdescham 129M okt 11 10:05 xfs_stage1_5
All the other patches did not receive further feedback, and are thus marked as Rejected.
Best regards,
Thomas
Quoted 9 lines · Thomas De Schampheleire
Quoted 7 lines
Quoted 3 lines
4 [V2] p910nd: Add p910nd lightweight printserver
http://patchwork.ozlabs.org/patch/165542/
david.c.purdy at gmail.comNo feedback yet.
In patchwork this is indicated as 'delegated to gustavoz'. Gustavo:
does this mean you are working on this, or plan on working this?Gustavo said he would take this up. Marked as 'Changes requested' in patchwork.
I've got this in my git repo already, i just need to flash it in some board and plug a printer to it to test the conf/initscript (qemu doesn't seem to do printer emulation right?).
Regards.