Skip to contentSkip to conversation

hexagon: kernel: kgdb: include related header for pass compiling.

PATCH In review Chen Gang 3 participants 5 messages Nov 1, 2013 – Nov 4, 2013 Qualcomm hexagon architecture

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 hexagon: kernel: kgdb: include related header for pass compiling.

Need include related headers for pass compiling, the related error (with allmodconfig for v4):

CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs' arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
...
arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save' arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
...

---
 arch/hexagon/kernel/kgdb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/hexagon/kernel/kgdb.c +2 -0
index 82d5c25..038580c 100644
@@ -18,6 +18,8 @@
  * 02110-1301, USA.
  */
 
+#include <linux/irq.h>
+#include <linux/sched.h>
 #include <linux/kdebug.h>
 #include <linux/kgdb.h>
 
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Chen Gang

Need include related headers for pass compiling, the related error (with allmodconfig for v4):

CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'

looks good to me

author
#2 lore raw
Quoted 4 lines · Linas Vepstas
Quoted 3 lines · Chen Gang

Need include related headers for pass compiling, the related error (with allmodconfig for v4):

Quoted 8 lines
Quoted 2 lines

CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs'

looks good to me

Thanks.

Signature · 1 line
Chen Gang
Acked-by on v1 1/1
#3 lore raw
In reply to Chen Gang
Quoted 12 lines · Chen Gang

Need include related headers for pass compiling, the related error (with allmodconfig for v4):

CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs' arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
...
arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save' arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
...

Quoted 5 lines
---
 arch/hexagon/kernel/kgdb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Thanks for the cleanup. I can take these patches into my tree for my next push, or they can go in one of the other tree. In that case,

Signature · 3 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
author
#4 lore raw
Quoted 19 lines · rkuo
Quoted 12 lines · Chen Gang

Need include related headers for pass compiling, the related error (with allmodconfig for v4):

CC arch/hexagon/kernel/kgdb.o
arch/hexagon/kernel/kgdb.c:30: error: invalid use of undefined type 'struct pt_regs' arch/hexagon/kernel/kgdb.c:31: error: invalid use of undefined type 'struct pt_regs'
...
arch/hexagon/kernel/kgdb.c:220: error: implicit declaration of function 'local_irq_save' arch/hexagon/kernel/kgdb.c:222: error: implicit declaration of function 'local_irq_restore'
...

Quoted 5 lines
---
 arch/hexagon/kernel/kgdb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 6 lines

Thanks for the cleanup. I can take these patches into my tree for my next push, or they can go in one of the other tree. In that case,

For me, both are OK.

Thanks.

Signature · 1 line
Chen Gang