tegra: allow build to succeed with SPL disabled
PATCH 1/1 tegra: allow build to succeed with SPL disabled
u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
--- Makefile | 2 ++ 1 file changed, 2 insertions(+)
Makefile +2 -0
@@ -407,12 +407,14 @@ endif # enable combined SPL/u-boot/dtb rules for tegra ifneq ($(CONFIG_TEGRA),) +ifeq ($(CONFIG_SPL),y) ifeq ($(CONFIG_OF_SEPARATE),y) ALL-y += $(obj)u-boot-dtb-tegra.bin else ALL-y += $(obj)u-boot-nodtb-tegra.bin endif endif +endif all: $(ALL-y) $(SUBDIR_EXAMPLES)
Signature · 1 line
1.8.1.5
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Vidya,
Quoted 35 lines
-----Original Message-----
From: Vidya Sagar [mailto:vidyas at nvidia.com]
Sent: Thursday, October 31, 2013 2:22 AM
To: u-boot at lists.denx.de
Cc: Tom Warren; Stephen Warren; Vidya Sagar
Subject: [PATCH] tegra: allow build to succeed with SPL disabledu-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Signed-off-by Vidya Sagar <[email protected]>--- Makefile | 2 ++ 1 file changed, 2 insertions(+)Makefile +2
-1@@ -407,12 +407,14 @@ endif # enable combined SPL/u-boot/dtb rules for tegra ifneq ($(CONFIG_TEGRA),) +ifeq ($(CONFIG_SPL),y) ifeq ($(CONFIG_OF_SEPARATE),y) ALL-y += $(obj)u-boot-dtb-tegra.bin else ALL-y += $(obj)u-boot-nodtb-tegra.bin endif endif +endif all: $(ALL-y) $(SUBDIR_EXAMPLES) --
Quoted 1 line
1.8.1.5
LGTM, thanks. I assume you built all Tegra boards using MAKEALL?
If so, then:
--
nvpublic
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Quoted 29 lines · On 10/31/2013 11:58 PM, wrote:
________________________________________ From: Tom Warren Sent:
Thursday, October 31, 2013 9:38 PM To: Vidya Sagar; u-boot at lists.denx.de Cc: Stephen Warren; Vidya Sagar; Tom Warren
Subject: RE: [PATCH] tegra: allow build to succeed with SPL disabledVidya,
Quoted 21 lines
-----Original Message----- From: Vidya Sagar [mailto:vidyas at nvidia.com] Sent: Thursday, October 31, 2013 2:22 AM To: u-boot at lists.denx.de Cc: Tom Warren; Stephen Warren; Vidya Sagar Subject: [PATCH] tegra: allow build to succeed with SPL disabled
u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Signed-off-by Vidya Sagar <[email protected]> --- Makefile | 2 ++1 file changed, 2 insertions(+)Makefile index 1365db6..3c71082 100644 --- renamed from Makefile +0
-0a/Makefile +++ b/Makefile @@ -407,12 +407,14 @@ endif
# enable combined SPL/u-boot/dtb rules for tegra ifneq ($(CONFIG_TEGRA),) +ifeq ($(CONFIG_SPL),y) ifeq ($(CONFIG_OF_SEPARATE),y) ALL-y += $(obj)u-boot-dtb-tegra.bin else ALL-y += $(obj)u-boot-nodtb-tegra.bin endif endif +endif
Quoted 6 lines
Quoted 3 lines
all: $(ALL-y) $(SUBDIR_EXAMPLES)
-- 1.8.1.5
LGTM, thanks. I assume you built all Tegra boards using MAKEALL?
If so, then: Acked-by: Tom Warren <[email protected]> -- nvpublic
yes, I've built for all nvidia boards.
Here is the log...
#./MAKEALL -v nvidia
Configuring for dalmore board...
text data bss dec hex filename
256692 15308 309924 581924 8e124/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for harmony board...
text data bss dec hex filename
295786 11870 311232 618888 97188/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for seaboard board...
text data bss dec hex filename
310284 13450 309544 633278 9a9be/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for ventana board...
text data bss dec hex filename
248990 7690 307820 564500 89d14/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for whistler board...
text data bss dec hex filename
244038 9018 307768 560824 88eb8/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for beaver board...
text data bss dec hex filename
255926 16672 308676 581274 8de9a/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for cardhu board...
text data bss dec hex filename
255926 16672 308676 581274 8de9a/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot
--------------------- SUMMARY ---------------------------- Boards compiled: 7
----------------------------------------------------------
PATCH 1/1 tegra: allow build to succeed with SPL disabled
In reply to a message not in the archiveQuoted 43 lines · On 10/31/2013 11:58 PM, wrote:
________________________________________
From: Tom Warren
Sent: Thursday, October 31, 2013 9:38 PM
To: Vidya Sagar;u-boot at lists.denx.de
Cc: Stephen Warren; Vidya Sagar; Tom Warren
Subject: RE: [PATCH] tegra: allow build to succeed with SPL disabledVidya,
Quoted 34 lines
-----Original Message-----
From: Vidya Sagar [mailto:vidyas at nvidia.com]
Sent: Thursday, October 31, 2013 2:22 AM
To:u-boot at lists.denx.de
Cc: Tom Warren; Stephen Warren; Vidya Sagar
Subject: [PATCH] tegra: allow build to succeed with SPL disabledu-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Signed-off-by Vidya Sagar<[email protected]>--- Makefile | 2 ++ 1 file changed, 2 insertions(+)Makefile +2
-0@@ -407,12 +407,14 @@ endif # enable combined SPL/u-boot/dtb rules for tegra ifneq ($(CONFIG_TEGRA),) +ifeq ($(CONFIG_SPL),y) ifeq ($(CONFIG_OF_SEPARATE),y) ALL-y += $(obj)u-boot-dtb-tegra.bin else ALL-y += $(obj)u-boot-nodtb-tegra.bin endif endif +endif all: $(ALL-y) $(SUBDIR_EXAMPLES)
Quoted 8 lines
Quoted 2 lines
--
1.8.1.5LGTM, thanks. I assume you built all Tegra boards using MAKEALL?
If so, then:
Acked-by Tom Warren<[email protected]>--
nvpublic
yes, I've built for all nvidia boards.
Here is the log...
#./MAKEALL -v nvidia
Configuring for dalmore board...
text data bss dec hex filename
256692 15308 309924 581924 8e124/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for harmony board...
text data bss dec hex filename
295786 11870 311232 618888 97188/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for seaboard board...
text data bss dec hex filename
310284 13450 309544 633278 9a9be/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for ventana board...
text data bss dec hex filename
248990 7690 307820 564500 89d14/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for whistler board...
text data bss dec hex filename
244038 9018 307768 560824 88eb8/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for beaver board...
text data bss dec hex filename
255926 16672 308676 581274 8de9a/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for cardhu board...
text data bss dec hex filename
255926 16672 308676 581274 8de9a/home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot
--------------------- SUMMARY ---------------------------- Boards compiled: 7
----------------------------------------------------------
PATCH 1/1 tegra: allow build to succeed with SPL disabled
In reply to Tom WarrenQuoted 43 lines
-----Original Message-----
From: Tom Warren
Sent: Thursday, October 31, 2013 9:38 PM
To: Vidya Sagar; u-boot at lists.denx.de
Cc: Stephen Warren; Vidya Sagar; Tom Warren
Subject: RE: [PATCH] tegra: allow build to succeed with SPL disabledVidya,
Quoted 32 lines
-----Original Message-----
From: Vidya Sagar [mailto:vidyas at nvidia.com]
Sent: Thursday, October 31, 2013 2:22 AM
To: u-boot at lists.denx.de
Cc: Tom Warren; Stephen Warren; Vidya Sagar
Subject: [PATCH] tegra: allow build to succeed with SPL disabledu-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Signed-off-by Vidya Sagar <[email protected]>--- Makefile | 2 ++ 1 file changed, 2 insertions(+)Makefile +2
-0@@ -407,12 +407,14 @@ endif # enable combined SPL/u-boot/dtb rules for tegra ifneq ($(CONFIG_TEGRA),) +ifeq ($(CONFIG_SPL),y) ifeq ($(CONFIG_OF_SEPARATE),y) ALL-y += $(obj)u-boot-dtb-tegra.bin else ALL-y += $(obj)u-boot-nodtb-tegra.bin endif endif +endif all: $(ALL-y) $(SUBDIR_EXAMPLES)
Quoted 8 lines
Quoted 2 lines
Makefile +0
-1--1.8.1.5
LGTM, thanks. I assume you built all Tegra boards using MAKEALL?
If so, then:
Acked-by Tom Warren <[email protected]>--
nvpublic
I've run "./MAKEALL -v nvidia" and didn't see any issue.
--
nvpublic
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Quoted 7 lines · Vidya Sagar
Tom Warren wrote at Thursday, October 31, 2013 9:38 PM:
Quoted 4 lines
If so, then:
Acked-by Tom Warren <[email protected]>--
nvpublicI've run "./MAKEALL -v nvidia" and didn't see any issue.
You want "./MAKEALL -s tegra", since not all Tegra boards were created by NVIDIA; quite a few come from other vendors.
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Quoted 16 lines
-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Friday, November 01, 2013 11:05 PM
To: Vidya Sagar; Tom Warren; u-boot at lists.denx.de
Cc: Tom Warren; Stephen Warren
Subject: Re: [U-Boot] [PATCH] tegra: allow build to succeed with SPL disabledQuoted 6 lines · Vidya Sagar
Tom Warren wrote at Thursday, October 31, 2013 9:38 PM:
Quoted 4 lines
If so, then:
Acked-by Tom Warren <[email protected]>--
nvpublic
Quoted 4 lines
Quoted 1 line
I've run "./MAKEALL -v nvidia" and didn't see any issue.
You want "./MAKEALL -s tegra", since not all Tegra boards were created by NVIDIA; quite a few come from other vendors.
just now gave a try. Total number of boards compiled are 13 and didn't see any issue.
--
nvpublic
PATCH 1/1 tegra: allow build to succeed with SPL disabled
In reply to Vidya SagarQuoted 3 lines · Vidya Sagar
u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Should they though? If there's no SPL, surely we still want to generate the same output filenames, so that consumers of the binaries don't have to care whether a particular board needs the SPL tacked onto the binary.
In other words, rather than:
u-boot-nodtb-tegra.bin == SPL + U-Boot
u-boot-dtb-tegra.bin == SPL + U-Boot + DTB
... when SPL is disabled, shouldn't we generate:
u-boot-nodtb-tegra.bin == U-Boot
u-boot-dtb-tegra.bin == U-Boot + DTB
That would require modifying the rules that generate those files not to include the SPL binary in the concatenation, rather than simply not generating those files at all.
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Quoted 22 lines
-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Thursday, October 31, 2013 9:59 PM
To: Vidya Sagar; u-boot at lists.denx.de
Cc: Stephen Warren; Tom Warren
Subject: Re: [U-Boot] [PATCH] tegra: allow build to succeed with SPL disabledQuoted 2 lines · Vidya Sagar
u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Should they though? If there's no SPL, surely we still want to generate the same output filenames, so that consumers of the binaries don't have to care whether a particular board needs the SPL tacked onto the binary.
In other words, rather than:
u-boot-nodtb-tegra.bin == SPL + U-Boot
u-boot-dtb-tegra.bin == SPL + U-Boot + DTB
Quoted 8 lines
... when SPL is disabled, shouldn't we generate:
u-boot-nodtb-tegra.bin == U-Boot
u-boot-dtb-tegra.bin == U-Boot + DTBThat would require modifying the rules that generate those files not to include the SPL binary in the concatenation, rather than simply not generating those files at all.
When the SPL build is disabled, we are already generating u-boot.bin and u-boot-dtb.bin. Do we really want to generate two more binaries with the same content but with different names ?
--
nvpublic
PATCH 1/1 tegra: allow build to succeed with SPL disabled
Quoted 27 lines · Vidya Sagar
Quoted 27 lines
-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Thursday, October 31, 2013 9:59 PM
To: Vidya Sagar; u-boot at lists.denx.de
Cc: Stephen Warren; Tom Warren
Subject: Re: [U-Boot] [PATCH] tegra: allow build to succeed with SPL disabledQuoted 2 lines · Vidya Sagar
u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated only if the SPL build is enabled as they have dependency on SPL build
Should they though? If there's no SPL, surely we still want to generate the same output filenames, so that consumers of the binaries don't have to care whether a particular board needs the SPL tacked onto the binary.
In other words, rather than:
u-boot-nodtb-tegra.bin == SPL + U-Boot
u-boot-dtb-tegra.bin == SPL + U-Boot + DTB... when SPL is disabled, shouldn't we generate:
u-boot-nodtb-tegra.bin == U-Boot
u-boot-dtb-tegra.bin == U-Boot + DTB
Quoted 6 lines
Quoted 3 lines
That would require modifying the rules that generate those files not to include the SPL binary in the concatenation, rather than simply not generating those files at all.
When the SPL build is disabled, we are already generating u-boot.bin and u-boot-dtb.bin. Do we really want to generate two more binaries with the same content but with different names ?
Oh, I guess that the way u-boot-tegra-*.bin is a bit different to what I thought, so indeed if you just disable those, then the desired U-Boot+DTB files are still created. So, I guess it's fine the way you have it.
It's a bit annoying that the output filenames are different based on whether you have SPL or not, but I guess I can make our flasher scripts cope with that easily enough.