Skip to contentSkip to conversation

cxd2820r_c: Fix if_ctl calculation

PATCH In review CrazyCat 2 participants 3 messages Nov 2, 2013 – Nov 3, 2013

Subsystems (2)
lore
Share & tools
lore

CrazyCat

author
#0 lore raw

PATCH 1/1 cxd2820r_c: Fix if_ctl calculation

Fix tune for DVB-C.

drivers/media/dvb-frontends/cxd2820r_c.c +1 -1
index 125a440..5c6ab49 100644
@@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe)
 
 	num = if_freq / 1000; /* Hz => kHz */
 	num *= 0x4000;
-	if_ctl = cxd2820r_div_u64_round_closest(num, 41000);
+	if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000);
 	buf[0] = (if_ctl >> 8) & 0x3f;
 	buf[1] = (if_ctl >> 0) & 0xff;
 
#1 lore raw

CrazyCat,

Could you fix your mailer? Or tell me the command I can import that patch to my local git tree for testing?

git send-email is at least know to break patches.

I will manually applying that patch and testing, but..

$ wget --no-check-certificate -O - https://patchwork.linuxtv.org/patch/20560/mbox/ | git am -s
--2013-11-03 19:15:11--  https://patchwork.linuxtv.org/patch/20560/mbox/
Resolving patchwork.linuxtv.org (patchwork.linuxtv.org)... 130.149.80.248
Connecting to patchwork.linuxtv.org (patchwork.linuxtv.org)|130.149.80.248|:443... connected.
WARNING: cannot verify patchwork.linuxtv.org's certificate, issued by ‘/C=XX/ST=There is no such thing outside US/L=Everywhere/O=OCOSA/OU=Office for Complication of Otherwise Simple Affairs/CN=www.linuxtv.org/[email protected]’:
  Self-signed certificate encountered.
    WARNING: certificate common name ‘www.linuxtv.org’ doesn't match 
requested host name ‘patchwork.linuxtv.org’.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘STDOUT’
    [ <=> 

       ] 1 199       --.-K/s   in 0s
2013-11-03 19:15:11 (9,34 MB/s) - written to stdout [1199]

Applying: cxd2820r_c: Fix if_ctl calculation
error: patch failed: drivers/media/dvb-frontends/cxd2820r_c.c:78
error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply Patch failed at 0001 cxd2820r_c: Fix if_ctl calculation
The copy of the patch that failed is found in:
/home/crope/linuxtv/code/linux/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".

regards
Antti

Quoted 22 lines · CrazyCat

Fix tune for DVB-C.

drivers/media/dvb-frontends/cxd2820r_c.c +1 -2
index 125a440..5c6ab49 100644
@@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe)
 
      num = if_freq / 1000; /* Hz => kHz */
      num *= 0x4000;
-    if_ctl = cxd2820r_div_u64_round_closest(num, 41000);
+    if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000);
      buf[0] = (if_ctl >> 8) & 0x3f;
      buf[1] = (if_ctl >> 0) & 0xff;
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
http://palosaari.fi/
Acked-by Reviewed-by Tested-by
#2 lore raw
Quoted 6 lines · Antti Palosaari

CrazyCat,

Could you fix your mailer? Or tell me the command I can import that patch to my local git tree for testing?

git send-email is at least know to break patches.

*not* to break patches!

Quoted 7 lines

I will manually applying that patch and testing, but..

error: drivers/media/dvb-frontends/cxd2820r_c.c: patch does not apply

I tested it, by manually copy & pasting that single line. I didn't noticed any change to existing behavior, but I have no reason to suspect patch is wrong.

I am not going to apply that via my tree as patch fails.

It is up to subsystem maintainers to pick it up.

regards
Antti

Quoted 26 lines · CrazyCat
Quoted 22 lines

Fix tune for DVB-C.

drivers/media/dvb-frontends/cxd2820r_c.c +1 -2
index 125a440..5c6ab49 100644
@@ -78,7 +78,7 @@ int cxd2820r_set_frontend_c(struct dvb_frontend *fe)
 
      num = if_freq / 1000; /* Hz => kHz */
      num *= 0x4000;
-    if_ctl = cxd2820r_div_u64_round_closest(num, 41000);
+    if_ctl = 0x4000 - cxd2820r_div_u64_round_closest(num, 41000);
      buf[0] = (if_ctl >> 8) & 0x3f;
      buf[1] = (if_ctl >> 0) & 0xff;
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
http://palosaari.fi/