Skip to contentSkip to conversation

openpgm: disable on AVR32

PATCH Superseded Alexander Lukichev 3 participants 6 messages Oct 31, 2013 – Nov 3, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openpgm: disable on AVR32

openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected.

This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

---
 package/openpgm/Config.in | 5 +++++
 package/zeromq/Config.in  | 1 +
 2 files changed, 6 insertions(+)
package/openpgm/Config.in +5 -0
index cae74f7..94733cd 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_OPENPGM
 	bool "openpgm"
+	depends on !BR2_avr32
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_USE_WCHAR
@@ -14,3 +15,7 @@ config BR2_PACKAGE_OPENPGM
 
 comment "openpgm needs a toolchain w/ wchar, threads, IPv6"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR)
+	depends on !BR2_avr32
+
+comment "openpgm is BROKEN on AVR32"
+	depends on BR2_avr32
package/zeromq/Config.in +1 -0
index 42e13d2..3e8516c 100644
@@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ
 config BR2_PACKAGE_ZEROMQ_PGM
 	bool "PGM/EPGM support"
 	depends on BR2_PACKAGE_ZEROMQ
+	depends on !BR2_avr32
 	select BR2_PACKAGE_OPENPGM
 	help
 	  Add support for Pragmatic General Multicast protocol (RFC 3208)
Signature · 1 line
1.8.0.1
#1 lore raw

PATCH 1/1 openpgm: disable on AVR32

Quoted 9 lines · Alexander Lukichev

openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected.

Quoted 8 lines

This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

Good plan! However, your patch is incomplete.

Quoted 17 lines
---
  package/openpgm/Config.in | 5 +++++
  package/zeromq/Config.in  | 1 +
  2 files changed, 6 insertions(+)
package/openpgm/Config.in +1 -0
index cae74f7..94733cd 100644
@@ -1,5 +1,6 @@
  config BR2_PACKAGE_OPENPGM
  	bool "openpgm"
+	depends on !BR2_avr32
  	depends on BR2_TOOLCHAIN_HAS_THREADS
  	depends on BR2_INET_IPV6
  	depends on BR2_USE_WCHAR

package/openpgm/Config.in config BR2_PACKAGE_OPENPGM · line 21

Quoted 7 lines
package/openpgm/Config.in +4 -0
@@ -14,3 +15,7 @@ config BR2_PACKAGE_OPENPGM
 
  comment "openpgm needs a toolchain w/ wchar, threads, IPv6"
  	depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR)
+	depends on !BR2_avr32
+
+comment "openpgm is BROKEN on AVR32"
+	depends on BR2_avr32

This comment isn't needed. We don't do it for other packages, and
adding it would make it even more work to disable architectures.

package/zeromq/Config.in config BR2_PACKAGE_ZEROMQ · line 33

Quoted 9 lines
package/zeromq/Config.in +1 -0
index 42e13d2..3e8516c 100644
@@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ
  config BR2_PACKAGE_ZEROMQ_PGM
  	bool "PGM/EPGM support"
  	depends on BR2_PACKAGE_ZEROMQ
+	depends on !BR2_avr32

zeromq has a lot of reverse dependencies: cppzmq, czmq, filemq,
mongrel2, [python-pyzmq not necessary because python needs MMU], [zmqpp already disabled for avr32]. And there's one more transitive dependency to zyre. So all these should also be disabled.

Regards,
Arnout

Quoted 4 lines
package/zeromq/Config.in +0 -0
  	select BR2_PACKAGE_OPENPGM
  	help
  	  Add support for Pragmatic General Multicast protocol (RFC 3208)
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 openpgm: disable on AVR32

Hi Arnout,

Quoted 4 lines · Arnout Vandecappelle

package/openpgm/Config.in config BR2_PACKAGE_OPENPGM · line 21

Quoted 2 lines
package/openpgm/Config.in +2 -0
+comment "openpgm is BROKEN on AVR32"
+    depends on BR2_avr32

This comment isn't needed. We don't do it for other packages, and
adding it would make it even more work to disable architectures.

Understood. I was angry at openpgm :)

Quoted 8 lines
Quoted 4 lines

config BR2_PACKAGE_ZEROMQ_PGM
bool "PGM/EPGM support"
depends on BR2_PACKAGE_ZEROMQ
+ depends on !BR2_avr32

zeromq has a lot of reverse dependencies: cppzmq, czmq, filemq,
mongrel2, [python-pyzmq not necessary because python needs MMU], [zmqpp already disabled for avr32]. And there's one more transitive dependency to zyre. So all these should also be disabled.

I do not understand. Why should they be disabled? This patch does not disable the zeromq library, merely PGM support in it. I may be mistaken but "users" of zeromq that we have in Buildroot do not actually require this feature (PGM support). Or am I missing the point?

Thanks for your comments!

--
Best regards,
Alexander Lukichev

#3 lore raw

PATCH 1/1 openpgm: disable on AVR32

Dear Alexander Lukichev,

Quoted 9 lines · Alexander Lukichev
Quoted 8 lines
Quoted 4 lines

config BR2_PACKAGE_ZEROMQ_PGM
bool "PGM/EPGM support"
depends on BR2_PACKAGE_ZEROMQ
+ depends on !BR2_avr32

zeromq has a lot of reverse dependencies: cppzmq, czmq, filemq,
mongrel2, [python-pyzmq not necessary because python needs MMU], [zmqpp already disabled for avr32]. And there's one more transitive dependency to zyre. So all these should also be disabled.

Quoted 4 lines

I do not understand. Why should they be disabled? This patch does not disable the zeromq library, merely PGM support in it. I may be mistaken but "users" of zeromq that we have in Buildroot do not actually require this feature (PGM support). Or am I missing the point?

You're correct, I believe Arnout missed the fact that the dependency is added on a sub-option of the ZeroMQ package, and not on the ZeroMQ package itself, and there is nothing that selects BR2_PACKAGE_ZEROMQ_PGM.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 openpgm: disable on AVR32

Quoted 18 lines · Thomas Petazzoni

Dear Alexander Lukichev,

Quoted 9 lines · Alexander Lukichev
Quoted 8 lines
Quoted 4 lines

config BR2_PACKAGE_ZEROMQ_PGM
bool "PGM/EPGM support"
depends on BR2_PACKAGE_ZEROMQ
+ depends on !BR2_avr32

zeromq has a lot of reverse dependencies: cppzmq, czmq, filemq,
mongrel2, [python-pyzmq not necessary because python needs MMU], [zmqpp already disabled for avr32]. And there's one more transitive dependency to zyre. So all these should also be disabled.

Quoted 4 lines

I do not understand. Why should they be disabled? This patch does not disable the zeromq library, merely PGM support in it. I may be mistaken but "users" of zeromq that we have in Buildroot do not actually require this feature (PGM support). Or am I missing the point?

Quoted 4 lines

You're correct, I believe Arnout missed the fact that the dependency is added on a sub-option of the ZeroMQ package, and not on the ZeroMQ package itself, and there is nothing that selects BR2_PACKAGE_ZEROMQ_PGM.

Indeed, sorry for the noise.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 openpgm: disable on AVR32

In reply to Alexander Lukichev

Dear Alexander Lukichev,

package/openpgm/Config.in line 3

Quoted 3 lines · Alexander Lukichev

config BR2_PACKAGE_OPENPGM

package/openpgm/Config.in +1 -0
 	bool "openpgm"
+	depends on !BR2_avr32

Would be good to add a comment explaining why we have this (compiler too old, missing intrinsics)

package/openpgm/Config.in config BR2_PACKAGE_OPENPGM · line 21

Quoted 11 lines
package/openpgm/Config.in +4 -0
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_USE_WCHAR
@@ -14,3 +15,7 @@ config BR2_PACKAGE_OPENPGM
 
 comment "openpgm needs a toolchain w/ wchar, threads, IPv6"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR)
+	depends on !BR2_avr32
+
+comment "openpgm is BROKEN on AVR32"
+	depends on BR2_avr32

We generally don't add comments for such cases (i.e package not available on the selected architecture).

package/zeromq/Config.in config BR2_PACKAGE_ZEROMQ · line 33

Quoted 9 lines
package/zeromq/Config.in +1 -0
index 42e13d2..3e8516c 100644
@@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ
 config BR2_PACKAGE_ZEROMQ_PGM
 	bool "PGM/EPGM support"
 	depends on BR2_PACKAGE_ZEROMQ
+	depends on !BR2_avr32

Maybe:

depends on !BR2_avr32 # openpgm

package/zeromq/Config.in config BR2_PACKAGE_ZEROMQ · line 36

Quoted 3 lines
package/zeromq/Config.in +0 -0
 	select BR2_PACKAGE_OPENPGM
 	help
 	  Add support for Pragmatic General Multicast protocol (RFC 3208)

Can you fix these minor comments and resend an updated version?

Thanks a lot!

Thomas Petazzoni

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com