titanium: Return the error when cpu_eth_init() fails
PATCH 1/1 titanium: Return the error when cpu_eth_init() fails
From: Fabio Estevam <[email protected]>
When cpu_eth_init() fails we should not return success.
Signed-off-by Fabio Estevam <[email protected]>
--- board/freescale/titanium/titanium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/titanium/titanium.c +1 -1
@@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis)if (ret)printf ("FEC MXC: %s:failed\n" , __func__); -return 0 ; +return ret; }int board_early_init_f (void )
Signature · 1 line
1.8.1.2
PATCH 1/1 titanium: Return the error when cpu_eth_init() fails
Hi Fabio,
Quoted 14 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
When
cpu_eth_init()fails we should not return success.Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/titanium/titanium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/freescale/titanium/titanium.c +0
-0
board/freescale/titanium/titanium.c int board_eth_init(bd_t *bis) · line 278
Quoted 8 lines
board/freescale/titanium/titanium.c +1
-1@@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis)if (ret)printf ("FEC MXC: %s:failed\n" , __func__); -return 0 ; +return ret; }int board_early_init_f (void )
Thanks.
Acked-by Stefan Roese <[email protected]>
Thanks,
Stefan
PATCH 1/1 titanium: Return the error when cpu_eth_init() fails
In reply to Fabio EstevamQuoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
When
cpu_eth_init()fails we should not return success.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================