Skip to contentSkip to conversation

configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

PATCH New Fabio Estevam 3 participants 4 messages Nov 1, 2013 – Nov 13, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

There is no real benefit in adding the board name into U-boot's prompt, so remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " prompt is used across FSL boards.

---
Changes since v1:
- Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'

 include/configs/mx25pdk.h         | 1 -
 include/configs/mx28evk.h         | 1 -
 include/configs/mx31pdk.h         | 1 -
 include/configs/mx35pdk.h         | 1 -
 include/configs/mx51evk.h         | 1 -
 include/configs/mx53evk.h         | 1 -
 include/configs/mx53loco.h        | 1 -
 include/configs/mx53smd.h         | 1 -
 include/configs/mx6qarm2.h        | 1 -
 include/configs/mx6sabre_common.h | 1 -
 10 files changed, 10 deletions(-)
include/configs/mx25pdk.h +0 -1
index 543c415..79b36c2 100644
@@ -65,7 +65,6 @@
 #define CONFIG_SYS_MMC_ENV_DEV 0
 
 /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT	"MX25PDK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size  */
 /* Print buffer sz */
include/configs/mx28evk.h +0 -1
index 07f88ca..22fdb3a 100644
@@ -14,7 +14,6 @@
 /* System configurations */
 #define CONFIG_MX28				/* i.MX28 SoC */
 #define CONFIG_MACH_TYPE	MACH_TYPE_MX28EVK
-#define CONFIG_SYS_PROMPT	"MX28EVK U-Boot > "
 
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
include/configs/mx31pdk.h +0 -1
index d41f2cd..591ab54 100644
@@ -120,7 +120,6 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \
include/configs/mx35pdk.h +0 -1
index 2f59104..d72b312 100644
@@ -136,7 +136,6 @@
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX35 U-Boot > "
 #define CONFIG_CMDLINE_EDITING
 #define CONFIG_SYS_HUSH_PARSER	/* Use the HUSH parser */
 
include/configs/mx51evk.h +0 -1
index 04f518a..4edbc4c 100644
@@ -219,7 +219,6 @@
  */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX51EVK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
include/configs/mx53evk.h +0 -1
index fe5cf3c..99c40d8 100644
@@ -136,7 +136,6 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53EVK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
include/configs/mx53loco.h +0 -1
index bd2fa43..e000839 100644
@@ -178,7 +178,6 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53LOCO U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
 
include/configs/mx53smd.h +0 -1
index 12b2c0d..a1d5b70 100644
@@ -121,7 +121,6 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53SMD U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
include/configs/mx6qarm2.h +0 -1
index ef3058c..d759de7 100644
@@ -114,7 +114,6 @@
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
-#define CONFIG_SYS_PROMPT		"MX6QARM2 U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256
 
include/configs/mx6sabre_common.h +0 -1
index bf6113b..0fb8e0b 100644
@@ -171,7 +171,6 @@
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_PROMPT              "U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v2 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

Hi Stefano,

Quoted 8 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt, so remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " prompt is used across FSL boards.

---
Changes since v1:
- Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'

Forgot to mention that this patch depends on Rob's:
http://patchwork.ozlabs.org/patch/279334/

,otherwise we get build errors.

Regards,

Fabio Estevam

#2 lore raw

PATCH v2 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

Hi Fabio,

Quoted 8 lines · Fabio Estevam

Hi Stefano,

Quoted 4 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt, so remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " prompt is used across FSL boards.

Quoted 8 lines
Quoted 4 lines

---
Changes since v1:
- Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'

Forgot to mention that this patch depends on Rob's:
http://patchwork.ozlabs.org/patch/279334/

Right, I am tracking Rob's patch before including yours.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 1/1 configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

There is no real benefit in adding the board name into U-boot's prompt, so remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " prompt is used across FSL boards.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================