Skip to contentSkip to conversation

configure: Enable pie for powerpc and arm Linux

PATCH In review Dinar Valeev 4 participants 5 messages Nov 4, 2013 – Nov 5, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Enable pie for powerpc and arm Linux

From: Dinar Valeev <[email protected]>

This patch enables pie for PowerPC and ARM architectures

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 91372f9..0130e7e 100755
@@ -1297,7 +1297,7 @@ fi
 
 if test "$pie" = ""; then
   case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
       ;;
     *)
       pie="no"
Signature · 1 line
1.7.12.4
#1 lore raw
Quoted 14 lines · Dinar Valeev

From: Dinar Valeev <[email protected]>

This patch enables pie for PowerPC and ARM architectures

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 91372f9..0130e7e 100755

configure fi · line 1300

Quoted 5 lines
configure +1 -1
@@ -1297,7 +1297,7 @@ fi
 
 if test "$pie" = ""; then
   case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)

I'd much prefer that we have a blacklist than a whitelist for this. Honestly, most ELF systems can support PIE, and we have very few non-ELF systems to support.

r~

#2 lore raw

Il 04/11/2013 21:51, Richard Henderson ha scritto:

Quoted 7 lines
Quoted 4 lines

configure fi · line 1300

Quoted 4 lines

if test "$pie" = ""; then
case "$cpu-$targetos" in

configure +1 -1
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)

I'd much prefer that we have a blacklist than a whitelist for this. Honestly, most ELF systems can support PIE, and we have very few non-ELF systems to support.

Since the test is followed by a compile test, we probably do not even need the whitelist.

Paolo

#3 lore raw

Am 04.11.2013 22:16, schrieb Paolo Bonzini:

Quoted 11 lines

Il 04/11/2013 21:51, Richard Henderson ha scritto:

Quoted 7 lines
Quoted 4 lines

configure fi · line 1300

Quoted 4 lines

if test "$pie" = ""; then
case "$cpu-$targetos" in

configure +1 -1
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)

I'd much prefer that we have a blacklist than a whitelist for this. Honestly, most ELF systems can support PIE, and we have very few non-ELF systems to support.

Since the test is followed by a compile test, we probably do not even need the whitelist.

I remember reading a report here that someone ran into a link issue with PIE on x86 at build time (check went okay) and was able to resolve it via --disable-pie. Unfortunately I couldn't locate the post - do you remember what that was about? Was that some BSD rather than Linux maybe?

It's probably a good idea to still allow overriding it, whether we white- or blacklist or trust a compile test.

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
#4 lore raw
In reply to Dinar Valeev

Am 04.11.2013 13:19, schrieb Dinar Valeev:

Quoted 14 lines

From: Dinar Valeev <[email protected]>

This patch enables pie for PowerPC and ARM architectures

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 91372f9..0130e7e 100755

configure fi · line 1303

Quoted 8 lines
configure +1 -1
@@ -1297,7 +1297,7 @@ fi
 
 if test "$pie" = ""; then
   case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
       ;;
     *)
       pie="no"

For the benefit of the list, we have been using the ppc part of this patch for the openSUSE ppc/ppc64 builds (some helper would otherwise fail to link), and for our arm/aarch64 builds we've been using --enable-pie to skip the above test. So those are known to work for us.

Andreas

Signature · 2 lines
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg