Skip to contentSkip to conversation

pinctrl: at91: copy define to driver

PATCH New Linus Walleij 2 participants 2 messages Nov 5, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 3/4 pinctrl: at91: copy define to driver

The #define for the maximum number of GPIO blocks was retrieved into pinctrl-at91.c by implicit inclusion of <mach/gpio.h> from <linux/gpio.h> creating a dependency on machine-local <mach/gpio.h>. Break the depenency by copying this single define into the driver.

---
This will be applied directly to the pinctrl tree unless there are specific protests.

---
 drivers/pinctrl/pinctrl-at91.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/pinctrl-at91.c +1 -0
index f350fd2e170e..0dfb8c7b58df 100644
@@ -33,6 +33,7 @@
 
 #include "core.h"
 
+#define MAX_GPIO_BANKS		5
 #define MAX_NB_GPIO_PER_BANK	32
 
 struct at91_pinctrl_mux_ops;
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 3/4 pinctrl: at91: copy define to driver

On 05/11/2013 10:30, Linus Walleij :

Quoted 7 lines

The #define for the maximum number of GPIO blocks was retrieved into pinctrl-at91.c by implicit inclusion of <mach/gpio.h> from <linux/gpio.h> creating a dependency on machine-local <mach/gpio.h>. Break the depenency by copying this single define into the driver.

Yes, that seems reasonable.

Quoted 20 lines

---
This will be applied directly to the pinctrl tree unless there are specific protests.

---
  drivers/pinctrl/pinctrl-at91.c | 1 +
  1 file changed, 1 insertion(+)
drivers/pinctrl/pinctrl-at91.c +1 -0
index f350fd2e170e..0dfb8c7b58df 100644
@@ -33,6 +33,7 @@
 
  #include "core.h"
 
+#define MAX_GPIO_BANKS		5
  #define MAX_NB_GPIO_PER_BANK	32
 
  struct at91_pinctrl_mux_ops;
Signature · 1 line
Nicolas Ferre