Avoid toolchain download when it is preinstalled
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.
--- toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++ 1 file changed, 8 insertions(+)
toolchain/toolchain-external/toolchain-external.mk +8 -0
@@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) endif +# In fact, we don't need to download the toolchain, since it is already +# available on the system, so force the site and source to be empty so +# that nothing will be downloaded/extracted. +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y) +TOOLCHAIN_EXTERNAL_SITE = +TOOLCHAIN_EXTERNAL_SOURCE = +endif + TOOLCHAIN_EXTERNAL_INSTALL_STAGING = YES ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
Signature · 1 line
1.7.10.4
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
Quoted 28 lines · Laurent GONZALEZ
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.Signed-off-by GONZALEZ Laurent <[email protected]>---
toolchain/toolchain-external/toolchain-external.mk| 8 ++++++++1 file changed, 8 insertions(+)toolchain/toolchain-external/toolchain-external.mk +0
-0@@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))endif
toolchain/toolchain-external/toolchain-external.mk +8
-0+# In fact, we don't need to download the toolchain, since it is already +# available on the system, so force the site and source to be empty so +# that nothing will be downloaded/extracted. +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y) +TOOLCHAIN_EXTERNAL_SITE = +TOOLCHAIN_EXTERNAL_SOURCE = +endif +
TOOLCHAIN_EXTERNAL_INSTALL_STAGING= YES
Quoted 1 line
ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
In the previous thread you said there was still a problem with v2... What was that problem? I tested v2 and seemed to work fine...
Thanks,
Thomas
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
Quoted 29 lines · Thomas De Schampheleire
Quoted 28 lines · Laurent GONZALEZ
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.Signed-off-by GONZALEZ Laurent <[email protected]>---
toolchain/toolchain-external/toolchain-external.mk| 8 ++++++++1 file changed, 8 insertions(+)toolchain/toolchain-external/toolchain-external.mk +0
-0@@ -348,6 +348,14 @@ TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))endif
toolchain/toolchain-external/toolchain-external.mk +8
-0+# In fact, we don't need to download the toolchain, since it is already +# available on the system, so force the site and source to be empty so +# that nothing will be downloaded/extracted. +ifeq ($(BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED),y) +TOOLCHAIN_EXTERNAL_SITE = +TOOLCHAIN_EXTERNAL_SOURCE = +endif +
TOOLCHAIN_EXTERNAL_INSTALL_STAGING= YES
Quoted 5 lines
Quoted 1 line
ifeq ($(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1)$(BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2),y)
In the previous thread you said there was still a problem with v2... What was that problem? I tested v2 and seemed to work fine...
There were no other problem than the one you highlighted in my very first thread. This v3 looks good, when everyone agrees it should be ready for integration.
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
In reply to Laurent GONZALEZDear Laurent GONZALEZ,
Quoted 9 lines · Laurent GONZALEZ
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.Signed-off-by GONZALEZ Laurent <[email protected]>--- toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++ 1 file changed, 8 insertions(+)
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
Quoted 8 lines · Thomas Petazzoni
Dear Laurent GONZALEZ,
Quoted 5 lines · Laurent GONZALEZ
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.
Quoted 6 lines
Quoted 4 lines
Signed-off-by GONZALEZ Laurent <[email protected]>--- toolchain/toolchain-external/toolchain-external.mk | 8 ++++++++ 1 file changed, 8 insertions(+)Reviewed-by Thomas Petazzoni <[email protected]>
PATCH v3 1/1 Avoid toolchain download when it is preinstalled
In reply to Laurent GONZALEZQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Laurent" == Laurent GONZALEZ <[email protected]> writes:
For configurations using a toolchain that is preinstalled on the host, <pkg>_SITE and <pkg>_SOURCE variables must be kept empty to avoid downloading any toolchain package.
The actual implementation has been proposed by Thomas Petazzoni.Signed-off-by GONZALEZ Laurent <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard