Silence unused_result warning from write()
PATCH 1/1 Silence unused_result warning from write()
Some glibc versions mark write() with attribute warn_unused_result (found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.
--- lib/cobalt/init.c | 4 +++- testsuite/latency/latency.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
lib/cobalt/init.c +3 -1
@@ -53,7 +53,9 @@ int __rtdm_fd_start = INT_MAX;static void sigill_handler (int sig) {const char m[] ="no Xenomai support in kernel?\n" ; -write (2 , m,sizeof (m) -1 ); +if (write (2 , m,sizeof (m) -1 ) <1 ) { +/* Silence unused_result warning. No handling in error case, though. */ + }exit (EXIT_FAILURE ); }
testsuite/latency/latency.c +3 -1
@@ -507,7 +507,9 @@ static void sigdebug(int sig, siginfo_t *si, void *context)case SIGDEBUG_WATCHDOG : n =snprintf (buffer,sizeof (buffer),"%s\n" , reason_str[reason]); -write (STDERR_FILENO , buffer, n); +if (write (STDERR_FILENO , buffer, n) <1 ) { +/* Silence unused_result warning. No handling in error case, though. */ + }exit (EXIT_FAILURE ); }
Signature · 8 lines
1.8.1.2 -- Regards, Gernot Hillier Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux
Quoted 3 lines · Gernot Hillier
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.
Why not casting write result to void, it does not work?
Signature · 1 line
Gilles.
Am 07.11.2013 19:01, schrieb Gilles Chanteperdrix:
Quoted 7 lines · Gernot Hillier
Quoted 3 lines
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.Why not casting write result to void, it does not work?
No, it doesn't. For rationale, please see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.
Signature · 1 line
Gernot
Quoted 6 lines · Gernot Hillier
Am 07.11.2013 19:01, schrieb Gilles Chanteperdrix:
Quoted 5 lines · Gernot Hillier
Quoted 3 lines
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.
Quoted 6 lines
Quoted 2 lines
Why not casting write result to void, it does not work?
No, it doesn't. For rationale, please see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.
Ok, but I do not like your patch anyway:
- it compares directly the function result, which no other code in Xenomai sources does, we always store the result in a variable and test the variable
- it opens and closes braces for no good reason.
I believe you still can do:
rc = write
(void)rc
The link you sent also indicates that the warning can be disabled with -Wno-unused-result
Can you not compile with this option on distributions with this behaviour?
Signature · 1 line
Gilles.
Quoted 19 lines · Gilles Chanteperdrix
Quoted 6 lines · Gernot Hillier
Am 07.11.2013 19:01, schrieb Gilles Chanteperdrix:
Quoted 5 lines · Gernot Hillier
Quoted 3 lines
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.Quoted 6 lines
Quoted 2 lines
Why not casting write result to void, it does not work?
No, it doesn't. For rationale, please see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.Ok, but I do not like your patch anyway:
- it compares directly the function result, which no other code in Xenomai sources does, we always store the result in a variable and test the variable
- it opens and closes braces for no good reason.
Quoted 4 lines
I believe you still can do:
rc = write
(void)rc
Yep, that's what other projects do as well when there is really no use for the return code.
Quoted 5 lines
The link you sent also indicates that the warning can be disabled with -Wno-unused-result
Can you not compile with this option on distributions with this behaviour?
Let's fix this in our source code, not in the ./configure command line. I expect the warning to become more frequent with recent compilers and/or distros.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux
Quoted 28 lines
Von: Jan Kiszka
Gesendet: Freitag, 8. November 2013 19:18Quoted 13 lines · Gilles Chanteperdrix
Quoted 6 lines · Gernot Hillier
Am 07.11.2013 19:01, schrieb Gilles Chanteperdrix:
Quoted 5 lines · Gernot Hillier
Quoted 3 lines
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.Quoted 6 lines
Quoted 2 lines
Why not casting write result to void, it does not work?
No, it doesn't. For rationale, please see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.Quoted 6 lines
...
I believe you still can do:
rc = write
(void)rcYep, that's what other projects do as well when there is really no use for the return code.
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
The link you sent also indicates that the warning can be disabled with -Wno-unused-result
Can you not compile with this option on distributions with this behaviour?
Let's fix this in our source code, not in the ./configure command line. I expect the warning to become more frequent with recent compilers and/or distros.
Since this has been recognized as a bug http://sourceware.org/bugzilla/show_bug.cgi?id=11959 in glibc and fixed, it should become less frequent with recent distros. I think, source code shouldn't be cluttered with silly workarounds.
--
Best regards,
Dietmar Schindler
________________________________________
manroland web systems GmbH -- Managing Director: Eckhard Hoerner-Marass
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No. 26816 -- VAT: DE281389840
Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.
! Please consider your environmental responsibility before printing this eMail
________________________________________
Hi!
Am 11.11.2013 09:36, schrieb [email protected]:
Quoted 33 lines
Quoted 33 lines
Von: Jan Kiszka
Gesendet: Freitag, 8. November 2013 19:18Quoted 13 lines · Gilles Chanteperdrix
Quoted 6 lines · Gernot Hillier
Am 07.11.2013 19:01, schrieb Gilles Chanteperdrix:
Quoted 5 lines · Gernot Hillier
Quoted 3 lines
Some glibc versions mark
write()with attributewarn_unused_result(found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially when building with -Werror.Quoted 6 lines
Quoted 2 lines
Why not casting write result to void, it does not work?
No, it doesn't. For rationale, please see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509.Quoted 6 lines
...
I believe you still can do:
rc = write
(void)rcYep, that's what other projects do as well when there is really no use for the return code.
Quoted 5 lines
The link you sent also indicates that the warning can be disabled with -Wno-unused-result
Can you not compile with this option on distributions with this behaviour?
Quoted 8 lines
Quoted 3 lines
Let's fix this in our source code, not in the ./configure command line. I expect the warning to become more frequent with recent compilers and/or distros.
Since this has been recognized as a bug
http://sourceware.org/bugzilla/show_bug.cgi?id=11959 in glibc and fixed, it should become less frequent with recent distros. I think, source code shouldn't be cluttered with silly workarounds.
The glibc bug is about fwrite(), not write(). And one argument for removing __wur in fwrite() was that errors can be checked explicitely with ferror() - which is not true for write(). _wur is still here:
And even if we would file another bug for removing __wur from write(), I seriously suspect that this will be accepted quickly and we'll see this behaviour go away in recent distros anytime soon.
What do you think about this? Looks a bit more concise to me:
lib/cobalt/init.c +2 -1
@@ -53,7 +53,8 @@ int __rtdm_fd_start = INT_MAX;static void sigill_handler (int sig) {const char m[] ="no Xenomai support in kernel?\n" ; -write (2 , m,sizeof (m) -1 ); + ssize_t rc __attribute__ ((unused)); + rc =write (2 , m,sizeof (m) -1 );exit (EXIT_FAILURE ); }
testsuite/latency/latency.c +1 -1
@@ -507,7 +507,7 @@ static void sigdebug(int sig, siginfo_t *si, void *context)case SIGDEBUG_WATCHDOG : n =snprintf (buffer,sizeof (buffer),"%s\n" , reason_str[reason]); -write (STDERR_FILENO , buffer, n); + n =write (STDERR_FILENO , buffer, n);exit (EXIT_FAILURE ); }
Signature · 4 lines
Gernot Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux
Some glibc versions mark write() with attribute warn_unused_result (found in Ubuntu 12.04 / eglibc 2.15 / gcc 4.6.3), so we need to silence this warning, especially because we're building with -Werror.
--- lib/cobalt/init.c | 3 ++- testsuite/latency/latency.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
Sorry for late self follow-up, but I was a bit offline due to parental leave...
This is a friendly reminder to v2 of the patch (already posted on 2013-11-11), adressing your comments from 2013-11-08, Gilles. I also rebased patch to today's master.
The "attribute unused" style was adopted from testsuite/latency/latency.c. We still think fixing the warning in the source code is better than in the configure command line.
lib/cobalt/init.c +2 -1
@@ -54,7 +54,8 @@ int __rtdm_fd_start = INT_MAX;static void sigill_handler (int sig) {const char m[] ="no Xenomai support in kernel?\n" ; -write (2 , m,sizeof (m) -1 ); + ssize_t rc __attribute__ ((unused)); + rc =write (2 , m,sizeof (m) -1 );exit (EXIT_FAILURE ); }
testsuite/latency/latency.c +1 -1
@@ -507,7 +507,7 @@ static void sigdebug(int sig, siginfo_t *si, void *context)case SIGDEBUG_WATCHDOG : n =snprintf (buffer,sizeof (buffer),"%s\n" , reason_str[reason]); -write (STDERR_FILENO , buffer, n); + n =write (STDERR_FILENO , buffer, n);exit (EXIT_FAILURE ); }
Signature · 1 line
1.8.4