exynos4-is: cleanup a define
Subsystems (3)
PATCH 1/1 exynos4-is: cleanup a define
This define is only used in s5pcsis_irq_handler():
if ((status & S5PCSIS_INTSRC_NON_IMAGE_DATA) && pktbuf->data) {The problem is that "status" is a 32 bit and (0xff << 28) is larger than 32 bits and that sets off a static checker warning. I consulted with Sylwester Nawrocki and the define should actually be (0xf << 28).
drivers/media/platform/exynos4-is/mipi-csis.c +1 -1
@@ -91,7 +91,7 @@ MODULE_PARM_DESC(debug, "Debug level (0-2)");#define S5PCSIS_INTSRC_ODD_BEFORE (1 << 29)#define S5PCSIS_INTSRC_ODD_AFTER (1 << 28)#define S5PCSIS_INTSRC_ODD (0x3 << 28) -#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff << 28) +#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xf << 28)#define S5PCSIS_INTSRC_FRAME_START (1 << 27)#define S5PCSIS_INTSRC_FRAME_END (1 << 26)#define S5PCSIS_INTSRC_ERR_SOT_HS (0xf << 12)
(dropping some unrelated e-mail addresses from Cc)
Quoted 9 lines · Dan Carpenter
This define is only used in
s5pcsis_irq_handler():if ((status& S5PCSIS_INTSRC_NON_IMAGE_DATA)&& pktbuf->data) {The problem is that "status" is a 32 bit and (0xff<< 28) is larger than 32 bits and that sets off a static checker warning. I consulted with Sylwester Nawrocki and the define should actually be (0xf<< 28).
Signed-off-by Dan Carpenter<[email protected]>
Thanks for the fix, patch added to my tree for v3.14.
drivers/media/platform/exynos4-is/mipi-csis.c MODULE_PARM_DESC(debug, "Debug level (0-2)"); · line 97
Quoted 13 lines
drivers/media/platform/exynos4-is/mipi-csis.c +1
-1@@ -91,7 +91,7 @@ MODULE_PARM_DESC(debug, "Debug level (0-2)");#define S5PCSIS_INTSRC_ODD_BEFORE (1<< 29)#define S5PCSIS_INTSRC_ODD_AFTER (1<< 28)#define S5PCSIS_INTSRC_ODD (0x3<< 28) -#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xff<< 28) +#define S5PCSIS_INTSRC_NON_IMAGE_DATA (0xf<< 28)#define S5PCSIS_INTSRC_FRAME_START (1<< 27)#define S5PCSIS_INTSRC_FRAME_END (1<< 26)#define S5PCSIS_INTSRC_ERR_SOT_HS (0xf<< 12)
--
Regards,
Sylwester