Staging: android: Add possibility to compile android drivers as modules
PATCH 1/1 Staging: android: Add possibility to compile android drivers as modules
Compilation of Android staging drivers as drivers is now possible.
--- drivers/staging/android/Kconfig | 18 +++++++++--------- drivers/staging/android/TODO | 1 - 2 files changed, 9 insertions(+), 10 deletions(-)
drivers/staging/android/Kconfig +9 -9
@@ -1,7 +1,7 @@ menu "Android" config ANDROID - bool "Android Drivers" + tristate "Android Drivers" default N ---help--- Enable support for various drivers needed on the Android platform
@@ -9,7 +9,7 @@ config ANDROID if ANDROID config ANDROID_BINDER_IPC - bool "Android Binder IPC Driver" + tristate "Android Binder IPC Driver" depends on MMU default n ---help---
@@ -21,7 +21,7 @@ config ANDROID_BINDER_IPC between said processes. config ASHMEM - bool "Enable the Anonymous Shared Memory Subsystem" + tristate "Enable the Anonymous Shared Memory Subsystem" default n depends on SHMEM ---help---
@@ -50,7 +50,7 @@ config ANDROID_LOGGER much overhead in the system. config ANDROID_TIMED_OUTPUT - bool "Timed output class driver" + tristate "Timed output class driver" default y config ANDROID_TIMED_GPIO
@@ -59,13 +59,13 @@ config ANDROID_TIMED_GPIO default n config ANDROID_LOW_MEMORY_KILLER - bool "Android Low Memory Killer" + tristate "Android Low Memory Killer" default N ---help--- Registers processes to be killed when memory is low config ANDROID_INTF_ALARM_DEV - bool "Android alarm driver" + tristate "Android alarm driver" depends on RTC_CLASS default n ---help---
@@ -74,7 +74,7 @@ config ANDROID_INTF_ALARM_DEV Also exports the alarm interface to user-space. config SYNC - bool "Synchronization framework" + tristate "Synchronization framework" default n select ANON_INODES ---help---
@@ -83,7 +83,7 @@ config SYNC synchronization built into devices like GPUs. config SW_SYNC - bool "Software synchronization objects" + tristate "Software synchronization objects" default n depends on SYNC ---help---
@@ -92,7 +92,7 @@ config SW_SYNC the synchronization. config SW_SYNC_USER - bool "Userspace API for SW_SYNC" + tristate "Userspace API for SW_SYNC" default n depends on SW_SYNC ---help---
drivers/staging/android/TODO +0 -1
@@ -2,7 +2,6 @@ TODO: - checkpatch.pl cleanups - sparse fixes - rename files to be not so "generic" - - make sure things build as modules properly - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane
Signature · 1 line
1.8.4.2
2013-11-09 14:23 keltezéssel, Baptiste Covolato írta:
Quoted 1 line
Compilation of Android staging drivers as drivers is now possible.
'drivers as drivers'? :-)
Also, this commit message says nothing about what the patch does. Something like this would be more appropriate:
Edit Android Kconfig files to allow building the drivers as modules.
Signature · 2 lines
Regards, Levente Kurusa
Thanks for the review.
Should I repost this patch with correct git commit message here or in another mail ?
Regards,
--
Baptiste Covolato
2013/11/9 Levente Kurusa <[email protected]>:
Quoted 14 lines
2013-11-09 14:23 keltezéssel, Baptiste Covolato írta:
Quoted 1 line
Compilation of Android staging drivers as drivers is now possible.
'drivers as drivers'? :-)
Also, this commit message says nothing about what the patch does. Something like this would be more appropriate:
Edit AndroidKconfigfiles to allow building the drivers as modules.--
Regards,
Levente Kurusa
2013-11-09 14:15 keltezéssel, Baptiste Covolato írta:
Quoted 4 lines
Thanks for the review.
Should I repost this patch with correct git commit message here or in another mail ?
Post it a new mail with a subject like [PATCH v2] or something among the lines.
Also, have you tested that they compile as modules and can be insmod'ed?
Signature · 2 lines
Regards, Levente Kurusa