gpio_led driver updates
cover gpio_led driver updates
This simple series enhances the gpio_led driver a bit by some documentation, checking the return value of gpio_request() call, and finally adding support for inverted polarity GPIOs.
Igor Grinberg (3):
README: document the CONFIG_GPIO_LED symbol
gpio_led: check gpio_request() return value
gpio_led: add support for inverted polarity
README | 15 +++++++++++++++ drivers/misc/gpio_led.c | 33 ++++++++++++++++++++++++++++++--- 2 files changed, 45 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.5
PATCH 1/3 README: document the CONFIG_GPIO_LED symbol
The CONFIG_GPIO_LED symbol does not have any documentation in the README file. Document the CONFIG_GPIO_LED symbol.
--- README | 8 ++++++++ 1 file changed, 8 insertions(+)
README +8 -0
@@ -1951,6 +1951,14 @@ CBFS (Coreboot Filesystem) support kernel). Defining CONFIG_STATUS_LED enables this feature in U-Boot. + Additional options: + + CONFIG_GPIO_LED + The status LED can be connected to a GPIO pin. + In such cases, the gpio_led driver can be used as a + status LED backend implementation. Define CONFIG_GPIO_LED + to include the gpio_led driver in the U-Boot binary. + - CAN Support: CONFIG_CAN_DRIVER Defining CONFIG_CAN_DRIVER enables CAN driver support
Signature · 1 line
1.8.1.5
PATCH 1/3 README: document the CONFIG_GPIO_LED symbol
Quoted 4 lines · Igor Grinberg
The
CONFIG_GPIO_LEDsymbol does not have any documentation in the README file. Document theCONFIG_GPIO_LEDsymbol.Signed-off-by Igor Grinberg <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131125/a6d7f856/attachment.pgp>
PATCH 2/3 gpio_led: check gpio_request() return value
In reply to Igor GrinbergAdd a check for the gpio_request() function return value and do not try to configure the GPIO if the gpio_request() call fails. Also, print an error message indicating the gpio_request() has failed.
--- drivers/misc/gpio_led.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/misc/gpio_led.c +5 -1
@@ -11,7 +11,11 @@void __led_init (led_id_t mask,int state) { -gpio_request (mask,"gpio_led" ); +if (gpio_request (mask,"gpio_led" ) !=0 ) { +printf ("%s: failed requesting GPIO%lu!\n" , __func__, mask); +return ; + } +gpio_direction_output (mask, state ==STATUS_LED_ON ); }
Signature · 1 line
1.8.1.5
PATCH 2/3 gpio_led: check gpio_request() return value
Quoted 5 lines · Igor Grinberg
Add a check for the
gpio_request()function return value and do not try to configure the GPIO if thegpio_request()call fails. Also, print an error message indicating thegpio_request()has failed.Signed-off-by Igor Grinberg <[email protected]>
Quoted 22 lines
--- drivers/misc/gpio_led.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/misc/gpio_led.c +5
-1@@ -11,7 +11,11 @@void __led_init (led_id_t mask,int state) { -gpio_request (mask,"gpio_led" ); +if (gpio_request (mask,"gpio_led" ) !=0 ) { +printf ("%s: failed requesting GPIO%lu!\n" , __func__, mask); +return ; + } +gpio_direction_output (mask, state ==STATUS_LED_ON ); }
Signature · 2 lines
Regards, Igor.
PATCH 2/3 gpio_led: check gpio_request() return value
In reply to Igor GrinbergQuoted 6 lines · Igor Grinberg
Add a check for the
gpio_request()function return value and do not try to configure the GPIO if thegpio_request()call fails. Also, print an error message indicating thegpio_request()has failed.Signed-off-by Igor Grinberg <[email protected]>Tested-by Ilya Ledvich <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131125/cfd2d937/attachment.pgp>
PATCH 3/3 gpio_led: add support for inverted polarity
In reply to Igor GrinbergSome GPIO connected LEDs have inverted polarity.
Introduce new config option: CONFIG_GPIO_LED_INVERTED_TABLE for the specifying the inverted GPIO LEDs list and add support for this in the gpio_led driver.
--- README | 7 +++++++ drivers/misc/gpio_led.c | 27 +++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 2 deletions(-)
README +7 -0
@@ -1959,6 +1959,13 @@ CBFS (Coreboot Filesystem) support status LED backend implementation. Define CONFIG_GPIO_LED to include the gpio_led driver in the U-Boot binary. + CONFIG_GPIO_LED_INVERTED_TABLE + Some GPIO connected LEDs may have inverted polarity in which + case the GPIO high value corresponds to LED off state and + GPIO low value corresponds to LED on state. + In such cases CONFIG_GPIO_LED_INVERTED_TABLE may be defined + with a list of GPIO LEDs that have inverted polarity. + - CAN Support: CONFIG_CAN_DRIVER Defining CONFIG_CAN_DRIVER enables CAN driver support
drivers/misc/gpio_led.c +25 -2
@@ -9,19 +9,42 @@#include <status_led.h> #include <asm/gpio.h> +#ifndef CONFIG_GPIO_LED_INVERTED_TABLE +#define CONFIG_GPIO_LED_INVERTED_TABLE {} +#endif + +static led_id_t gpio_led_inv[] =CONFIG_GPIO_LED_INVERTED_TABLE ; + +static int gpio_led_gpio_value (led_id_t mask,int state) +{ +int i, gpio_value = (state ==STATUS_LED_ON ); + +for (i =0 ; i <ARRAY_SIZE (gpio_led_inv); i++) { +if (gpio_led_inv[i] == mask) + gpio_value = !gpio_value; + } + +return gpio_value; +} +void __led_init (led_id_t mask,int state) { +int gpio_value; +if (gpio_request (mask,"gpio_led" ) !=0 ) {printf ("%s: failed requesting GPIO%lu!\n" , __func__, mask);return ; } -gpio_direction_output (mask, state ==STATUS_LED_ON ); + gpio_value =gpio_led_gpio_value (mask, state); +gpio_direction_output (mask, gpio_value); }void __led_set (led_id_t mask,int state) { -gpio_set_value (mask, state ==STATUS_LED_ON ); +int gpio_value =gpio_led_gpio_value (mask, state); + +gpio_set_value (mask, gpio_value); }void __led_toggle (led_id_t mask)
Signature · 1 line
1.8.1.5
PATCH 3/3 gpio_led: add support for inverted polarity
Quoted 6 lines · Igor Grinberg
Some GPIO connected LEDs have inverted polarity.
Introduce new config option:CONFIG_GPIO_LED_INVERTED_TABLEfor the specifying the inverted GPIO LEDs list and add support for this in thegpio_leddriver.Signed-off-by Igor Grinberg <[email protected]>
on cm-t335.
Quoted 73 lines
--- README | 7 +++++++ drivers/misc/gpio_led.c | 27 +++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 2 deletions(-)README +7
-0@@ -1959,6 +1959,13 @@ CBFS (Coreboot Filesystem) support status LED backend implementation. Define CONFIG_GPIO_LED to include the gpio_led driver in the U-Boot binary. + CONFIG_GPIO_LED_INVERTED_TABLE + Some GPIO connected LEDs may have inverted polarity in which + case the GPIO high value corresponds to LED off state and + GPIO low value corresponds to LED on state. + In such cases CONFIG_GPIO_LED_INVERTED_TABLE may be defined + with a list of GPIO LEDs that have inverted polarity. + - CAN Support: CONFIG_CAN_DRIVER Defining CONFIG_CAN_DRIVER enables CAN driver supportdrivers/misc/gpio_led.c +25
-2@@ -9,19 +9,42 @@#include <status_led.h> #include <asm/gpio.h> +#ifndef CONFIG_GPIO_LED_INVERTED_TABLE +#define CONFIG_GPIO_LED_INVERTED_TABLE {} +#endif + +static led_id_t gpio_led_inv[] =CONFIG_GPIO_LED_INVERTED_TABLE ; + +static int gpio_led_gpio_value (led_id_t mask,int state) +{ +int i, gpio_value = (state ==STATUS_LED_ON ); + +for (i =0 ; i <ARRAY_SIZE (gpio_led_inv); i++) { +if (gpio_led_inv[i] == mask) + gpio_value = !gpio_value; + } + +return gpio_value; +} +void __led_init (led_id_t mask,int state) { +int gpio_value; +if (gpio_request (mask,"gpio_led" ) !=0 ) {printf ("%s: failed requesting GPIO%lu!\n" , __func__, mask);return ; } -gpio_direction_output (mask, state ==STATUS_LED_ON ); + gpio_value =gpio_led_gpio_value (mask, state); +gpio_direction_output (mask, gpio_value); }void __led_set (led_id_t mask,int state) { -gpio_set_value (mask, state ==STATUS_LED_ON ); +int gpio_value =gpio_led_gpio_value (mask, state); + +gpio_set_value (mask, gpio_value); }void __led_toggle (led_id_t mask)
Signature · 2 lines
Regards, Igor.
PATCH 3/3 gpio_led: add support for inverted polarity
In reply to Igor GrinbergQuoted 6 lines · Igor Grinberg
Some GPIO connected LEDs have inverted polarity.
Introduce new config option:CONFIG_GPIO_LED_INVERTED_TABLEfor the specifying the inverted GPIO LEDs list and add support for this in thegpio_leddriver.Signed-off-by Igor Grinberg <[email protected]>
Neat; I will test this in the board I have same situation and see if it works for my case fully but this seems to be a lean and simply solution for the issue.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
PATCH 3/3 gpio_led: add support for inverted polarity
In reply to Igor GrinbergQuoted 7 lines · Igor Grinberg
Some GPIO connected LEDs have inverted polarity.
Introduce new config option:CONFIG_GPIO_LED_INVERTED_TABLEfor the specifying the inverted GPIO LEDs list and add support for this in thegpio_leddriver.Signed-off-by Igor Grinberg <[email protected]>Tested-by Ilya Ledvich <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131125/f5db6619/attachment.pgp>