drm/amd/display: fix comment format
Subsystems (3)
Alex Deucher
maintainerPATCH 1/2 drm/amd/display: fix comment format
This is not a compliant kerneldoc comment, so make it just a regular comment.
--- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1 -1
@@ -42,7 +42,7 @@#define FN (reg_name, field_name) \ optc1->tg_shift->field_name, optc1->tg_mask->field_name -/** +/* * Enable CRTC * Enable CRTC - call ASIC Control Object to enable Timing generator. */
Signature · 1 line
2.35.3
Alex Deucher
maintainerPATCH 2/2 drm/amd/display: make to_dal_irq_source_dcn314 static
It's not used outside of irq_service_dcn314.c.
--- drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c +1 -1
@@ -38,7 +38,7 @@#define DCN_BASE__INST0_SEG2 0x000034C0 -enum dc_irq_source to_dal_irq_source_dcn314 ( +static enum dc_irq_source to_dal_irq_source_dcn314 (struct irq_service *irq_service,uint32_t src_id,uint32_t ext_id)
Signature · 1 line
2.35.3
Re: [PATCH 2/2] drm/amd/display: make to_dal_irq_source_dcn314 static
Quoted 4 lines · Alex Deucher
It's not used outside of
irq_service_dcn314.c.Reported-by kernel test robot <[email protected]>Signed-off-by Alex Deucher <[email protected]>
Harry
Quoted 17 lines
--- drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c +1
-1@@ -38,7 +38,7 @@#define DCN_BASE__INST0_SEG2 0x000034C0 -enum dc_irq_source to_dal_irq_source_dcn314 ( +static enum dc_irq_source to_dal_irq_source_dcn314 (struct irq_service *irq_service,uint32_t src_id,uint32_t ext_id)
Hi Alex,
Às 11:31 de 12/07/22, Alex Deucher escreveu:
Quoted 14 lines
This is not a compliant kerneldoc comment, so make it just a regular comment.
Reported-by kernel test robot <[email protected]>Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +0
-0
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c line 48
Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1
-1@@ -42,7 +42,7 @@#define FN (reg_name, field_name) \ optc1->tg_shift->field_name, optc1->tg_mask->field_name -/** +/* * Enable CRTC * Enable CRTC - call ASIC Control Object to enable Timing generator. */
This comment is placed in a random part of the file, the proper fix it would be to place it above the function that it's describing:
static bool optc314_enable_crtc(struct timing_generator *optc)
There it could even be a correct kerneldoc comment, fixed the function name and adding the argument description.
Am 12.07.22 um 16:31 schrieb Alex Deucher:
Quoted 5 lines
This is not a compliant kerneldoc comment, so make it just a regular comment.
Reported-by kernel test robot <[email protected]>Signed-off-by Alex Deucher <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1
-1@@ -42,7 +42,7 @@#define FN (reg_name, field_name) \ optc1->tg_shift->field_name, optc1->tg_mask->field_name -/** +/* * Enable CRTC * Enable CRTC - call ASIC Control Object to enable Timing generator. */