Skip to contentSkip to conversation

drm/amd/display: fix comment format

PATCH In review Alex Deucher 4 participants 5 messages Jul 12, 2022

Subsystems (3)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/2 drm/amd/display: fix comment format

This is not a compliant kerneldoc comment, so make it just a regular comment.

---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1 -1
index c4a5f8198209..436c3545a983 100644
@@ -42,7 +42,7 @@
 #define FN(reg_name, field_name) \
 	optc1->tg_shift->field_name, optc1->tg_mask->field_name
 
-/**
+/*
  * Enable CRTC
  * Enable CRTC - call ASIC Control Object to enable Timing generator.
  */
Signature · 1 line
2.35.3
author maintainer
#1 lore raw

PATCH 2/2 drm/amd/display: make to_dal_irq_source_dcn314 static

It's not used outside of irq_service_dcn314.c.

---
 drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c +1 -1
index bea6f157cbb7..c923b2af8510 100644
@@ -38,7 +38,7 @@
 
 #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn314(
+static enum dc_irq_source to_dal_irq_source_dcn314(
 		struct irq_service *irq_service,
 		uint32_t src_id,
 		uint32_t ext_id)
Signature · 1 line
2.35.3
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/amd/display: make to_dal_irq_source_dcn314 static

Quoted 4 lines · Alex Deucher

It's not used outside of irq_service_dcn314.c.

Harry

Quoted 17 lines
---
 drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c +1 -1
index bea6f157cbb7..c923b2af8510 100644
@@ -38,7 +38,7 @@
 
 #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn314(
+static enum dc_irq_source to_dal_irq_source_dcn314(
 		struct irq_service *irq_service,
 		uint32_t src_id,
 		uint32_t ext_id)
#3 lore raw
In reply to Alex Deucher

Hi Alex,

Às 11:31 de 12/07/22, Alex Deucher escreveu:

Quoted 14 lines

This is not a compliant kerneldoc comment, so make it just a regular comment.

---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +0 -0
index c4a5f8198209..436c3545a983 100644

drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c line 48

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1 -1
@@ -42,7 +42,7 @@
 #define FN(reg_name, field_name) \
 	optc1->tg_shift->field_name, optc1->tg_mask->field_name
 
-/**
+/*
  * Enable CRTC
  * Enable CRTC - call ASIC Control Object to enable Timing generator.
  */

This comment is placed in a random part of the file, the proper fix it would be to place it above the function that it's describing:

static bool optc314_enable_crtc(struct timing_generator *optc)

There it could even be a correct kerneldoc comment, fixed the function name and adding the argument description.

Reviewed-by on v1 1/2
#4 lore raw
In reply to Alex Deucher

Am 12.07.22 um 16:31 schrieb Alex Deucher:

Quoted 5 lines

This is not a compliant kerneldoc comment, so make it just a regular comment.

Quoted 17 lines
---
  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c +1 -1
index c4a5f8198209..436c3545a983 100644
@@ -42,7 +42,7 @@
  #define FN(reg_name, field_name) \
  	optc1->tg_shift->field_name, optc1->tg_mask->field_name
 
-/**
+/*
   * Enable CRTC
   * Enable CRTC - call ASIC Control Object to enable Timing generator.
   */