Skip to contentSkip to conversation

audiofile: needs dynamic library

PATCH New spdawson at gmail.com 4 participants 6 messages Nov 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 audiofile: needs dynamic library

From: Simon Dawson <[email protected]>

Fixes build failures such as the following.

http://autobuild.buildroot.net/results/c00/c002711ef82fb29f1765df251bd0006caeccc508/

---
 package/audiofile/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/audiofile/Config.in +3 -2
index 4aa8d69..9752648 100644
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_AUDIOFILE
 	bool "audiofile"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  The Audio File Library handles reading and writing audio files
 	  in many common formats.
 
 	  http://www.68k.org/~michael/audiofile/
 
-comment "audiofile needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "audiofile needs a toolchain w/ C++, dynamic library"
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_PREFER_STATIC_LIB
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 audiofile: needs dynamic library

Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
Fixes build failures such as the following.

http://autobuild.buildroot.net/results/c00/c002711ef82fb29f1765df251bd0006caeccc508/

---
 package/audiofile/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/audiofile/Config.in +1 -0
index 4aa8d69..9752648 100644
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_AUDIOFILE
 	bool "audiofile"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_PREFER_STATIC_LIB

package/audiofile/Config.in line 12

Quoted 10 lines
package/audiofile/Config.in +2 -2
 	help
 	  The Audio File Library handles reading and writing audio files
 	  in many common formats.
 
 	  http://www.68k.org/~michael/audiofile/
 
-comment "audiofile needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "audiofile needs a toolchain w/ C++, dynamic library"
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_PREFER_STATIC_LIB

Thanks, but you forgot the reverse dependencies:

git grep -l 'select BR2_PACKAGE_AUDIOFILE'
package/mpd/Config.in

Looking at the build log, the only reason why it fails is that libtool is acting up. It wants to link with libstdc++.so instead of libstdc++.a.

A quick test shows that you can fix it by passing -static instead of --static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:

http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c

Does anybody know what the right solution is?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 audiofile: needs dynamic library

Quoted 9 lines · Peter Korsgaard

Looking at the build log, the only reason why it fails is that libtool is acting up. It wants to link with libstdc++.so instead of libstdc++.a.

A quick test shows that you can fix it by passing -static instead of --static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:

http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c

Does anybody know what the right solution is?

I think this is related to the nettle failure i've mentioned, after the gcc conversion host-gcc-final isn't installing libstdc++.a, and after an extra look it isn't even building it because of --disable-static in the default CONFIGURE_CMDS.
So it'll never find a libstdc++.a for the internal toolchain in staging. Regards.

#3 lore raw

PATCH 1/1 audiofile: needs dynamic library

Dear Gustavo Zacarias,

Quoted 10 lines · Gustavo Zacarias
Quoted 9 lines · Peter Korsgaard

Looking at the build log, the only reason why it fails is that libtool is acting up. It wants to link with libstdc++.so instead of libstdc++.a.

A quick test shows that you can fix it by passing -static instead of --static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:

http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c

Quoted 8 lines
Quoted 1 line

Does anybody know what the right solution is?

I think this is related to the nettle failure i've mentioned, after the gcc conversion host-gcc-final isn't installing libstdc++.a, and after an extra look it isn't even building it because of --disable-static in the default CONFIGURE_CMDS.
So it'll never find a libstdc++.a for the internal toolchain in staging. Regards.

I'll try to have a look at this issue tonight.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 audiofile: needs dynamic library

In reply to Gustavo Zacarias
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

I think this is related to the nettle failure i've mentioned, after the gcc conversion host-gcc-final isn't installing libstdc++.a, and after an extra look it isn't even building it because of --disable-static in the default CONFIGURE_CMDS.
So it'll never find a libstdc++.a for the internal toolchain in staging. Regards.

Yes, but I've just tested with an external toolchain where libstdc++.a IS copied to staging, and same problem.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 audiofile: needs dynamic library

Quoted 2 lines · Peter Korsgaard

Yes, but I've just tested with an external toolchain where libstdc++.a IS copied to staging, and same problem.

Yes, fixing libstdc++.a on the internal toolchain solves the nettle issue, but it doesn't solve audiofile (tested here with a quick hack). Regards.