Skip to contentSkip to conversation

grub2 should not unzip Linux initramfs

PATCH In review Lukas Schwaighofer 2 participants 2 messages Nov 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 grub2 should not unzip Linux initramfs

Hi,

the initramfs protocol (see [1]) supports multiple concatenated archives.

Because of grub2's implicit unzipping of gz-compressed multiboot modules, a valid initramfs-file (e.g. in my case containing of two concatenated gz-files) may be rendered unbootable.

I have attached the trivial patch adding --nounzip to the the appropriate module-directive when generating XEN boot entries. As this resembles the behavior when booting without XEN (using the grub2 commands linux and initrd) more closely I don't expect any problems.

I have reported this to the Debian bugtracker before [2] with no response, but I suppose this is the correct point to report this issue.

Thank you
Lukas

[1]
https://www.kernel.org/doc/Documentation/early-userspace/buffer-format.txt
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700197

util/grub.d/20_linux_xen.in +1 -1
index 4cf93d2..f12f059 100644
@@ -135,7 +135,7 @@ EOF
     message="$(gettext_printf "Loading initial ramdisk ...")"
     sed "s/^/$submenu_indentation/" << EOF
 	echo	'$(echo "$message" | grub_quote)'
-	module	${rel_dirname}/${initrd}
+	module	--nounzip   ${rel_dirname}/${initrd}
 EOF
   fi
   sed "s/^/$submenu_indentation/" << EOF
#1 lore raw

Committed, thanks.

Quoted 31 lines · Lukas Schwaighofer

Hi,

the initramfs protocol (see [1]) supports multiple concatenated archives.

Because of grub2's implicit unzipping of gz-compressed multiboot modules, a valid initramfs-file (e.g. in my case containing of two concatenated gz-files) may be rendered unbootable.

I have attached the trivial patch adding --nounzip to the the appropriate module-directive when generating XEN boot entries. As this resembles the behavior when booting without XEN (using the grub2 commands linux and initrd) more closely I don't expect any problems.

I have reported this to the Debian bugtracker before [2] with no response, but I suppose this is the correct point to report this issue.

Thank you
Lukas

[1]
https://www.kernel.org/doc/Documentation/early-userspace/buffer-format.txt
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700197

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel