Skip to contentSkip to conversation

wandboard: Return the error immediately when ipuv3_fb_init() fails

PATCH New Fabio Estevam 2 participants 4 messages Nov 4, 2013 – Nov 13, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 wandboard: Return the error immediately when ipuv3_fb_init() fails

From: Fabio Estevam <[email protected]>

If ipuv3_fb_init() fails, we should return the error immediately.

---
 board/wandboard/wandboard.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
board/wandboard/wandboard.c +3 -1
index 23a78c1..99150f9 100644
@@ -230,8 +230,10 @@ int board_video_skip(void)
 
 	ret = ipuv3_fb_init(&hdmi, 0, IPU_PIX_FMT_RGB24);
 
-	if (ret)
+	if (ret) {
 		printf("HDMI cannot be configured: %d\n", ret);
+		return ret;
+	}
 
 	imx_enable_hdmi_phy();
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 2/2 wandboard: Return the error when cpu_eth_init() fails

From: Fabio Estevam <[email protected]>

When cpu_eth_init() fails we should not return success.

---
 board/wandboard/wandboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/wandboard/wandboard.c +1 -1
index 99150f9..bf9898c 100644
@@ -265,7 +265,7 @@ int board_eth_init(bd_t *bis)
 	if (ret)
 		printf("FEC MXC: %s:failed\n", __func__);
 
-	return 0;
+	return ret;
 }
 
 int board_early_init_f(void)
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 2/2 wandboard: Return the error when cpu_eth_init() fails

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When cpu_eth_init() fails we should not return success.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 wandboard: Return the error immediately when ipuv3_fb_init() fails

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

If ipuv3_fb_init() fails, we should return the error immediately.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================