Skip to contentSkip to conversation

powerpc/esdhc: Map register for eSDHC Host Controller V3.0

PATCH New Haijun Zhang 4 participants 9 messages Oct 30, 2013 – Nov 19, 2013 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0

 drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
 	uint    mixctrl;
 	char    reserved1[4];
 	uint	fevt;
-	char	reserved2[168];
+	uint	admaes;
+	uint	adsaddr;
+	char	reserved2[160];
 	uint	hostver;
-	char	reserved3[780];
+	char	reserved3[4];
+	uint	dmaerraddr;
+	char	reserved4[4];
+	uint	dmaerrattr;
+	char	reserved5[4];
+	uint	hostcapblt2;
+	char	reserved6[8];
+	uint	tcr;
+	char	reserved7[28];
+	uint	sddirctl;
+	char	reserved8[712];
 	uint	scr;
 };
 
Signature · 1 line
1.8.4
#1 lore raw

PATCH v2 2/2 Powerpc/esdhc: Add simple description of esdhc register

Add some descriptions for esdhc register for easily using.

---
 drivers/mmc/fsl_esdhc.c | 74 ++++++++++++++++++++++++-------------------------
 1 file changed, 37 insertions(+), 37 deletions(-)
drivers/mmc/fsl_esdhc.c +37 -37
index a3b165e..0d0b748 100644
@@ -24,43 +24,43 @@
 DECLARE_GLOBAL_DATA_PTR;
 
 struct fsl_esdhc {
-	uint	dsaddr;
-	uint	blkattr;
-	uint	cmdarg;
-	uint	xfertyp;
-	uint	cmdrsp0;
-	uint	cmdrsp1;
-	uint	cmdrsp2;
-	uint	cmdrsp3;
-	uint	datport;
-	uint	prsstat;
-	uint	proctl;
-	uint	sysctl;
-	uint	irqstat;
-	uint	irqstaten;
-	uint	irqsigen;
-	uint	autoc12err;
-	uint	hostcapblt;
-	uint	wml;
-	uint    mixctrl;
-	char    reserved1[4];
-	uint	fevt;
-	uint	admaes;
-	uint	adsaddr;
-	char	reserved2[160];
-	uint	hostver;
-	char	reserved3[4];
-	uint	dmaerraddr;
-	char	reserved4[4];
-	uint	dmaerrattr;
-	char	reserved5[4];
-	uint	hostcapblt2;
-	char	reserved6[8];
-	uint	tcr;
-	char	reserved7[28];
-	uint	sddirctl;
-	char	reserved8[712];
-	uint	scr;
+	uint    dsaddr;		/* SDMA system address register */
+	uint    blkattr;	/* Block attributes register */
+	uint    cmdarg;		/* Command argument register */
+	uint    xfertyp;	/* Transfer type register */
+	uint    cmdrsp0;	/* Command response 0 register */
+	uint    cmdrsp1;	/* Command response 1 register */
+	uint    cmdrsp2;	/* Command response 2 register */
+	uint    cmdrsp3;	/* Command response 3 register */
+	uint    datport;	/* Buffer data port register */
+	uint    prsstat;	/* Present state register */
+	uint    proctl;		/* Protocol control register */
+	uint    sysctl;		/* System Control Register */
+	uint    irqstat;	/* Interrupt status register */
+	uint    irqstaten;	/* Interrupt status enable register */
+	uint    irqsigen;	/* Interrupt signal enable register */
+	uint    autoc12err;	/* Auto CMD error status register */
+	uint    hostcapblt;	/* Host controller capabilities register */
+	uint    wml;		/* Watermark level register */
+	uint    mixctrl;	/* For USDHC */
+	char    reserved1[4];	/* reserved */
+	uint    fevt;		/* Force event register */
+	uint    admaes;		/* ADMA error status register */
+	uint    adsaddr;	/* ADMA system address register */
+	char    reserved2[160];	/* reserved */
+	uint    hostver;	/* Host controller version register */
+	char    reserved3[4];	/* reserved */
+	uint    dmaerraddr;	/* DMA error address register */
+	char    reserved4[4];	/* reserved */
+	uint    dmaerrattr;	/* DMA error attribute register */
+	char    reserved5[4];	/* reserved */
+	uint    hostcapblt2;	/* Host controller capabilities register 2 */
+	char    reserved6[8];	/* reserved */
+	uint    tcr;		/* Tuning control register */
+	char    reserved7[28];	/* reserved */
+	uint    sddirctl;	/* SD direction control register */
+	char    reserved8[712];	/* reserved */
+	uint    scr;		/* eSDHC control register */
 };
 
 /* Return the XFERTYP flags for a given command and data packet */
Signature · 1 line
1.8.4
#2 lore raw

PATCH v2 2/2 Powerpc/esdhc: Add simple description of esdhc register

Hi Haijun,

Quoted 96 lines · Haijun Zhang

Add some descriptions for esdhc register for easily using.

---
drivers/mmc/fsl_esdhc.c | 74 ++++++++++++++++++++++++-------------------------

1 file changed, 37 insertions(+), 37 deletions(-)
drivers/mmc/fsl_esdhc.c +37 -37
index a3b165e..0d0b748 100644
@@ -24,43 +24,43 @@
 DECLARE_GLOBAL_DATA_PTR;
 
 struct fsl_esdhc {
-	uint	dsaddr;
-	uint	blkattr;
-	uint	cmdarg;
-	uint	xfertyp;
-	uint	cmdrsp0;
-	uint	cmdrsp1;
-	uint	cmdrsp2;
-	uint	cmdrsp3;
-	uint	datport;
-	uint	prsstat;
-	uint	proctl;
-	uint	sysctl;
-	uint	irqstat;
-	uint	irqstaten;
-	uint	irqsigen;
-	uint	autoc12err;
-	uint	hostcapblt;
-	uint	wml;
-	uint    mixctrl;
-	char    reserved1[4];
-	uint	fevt;
-	uint	admaes;
-	uint	adsaddr;
-	char	reserved2[160];
-	uint	hostver;
-	char	reserved3[4];
-	uint	dmaerraddr;
-	char	reserved4[4];
-	uint	dmaerrattr;
-	char	reserved5[4];
-	uint	hostcapblt2;
-	char	reserved6[8];
-	uint	tcr;
-	char	reserved7[28];
-	uint	sddirctl;
-	char	reserved8[712];
-	uint	scr;
+	uint    dsaddr;		/* SDMA system address register */
+	uint    blkattr;	/* Block attributes register */
+	uint    cmdarg;		/* Command argument register */
+	uint    xfertyp;	/* Transfer type register */
+	uint    cmdrsp0;	/* Command response 0 register */
+	uint    cmdrsp1;	/* Command response 1 register */
+	uint    cmdrsp2;	/* Command response 2 register */
+	uint    cmdrsp3;	/* Command response 3 register */
+	uint    datport;	/* Buffer data port register */
+	uint    prsstat;	/* Present state register */
+	uint    proctl;		/* Protocol control register */
+	uint    sysctl;		/* System Control Register */
+	uint    irqstat;	/* Interrupt status register */
+	uint    irqstaten;	/* Interrupt status enable register */
+	uint    irqsigen;	/* Interrupt signal enable register */
+	uint    autoc12err;	/* Auto CMD error status register */
+	uint    hostcapblt;	/* Host controller capabilities register */
+	uint    wml;		/* Watermark level register */
+	uint    mixctrl;	/* For USDHC */
+	char    reserved1[4];	/* reserved */
+	uint    fevt;		/* Force event register */
+	uint    admaes;		/* ADMA error status register */
+	uint    adsaddr;	/* ADMA system address register */
+	char    reserved2[160];	/* reserved */
+	uint    hostver;	/* Host controller version register */
+	char    reserved3[4];	/* reserved */
+	uint    dmaerraddr;	/* DMA error address register */
+	char    reserved4[4];	/* reserved */
+	uint    dmaerrattr;	/* DMA error attribute register */
+	char    reserved5[4];	/* reserved */
+	uint    hostcapblt2;	/* Host controller capabilities register 2 */
+	char    reserved6[8];	/* reserved */
+	uint    tcr;		/* Tuning control register */
+	char    reserved7[28];	/* reserved */
+	uint    sddirctl;	/* SD direction control register */
+	char    reserved8[712];	/* reserved */
+	uint    scr;		/* eSDHC control register */
 };
 
 /* Return the XFERTYP flags for a given command and data packet */
Signature · 1 line
1.8.4

Applied, thanks

#3 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

In reply to Haijun Zhang

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
 	uint    mixctrl;
 	char    reserved1[4];
 	uint	fevt;
-	char	reserved2[168];
+	uint	admaes;
+	uint	adsaddr;
+	char	reserved2[160];
 	uint	hostver;
-	char	reserved3[780];
+	char	reserved3[4];
+	uint	dmaerraddr;
+	char	reserved4[4];
+	uint	dmaerrattr;
+	char	reserved5[4];
+	uint	hostcapblt2;
+	char	reserved6[8];
+	uint	tcr;
+	char	reserved7[28];
+	uint	sddirctl;
+	char	reserved8[712];
 	uint	scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

#4 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

Hi, all

Who could help review this patch set?

Thanks in advance.

? 2013/10/31 15:51, Pantelis Antoniou ??:

Quoted 54 lines

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
 	uint    mixctrl;
 	char    reserved1[4];
 	uint	fevt;
-	char	reserved2[168];
+	uint	admaes;
+	uint	adsaddr;
+	char	reserved2[160];
 	uint	hostver;
-	char	reserved3[780];
+	char	reserved3[4];
+	uint	dmaerraddr;
+	char	reserved4[4];
+	uint	dmaerrattr;
+	char	reserved5[4];
+	uint	hostcapblt2;
+	char	reserved6[8];
+	uint	tcr;
+	char	reserved7[28];
+	uint	sddirctl;
+	char	reserved8[712];
 	uint	scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

Signature · 2 lines
Thanks & Regards
Haijun.
#5 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

Hi Zhang,

I known this patch have been merged at u-boot-mmc repository.

Best Regards,
Jaehoon Chung

Quoted 62 lines · Zhang Haijun

Hi, all

Who could help review this patch set?

Thanks in advance.

? 2013/10/31 15:51, Pantelis Antoniou ??:

Quoted 54 lines

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map
register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
    uint    mixctrl;
    char    reserved1[4];
    uint    fevt;
-    char    reserved2[168];
+    uint    admaes;
+    uint    adsaddr;
+    char    reserved2[160];
    uint    hostver;
-    char    reserved3[780];
+    char    reserved3[4];
+    uint    dmaerraddr;
+    char    reserved4[4];
+    uint    dmaerrattr;
+    char    reserved5[4];
+    uint    hostcapblt2;
+    char    reserved6[8];
+    uint    tcr;
+    char    reserved7[28];
+    uint    sddirctl;
+    char    reserved8[712];
    uint    scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

#6 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

Oh, Sorry.

I mean http://patchwork.ozlabs.org/bundle/b42677/Need%20review/ .

? 2013/11/18 16:09, Jaehoon Chung ??:

Quoted 70 lines

Hi Zhang,

I known this patch have been merged at u-boot-mmc repository.

Best Regards,
Jaehoon Chung

Quoted 61 lines · Zhang Haijun

Hi, all

Who could help review this patch set?

Thanks in advance.

? 2013/10/31 15:51, Pantelis Antoniou ??:

Quoted 54 lines

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
     uint    mixctrl;
     char    reserved1[4];
     uint    fevt;
-    char    reserved2[168];
+    uint    admaes;
+    uint    adsaddr;
+    char    reserved2[160];
     uint    hostver;
-    char    reserved3[780];
+    char    reserved3[4];
+    uint    dmaerraddr;
+    char    reserved4[4];
+    uint    dmaerrattr;
+    char    reserved5[4];
+    uint    hostcapblt2;
+    char    reserved6[8];
+    uint    tcr;
+    char    reserved7[28];
+    uint    sddirctl;
+    char    reserved8[712];
     uint    scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

Signature · 2 lines
Thanks & Regards
Haijun.
#7 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

Hi Zhang,

I'm on travel yet again. Will be back Monday and I'll put my reviewing hat on.

Regards

-- Pantelis

Quoted 82 lines · Zhang Haijun

Oh, Sorry.

I mean http://patchwork.ozlabs.org/bundle/b42677/Need%20review/ .

? 2013/11/18 16:09, Jaehoon Chung ??:

Quoted 70 lines

Hi Zhang,

I known this patch have been merged at u-boot-mmc repository.

Best Regards,
Jaehoon Chung

Quoted 61 lines · Zhang Haijun

Hi, all

Who could help review this patch set?

Thanks in advance.

? 2013/10/31 15:51, Pantelis Antoniou ??:

Quoted 54 lines

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map
register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
    uint    mixctrl;
    char    reserved1[4];
    uint    fevt;
-    char    reserved2[168];
+    uint    admaes;
+    uint    adsaddr;
+    char    reserved2[160];
    uint    hostver;
-    char    reserved3[780];
+    char    reserved3[4];
+    uint    dmaerraddr;
+    char    reserved4[4];
+    uint    dmaerrattr;
+    char    reserved5[4];
+    uint    hostcapblt2;
+    char    reserved6[8];
+    uint    tcr;
+    char    reserved7[28];
+    uint    sddirctl;
+    char    reserved8[712];
    uint    scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

Signature · 2 lines
Thanks & Regards
Haijun.
#8 lore raw

PATCH v2 1/2 powerpc/esdhc: Map register for eSDHC Host Controller V3.0

Many thanks.

? 2013/11/18 20:04, Pantelis Antoniou ??:

Quoted 91 lines

Hi Zhang,

I'm on travel yet again. Will be back Monday and I'll put my reviewing hat on.

Regards

-- Pantelis

Quoted 80 lines · Zhang Haijun

Oh, Sorry.

I mean http://patchwork.ozlabs.org/bundle/b42677/Need%20review/ .

? 2013/11/18 16:09, Jaehoon Chung ??:

Quoted 69 lines

Hi Zhang,

I known this patch have been merged at u-boot-mmc repository.

Best Regards,
Jaehoon Chung

Quoted 61 lines · Zhang Haijun

Hi, all

Who could help review this patch set?

Thanks in advance.

? 2013/10/31 15:51, Pantelis Antoniou ??:

Quoted 54 lines

Hi Haijun,

Quoted 45 lines · Haijun Zhang

eSDHC host controller has new register to support SD Spec 3.0. And the according host controller version was Freescale eSDHC Version 3.0.

---
changes:
- Split from patch [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0

drivers/mmc/fsl_esdhc.c | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +14 -2
index 1fba3f7..a3b165e 100644
@@ -45,9 +45,21 @@ struct fsl_esdhc {
     uint    mixctrl;
     char    reserved1[4];
     uint    fevt;
-    char    reserved2[168];
+    uint    admaes;
+    uint    adsaddr;
+    char    reserved2[160];
     uint    hostver;
-    char    reserved3[780];
+    char    reserved3[4];
+    uint    dmaerraddr;
+    char    reserved4[4];
+    uint    dmaerrattr;
+    char    reserved5[4];
+    uint    hostcapblt2;
+    char    reserved6[8];
+    uint    tcr;
+    char    reserved7[28];
+    uint    sddirctl;
+    char    reserved8[712];
     uint    scr;
 };
 
Signature · 1 line
1.8.4

Applied, thanks

Signature · 2 lines
Thanks & Regards
Haijun.
Signature · 2 lines
Thanks & Regards
Haijun.